[GitHub] [phoenix] ChinmaySKulkarni opened a new pull request #620: PHOENIX-5544: Dropping a base table with cascade with an older client does not clear all child view metadata

ChinmaySKulkarni opened a new pull request #620: PHOENIX-5544: Dropping a base table with cascade with an older client does not clear all child view metadata URL: https://github.com/apache/phoenix/pull/620 Please review @twdsilva @lhofhansl This PR makes the following changes:

[jira] [Commented] (PHOENIX-5544) Dropping a base table with cascade with an older client does not clear all child view metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968292#comment-16968292 ] Chinmay Kulkarni commented on PHOENIX-5544: --- [~larsh] [~tdsilva] please revie

[jira] [Commented] (PHOENIX-5544) Dropping a base table with cascade with an older client does not clear all child view metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968321#comment-16968321 ] Hadoop QA commented on PHOENIX-5544: {color:red}-1 overall{color}. Here are the re

[GitHub] [phoenix-connectors] brfrn169 commented on issue #7: PHOENIX-5552 Hive against Phoenix gets 'Expecting "RPAREN", got "L"' …

brfrn169 commented on issue #7: PHOENIX-5552 Hive against Phoenix gets 'Expecting "RPAREN", got "L"' … URL: https://github.com/apache/phoenix-connectors/pull/7#issuecomment-550351813 Thank you for your comment. @ankitsinghal I will do that. -

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #607: PHOENIX-5103: Can't create/drop table using 4.14 client against 4.15 server (Addendum)

gjacoby126 commented on a change in pull request #607: PHOENIX-5103: Can't create/drop table using 4.14 client against 4.15 server (Addendum) URL: https://github.com/apache/phoenix/pull/607#discussion_r343243503 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocesso

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #607: PHOENIX-5103: Can't create/drop table using 4.14 client against 4.15 server (Addendum)

gjacoby126 commented on a change in pull request #607: PHOENIX-5103: Can't create/drop table using 4.14 client against 4.15 server (Addendum) URL: https://github.com/apache/phoenix/pull/607#discussion_r343243409 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocesso

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #607: PHOENIX-5103: Can't create/drop table using 4.14 client against 4.15 server (Addendum)

gjacoby126 commented on a change in pull request #607: PHOENIX-5103: Can't create/drop table using 4.14 client against 4.15 server (Addendum) URL: https://github.com/apache/phoenix/pull/607#discussion_r343244191 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/Dele

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #607: PHOENIX-5103: Can't create/drop table using 4.14 client against 4.15 server (Addendum)

ChinmaySKulkarni commented on a change in pull request #607: PHOENIX-5103: Can't create/drop table using 4.14 client against 4.15 server (Addendum) URL: https://github.com/apache/phoenix/pull/607#discussion_r343247931 ## File path: phoenix-core/src/main/java/org/apache/phoenix/quer

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #607: PHOENIX-5103: Can't create/drop table using 4.14 client against 4.15 server (Addendum)

ChinmaySKulkarni commented on a change in pull request #607: PHOENIX-5103: Can't create/drop table using 4.14 client against 4.15 server (Addendum) URL: https://github.com/apache/phoenix/pull/607#discussion_r343248115 ## File path: phoenix-core/src/main/java/org/apache/phoenix/copr

[jira] [Commented] (PHOENIX-5559) With short index ids, index updates are written with the same index id in 4.15.0

[ https://issues.apache.org/jira/browse/PHOENIX-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968608#comment-16968608 ] Rajeshbabu Chintaguntla commented on PHOENIX-5559: -- [~larsh] I am fine

[GitHub] [phoenix] ChinmaySKulkarni closed pull request #607: PHOENIX-5103: Can't create/drop table using 4.14 client against 4.15 server (Addendum)

ChinmaySKulkarni closed pull request #607: PHOENIX-5103: Can't create/drop table using 4.14 client against 4.15 server (Addendum) URL: https://github.com/apache/phoenix/pull/607 This is an automated message from the Apache G

[jira] [Commented] (PHOENIX-5544) Dropping a base table with cascade with an older client does not clear all child view metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968614#comment-16968614 ] Chinmay Kulkarni commented on PHOENIX-5544: --- Thanks for the review [~tdsilva]

[GitHub] [phoenix] kadirozde closed pull request #619: PHOENIX-5558 Eliminate the second single data row scan during read re…

kadirozde closed pull request #619: PHOENIX-5558 Eliminate the second single data row scan during read re… URL: https://github.com/apache/phoenix/pull/619 This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (PHOENIX-5558) Eliminate the second single data row scan during read repairs

[ https://issues.apache.org/jira/browse/PHOENIX-5558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968648#comment-16968648 ] Hudson commented on PHOENIX-5558: - FAILURE: Integrated in Jenkins build PreCommit-PHOEN

[jira] [Commented] (PHOENIX-5544) Dropping a base table with cascade with an older client does not clear all child view metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968647#comment-16968647 ] Hadoop QA commented on PHOENIX-5544: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-5560) View Index Tables created incorrectly with IndexRegionObserver

[ https://issues.apache.org/jira/browse/PHOENIX-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968691#comment-16968691 ] Kadir OZDEMIR commented on PHOENIX-5560: [~gjacoby], is this a new behavior due

[jira] [Commented] (PHOENIX-5558) Eliminate the second single data row scan during read repairs

[ https://issues.apache.org/jira/browse/PHOENIX-5558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968714#comment-16968714 ] Hudson commented on PHOENIX-5558: - SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBa

[jira] [Commented] (PHOENIX-5558) Eliminate the second single data row scan during read repairs

[ https://issues.apache.org/jira/browse/PHOENIX-5558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968752#comment-16968752 ] Hudson commented on PHOENIX-5558: - SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBa

[jira] [Commented] (PHOENIX-5558) Eliminate the second single data row scan during read repairs

[ https://issues.apache.org/jira/browse/PHOENIX-5558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968755#comment-16968755 ] Hudson commented on PHOENIX-5558: - SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBa

[jira] [Commented] (PHOENIX-5560) View Index Tables created incorrectly with IndexRegionObserver

[ https://issues.apache.org/jira/browse/PHOENIX-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968800#comment-16968800 ] Geoffrey Jacoby commented on PHOENIX-5560: -- [~kozdemir] - this appears to be n

[jira] [Commented] (PHOENIX-5560) View Index Tables created incorrectly with IndexRegionObserver

[ https://issues.apache.org/jira/browse/PHOENIX-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968815#comment-16968815 ] Kadir OZDEMIR commented on PHOENIX-5560: [~gjacoby], Got it. We should fix this

[jira] [Commented] (PHOENIX-5560) View Index Tables created incorrectly with IndexRegionObserver

[ https://issues.apache.org/jira/browse/PHOENIX-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968825#comment-16968825 ] Geoffrey Jacoby commented on PHOENIX-5560: -- What's interesting is that I can't

[GitHub] [phoenix] yanxinyi commented on a change in pull request #616: PHOENIX-5432: Refactor LiteralExpression to use the builder pattern

yanxinyi commented on a change in pull request #616: PHOENIX-5432: Refactor LiteralExpression to use the builder pattern URL: https://github.com/apache/phoenix/pull/616#discussion_r343411884 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataProtocol.ja

[GitHub] [phoenix] yanxinyi commented on a change in pull request #616: PHOENIX-5432: Refactor LiteralExpression to use the builder pattern

yanxinyi commented on a change in pull request #616: PHOENIX-5432: Refactor LiteralExpression to use the builder pattern URL: https://github.com/apache/phoenix/pull/616#discussion_r343412319 ## File path: phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ###

[GitHub] [phoenix] yanxinyi commented on a change in pull request #616: PHOENIX-5432: Refactor LiteralExpression to use the builder pattern

yanxinyi commented on a change in pull request #616: PHOENIX-5432: Refactor LiteralExpression to use the builder pattern URL: https://github.com/apache/phoenix/pull/616#discussion_r343412677 ## File path: phoenix-core/src/main/java/org/apache/phoenix/expression/DelegateExpression.j

[GitHub] [phoenix] yanxinyi commented on a change in pull request #616: PHOENIX-5432: Refactor LiteralExpression to use the builder pattern

yanxinyi commented on a change in pull request #616: PHOENIX-5432: Refactor LiteralExpression to use the builder pattern URL: https://github.com/apache/phoenix/pull/616#discussion_r343412694 ## File path: phoenix-core/src/main/java/org/apache/phoenix/expression/Expression.java ###

[jira] [Commented] (PHOENIX-5140) TableNotFoundException occurs when we create local asynchronous index

[ https://issues.apache.org/jira/browse/PHOENIX-5140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968858#comment-16968858 ] dan zheng commented on PHOENIX-5140: [~gjacoby] i can't find a UpsertCompilerTest,

[jira] [Commented] (PHOENIX-5140) TableNotFoundException occurs when we create local asynchronous index

[ https://issues.apache.org/jira/browse/PHOENIX-5140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968859#comment-16968859 ] dan zheng commented on PHOENIX-5140: [~gjacoby] actually, i change the code and bui

[GitHub] [phoenix] ChinmaySKulkarni commented on issue #620: PHOENIX-5544: Dropping a base table with cascade with an older client does not clear all child view metadata

ChinmaySKulkarni commented on issue #620: PHOENIX-5544: Dropping a base table with cascade with an older client does not clear all child view metadata URL: https://github.com/apache/phoenix/pull/620#issuecomment-550586764 Thanks for the review @twdsilva. Precommit is broken as usual. I ran

[GitHub] [phoenix] ChinmaySKulkarni closed pull request #620: PHOENIX-5544: Dropping a base table with cascade with an older client does not clear all child view metadata

ChinmaySKulkarni closed pull request #620: PHOENIX-5544: Dropping a base table with cascade with an older client does not clear all child view metadata URL: https://github.com/apache/phoenix/pull/620 This is an automated mes

[jira] [Commented] (PHOENIX-5556) Avoid repeatedly loading IndexMetaData For IndexRegionObserver

[ https://issues.apache.org/jira/browse/PHOENIX-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968889#comment-16968889 ] Kadir OZDEMIR commented on PHOENIX-5556: +1. Thank you for catching this. > Av

[jira] [Commented] (PHOENIX-5544) Dropping a base table with cascade with an older client does not clear all child view metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968904#comment-16968904 ] Hudson commented on PHOENIX-5544: - SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBa

[jira] [Commented] (PHOENIX-5544) Dropping a base table with cascade with an older client does not clear all child view metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968922#comment-16968922 ] Hudson commented on PHOENIX-5544: - SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBa

[jira] [Commented] (PHOENIX-5544) Dropping a base table with cascade with an older client does not clear all child view metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968930#comment-16968930 ] Hudson commented on PHOENIX-5544: - SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBa

[jira] [Commented] (PHOENIX-5556) Avoid repeatedly loading IndexMetaData For IndexRegionObserver

[ https://issues.apache.org/jira/browse/PHOENIX-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968940#comment-16968940 ] Hudson commented on PHOENIX-5556: - SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBa

[jira] [Commented] (PHOENIX-5559) With short index ids, index updates are written with the same index id in 4.15.0

[ https://issues.apache.org/jira/browse/PHOENIX-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968943#comment-16968943 ] Lars Hofhansl commented on PHOENIX-5559: -v1 revives some of the code from PHOE

[jira] [Commented] (PHOENIX-5562) The last concurrent update can complete the last write phase

[ https://issues.apache.org/jira/browse/PHOENIX-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968951#comment-16968951 ] Kadir OZDEMIR commented on PHOENIX-5562: In the current implementation, we have

[jira] [Commented] (PHOENIX-5544) Dropping a base table with cascade with an older client does not clear all child view metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968953#comment-16968953 ] Hudson commented on PHOENIX-5544: - FAILURE: Integrated in Jenkins build PreCommit-PHOEN

[jira] [Commented] (PHOENIX-5556) Avoid repeatedly loading IndexMetaData For IndexRegionObserver

[ https://issues.apache.org/jira/browse/PHOENIX-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968954#comment-16968954 ] Hudson commented on PHOENIX-5556: - FAILURE: Integrated in Jenkins build PreCommit-PHOEN

[jira] [Commented] (PHOENIX-5559) With short index ids, index updates are written with the same index id in 4.15.0

[ https://issues.apache.org/jira/browse/PHOENIX-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968952#comment-16968952 ] Hadoop QA commented on PHOENIX-5559: {color:red}-1 overall{color}. Here are the re

[GitHub] [phoenix] kadirozde opened a new pull request #621: PHOENIX-5562 The last concurrent update can complete the last write p…

kadirozde opened a new pull request #621: PHOENIX-5562 The last concurrent update can complete the last write p… URL: https://github.com/apache/phoenix/pull/621 …hase In the current implementation, we have two pending-rows sets. The first one is at the table region level and the second

[jira] [Commented] (PHOENIX-5557) Prevent String comparison using ==

[ https://issues.apache.org/jira/browse/PHOENIX-5557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968955#comment-16968955 ] Mihir Monani commented on PHOENIX-5557: --- Will commit this today for all 4.x and m

[jira] [Commented] (PHOENIX-5557) Prevent String comparison using ==

[ https://issues.apache.org/jira/browse/PHOENIX-5557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968966#comment-16968966 ] Mihir Monani commented on PHOENIX-5557: --- committed to 4.x-HBase-1.x and Master Br

[jira] [Commented] (PHOENIX-5559) With short index ids, index updates are written with the same index id in 4.15.0

[ https://issues.apache.org/jira/browse/PHOENIX-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968968#comment-16968968 ] Lars Hofhansl commented on PHOENIX-5559: OK... I think I fixed pre-commit! Let'

[jira] [Commented] (PHOENIX-5559) With short index ids, index updates are written with the same index id in 4.15.0

[ https://issues.apache.org/jira/browse/PHOENIX-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968981#comment-16968981 ] Lars Hofhansl commented on PHOENIX-5559: I ran all the modified tests locally a

[jira] [Commented] (PHOENIX-5556) Avoid repeatedly loading IndexMetaData For IndexRegionObserver

[ https://issues.apache.org/jira/browse/PHOENIX-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968997#comment-16968997 ] Hudson commented on PHOENIX-5556: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBa