[GitHub] [phoenix] kadirozde closed pull request #646: PHOENIX-5597 No read repair happens when scans filter rows based on a…

2019-11-28 Thread GitBox
kadirozde closed pull request #646: PHOENIX-5597 No read repair happens when scans filter rows based on a… URL: https://github.com/apache/phoenix/pull/646 This is an automated message from the Apache Git Service. To respond

[GitHub] [phoenix] kadirozde commented on a change in pull request #646: PHOENIX-5597 No read repair happens when scans filter rows based on a…

2019-11-28 Thread GitBox
kadirozde commented on a change in pull request #646: PHOENIX-5597 No read repair happens when scans filter rows based on a… URL: https://github.com/apache/phoenix/pull/646#discussion_r351985662 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexChec

[GitHub] [phoenix] kadirozde commented on a change in pull request #646: PHOENIX-5597 No read repair happens when scans filter rows based on a…

2019-11-28 Thread GitBox
kadirozde commented on a change in pull request #646: PHOENIX-5597 No read repair happens when scans filter rows based on a… URL: https://github.com/apache/phoenix/pull/646#discussion_r351985207 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.

[GitHub] [phoenix] kadirozde commented on a change in pull request #646: PHOENIX-5597 No read repair happens when scans filter rows based on a…

2019-11-28 Thread GitBox
kadirozde commented on a change in pull request #646: PHOENIX-5597 No read repair happens when scans filter rows based on a… URL: https://github.com/apache/phoenix/pull/646#discussion_r351984517 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexChec

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #646: PHOENIX-5597 No read repair happens when scans filter rows based on a…

2019-11-28 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #646: PHOENIX-5597 No read repair happens when scans filter rows based on a… URL: https://github.com/apache/phoenix/pull/646#discussion_r351960276 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesO

[jira] [Commented] (PHOENIX-5597) No read repair happens when scans filter rows based on a covered column

2019-11-28 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984711#comment-16984711 ] Chinmay Kulkarni commented on PHOENIX-5597: --- I have left a couple of comments

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #646: PHOENIX-5597 No read repair happens when scans filter rows based on a…

2019-11-28 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #646: PHOENIX-5597 No read repair happens when scans filter rows based on a… URL: https://github.com/apache/phoenix/pull/646#discussion_r351948004 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIn

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #646: PHOENIX-5597 No read repair happens when scans filter rows based on a…

2019-11-28 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #646: PHOENIX-5597 No read repair happens when scans filter rows based on a… URL: https://github.com/apache/phoenix/pull/646#discussion_r351960276 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesO

[jira] [Commented] (PHOENIX-5593) Remove null checks for JoinCompiler

2019-11-28 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984340#comment-16984340 ] Viraj Jasani commented on PHOENIX-5593: --- Now QA results look good > Remove null

[jira] [Commented] (PHOENIX-5593) Remove null checks for JoinCompiler

2019-11-28 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984318#comment-16984318 ] Hadoop QA commented on PHOENIX-5593: {color:red}-1 overall{color}. Here are the re