[jira] [Commented] (PHOENIX-5718) GetTable builds a table excluding the given clientTimeStamp

2020-03-16 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060666#comment-17060666 ] Sandeep Guggilam commented on PHOENIX-5718: --- [~ckulkarni] I have the Hadoop Q

[jira] [Commented] (PHOENIX-5718) GetTable builds a table excluding the given clientTimeStamp

2020-03-16 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060645#comment-17060645 ] Hadoop QA commented on PHOENIX-5718: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-5749) Add unit tests for verifySingleIndexRow() of IndexRebuildRegionScanner

2020-03-16 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060644#comment-17060644 ] Hadoop QA commented on PHOENIX-5749: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-5771) Make standalone queryserver assembly useful again

2020-03-16 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060642#comment-17060642 ] Guanghao Zhang commented on PHOENIX-5771: - Got it. Thanks for your remind. I me

[jira] [Commented] (PHOENIX-5771) Make standalone queryserver assembly useful again

2020-03-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060637#comment-17060637 ] Istvan Toth commented on PHOENIX-5771: -- Yes, but keep in mind the queryserver asse

[jira] [Commented] (PHOENIX-5771) Make standalone queryserver assembly useful again

2020-03-16 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060635#comment-17060635 ] Guanghao Zhang commented on PHOENIX-5771: - So the recommended way is download a

[jira] [Comment Edited] (PHOENIX-5771) Make standalone queryserver assembly useful again

2020-03-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060628#comment-17060628 ] Istvan Toth edited comment on PHOENIX-5771 at 3/17/20, 4:32 AM: -

[jira] [Commented] (PHOENIX-5771) Make standalone queryserver assembly useful again

2020-03-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060628#comment-17060628 ] Istvan Toth commented on PHOENIX-5771: -- We cannot add the thick client JAR to the

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060627#comment-17060627 ] Guanghao Zhang commented on PHOENIX-5778: - For hbase, jira admins can set proje

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060621#comment-17060621 ] Istvan Toth commented on PHOENIX-5778: -- I tried to, but I either don't have the pe

[jira] [Commented] (PHOENIX-5718) GetTable builds a table excluding the given clientTimeStamp

2020-03-16 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060549#comment-17060549 ] Hadoop QA commented on PHOENIX-5718: {color:red}-1 overall{color}. Here are the re

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild

2020-03-16 Thread GitBox
gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild URL: https://github.com/apache/phoenix/pull/728#discussion_r393366707 ## File path: phoenix-core/src/test/java/org/apache/phoenix/index/PrepareIndexMutationsForRebu

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild

2020-03-16 Thread GitBox
gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild URL: https://github.com/apache/phoenix/pull/728#discussion_r393368770 ## File path: phoenix-core/src/test/java/org/apache/phoenix/index/PrepareIndexMutationsForRebu

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild

2020-03-16 Thread GitBox
gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild URL: https://github.com/apache/phoenix/pull/728#discussion_r393368210 ## File path: phoenix-core/src/test/java/org/apache/phoenix/index/PrepareIndexMutationsForRebu

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild

2020-03-16 Thread GitBox
gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild URL: https://github.com/apache/phoenix/pull/728#discussion_r393379077 ## File path: phoenix-core/src/test/java/org/apache/phoenix/index/PrepareIndexMutationsForRebu

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild

2020-03-16 Thread GitBox
gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild URL: https://github.com/apache/phoenix/pull/728#discussion_r393369004 ## File path: phoenix-core/src/test/java/org/apache/phoenix/index/PrepareIndexMutationsForRebu

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild

2020-03-16 Thread GitBox
gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild URL: https://github.com/apache/phoenix/pull/728#discussion_r393378976 ## File path: phoenix-core/src/test/java/org/apache/phoenix/index/PrepareIndexMutationsForRebu

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild

2020-03-16 Thread GitBox
gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild URL: https://github.com/apache/phoenix/pull/728#discussion_r393378420 ## File path: phoenix-core/src/test/java/org/apache/phoenix/index/PrepareIndexMutationsForRebu

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild

2020-03-16 Thread GitBox
gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild URL: https://github.com/apache/phoenix/pull/728#discussion_r393369422 ## File path: phoenix-core/src/test/java/org/apache/phoenix/index/PrepareIndexMutationsForRebu

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild

2020-03-16 Thread GitBox
gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild URL: https://github.com/apache/phoenix/pull/728#discussion_r393378378 ## File path: phoenix-core/src/test/java/org/apache/phoenix/index/PrepareIndexMutationsForRebu

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild

2020-03-16 Thread GitBox
gjacoby126 commented on a change in pull request #728: PHOENIX-5765 Add unit test for PrepareIndexMutationsForRebuild URL: https://github.com/apache/phoenix/pull/728#discussion_r393371044 ## File path: phoenix-core/src/test/java/org/apache/phoenix/index/PrepareIndexMutationsForRebu

[jira] [Commented] (PHOENIX-5771) Make standalone queryserver assembly useful again

2020-03-16 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060535#comment-17060535 ] Guanghao Zhang commented on PHOENIX-5771: - bq. Make sure PQS can access the fat

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060533#comment-17060533 ] Guanghao Zhang commented on PHOENIX-5778: - [~stoty] Sir, can you help to add me

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060514#comment-17060514 ] Guanghao Zhang commented on PHOENIX-5778: - bq. Defaulting to building against

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060512#comment-17060512 ] Guanghao Zhang commented on PHOENIX-5778: - bq. However, I don't think that copy

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060508#comment-17060508 ] Guanghao Zhang commented on PHOENIX-5778: - bq. It is a calculated risk vs copyi

[jira] [Commented] (PHOENIX-5779) SpliitSystemCatalogIT tests fail with Multiple Regions error

2020-03-16 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060419#comment-17060419 ] Sandeep Guggilam commented on PHOENIX-5779: --- The error is coming from here : 

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060254#comment-17060254 ] Istvan Toth commented on PHOENIX-5778: -- {quote}And if new version hbase (2.3.x+) c

[jira] [Comment Edited] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060239#comment-17060239 ] Guanghao Zhang edited comment on PHOENIX-5778 at 3/16/20, 2:18 PM: --

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060243#comment-17060243 ] Istvan Toth commented on PHOENIX-5778: -- pom.xml (the text file) will be bigger by

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060239#comment-17060239 ] Guanghao Zhang commented on PHOENIX-5778: - bq. It is only ever loaded and refer

[jira] [Comment Edited] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060228#comment-17060228 ] Istvan Toth edited comment on PHOENIX-5778 at 3/16/20, 1:47 PM: -

[jira] [Commented] (PHOENIX-5777) Unify the queryserver config keys to use QueryServerProperties

2020-03-16 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060230#comment-17060230 ] Guanghao Zhang commented on PHOENIX-5777: - bq. I really wish we had versions de

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060228#comment-17060228 ] Istvan Toth commented on PHOENIX-5778: -- Keep in mind that this a TEST dependency.

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060225#comment-17060225 ] Guanghao Zhang commented on PHOENIX-5778: - Sir. I got your point. “Add differen

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060218#comment-17060218 ] Istvan Toth commented on PHOENIX-5778: -- Of course you will need to add the corresp

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060208#comment-17060208 ] Guanghao Zhang commented on PHOENIX-5778: - bq. Add profiles to be able to test

[jira] [Comment Edited] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060205#comment-17060205 ] Istvan Toth edited comment on PHOENIX-5778 at 3/16/20, 1:22 PM: -

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060205#comment-17060205 ] Istvan Toth commented on PHOENIX-5778: -- That's a different situation. I've tried

[jira] [Comment Edited] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060205#comment-17060205 ] Istvan Toth edited comment on PHOENIX-5778 at 3/16/20, 1:19 PM: -

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060147#comment-17060147 ] Guanghao Zhang commented on PHOENIX-5778: - bq. If any of those go away or chang

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060135#comment-17060135 ] Istvan Toth commented on PHOENIX-5778: -- I do not dispute that we are using classes

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060116#comment-17060116 ] Guanghao Zhang commented on PHOENIX-5778: - If the queryserver tied to HBase cla

[jira] [Commented] (PHOENIX-5778) Remove the dependency of KeyStoreTestUtil

2020-03-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060097#comment-17060097 ] Istvan Toth commented on PHOENIX-5778: -- I don't think that this is a good idea. W

[jira] [Commented] (PHOENIX-5777) Unify the queryserver config keys to use QueryServerProperties

2020-03-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060089#comment-17060089 ] Istvan Toth commented on PHOENIX-5777: -- Thank you [~zghao] > Unify the queryserve

[GitHub] [phoenix-queryserver] asfgit closed pull request #21: PHOENIX-5777 Unify the queryserver config keys to use QueryServerProp…

2020-03-16 Thread GitBox
asfgit closed pull request #21: PHOENIX-5777 Unify the queryserver config keys to use QueryServerProp… URL: https://github.com/apache/phoenix-queryserver/pull/21 This is an automated message from the Apache Git Service. To r