[jira] [Commented] (PHOENIX-5771) Make standalone queryserver assembly useful again

2020-04-20 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088259#comment-17088259 ] Guanghao Zhang commented on PHOENIX-5771: - [~stoty] Sir, can you help to review

[jira] [Commented] (PHOENIX-5580) Wrong values seen when updating a view for a table that has an index

2020-04-20 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088237#comment-17088237 ] Sandeep Guggilam commented on PHOENIX-5580: --- [~abhishek.chouhan] [~gjacoby] 

[jira] [Commented] (PHOENIX-5580) Wrong values seen when updating a view for a table that has an index

2020-04-20 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088220#comment-17088220 ] Hadoop QA commented on PHOENIX-5580: {color:green}+1 overall{color}. Here are the

[jira] [Commented] (PHOENIX-5818) Add documentation for query timeoutDuration attribute in Pherf scenarios

2020-04-20 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088190#comment-17088190 ] Chinmay Kulkarni commented on PHOENIX-5818: --- Committed. Thanks for the contri

[jira] [Commented] (PHOENIX-4521) Allow Pherf scenario to define per query max allowed query execution duration after which thread is interrupted

2020-04-20 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088187#comment-17088187 ] Hadoop QA commented on PHOENIX-4521: {color:green}+1 overall{color}. Here are the

[jira] [Commented] (PHOENIX-4521) Allow Pherf scenario to define per query max allowed query execution duration after which thread is interrupted

2020-04-20 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088182#comment-17088182 ] Chinmay Kulkarni commented on PHOENIX-4521: --- Committed to master and 4.x. Tha

[GitHub] [phoenix] swaroopak commented on a change in pull request #758: PHOENIX-5804: Implement strong verification with -v ONLY option for o…

2020-04-20 Thread GitBox
swaroopak commented on a change in pull request #758: URL: https://github.com/apache/phoenix/pull/758#discussion_r411753160 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexerRegionScanner.java ## @@ -0,0 +1,484 @@ +/* + * Licensed to the Apache Sof

[GitHub] [phoenix-queryserver] joshelser commented on issue #27: PHOENIX-5844 Feature parity for the python client (part 1:authentication rewrite)

2020-04-20 Thread GitBox
joshelser commented on issue #27: URL: https://github.com/apache/phoenix-queryserver/pull/27#issuecomment-616852544 👍 perfect. Thanks for your due diligence! This is an automated message from the Apache Git Service. To respo

[GitHub] [phoenix] kadirozde commented on a change in pull request #758: PHOENIX-5804: Implement strong verification with -v ONLY option for o…

2020-04-20 Thread GitBox
kadirozde commented on a change in pull request #758: URL: https://github.com/apache/phoenix/pull/758#discussion_r411727166 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java ## @@ -0,0 +1,483 @@ +/* Review comment: Th

[GitHub] [phoenix] priyankporwal commented on a change in pull request #765: PHOENIX-5841 add a counter for mismatching num of columns

2020-04-20 Thread GitBox
priyankporwal commented on a change in pull request #765: URL: https://github.com/apache/phoenix/pull/765#discussion_r411725027 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java ## @@ -85,10 +85,14 @@ import java.util.concurrent.atomic.AtomicIn

[GitHub] [phoenix] dbwong commented on a change in pull request #759: Initial code push for TableLevel metrics.

2020-04-20 Thread GitBox
dbwong commented on a change in pull request #759: URL: https://github.com/apache/phoenix/pull/759#discussion_r411697149 ## File path: phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java ## @@ -9,32 +9,9 @@ */ package org.apache.phoenix.monitoring;

[GitHub] [phoenix] swaroopak commented on a change in pull request #758: PHOENIX-5804: Implement strong verification with -v ONLY option for o…

2020-04-20 Thread GitBox
swaroopak commented on a change in pull request #758: URL: https://github.com/apache/phoenix/pull/758#discussion_r411716477 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache

[GitHub] [phoenix] kadirozde commented on a change in pull request #758: PHOENIX-5804: Implement strong verification with -v ONLY option for o…

2020-04-20 Thread GitBox
kadirozde commented on a change in pull request #758: URL: https://github.com/apache/phoenix/pull/758#discussion_r411716301 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexerRegionScanner.java ## @@ -0,0 +1,484 @@ +/* + * Licensed to the Apache Sof

[GitHub] [phoenix] kadirozde commented on a change in pull request #758: PHOENIX-5804: Implement strong verification with -v ONLY option for o…

2020-04-20 Thread GitBox
kadirozde commented on a change in pull request #758: URL: https://github.com/apache/phoenix/pull/758#discussion_r411715628 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache

[jira] [Comment Edited] (PHOENIX-5833) Incorrect results with LIKE operator

2020-04-20 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088003#comment-17088003 ] Daniel Wong edited comment on PHOENIX-5833 at 4/20/20, 6:44 PM: -

[jira] [Commented] (PHOENIX-5833) Incorrect results with LIKE operator

2020-04-20 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088003#comment-17088003 ] Daniel Wong commented on PHOENIX-5833: -- Does look like one of the likey many RVC r

[jira] [Commented] (PHOENIX-5833) Incorrect results with LIKE operator

2020-04-20 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087985#comment-17087985 ] Chinmay Kulkarni commented on PHOENIX-5833: --- FYI [~dbwong] perhaps you have t

[jira] [Commented] (PHOENIX-3445) Add a CREATE IMMUTABLE TABLE construct to make immutable tables more explicit

2020-04-20 Thread Andrew Olson (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087859#comment-17087859 ] Andrew Olson commented on PHOENIX-3445: --- The Grammar section of the documentation

[GitHub] [phoenix-queryserver] stoty opened a new pull request #30: PHOENIX-5844 Feature parity for the python client (part2: transaction…

2020-04-20 Thread GitBox
stoty opened a new pull request #30: URL: https://github.com/apache/phoenix-queryserver/pull/30 … support and test suite) includes: PHOENIX-5857 Get the python test suite working PHOENIX-5858 Add commit/rollback support to the python client