[jira] [Commented] (PHOENIX-5872) Close Internal Phoenix Connections that were running during cancel

2020-04-29 Thread Xinyi Yan (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096079#comment-17096079 ] Xinyi Yan commented on PHOENIX-5872: Merged to 4.x branch, [~dbwong] can you rebase

[jira] [Commented] (PHOENIX-5872) Close Internal Phoenix Connections that were running during cancel

2020-04-29 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096052#comment-17096052 ] Hadoop QA commented on PHOENIX-5872: {color:red}-1 overall{color}. Here are the re

[GitHub] [phoenix] jpisaac commented on a change in pull request #762: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VIEW_TTL has expired

2020-04-29 Thread GitBox
jpisaac commented on a change in pull request #762: URL: https://github.com/apache/phoenix/pull/762#discussion_r417714966 ## File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/ViewInfoTracker.java ## @@ -24,24 +24,6 @@ import java.io.IOException; publi

[GitHub] [phoenix] jpisaac commented on a change in pull request #762: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VIEW_TTL has expired

2020-04-29 Thread GitBox
jpisaac commented on a change in pull request #762: URL: https://github.com/apache/phoenix/pull/762#discussion_r417714221 ## File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/ViewInfoWritable.java ## @@ -24,6 +24,25 @@ import java.io.IOException; publ

[GitHub] [phoenix] jpisaac commented on a change in pull request #762: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VIEW_TTL has expired

2020-04-29 Thread GitBox
jpisaac commented on a change in pull request #762: URL: https://github.com/apache/phoenix/pull/762#discussion_r417711242 ## File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/DefaultMultiViewSplitStrategy.java ## @@ -26,28 +26,28 @@ public class Defaul

[jira] [Commented] (PHOENIX-5580) Wrong values seen when updating a view for a table that has an index

2020-04-29 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095986#comment-17095986 ] Hadoop QA commented on PHOENIX-5580: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-5878) IndexTool should not fail jobs when the only errors are due to rows out of MaxLookback

2020-04-29 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095978#comment-17095978 ] Hadoop QA commented on PHOENIX-5878: {color:green}+1 overall{color}. Here are the

[jira] [Commented] (PHOENIX-5872) Close Internal Phoenix Connections that were running during cancel

2020-04-29 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095977#comment-17095977 ] Hadoop QA commented on PHOENIX-5872: {color:red}-1 overall{color}. Here are the re

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #771: PHOENIX-5872 Close Internal Phoenix Connections that were running during cancel

2020-04-29 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #771: URL: https://github.com/apache/phoenix/pull/771#discussion_r417645810 ## File path: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java ## @@ -441,6 +453,23 @@ private static Properties filterK

[GitHub] [phoenix] dbwong commented on a change in pull request #771: PHOENIX-5872 Close Internal Phoenix Connections that were running during cancel

2020-04-29 Thread GitBox
dbwong commented on a change in pull request #771: URL: https://github.com/apache/phoenix/pull/771#discussion_r417644120 ## File path: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java ## @@ -655,13 +678,20 @@ public void close() throws SQLException {

[GitHub] [phoenix] dbwong commented on a change in pull request #771: PHOENIX-5872 Close Internal Phoenix Connections that were running during cancel

2020-04-29 Thread GitBox
dbwong commented on a change in pull request #771: URL: https://github.com/apache/phoenix/pull/771#discussion_r417621247 ## File path: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java ## @@ -441,6 +453,17 @@ private static Properties filterKnownNonPro

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #771: PHOENIX-5872 Close Internal Phoenix Connections that were running during cancel

2020-04-29 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #771: URL: https://github.com/apache/phoenix/pull/771#discussion_r417613015 ## File path: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java ## @@ -441,6 +453,17 @@ private static Properties filterK

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #771: PHOENIX-5872 Close Internal Phoenix Connections that were running during cancel

2020-04-29 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #771: URL: https://github.com/apache/phoenix/pull/771#discussion_r417611476 ## File path: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java ## @@ -655,13 +678,20 @@ public void close() throws SQLExc

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #771: PHOENIX-5872 Close Internal Phoenix Connections that were running during cancel

2020-04-29 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #771: URL: https://github.com/apache/phoenix/pull/771#discussion_r417610723 ## File path: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java ## @@ -655,13 +678,20 @@ public void close() throws SQLExc

[GitHub] [phoenix] gjacoby126 opened a new pull request #772: PHOENIX-5878 - IndexTool should not fail jobs when the only errors ar…

2020-04-29 Thread GitBox
gjacoby126 opened a new pull request #772: URL: https://github.com/apache/phoenix/pull/772 …e due to rows out of MaxLookback This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Commented] (PHOENIX-5872) Close Internal Phoenix Connections that were running during cancel

2020-04-29 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095855#comment-17095855 ] Hadoop QA commented on PHOENIX-5872: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-5873) Fix loadbalancer packaging problem for queryserver scripts

2020-04-29 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095379#comment-17095379 ] Istvan Toth commented on PHOENIX-5873: -- I have committed the patch. Thank you [~z

[jira] [Commented] (PHOENIX-5872) Close Internal Phoenix Connections that were running during cancel

2020-04-29 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095282#comment-17095282 ] Hadoop QA commented on PHOENIX-5872: {color:red}-1 overall{color}. Here are the re