[jira] [Commented] (PHOENIX-5984) Query timeout counter is not updated in all timeouts cases

2020-07-01 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149871#comment-17149871 ] Hadoop QA commented on PHOENIX-5984: {color:red}-1 overall{color}. Here are the re

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #818: PHOENIX-5984: Query timeout counter is not updated in all timeouts cases

2020-07-01 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #818: URL: https://github.com/apache/phoenix/pull/818#discussion_r448724324 ## File path: phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java ## @@ -93,6 +97,23 @@ private static final Logge

[jira] [Commented] (PHOENIX-5985) Consolidate custom EnvironmentEdge classes throughout tests

2020-07-01 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149784#comment-17149784 ] Chinmay Kulkarni commented on PHOENIX-5985: --- FYI [~dbwong] > Consolidate cus

[GitHub] [phoenix] dbwong commented on a change in pull request #818: PHOENIX-5984: Query timeout counter is not updated in all timeouts cases

2020-07-01 Thread GitBox
dbwong commented on a change in pull request #818: URL: https://github.com/apache/phoenix/pull/818#discussion_r448722098 ## File path: phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java ## @@ -93,6 +97,23 @@ private static final Logger LOGGER =

[GitHub] [phoenix] ChinmaySKulkarni commented on pull request #818: PHOENIX-5984: Query timeout counter is not updated in all timeouts cases

2020-07-01 Thread GitBox
ChinmaySKulkarni commented on pull request #818: URL: https://github.com/apache/phoenix/pull/818#issuecomment-652751383 Please review @gjacoby126 @yanxinyi @jpisaac This is an automated message from the Apache Git Service. T

[GitHub] [phoenix] ChinmaySKulkarni opened a new pull request #818: PHOENIX-5984: Query timeout counter is not updated in all timeouts cases

2020-07-01 Thread GitBox
ChinmaySKulkarni opened a new pull request #818: URL: https://github.com/apache/phoenix/pull/818 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [phoenix] wangchao316 commented on pull request #817: PHOENIX-5861 Delete index data failed,due to pool closed

2020-07-01 Thread GitBox
wangchao316 commented on pull request #817: URL: https://github.com/apache/phoenix/pull/817#issuecomment-652746979 I will open this pr for 4.* brach, so close for 4.x-HBase-1.3 This is an automated message from the Apache Gi

[GitHub] [phoenix] wangchao316 closed pull request #817: PHOENIX-5861 Delete index data failed,due to pool closed

2020-07-01 Thread GitBox
wangchao316 closed pull request #817: URL: https://github.com/apache/phoenix/pull/817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [phoenix] wangchao316 commented on pull request #817: PHOENIX-5861 Delete index data failed,due to pool closed

2020-07-01 Thread GitBox
wangchao316 commented on pull request #817: URL: https://github.com/apache/phoenix/pull/817#issuecomment-652746148 thanks,I will open this pr for 4.x ---Original--- From: "Geoffrey Jacoby"

[jira] [Commented] (PHOENIX-5981) Wrong multiple counting of resultSetTimeMs and wallclockTimeMs in OverallQueryMetrics

2020-07-01 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149700#comment-17149700 ] Hadoop QA commented on PHOENIX-5981: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-5982) Overall query metrics not updated if rs.next is called just once

2020-07-01 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149679#comment-17149679 ] Chinmay Kulkarni commented on PHOENIX-5982: --- [~shahrs87] this is because we u

[jira] [Commented] (PHOENIX-5982) Overall query metrics not updated if rs.next is called just once

2020-07-01 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149677#comment-17149677 ] Rushabh Shah commented on PHOENIX-5982: --- [~ckulkarni] Why is this resolved as not

[jira] [Commented] (PHOENIX-5981) Wrong multiple counting of resultSetTimeMs and wallclockTimeMs in OverallQueryMetrics

2020-07-01 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149594#comment-17149594 ] Chinmay Kulkarni commented on PHOENIX-5981: --- Thanks for the review [~gjacoby]

[jira] [Commented] (PHOENIX-4844) Refactor queryserver tests to use QueryServerTestUtil

2020-07-01 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149573#comment-17149573 ] Josh Elser commented on PHOENIX-4844: - Unscheduling from queryserver-1.0.0 due to l

[GitHub] [phoenix-queryserver] joshelser commented on pull request #22: PHOENIX-5778 Remove the dependency of KeyStoreTestUtil

2020-07-01 Thread GitBox
joshelser commented on pull request #22: URL: https://github.com/apache/phoenix-queryserver/pull/22#issuecomment-652546635 Let me take a look at this. Sorry it's been sitting here for ages. This is an automated message from

[GitHub] [phoenix-queryserver] joshelser closed pull request #39: PHOENIX-5901 Fix licensing in preparation for first python release

2020-07-01 Thread GitBox
joshelser closed pull request #39: URL: https://github.com/apache/phoenix-queryserver/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [phoenix] gjacoby126 commented on pull request #817: PHOENIX-5861 Delete index data failed,due to pool closed

2020-07-01 Thread GitBox
gjacoby126 commented on pull request #817: URL: https://github.com/apache/phoenix/pull/817#issuecomment-652480876 @wangchao316 - 4.x-HBase-1.3 is an obsolete branch -- the current branch for the next 4.x release is named "4.x", and contains different Maven profiles for different HBase vers

[GitHub] [phoenix] wangchao316 opened a new pull request #817: PHOENIX-5861 Delete index data failed,due to pool closed

2020-07-01 Thread GitBox
wangchao316 opened a new pull request #817: URL: https://github.com/apache/phoenix/pull/817 PHOENIX-5861 Delete index data failed,due to pool closed This is an automated message from the Apache Git Service. To respond to the

[GitHub] [phoenix] wangchao316 closed pull request #816: PHOENIX-5860 Throw exception which region is closing or splitting whe…

2020-07-01 Thread GitBox
wangchao316 closed pull request #816: URL: https://github.com/apache/phoenix/pull/816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [phoenix] wangchao316 opened a new pull request #816: PHOENIX-5860 Throw exception which region is closing or splitting whe…

2020-07-01 Thread GitBox
wangchao316 opened a new pull request #816: URL: https://github.com/apache/phoenix/pull/816 this patch submited, this issues sovled. This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (PHOENIX-5779) SplitSystemCatalogIT tests fail with Multiple Regions error

2020-07-01 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149372#comment-17149372 ] Hudson commented on PHOENIX-5779: - FAILURE: Integrated in Jenkins build PreCommit-PHOEN

[jira] [Commented] (PHOENIX-5983) Set Hadoop dependencies as provided in phoenix-server

2020-07-01 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149371#comment-17149371 ] Hadoop QA commented on PHOENIX-5983: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-5967) phoenix-client transitively pulling in phoenix-core

2020-07-01 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149362#comment-17149362 ] Istvan Toth commented on PHOENIX-5967: -- I'm leaning towards [~larsh] 's solution.

[jira] [Commented] (PHOENIX-5983) Set Hadoop dependencies as provided in phoenix-server

2020-07-01 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149361#comment-17149361 ] Istvan Toth commented on PHOENIX-5983: -- With these patches phoenix-server built wi

[GitHub] [phoenix] stoty opened a new pull request #815: PHOENIX-5983 Set Hadoop dependencies as provided in phoenix-server

2020-07-01 Thread GitBox
stoty opened a new pull request #815: URL: https://github.com/apache/phoenix/pull/815 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (PHOENIX-5779) SplitSystemCatalogIT tests fail with Multiple Regions error

2020-07-01 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149223#comment-17149223 ] Istvan Toth commented on PHOENIX-5779: -- Thank you [~RichardAntal] > SplitSystemCa

[jira] [Commented] (PHOENIX-5975) Index rebuild/verification page size should be configurable from IndexTool

2020-07-01 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149204#comment-17149204 ] Hudson commented on PHOENIX-5975: - FAILURE: Integrated in Jenkins build PreCommit-PHOEN

[jira] [Commented] (PHOENIX-5981) Wrong multiple counting of resultSetTimeMs and wallclockTimeMs in OverallQueryMetrics

2020-07-01 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149201#comment-17149201 ] Hadoop QA commented on PHOENIX-5981: {color:red}-1 overall{color}. Here are the re