[GitHub] [phoenix] wangchao316 commented on pull request #874: PHOENIX-5860 Throw exception which region is closing or splitting when delete data

2020-09-07 Thread GitBox
wangchao316 commented on pull request #874: URL: https://github.com/apache/phoenix/pull/874#issuecomment-688600383 @joshelser @gjacoby126 @swaroopak , hello , could you please review this? Thanks This is an automated m

[jira] [Commented] (PHOENIX-6010) Create phoenix-thirdparty, and consume guava through it

2020-09-07 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191726#comment-17191726 ] Hadoop QA commented on PHOENIX-6010: {color:red}-1 overall{color}. Here are the re

[GitHub] [phoenix-connectors] stoty closed pull request #29: PHOENIX-6103 Replace apache.commons.logging in Phoenix-Connectors

2020-09-07 Thread GitBox
stoty closed pull request #29: URL: https://github.com/apache/phoenix-connectors/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [phoenix] stoty commented on pull request #845: PHOENIX-6010 Create phoenix-thirdparty, and consume guava through it

2020-09-07 Thread GitBox
stoty commented on pull request #845: URL: https://github.com/apache/phoenix/pull/845#issuecomment-688283208 It's a huge patch, but 99% of it is import renames. There are some minor code changes to account for the the Guava differences between 13 and 29. The rest is the POM change, wh

[jira] [Commented] (PHOENIX-6010) Create phoenix-thirdparty, and consume guava through it

2020-09-07 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191650#comment-17191650 ] Hadoop QA commented on PHOENIX-6010: {color:red}-1 overall{color}. Here are the re

[GitHub] [phoenix-connectors] stoty commented on a change in pull request #29: PHOENIX-6103 Replace apache.commons.logging in Phoenix-Connectors

2020-09-07 Thread GitBox
stoty commented on a change in pull request #29: URL: https://github.com/apache/phoenix-connectors/pull/29#discussion_r484236334 ## File path: pom.xml ## @@ -76,6 +76,7 @@ ${hive3.version} 0.13.0 1.2.17 +1.6.4 Review comment: The version is already de