[jira] [Commented] (PHOENIX-6188) Jenkins job history uses too much storage

2020-10-15 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214579#comment-17214579 ] Istvan Toth commented on PHOENIX-6188: -- Pushed an addendum that compresses all txt

[GitHub] [phoenix] stoty commented on pull request #917: PHOENIX-6124 : Conditionally block adding/dropping a column on a parent view

2020-10-15 Thread GitBox
stoty commented on pull request #917: URL: https://github.com/apache/phoenix/pull/917#issuecomment-709261594 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 48s | Doc

[jira] [Commented] (PHOENIX-6124) Block adding/dropping a column on a parent view for clients <4.15 and for clients that have phoenix.allow.system.catalog.rollback=true

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214655#comment-17214655 ] ASF GitHub Bot commented on PHOENIX-6124: - stoty commented on pull request #917

[GitHub] [phoenix] stoty commented on pull request #920: PHOENIX-6129 : Avoid redundant Admin API call in the absence of SYSTEM.MUTEX table

2020-10-15 Thread GitBox
stoty commented on pull request #920: URL: https://github.com/apache/phoenix/pull/920#issuecomment-709267634 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 10m 18s | Doc

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214656#comment-17214656 ] ASF GitHub Bot commented on PHOENIX-6129: - stoty commented on pull request #920

[GitHub] [phoenix] virajjasani opened a new pull request #923: PHOENIX-6125 : Disable split policy for SYSTEM.TASK

2020-10-15 Thread GitBox
virajjasani opened a new pull request #923: URL: https://github.com/apache/phoenix/pull/923 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Commented] (PHOENIX-6125) Make sure SYSTEM.TASK does not split

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214680#comment-17214680 ] ASF GitHub Bot commented on PHOENIX-6125: - virajjasani opened a new pull reques

[GitHub] [phoenix] virajjasani commented on pull request #917: PHOENIX-6124 : Conditionally block adding/dropping a column on a parent view

2020-10-15 Thread GitBox
virajjasani commented on pull request #917: URL: https://github.com/apache/phoenix/pull/917#issuecomment-709325612 @ChinmaySKulkarni @gjacoby126 could you please review this PR? Recent build has no test failure and I have tried to fix max checkstyles except for the ones related to method

[jira] [Commented] (PHOENIX-6124) Block adding/dropping a column on a parent view for clients <4.15 and for clients that have phoenix.allow.system.catalog.rollback=true

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214686#comment-17214686 ] ASF GitHub Bot commented on PHOENIX-6124: - virajjasani commented on pull reques

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214709#comment-17214709 ] ASF GitHub Bot commented on PHOENIX-6129: - virajjasani commented on pull reques

[GitHub] [phoenix] virajjasani commented on pull request #920: PHOENIX-6129 : Avoid redundant Admin API call in the absence of SYSTEM.MUTEX table

2020-10-15 Thread GitBox
virajjasani commented on pull request #920: URL: https://github.com/apache/phoenix/pull/920#issuecomment-709339348 Could you please take a look @yanxinyi ? This is an automated message from the Apache Git Service. To respond

[GitHub] [phoenix] virajjasani edited a comment on pull request #920: PHOENIX-6129 : Avoid redundant Admin API call in the absence of SYSTEM.MUTEX table

2020-10-15 Thread GitBox
virajjasani edited a comment on pull request #920: URL: https://github.com/apache/phoenix/pull/920#issuecomment-709339348 Test failures don't seem relevant, tried locally, all passed. Fixed checkstyle issues relevant to this PR. Could you please take a look @yanxinyi ?

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214711#comment-17214711 ] ASF GitHub Bot commented on PHOENIX-6129: - virajjasani edited a comment on pull

[GitHub] [phoenix] stoty commented on pull request #919: PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException

2020-10-15 Thread GitBox
stoty commented on pull request #919: URL: https://github.com/apache/phoenix/pull/919#issuecomment-709384745 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 15m 44s | Doc

[jira] [Commented] (PHOENIX-6185) OPERATION_TIMED_OUT#newException method swallows the exception message and root cause exception.

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214763#comment-17214763 ] ASF GitHub Bot commented on PHOENIX-6185: - stoty commented on pull request #919

[GitHub] [phoenix] virajjasani commented on pull request #919: PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException

2020-10-15 Thread GitBox
virajjasani commented on pull request #919: URL: https://github.com/apache/phoenix/pull/919#issuecomment-709390900 @gjacoby126 checkstyle is fixed, should be visible in next build. This applies directly to 4.x. Would you like me to create 4.x PR? --

[jira] [Commented] (PHOENIX-6185) OPERATION_TIMED_OUT#newException method swallows the exception message and root cause exception.

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214766#comment-17214766 ] ASF GitHub Bot commented on PHOENIX-6185: - virajjasani commented on pull reques

[GitHub] [phoenix] shahrs87 commented on a change in pull request #919: PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException

2020-10-15 Thread GitBox
shahrs87 commented on a change in pull request #919: URL: https://github.com/apache/phoenix/pull/919#discussion_r505624689 ## File path: phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java ## @@ -453,8 +453,13 @@ public SQLException newException(SQLEx

[jira] [Commented] (PHOENIX-6185) OPERATION_TIMED_OUT#newException method swallows the exception message and root cause exception.

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214768#comment-17214768 ] ASF GitHub Bot commented on PHOENIX-6185: - shahrs87 commented on a change in pu

[GitHub] [phoenix] shahrs87 commented on a change in pull request #919: PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException

2020-10-15 Thread GitBox
shahrs87 commented on a change in pull request #919: URL: https://github.com/apache/phoenix/pull/919#discussion_r505624689 ## File path: phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java ## @@ -453,8 +453,13 @@ public SQLException newException(SQLEx

[GitHub] [phoenix] shahrs87 commented on a change in pull request #919: PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException

2020-10-15 Thread GitBox
shahrs87 commented on a change in pull request #919: URL: https://github.com/apache/phoenix/pull/919#discussion_r505632721 ## File path: phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java ## @@ -453,8 +453,13 @@ public SQLException newException(SQLEx

[jira] [Commented] (PHOENIX-6185) OPERATION_TIMED_OUT#newException method swallows the exception message and root cause exception.

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214776#comment-17214776 ] ASF GitHub Bot commented on PHOENIX-6185: - shahrs87 commented on a change in pu

[jira] [Commented] (PHOENIX-6185) OPERATION_TIMED_OUT#newException method swallows the exception message and root cause exception.

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214774#comment-17214774 ] ASF GitHub Bot commented on PHOENIX-6185: - shahrs87 commented on a change in pu

[GitHub] [phoenix] virajjasani commented on a change in pull request #919: PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException

2020-10-15 Thread GitBox
virajjasani commented on a change in pull request #919: URL: https://github.com/apache/phoenix/pull/919#discussion_r505642018 ## File path: phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java ## @@ -453,8 +453,13 @@ public SQLException newException(SQ

[jira] [Commented] (PHOENIX-6185) OPERATION_TIMED_OUT#newException method swallows the exception message and root cause exception.

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214785#comment-17214785 ] ASF GitHub Bot commented on PHOENIX-6185: - virajjasani commented on a change in

[jira] [Commented] (PHOENIX-6125) Make sure SYSTEM.TASK does not split

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214815#comment-17214815 ] ASF GitHub Bot commented on PHOENIX-6125: - stoty commented on pull request #923

[GitHub] [phoenix] stoty commented on pull request #923: PHOENIX-6125 : Disable region split for SYSTEM.TASK

2020-10-15 Thread GitBox
stoty commented on pull request #923: URL: https://github.com/apache/phoenix/pull/923#issuecomment-709434781 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Doc

[GitHub] [phoenix] swaroopak merged pull request #922: PHOENIX-5946 (Addendum to use slf4j logging)

2020-10-15 Thread GitBox
swaroopak merged pull request #922: URL: https://github.com/apache/phoenix/pull/922 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (PHOENIX-5946) Implement SchemaExtractionTool utility to get effective DDL from cluster

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214834#comment-17214834 ] ASF GitHub Bot commented on PHOENIX-5946: - swaroopak merged pull request #922:

[GitHub] [phoenix] shahrs87 commented on a change in pull request #919: PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException

2020-10-15 Thread GitBox
shahrs87 commented on a change in pull request #919: URL: https://github.com/apache/phoenix/pull/919#discussion_r505722662 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/OperationTimeoutWithReasonIT.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Sof

[GitHub] [phoenix] stoty commented on pull request #917: PHOENIX-6124 : Conditionally block adding/dropping a column on a parent view

2020-10-15 Thread GitBox
stoty commented on pull request #917: URL: https://github.com/apache/phoenix/pull/917#issuecomment-709483032 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Doc

[jira] [Commented] (PHOENIX-6185) OPERATION_TIMED_OUT#newException method swallows the exception message and root cause exception.

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214868#comment-17214868 ] ASF GitHub Bot commented on PHOENIX-6185: - shahrs87 commented on a change in pu

[jira] [Commented] (PHOENIX-6124) Block adding/dropping a column on a parent view for clients <4.15 and for clients that have phoenix.allow.system.catalog.rollback=true

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214869#comment-17214869 ] ASF GitHub Bot commented on PHOENIX-6124: - stoty commented on pull request #917

[GitHub] [phoenix] virajjasani commented on a change in pull request #919: PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException

2020-10-15 Thread GitBox
virajjasani commented on a change in pull request #919: URL: https://github.com/apache/phoenix/pull/919#discussion_r505730341 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/OperationTimeoutWithReasonIT.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache

[jira] [Commented] (PHOENIX-6185) OPERATION_TIMED_OUT#newException method swallows the exception message and root cause exception.

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214876#comment-17214876 ] ASF GitHub Bot commented on PHOENIX-6185: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #919: PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException

2020-10-15 Thread GitBox
virajjasani commented on a change in pull request #919: URL: https://github.com/apache/phoenix/pull/919#discussion_r505730341 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/OperationTimeoutWithReasonIT.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache

[jira] [Commented] (PHOENIX-6185) OPERATION_TIMED_OUT#newException method swallows the exception message and root cause exception.

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214878#comment-17214878 ] ASF GitHub Bot commented on PHOENIX-6185: - virajjasani commented on a change in

[GitHub] [phoenix] shahrs87 commented on a change in pull request #919: PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException

2020-10-15 Thread GitBox
shahrs87 commented on a change in pull request #919: URL: https://github.com/apache/phoenix/pull/919#discussion_r505733497 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/OperationTimeoutWithReasonIT.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Sof

[GitHub] [phoenix] virajjasani commented on a change in pull request #919: PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException

2020-10-15 Thread GitBox
virajjasani commented on a change in pull request #919: URL: https://github.com/apache/phoenix/pull/919#discussion_r505730341 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/OperationTimeoutWithReasonIT.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache

[jira] [Commented] (PHOENIX-6142) Make DDL operations resilient to orphan parent->child linking rows in SYSTEM.CHILD_LINK

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214883#comment-17214883 ] ASF GitHub Bot commented on PHOENIX-6142: - stoty commented on pull request #903

[jira] [Commented] (PHOENIX-6185) OPERATION_TIMED_OUT#newException method swallows the exception message and root cause exception.

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214881#comment-17214881 ] ASF GitHub Bot commented on PHOENIX-6185: - shahrs87 commented on a change in pu

[jira] [Commented] (PHOENIX-6185) OPERATION_TIMED_OUT#newException method swallows the exception message and root cause exception.

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214882#comment-17214882 ] ASF GitHub Bot commented on PHOENIX-6185: - virajjasani commented on a change in

[GitHub] [phoenix] stoty commented on pull request #903: PHOENIX-6142: Make DDL operations resilient to orphan parent->child linking rows in SYSTEM.CHILD_LINK

2020-10-15 Thread GitBox
stoty commented on pull request #903: URL: https://github.com/apache/phoenix/pull/903#issuecomment-709493485 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Doc

[jira] [Commented] (PHOENIX-6185) OPERATION_TIMED_OUT#newException method swallows the exception message and root cause exception.

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214885#comment-17214885 ] ASF GitHub Bot commented on PHOENIX-6185: - stoty commented on pull request #919

[GitHub] [phoenix] stoty commented on pull request #919: PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException

2020-10-15 Thread GitBox
stoty commented on pull request #919: URL: https://github.com/apache/phoenix/pull/919#issuecomment-709496926 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Doc

[GitHub] [phoenix] stoty commented on pull request #920: PHOENIX-6129 : Avoid redundant Admin API call in the absence of SYSTEM.MUTEX table

2020-10-15 Thread GitBox
stoty commented on pull request #920: URL: https://github.com/apache/phoenix/pull/920#issuecomment-709502608 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s | Doc

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214893#comment-17214893 ] ASF GitHub Bot commented on PHOENIX-6129: - stoty commented on pull request #920

[GitHub] [phoenix] virajjasani commented on a change in pull request #919: PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException

2020-10-15 Thread GitBox
virajjasani commented on a change in pull request #919: URL: https://github.com/apache/phoenix/pull/919#discussion_r505755842 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/OperationTimeoutWithReasonIT.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache

[jira] [Commented] (PHOENIX-6185) OPERATION_TIMED_OUT#newException method swallows the exception message and root cause exception.

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214907#comment-17214907 ] ASF GitHub Bot commented on PHOENIX-6185: - virajjasani commented on a change in

[GitHub] [phoenix] shahrs87 commented on a change in pull request #919: PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException

2020-10-15 Thread GitBox
shahrs87 commented on a change in pull request #919: URL: https://github.com/apache/phoenix/pull/919#discussion_r505758010 ## File path: phoenix-core/src/test/java/org/apache/phoenix/util/SQLExceptionCodeTest.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Fo

[jira] [Commented] (PHOENIX-6185) OPERATION_TIMED_OUT#newException method swallows the exception message and root cause exception.

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214910#comment-17214910 ] ASF GitHub Bot commented on PHOENIX-6185: - shahrs87 commented on a change in pu

[jira] [Commented] (PHOENIX-6185) OPERATION_TIMED_OUT#newException method swallows the exception message and root cause exception.

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214913#comment-17214913 ] ASF GitHub Bot commented on PHOENIX-6185: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #919: PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException

2020-10-15 Thread GitBox
virajjasani commented on a change in pull request #919: URL: https://github.com/apache/phoenix/pull/919#discussion_r505759040 ## File path: phoenix-core/src/test/java/org/apache/phoenix/util/SQLExceptionCodeTest.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (PHOENIX-6181) IndexRepairRegionScanner to verify and repair every global index row

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214947#comment-17214947 ] ASF GitHub Bot commented on PHOENIX-6181: - kadirozde commented on a change in p

[GitHub] [phoenix] kadirozde commented on a change in pull request #915: PHOENIX-6181 IndexRepairRegionScanner to verify and repair every glob…

2020-10-15 Thread GitBox
kadirozde commented on a change in pull request #915: URL: https://github.com/apache/phoenix/pull/915#discussion_r505789656 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRepairRegionScanner.java ## @@ -0,0 +1,426 @@ +/* + * Licensed to the Apache

[GitHub] [phoenix] stoty commented on pull request #923: PHOENIX-6125 : Disable region split for SYSTEM.TASK

2020-10-15 Thread GitBox
stoty commented on pull request #923: URL: https://github.com/apache/phoenix/pull/923#issuecomment-709572438 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Doc

[jira] [Commented] (PHOENIX-6125) Make sure SYSTEM.TASK does not split

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214988#comment-17214988 ] ASF GitHub Bot commented on PHOENIX-6125: - stoty commented on pull request #923

[GitHub] [phoenix] stoty commented on pull request #915: PHOENIX-6181 IndexRepairRegionScanner to verify and repair every glob…

2020-10-15 Thread GitBox
stoty commented on pull request #915: URL: https://github.com/apache/phoenix/pull/915#issuecomment-709585867 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Doc

[jira] [Commented] (PHOENIX-6181) IndexRepairRegionScanner to verify and repair every global index row

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215001#comment-17215001 ] ASF GitHub Bot commented on PHOENIX-6181: - stoty commented on pull request #915

[GitHub] [phoenix] stoty commented on pull request #919: PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException

2020-10-15 Thread GitBox
stoty commented on pull request #919: URL: https://github.com/apache/phoenix/pull/919#issuecomment-709605600 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Doc

[jira] [Commented] (PHOENIX-6185) OPERATION_TIMED_OUT#newException method swallows the exception message and root cause exception.

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215024#comment-17215024 ] ASF GitHub Bot commented on PHOENIX-6185: - stoty commented on pull request #919

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #923: PHOENIX-6125 : Disable region split for SYSTEM.TASK

2020-10-15 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #923: URL: https://github.com/apache/phoenix/pull/923#discussion_r505873712 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -1336,6 +1337,8 @@ private TableDescripto

[jira] [Commented] (PHOENIX-6125) Make sure SYSTEM.TASK does not split

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215028#comment-17215028 ] ASF GitHub Bot commented on PHOENIX-6125: - ChinmaySKulkarni commented on a chan

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #923: PHOENIX-6125 : Disable region split for SYSTEM.TASK

2020-10-15 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #923: URL: https://github.com/apache/phoenix/pull/923#discussion_r505885857 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -1451,7 +1454,35 @@ private TableDescript

[jira] [Commented] (PHOENIX-6125) Make sure SYSTEM.TASK does not split

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215030#comment-17215030 ] ASF GitHub Bot commented on PHOENIX-6125: - ChinmaySKulkarni commented on a chan

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #923: PHOENIX-6125 : Disable region split for SYSTEM.TASK

2020-10-15 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #923: URL: https://github.com/apache/phoenix/pull/923#discussion_r505888007 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -1336,6 +1337,8 @@ private TableDescripto

[jira] [Commented] (PHOENIX-6125) Make sure SYSTEM.TASK does not split

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215033#comment-17215033 ] ASF GitHub Bot commented on PHOENIX-6125: - ChinmaySKulkarni commented on a chan

[jira] [Commented] (PHOENIX-6125) Make sure SYSTEM.TASK does not split

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215034#comment-17215034 ] ASF GitHub Bot commented on PHOENIX-6125: - ChinmaySKulkarni commented on a chan

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #923: PHOENIX-6125 : Disable region split for SYSTEM.TASK

2020-10-15 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #923: URL: https://github.com/apache/phoenix/pull/923#discussion_r505879419 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -4006,6 +4037,33 @@ private PhoenixConnec

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #923: PHOENIX-6125 : Disable region split for SYSTEM.TASK

2020-10-15 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #923: URL: https://github.com/apache/phoenix/pull/923#discussion_r505888924 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -4006,6 +4037,33 @@ private PhoenixConnec

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #923: PHOENIX-6125 : Disable region split for SYSTEM.TASK

2020-10-15 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #923: URL: https://github.com/apache/phoenix/pull/923#discussion_r505874109 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -1451,7 +1454,35 @@ private TableDescript

[jira] [Commented] (PHOENIX-6125) Make sure SYSTEM.TASK does not split

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215036#comment-17215036 ] ASF GitHub Bot commented on PHOENIX-6125: - ChinmaySKulkarni commented on a chan

[jira] [Commented] (PHOENIX-6125) Make sure SYSTEM.TASK does not split

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215038#comment-17215038 ] ASF GitHub Bot commented on PHOENIX-6125: - ChinmaySKulkarni commented on a chan

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #923: PHOENIX-6125 : Disable region split for SYSTEM.TASK

2020-10-15 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #923: URL: https://github.com/apache/phoenix/pull/923#discussion_r505888007 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -1336,6 +1337,8 @@ private TableDescripto

[jira] [Commented] (PHOENIX-6125) Make sure SYSTEM.TASK does not split

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215040#comment-17215040 ] ASF GitHub Bot commented on PHOENIX-6125: - ChinmaySKulkarni commented on a chan

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215049#comment-17215049 ] ASF GitHub Bot commented on PHOENIX-6129: - ChinmaySKulkarni commented on a chan

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #920: PHOENIX-6129 : Avoid redundant Admin API call in the absence of SYSTEM.MUTEX table

2020-10-15 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #920: URL: https://github.com/apache/phoenix/pull/920#discussion_r505900118 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -4294,11 +4295,9 @@ public boolean acquir

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #920: PHOENIX-6129 : Avoid redundant Admin API call in the absence of SYSTEM.MUTEX table

2020-10-15 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #920: URL: https://github.com/apache/phoenix/pull/920#discussion_r505900118 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -4294,11 +4295,9 @@ public boolean acquir

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215050#comment-17215050 ] ASF GitHub Bot commented on PHOENIX-6129: - ChinmaySKulkarni commented on a chan

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215051#comment-17215051 ] ASF GitHub Bot commented on PHOENIX-6129: - ChinmaySKulkarni commented on a chan

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #920: PHOENIX-6129 : Avoid redundant Admin API call in the absence of SYSTEM.MUTEX table

2020-10-15 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #920: URL: https://github.com/apache/phoenix/pull/920#discussion_r505900118 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -4294,11 +4295,9 @@ public boolean acquir

[GitHub] [phoenix] stoty removed a comment on pull request #903: PHOENIX-6142: Make DDL operations resilient to orphan parent->child linking rows in SYSTEM.CHILD_LINK

2020-10-15 Thread GitBox
stoty removed a comment on pull request #903: URL: https://github.com/apache/phoenix/pull/903#issuecomment-709493485 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #908: PHOENIX-6172 Updating VIEW_INDEX_ID column type and ts in Syscat with…

2020-10-15 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #908: URL: https://github.com/apache/phoenix/pull/908#discussion_r505903071 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/UpgradeIT.java ## @@ -672,4 +689,61 @@ private SequenceKey createViewIndexSequen

[jira] [Commented] (PHOENIX-6172) Updating VIEW_INDEX_ID column type and ts in Syscat with a 4.16 upgrade script

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215058#comment-17215058 ] ASF GitHub Bot commented on PHOENIX-6172: - ChinmaySKulkarni commented on a chan

[jira] [Commented] (PHOENIX-6142) Make DDL operations resilient to orphan parent->child linking rows in SYSTEM.CHILD_LINK

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215059#comment-17215059 ] ASF GitHub Bot commented on PHOENIX-6142: - stoty removed a comment on pull requ

[GitHub] [phoenix] yanxinyi opened a new pull request #924: PHOENIX-6189 DATA_EXCEEDS_MAX_CAPACITY exception error string should …

2020-10-15 Thread GitBox
yanxinyi opened a new pull request #924: URL: https://github.com/apache/phoenix/pull/924 …contain column name instead of actual value This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (PHOENIX-6189) DATA_EXCEEDS_MAX_CAPACITY exception error string should contain column name instead of actual value

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215067#comment-17215067 ] ASF GitHub Bot commented on PHOENIX-6189: - yanxinyi opened a new pull request #

[GitHub] [phoenix] stoty commented on pull request #903: PHOENIX-6142: Make DDL operations resilient to orphan parent->child linking rows in SYSTEM.CHILD_LINK

2020-10-15 Thread GitBox
stoty commented on pull request #903: URL: https://github.com/apache/phoenix/pull/903#issuecomment-709674292 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Doc

[jira] [Commented] (PHOENIX-6142) Make DDL operations resilient to orphan parent->child linking rows in SYSTEM.CHILD_LINK

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215100#comment-17215100 ] ASF GitHub Bot commented on PHOENIX-6142: - stoty commented on pull request #903

[jira] [Commented] (PHOENIX-6172) Updating VIEW_INDEX_ID column type and ts in Syscat with a 4.16 upgrade script

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215113#comment-17215113 ] ASF GitHub Bot commented on PHOENIX-6172: - stoty commented on pull request #908

[GitHub] [phoenix] stoty commented on pull request #908: PHOENIX-6172 Updating VIEW_INDEX_ID column type and ts in Syscat with…

2020-10-15 Thread GitBox
stoty commented on pull request #908: URL: https://github.com/apache/phoenix/pull/908#issuecomment-709681745 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Doc

[jira] [Commented] (PHOENIX-6142) Make DDL operations resilient to orphan parent->child linking rows in SYSTEM.CHILD_LINK

2020-10-15 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215115#comment-17215115 ] Hadoop QA commented on PHOENIX-6142: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [phoenix] stoty commented on pull request #908: PHOENIX-6172 Updating VIEW_INDEX_ID column type and ts in Syscat with…

2020-10-15 Thread GitBox
stoty commented on pull request #908: URL: https://github.com/apache/phoenix/pull/908#issuecomment-709696508 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 35s | Doc

[jira] [Commented] (PHOENIX-6172) Updating VIEW_INDEX_ID column type and ts in Syscat with a 4.16 upgrade script

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215127#comment-17215127 ] ASF GitHub Bot commented on PHOENIX-6172: - stoty commented on pull request #908

[jira] [Commented] (PHOENIX-6189) DATA_EXCEEDS_MAX_CAPACITY exception error string should contain column name instead of actual value

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215142#comment-17215142 ] ASF GitHub Bot commented on PHOENIX-6189: - ntshmah commented on a change in pul

[GitHub] [phoenix] ntshmah commented on a change in pull request #924: PHOENIX-6189 DATA_EXCEEDS_MAX_CAPACITY exception error string should …

2020-10-15 Thread GitBox
ntshmah commented on a change in pull request #924: URL: https://github.com/apache/phoenix/pull/924#discussion_r506022114 ## File path: phoenix-core/src/test/java/org/apache/phoenix/schema/MutationTest.java ## @@ -92,18 +92,24 @@ public void testSizeConstraint() throws Excepti

[GitHub] [phoenix] stoty commented on pull request #924: PHOENIX-6189 DATA_EXCEEDS_MAX_CAPACITY exception error string should …

2020-10-15 Thread GitBox
stoty commented on pull request #924: URL: https://github.com/apache/phoenix/pull/924#issuecomment-709713405 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 16s | Doc

[jira] [Commented] (PHOENIX-6189) DATA_EXCEEDS_MAX_CAPACITY exception error string should contain column name instead of actual value

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215147#comment-17215147 ] ASF GitHub Bot commented on PHOENIX-6189: - stoty commented on pull request #924

[GitHub] [phoenix] virajjasani commented on a change in pull request #920: PHOENIX-6129 : Avoid redundant Admin API call in the absence of SYSTEM.MUTEX table

2020-10-15 Thread GitBox
virajjasani commented on a change in pull request #920: URL: https://github.com/apache/phoenix/pull/920#discussion_r506072933 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -4294,11 +4295,9 @@ public boolean acquireUpgr

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215212#comment-17215212 ] ASF GitHub Bot commented on PHOENIX-6129: - virajjasani commented on a change in

  1   2   >