[jira] [Commented] (PHOENIX-6172) Updating VIEW_INDEX_ID column type and ts in Syscat with a 4.16 upgrade script

2020-10-17 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215810#comment-17215810 ] Hadoop QA commented on PHOENIX-6172: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [phoenix] stoty opened a new pull request #925: PHOENIX-6193 PHOENIX-6151 slows down shading

2020-10-17 Thread GitBox
stoty opened a new pull request #925: URL: https://github.com/apache/phoenix/pull/925 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (PHOENIX-6193) PHOENIX-6151 slows down shading

2020-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215821#comment-17215821 ] ASF GitHub Bot commented on PHOENIX-6193: - stoty opened a new pull request #925

[jira] [Commented] (PHOENIX-6193) PHOENIX-6151 slows down shading

2020-10-17 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215822#comment-17215822 ] Istvan Toth commented on PHOENIX-6193: -- This seems to be caused by the unneccessar

[jira] [Commented] (PHOENIX-6151) Switch phoenix-client to shade-by-default mode

2020-10-17 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215823#comment-17215823 ] Istvan Toth commented on PHOENIX-6151: -- I have opened PHOENIX-6193 and atteched a

[GitHub] [phoenix] stoty commented on pull request #925: PHOENIX-6193 PHOENIX-6151 slows down shading

2020-10-17 Thread GitBox
stoty commented on pull request #925: URL: https://github.com/apache/phoenix/pull/925#issuecomment-710790374 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Doc

[jira] [Commented] (PHOENIX-6193) PHOENIX-6151 slows down shading

2020-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215838#comment-17215838 ] ASF GitHub Bot commented on PHOENIX-6193: - stoty commented on pull request #925

[GitHub] [phoenix] virajjasani opened a new pull request #926: PHOENIX-6194 : Include slf4j-api dependency in phoenix-tools

2020-10-17 Thread GitBox
virajjasani opened a new pull request #926: URL: https://github.com/apache/phoenix/pull/926 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Commented] (PHOENIX-6194) Build failure due to missing slf4j dependency in phoenix-tools

2020-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215839#comment-17215839 ] ASF GitHub Bot commented on PHOENIX-6194: - virajjasani opened a new pull reques

[GitHub] [phoenix] virajjasani commented on pull request #926: PHOENIX-6194 : Include slf4j-api dependency in phoenix-tools

2020-10-17 Thread GitBox
virajjasani commented on pull request #926: URL: https://github.com/apache/phoenix/pull/926#issuecomment-710791058 @stoty could you please take a look? This is an automated message from the Apache Git Service. To respond to t

[jira] [Commented] (PHOENIX-6194) Build failure due to missing slf4j dependency in phoenix-tools

2020-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215841#comment-17215841 ] ASF GitHub Bot commented on PHOENIX-6194: - virajjasani commented on pull reques

[GitHub] [phoenix] stoty commented on pull request #926: PHOENIX-6194 : Include slf4j-api dependency in phoenix-tools

2020-10-17 Thread GitBox
stoty commented on pull request #926: URL: https://github.com/apache/phoenix/pull/926#issuecomment-710853177 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Doc

[jira] [Commented] (PHOENIX-6194) Build failure due to missing slf4j dependency in phoenix-tools

2020-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215849#comment-17215849 ] ASF GitHub Bot commented on PHOENIX-6194: - stoty commented on pull request #926

[jira] [Commented] (PHOENIX-6194) Build failure due to missing slf4j dependency in phoenix-tools

2020-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215850#comment-17215850 ] ASF GitHub Bot commented on PHOENIX-6194: - virajjasani commented on pull reques

[GitHub] [phoenix] virajjasani commented on pull request #926: PHOENIX-6194 : Include slf4j-api dependency in phoenix-tools

2020-10-17 Thread GitBox
virajjasani commented on pull request #926: URL: https://github.com/apache/phoenix/pull/926#issuecomment-710856200 `mvninstall` for patch is +1 This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Commented] (PHOENIX-6194) Build failure due to missing slf4j dependency in phoenix-tools

2020-10-17 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215851#comment-17215851 ] Viraj Jasani commented on PHOENIX-6194: --- [~stoty] when you get time, can you plea

[jira] [Commented] (PHOENIX-6082) No need to do checkAndPut when altering properties for a table or view with column-encoding enabled

2020-10-17 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215877#comment-17215877 ] Viraj Jasani commented on PHOENIX-6082: --- [~ckulkarni] The only diff b/ "ALTER TAB

[jira] [Comment Edited] (PHOENIX-6082) No need to do checkAndPut when altering properties for a table or view with column-encoding enabled

2020-10-17 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215877#comment-17215877 ] Viraj Jasani edited comment on PHOENIX-6082 at 10/17/20, 12:29 PM: --

[jira] [Commented] (PHOENIX-6188) Jenkins job history uses too much storage

2020-10-17 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215884#comment-17215884 ] Istvan Toth commented on PHOENIX-6188: -- This compresses the logs that are linked f

[GitHub] [phoenix] yanxinyi commented on pull request #917: PHOENIX-6124 : Conditionally block adding/dropping a column on a parent view

2020-10-17 Thread GitBox
yanxinyi commented on pull request #917: URL: https://github.com/apache/phoenix/pull/917#issuecomment-711044727 LGTM +1. This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Commented] (PHOENIX-6124) Block adding/dropping a column on a parent view for clients <4.15 and for clients that have phoenix.allow.system.catalog.rollback=true

2020-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215941#comment-17215941 ] ASF GitHub Bot commented on PHOENIX-6124: - yanxinyi commented on pull request #

[GitHub] [phoenix] yanxinyi commented on a change in pull request #917: PHOENIX-6124 : Conditionally block adding/dropping a column on a parent view

2020-10-17 Thread GitBox
yanxinyi commented on a change in pull request #917: URL: https://github.com/apache/phoenix/pull/917#discussion_r506961711 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterParentTableWithSysCatRollbackIT.java ## @@ -0,0 +1,142 @@ +/* + * Licensed to the A

[jira] [Commented] (PHOENIX-6124) Block adding/dropping a column on a parent view for clients <4.15 and for clients that have phoenix.allow.system.catalog.rollback=true

2020-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215942#comment-17215942 ] ASF GitHub Bot commented on PHOENIX-6124: - yanxinyi commented on a change in pu

[GitHub] [phoenix] virajjasani commented on a change in pull request #917: PHOENIX-6124 : Conditionally block adding/dropping a column on a parent view

2020-10-17 Thread GitBox
virajjasani commented on a change in pull request #917: URL: https://github.com/apache/phoenix/pull/917#discussion_r506962076 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterParentTableWithSysCatRollbackIT.java ## @@ -0,0 +1,142 @@ +/* + * Licensed to th

[jira] [Commented] (PHOENIX-6124) Block adding/dropping a column on a parent view for clients <4.15 and for clients that have phoenix.allow.system.catalog.rollback=true

2020-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215944#comment-17215944 ] ASF GitHub Bot commented on PHOENIX-6124: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #917: PHOENIX-6124 : Conditionally block adding/dropping a column on a parent view

2020-10-17 Thread GitBox
virajjasani commented on a change in pull request #917: URL: https://github.com/apache/phoenix/pull/917#discussion_r506962076 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterParentTableWithSysCatRollbackIT.java ## @@ -0,0 +1,142 @@ +/* + * Licensed to th

[GitHub] [phoenix] virajjasani commented on a change in pull request #917: PHOENIX-6124 : Conditionally block adding/dropping a column on a parent view

2020-10-17 Thread GitBox
virajjasani commented on a change in pull request #917: URL: https://github.com/apache/phoenix/pull/917#discussion_r506962076 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterParentTableWithSysCatRollbackIT.java ## @@ -0,0 +1,142 @@ +/* + * Licensed to th

[jira] [Commented] (PHOENIX-6124) Block adding/dropping a column on a parent view for clients <4.15 and for clients that have phoenix.allow.system.catalog.rollback=true

2020-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215948#comment-17215948 ] ASF GitHub Bot commented on PHOENIX-6124: - virajjasani commented on a change in

[jira] [Commented] (PHOENIX-6124) Block adding/dropping a column on a parent view for clients <4.15 and for clients that have phoenix.allow.system.catalog.rollback=true

2020-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215949#comment-17215949 ] ASF GitHub Bot commented on PHOENIX-6124: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #917: PHOENIX-6124 : Conditionally block adding/dropping a column on a parent view

2020-10-17 Thread GitBox
virajjasani commented on a change in pull request #917: URL: https://github.com/apache/phoenix/pull/917#discussion_r506962076 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterParentTableWithSysCatRollbackIT.java ## @@ -0,0 +1,142 @@ +/* + * Licensed to th

[jira] [Commented] (PHOENIX-6124) Block adding/dropping a column on a parent view for clients <4.15 and for clients that have phoenix.allow.system.catalog.rollback=true

2020-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215951#comment-17215951 ] ASF GitHub Bot commented on PHOENIX-6124: - virajjasani commented on a change in

[jira] [Commented] (PHOENIX-6151) Switch phoenix-client to shade-by-default mode

2020-10-17 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216037#comment-17216037 ] Lars Hofhansl commented on PHOENIX-6151: Thanks. Sorry I don't have time to fix

[GitHub] [phoenix] lhofhansl commented on pull request #925: PHOENIX-6193 PHOENIX-6151 slows down shading

2020-10-17 Thread GitBox
lhofhansl commented on pull request #925: URL: https://github.com/apache/phoenix/pull/925#issuecomment-711079569 I'll try this out today. This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Commented] (PHOENIX-6193) PHOENIX-6151 slows down shading

2020-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216039#comment-17216039 ] ASF GitHub Bot commented on PHOENIX-6193: - lhofhansl commented on pull request

[GitHub] [phoenix] lhofhansl commented on pull request #925: PHOENIX-6193 PHOENIX-6151 slows down shading

2020-10-17 Thread GitBox
lhofhansl commented on pull request #925: URL: https://github.com/apache/phoenix/pull/925#issuecomment-711080988 Faster, about 500KB/s, but still take a long time to build the two 150MB jars. Can we build client and client-embedded in parallel? -

[jira] [Commented] (PHOENIX-6193) PHOENIX-6151 slows down shading

2020-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216044#comment-17216044 ] ASF GitHub Bot commented on PHOENIX-6193: - lhofhansl commented on pull request

[GitHub] [phoenix] lhofhansl edited a comment on pull request #925: PHOENIX-6193 PHOENIX-6151 slows down shading

2020-10-17 Thread GitBox
lhofhansl edited a comment on pull request #925: URL: https://github.com/apache/phoenix/pull/925#issuecomment-711080988 Faster, about 500KB/s, but still take a long time to build the two 150MB jars. It keeps one core busy on my machine... Can we build client and client-embedded in paral

[GitHub] [phoenix] lhofhansl edited a comment on pull request #925: PHOENIX-6193 PHOENIX-6151 slows down shading

2020-10-17 Thread GitBox
lhofhansl edited a comment on pull request #925: URL: https://github.com/apache/phoenix/pull/925#issuecomment-711080988 Faster, about 500KB/s, but still take a long time to build the two 150MB jars. It keeps one core busy on my machine... Can we build client and client-embedded in paral

[jira] [Commented] (PHOENIX-6193) PHOENIX-6151 slows down shading

2020-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216045#comment-17216045 ] ASF GitHub Bot commented on PHOENIX-6193: - lhofhansl edited a comment on pull r

[jira] [Commented] (PHOENIX-6193) PHOENIX-6151 slows down shading

2020-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216046#comment-17216046 ] ASF GitHub Bot commented on PHOENIX-6193: - lhofhansl edited a comment on pull r

[jira] [Issue Comment Deleted] (PHOENIX-6193) PHOENIX-6151 slows down shading

2020-10-17 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated PHOENIX-6193: --- Comment: was deleted (was: lhofhansl edited a comment on pull request #925: URL: https://gi

[jira] [Issue Comment Deleted] (PHOENIX-6193) PHOENIX-6151 slows down shading

2020-10-17 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl updated PHOENIX-6193: --- Comment: was deleted (was: lhofhansl commented on pull request #925: URL: https://github.co

[jira] [Commented] (PHOENIX-6181) IndexRepairRegionScanner to verify and repair every global index row

2020-10-17 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216068#comment-17216068 ] Hadoop QA commented on PHOENIX-6181: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (PHOENIX-6194) Build failure due to missing slf4j dependency in phoenix-tools

2020-10-17 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216098#comment-17216098 ] Viraj Jasani commented on PHOENIX-6194: --- Thanks for the review [~stoty], could yo