[jira] [Commented] (PHOENIX-5955) OrphanViewToolIT is flapping

2020-11-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228984#comment-17228984 ] Hadoop QA commented on PHOENIX-5955: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (PHOENIX-6139) Fix ConcurrentMutationsExtendedIT

2020-11-09 Thread Xinyi Yan (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228979#comment-17228979 ] Xinyi Yan commented on PHOENIX-6139: +1 :)  > Fix ConcurrentMutationsExtendedIT >

[jira] [Commented] (PHOENIX-6085) Remove duplicate calls to getSysMutexPhysicalTableNameBytes() during the upgrade path

2020-11-09 Thread Xinyi Yan (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228967#comment-17228967 ] Xinyi Yan commented on PHOENIX-6085: [~ckulkarni], maybe we can move this to 4.16.1

[jira] [Commented] (PHOENIX-6127) Prevent unnecessary HBase admin API calls in ViewUtil.getSystemTableForChildLinks() and act lazily instead

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228966#comment-17228966 ] ASF GitHub Bot commented on PHOENIX-6127: - yanxinyi commented on pull request #

[GitHub] [phoenix] yanxinyi commented on pull request #944: PHOENIX-6127 Prevent unnecessary HBase admin API calls in ViewUtil.ge…

2020-11-09 Thread GitBox
yanxinyi commented on pull request #944: URL: https://github.com/apache/phoenix/pull/944#issuecomment-72611 hi @gjacoby126 , can you take another look for @richardantal , thanks! This is an automated message from the Apac

[jira] [Commented] (PHOENIX-5066) The TimeZone is incorrectly used during writing or reading data

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228903#comment-17228903 ] ASF GitHub Bot commented on PHOENIX-5066: - yanxinyi commented on pull request #

[GitHub] [phoenix] yanxinyi commented on pull request #796: PHOENIX-5066 The TimeZone is incorrectly used during writing or reading data

2020-11-09 Thread GitBox
yanxinyi commented on pull request #796: URL: https://github.com/apache/phoenix/pull/796#issuecomment-724395802 @richardantal can you rebase and handle all the suggestions, thanks This is an automated message from the Apache

[jira] [Commented] (PHOENIX-5998) Paged server side ungrouped aggregate operations

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228887#comment-17228887 ] ASF GitHub Bot commented on PHOENIX-5998: - ChinmaySKulkarni commented on a chan

[jira] [Commented] (PHOENIX-5998) Paged server side ungrouped aggregate operations

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228886#comment-17228886 ] ASF GitHub Bot commented on PHOENIX-5998: - ChinmaySKulkarni commented on a chan

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #936: PHOENIX-5998 Paged server side ungrouped aggregate operations

2020-11-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #936: URL: https://github.com/apache/phoenix/pull/936#discussion_r520211914 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java ## @@ -0,0 +1,645 @@ +/* + * Licensed

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #936: PHOENIX-5998 Paged server side ungrouped aggregate operations

2020-11-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #936: URL: https://github.com/apache/phoenix/pull/936#discussion_r520204425 ## File path: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java ## @@ -629,6 +629,9 @@ public static Configuration setUpConfigForM

[jira] [Commented] (PHOENIX-5998) Paged server side ungrouped aggregate operations

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228885#comment-17228885 ] ASF GitHub Bot commented on PHOENIX-5998: - ChinmaySKulkarni commented on a chan

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #936: PHOENIX-5998 Paged server side ungrouped aggregate operations

2020-11-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #936: URL: https://github.com/apache/phoenix/pull/936#discussion_r520195446 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java ## @@ -268,7 +244,7 @@ public void d

[jira] [Commented] (PHOENIX-6199) Generate different query plan depending upon if the source is index table or data table

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228859#comment-17228859 ] ASF GitHub Bot commented on PHOENIX-6199: - stoty commented on pull request #958

[jira] [Commented] (PHOENIX-6186) Store table metadata last modified timestamp in PTable / System.Catalog

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228858#comment-17228858 ] ASF GitHub Bot commented on PHOENIX-6186: - ChinmaySKulkarni commented on a chan

[GitHub] [phoenix] stoty commented on pull request #958: PHOENIX-6199 Generate different query plan depending upon if the source is index table or data table

2020-11-09 Thread GitBox
stoty commented on pull request #958: URL: https://github.com/apache/phoenix/pull/958#issuecomment-724349529 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Doc

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #935: PHOENIX-6186 - Store last DDL timestamp in System.Catalog

2020-11-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #935: URL: https://github.com/apache/phoenix/pull/935#discussion_r520188127 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java ## @@ -2037,7 +2049,10 @@ public void createTabl

[jira] [Commented] (PHOENIX-6186) Store table metadata last modified timestamp in PTable / System.Catalog

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228857#comment-17228857 ] ASF GitHub Bot commented on PHOENIX-6186: - ChinmaySKulkarni commented on a chan

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #935: PHOENIX-6186 - Store last DDL timestamp in System.Catalog

2020-11-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #935: URL: https://github.com/apache/phoenix/pull/935#discussion_r520170305 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/AddColumnMutator.java ## @@ -399,6 +401,19 @@ public MetaDataMutationResul

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #955: PHOENIX-5601 Add a new coprocessor for PHOENIX_TTL - PhoenixTTLRegionObserver

2020-11-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #955: URL: https://github.com/apache/phoenix/pull/955#discussion_r520143718 ## File path: phoenix-core/src/test/java/org/apache/phoenix/query/PhoenixTestBuilder.java ## @@ -294,27 +423,104 @@ public void upsertRow(int rowI

[jira] [Commented] (PHOENIX-5601) Add a new Coprocessor - ViewTTLAware Coprocessor

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228829#comment-17228829 ] ASF GitHub Bot commented on PHOENIX-5601: - ChinmaySKulkarni commented on a chan

[jira] [Commented] (PHOENIX-5601) Add a new Coprocessor - ViewTTLAware Coprocessor

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228828#comment-17228828 ] ASF GitHub Bot commented on PHOENIX-5601: - ChinmaySKulkarni commented on a chan

[jira] [Commented] (PHOENIX-5601) Add a new Coprocessor - ViewTTLAware Coprocessor

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228827#comment-17228827 ] ASF GitHub Bot commented on PHOENIX-5601: - ChinmaySKulkarni commented on a chan

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #955: PHOENIX-5601 Add a new coprocessor for PHOENIX_TTL - PhoenixTTLRegionObserver

2020-11-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #955: URL: https://github.com/apache/phoenix/pull/955#discussion_r520128527 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixTTLRegionObserver.java ## @@ -0,0 +1,368 @@ +/* + * Licensed to the

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #955: PHOENIX-5601 Add a new coprocessor for PHOENIX_TTL - PhoenixTTLRegionObserver

2020-11-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #955: URL: https://github.com/apache/phoenix/pull/955#discussion_r520127407 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixTTLRegionObserver.java ## @@ -0,0 +1,368 @@ +/* + * Licensed to the

[jira] [Commented] (PHOENIX-6199) Generate different query plan depending upon if the source is index table or data table

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228813#comment-17228813 ] ASF GitHub Bot commented on PHOENIX-6199: - stoty commented on pull request #958

[GitHub] [phoenix] stoty commented on pull request #958: PHOENIX-6199 Generate different query plan depending upon if the source is index table or data table

2020-11-09 Thread GitBox
stoty commented on pull request #958: URL: https://github.com/apache/phoenix/pull/958#issuecomment-724275426 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Doc

[jira] [Commented] (PHOENIX-6203) CQS.getTable(byte[] tableName) does not throw TNFE even if table doesn't exist

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228773#comment-17228773 ] ASF GitHub Bot commented on PHOENIX-6203: - virajjasani closed pull request #957

[jira] [Commented] (PHOENIX-6203) CQS.getTable(byte[] tableName) does not throw TNFE even if table doesn't exist

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228774#comment-17228774 ] ASF GitHub Bot commented on PHOENIX-6203: - virajjasani commented on pull reques

[GitHub] [phoenix] virajjasani closed pull request #957: PHOENIX-6203 : Add new CQS method to return Table instance only if table exists

2020-11-09 Thread GitBox
virajjasani closed pull request #957: URL: https://github.com/apache/phoenix/pull/957 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [phoenix] virajjasani commented on pull request #957: PHOENIX-6203 : Add new CQS method to return Table instance only if table exists

2020-11-09 Thread GitBox
virajjasani commented on pull request #957: URL: https://github.com/apache/phoenix/pull/957#issuecomment-724225188 Thanks for the review @yanxinyi This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [phoenix] tkhurana opened a new pull request #958: PHOENIX-6199 Generate different query plan depending upon if the source is index table or data table

2020-11-09 Thread GitBox
tkhurana opened a new pull request #958: URL: https://github.com/apache/phoenix/pull/958 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (PHOENIX-6199) Generate different query plan depending upon if the source is index table or data table

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228755#comment-17228755 ] ASF GitHub Bot commented on PHOENIX-6199: - tkhurana opened a new pull request #

[jira] [Commented] (PHOENIX-6198) Add option to IndexTool to specify the source table for scan

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228746#comment-17228746 ] ASF GitHub Bot commented on PHOENIX-6198: - swaroopak merged pull request #937:

[GitHub] [phoenix] swaroopak merged pull request #937: PHOENIX-6198 Add option to IndexTool to specify the source table for scan

2020-11-09 Thread GitBox
swaroopak merged pull request #937: URL: https://github.com/apache/phoenix/pull/937 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (PHOENIX-6203) CQS.getTable(byte[] tableName) does not throw TNFE even if table doesn't exist

2020-11-09 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228734#comment-17228734 ] Viraj Jasani commented on PHOENIX-6203: --- Last 2 build results are for 4.x patch a

[jira] [Commented] (PHOENIX-6203) CQS.getTable(byte[] tableName) does not throw TNFE even if table doesn't exist

2020-11-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228653#comment-17228653 ] Hadoop QA commented on PHOENIX-6203: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [phoenix] stoty closed pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…

2020-11-09 Thread GitBox
stoty closed pull request #953: URL: https://github.com/apache/phoenix/pull/953 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (PHOENIX-6091) Calling MetaDataProtocol.getVersion() on a 4.16 timestamp gives version as 4.15.x

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228580#comment-17228580 ] ASF GitHub Bot commented on PHOENIX-6091: - stoty closed pull request #953: URL:

[jira] [Commented] (PHOENIX-6203) CQS.getTable(byte[] tableName) does not throw TNFE even if table doesn't exist

2020-11-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228533#comment-17228533 ] Hadoop QA commented on PHOENIX-6203: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (PHOENIX-6203) CQS.getTable(byte[] tableName) does not throw TNFE even if table doesn't exist

2020-11-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228480#comment-17228480 ] ASF GitHub Bot commented on PHOENIX-6203: - stoty commented on pull request #957

[GitHub] [phoenix] stoty commented on pull request #957: PHOENIX-6203 : Add new CQS method to return Table instance only if table exists

2020-11-09 Thread GitBox
stoty commented on pull request #957: URL: https://github.com/apache/phoenix/pull/957#issuecomment-72391 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Doc

[jira] [Commented] (PHOENIX-6203) CQS.getTable(byte[] tableName) does not throw TNFE even if table doesn't exist

2020-11-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228475#comment-17228475 ] Hadoop QA commented on PHOENIX-6203: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (PHOENIX-5940) Pre-4.15 client cannot connect to 4.15+ server after SYSTEM.CATALOG region has split

2020-11-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228461#comment-17228461 ] Hadoop QA commented on PHOENIX-5940: | (x) *{color:red}-1 overall{color}* | \\ \\ |