[
https://issues.apache.org/jira/browse/PHOENIX-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236598#comment-17236598
]
Viraj Jasani commented on PHOENIX-6086:
---
[~ckulkarni] Thanks for bring this up, a
[
https://issues.apache.org/jira/browse/PHOENIX-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236579#comment-17236579
]
ASF GitHub Bot commented on PHOENIX-5592:
-
stoty commented on pull request #975
stoty commented on pull request #975:
URL: https://github.com/apache/phoenix/pull/975#issuecomment-731502296
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 5m 45s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236569#comment-17236569
]
ASF GitHub Bot commented on PHOENIX-5435:
-
stoty commented on pull request #913
stoty commented on pull request #913:
URL: https://github.com/apache/phoenix/pull/913#issuecomment-731496674
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m 27s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236564#comment-17236564
]
ASF GitHub Bot commented on PHOENIX-5895:
-
sandeepvinayak opened a new pull req
sandeepvinayak opened a new pull request #981:
URL: https://github.com/apache/phoenix/pull/981
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236554#comment-17236554
]
ASF GitHub Bot commented on PHOENIX-5712:
-
stoty commented on pull request #972
stoty commented on pull request #972:
URL: https://github.com/apache/phoenix/pull/972#issuecomment-731480592
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 4s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236544#comment-17236544
]
ASF GitHub Bot commented on PHOENIX-5712:
-
yanxinyi edited a comment on pull re
yanxinyi edited a comment on pull request #972:
URL: https://github.com/apache/phoenix/pull/972#issuecomment-731417547
Added filter at the Coproc preScannerOpen method as we discussed offline.
Please take a look again, thanks!
cc @jpisaac @ChinmaySKulkarni @kadirozde @lhofhansl
--
[
https://issues.apache.org/jira/browse/PHOENIX-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236533#comment-17236533
]
ASF GitHub Bot commented on PHOENIX-5592:
-
yanxinyi commented on a change in pu
yanxinyi commented on a change in pull request #975:
URL: https://github.com/apache/phoenix/pull/975#discussion_r528034033
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/DefaultPhoenixMultiViewListProvider.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/PHOENIX-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236532#comment-17236532
]
ASF GitHub Bot commented on PHOENIX-5592:
-
yanxinyi commented on a change in pu
yanxinyi commented on a change in pull request #975:
URL: https://github.com/apache/phoenix/pull/975#discussion_r528032496
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/DefaultPhoenixMultiViewListProvider.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/PHOENIX-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236519#comment-17236519
]
ASF GitHub Bot commented on PHOENIX-5592:
-
yanxinyi commented on a change in pu
yanxinyi commented on a change in pull request #975:
URL: https://github.com/apache/phoenix/pull/975#discussion_r528027130
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/DefaultPhoenixMultiViewListProvider.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/PHOENIX-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236518#comment-17236518
]
ASF GitHub Bot commented on PHOENIX-5592:
-
yanxinyi commented on a change in pu
yanxinyi commented on a change in pull request #975:
URL: https://github.com/apache/phoenix/pull/975#discussion_r528026223
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/DefaultMultiViewSplitStrategy.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/PHOENIX-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236516#comment-17236516
]
ASF GitHub Bot commented on PHOENIX-6127:
-
ChinmaySKulkarni commented on a chan
ChinmaySKulkarni commented on a change in pull request #944:
URL: https://github.com/apache/phoenix/pull/944#discussion_r528024432
##
File path: phoenix-core/src/main/java/org/apache/phoenix/util/ViewUtil.java
##
@@ -337,6 +337,49 @@ public boolean filterAllRemaining() {
/
[
https://issues.apache.org/jira/browse/PHOENIX-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236517#comment-17236517
]
ASF GitHub Bot commented on PHOENIX-6213:
-
gjacoby126 commented on a change in
gjacoby126 commented on a change in pull request #978:
URL: https://github.com/apache/phoenix/pull/978#discussion_r528022823
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java
##
@@ -991,6 +999,46 @@ public void
preBatchMutateWith
[
https://issues.apache.org/jira/browse/PHOENIX-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236514#comment-17236514
]
ASF GitHub Bot commented on PHOENIX-6127:
-
ChinmaySKulkarni commented on a chan
yanxinyi commented on a change in pull request #975:
URL: https://github.com/apache/phoenix/pull/975#discussion_r528025843
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/DefaultMultiViewSplitStrategy.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/PHOENIX-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236513#comment-17236513
]
ASF GitHub Bot commented on PHOENIX-5592:
-
yanxinyi commented on a change in pu
ChinmaySKulkarni commented on a change in pull request #944:
URL: https://github.com/apache/phoenix/pull/944#discussion_r528022575
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
##
@@ -2458,6 +2455,35 @@ private MetaDataRespon
[
https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236498#comment-17236498
]
ASF GitHub Bot commented on PHOENIX-6186:
-
gjacoby126 commented on pull request
[
https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236499#comment-17236499
]
ASF GitHub Bot commented on PHOENIX-6186:
-
gjacoby126 merged pull request #977:
gjacoby126 merged pull request #977:
URL: https://github.com/apache/phoenix/pull/977
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gjacoby126 commented on pull request #977:
URL: https://github.com/apache/phoenix/pull/977#issuecomment-731452671
Tests passed; the failure seems to come from jacoco crashing afterward.
Since this is just a port of the previously approved 4.x version of
PHOENIX-6186, I'm going to go ahead
stoty commented on pull request #977:
URL: https://github.com/apache/phoenix/pull/977#issuecomment-731446812
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 42s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236494#comment-17236494
]
ASF GitHub Bot commented on PHOENIX-6186:
-
stoty commented on pull request #977
[
https://issues.apache.org/jira/browse/PHOENIX-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236488#comment-17236488
]
Chinmay Kulkarni edited comment on PHOENIX-6086 at 11/20/20, 10:43 PM:
--
[
https://issues.apache.org/jira/browse/PHOENIX-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236488#comment-17236488
]
Chinmay Kulkarni edited comment on PHOENIX-6086 at 11/20/20, 10:42 PM:
--
[
https://issues.apache.org/jira/browse/PHOENIX-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236488#comment-17236488
]
Chinmay Kulkarni commented on PHOENIX-6086:
---
[~vjasani] I created this Jira t
[
https://issues.apache.org/jira/browse/PHOENIX-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236477#comment-17236477
]
ASF GitHub Bot commented on PHOENIX-5592:
-
yanxinyi commented on a change in pu
yanxinyi commented on a change in pull request #975:
URL: https://github.com/apache/phoenix/pull/975#discussion_r528000931
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTTLTool.java
##
@@ -0,0 +1,320 @@
+/*
+ * Licensed to the Apache Software Founda
[
https://issues.apache.org/jira/browse/PHOENIX-5920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236474#comment-17236474
]
Hadoop QA commented on PHOENIX-5920:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|
[
https://issues.apache.org/jira/browse/PHOENIX-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236470#comment-17236470
]
ASF GitHub Bot commented on PHOENIX-5592:
-
yanxinyi commented on a change in pu
yanxinyi commented on a change in pull request #975:
URL: https://github.com/apache/phoenix/pull/975#discussion_r527994427
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/ViewTTLDeleteJobMapper.java
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Soft
[
https://issues.apache.org/jira/browse/PHOENIX-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236459#comment-17236459
]
Hadoop QA commented on PHOENIX-6207:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|
yanxinyi commented on pull request #972:
URL: https://github.com/apache/phoenix/pull/972#issuecomment-731417547
Added filter at the Coproc preScannerOpen method as we discussed offline.
Please take a look again, thanks!
cc @jpisaac @ChinmaySKulkarni @kadirozde
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236456#comment-17236456
]
ASF GitHub Bot commented on PHOENIX-5712:
-
yanxinyi commented on pull request #
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236427#comment-17236427
]
ASF GitHub Bot commented on PHOENIX-5712:
-
yanxinyi commented on a change in pu
yanxinyi commented on a change in pull request #972:
URL: https://github.com/apache/phoenix/pull/972#discussion_r527964134
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java
##
@@ -763,6 +770,18 @@ protected QueryPlan compileSingleFlatQuery(
[
https://issues.apache.org/jira/browse/PHOENIX-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236425#comment-17236425
]
ASF GitHub Bot commented on PHOENIX-6213:
-
shahrs87 commented on pull request #
shahrs87 commented on pull request #978:
URL: https://github.com/apache/phoenix/pull/978#issuecomment-731398665
@gjacoby126 While I fix the checkstyle errors, could you please help me
review the patch.
I have added TODO comment in couple of places where I am not clear what to
do. Could
[
https://issues.apache.org/jira/browse/PHOENIX-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236423#comment-17236423
]
ASF GitHub Bot commented on PHOENIX-6213:
-
stoty commented on pull request #978
stoty commented on pull request #978:
URL: https://github.com/apache/phoenix/pull/978#issuecomment-731389197
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236390#comment-17236390
]
ASF GitHub Bot commented on PHOENIX-6127:
-
stoty commented on pull request #944
stoty commented on pull request #944:
URL: https://github.com/apache/phoenix/pull/944#issuecomment-731362231
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 5m 3s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236354#comment-17236354
]
Chinmay Kulkarni commented on PHOENIX-6230:
---
Thanks for the reviews [~gjacoby
[
https://issues.apache.org/jira/browse/PHOENIX-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236317#comment-17236317
]
ASF GitHub Bot commented on PHOENIX-6120:
-
gokceni closed pull request #875:
UR
[
https://issues.apache.org/jira/browse/PHOENIX-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236318#comment-17236318
]
ASF GitHub Bot commented on PHOENIX-6120:
-
gokceni commented on pull request #8
gokceni commented on pull request #875:
URL: https://github.com/apache/phoenix/pull/875#issuecomment-731295993
@gjacoby126 I will close this PR and open another one.
This is an automated message from the Apache Git Service.
T
gokceni closed pull request #875:
URL: https://github.com/apache/phoenix/pull/875
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236310#comment-17236310
]
ASF GitHub Bot commented on PHOENIX-5712:
-
jpisaac commented on a change in pul
jpisaac commented on a change in pull request #972:
URL: https://github.com/apache/phoenix/pull/972#discussion_r527836747
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java
##
@@ -763,6 +770,18 @@ protected QueryPlan compileSingleFlatQuery(
[
https://issues.apache.org/jira/browse/PHOENIX-5592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236284#comment-17236284
]
ASF GitHub Bot commented on PHOENIX-5592:
-
jpisaac commented on a change in pul
jpisaac commented on a change in pull request #975:
URL: https://github.com/apache/phoenix/pull/975#discussion_r527746539
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixMultiViewInputFormat.java
##
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache S
[
https://issues.apache.org/jira/browse/PHOENIX-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236282#comment-17236282
]
Viraj Jasani commented on PHOENIX-6228:
---
Thanks [~gjacoby] for the review. 4.x pa
[
https://issues.apache.org/jira/browse/PHOENIX-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236248#comment-17236248
]
ASF GitHub Bot commented on PHOENIX-6180:
-
stoty commented on pull request #39:
stoty commented on pull request #39:
URL: https://github.com/apache/phoenix-connectors/pull/39#issuecomment-731247571
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 2
[
https://issues.apache.org/jira/browse/PHOENIX-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236246#comment-17236246
]
ASF GitHub Bot commented on PHOENIX-6127:
-
richardantal commented on pull reque
richardantal commented on pull request #944:
URL: https://github.com/apache/phoenix/pull/944#issuecomment-731246068
Thx @gjacoby126 for the review!
You are right, the only difference between the 2 dropChildViews functions
should be that one will try lazily.
(The original function was
[
https://issues.apache.org/jira/browse/PHOENIX-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236215#comment-17236215
]
ASF GitHub Bot commented on PHOENIX-6230:
-
gjacoby126 merged pull request #979:
gjacoby126 merged pull request #979:
URL: https://github.com/apache/phoenix/pull/979
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/PHOENIX-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236214#comment-17236214
]
ASF GitHub Bot commented on PHOENIX-6230:
-
gjacoby126 merged pull request #980:
gjacoby126 merged pull request #980:
URL: https://github.com/apache/phoenix/pull/980
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/PHOENIX-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236207#comment-17236207
]
ASF GitHub Bot commented on PHOENIX-6078:
-
gjacoby126 merged pull request #858:
[
https://issues.apache.org/jira/browse/PHOENIX-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236205#comment-17236205
]
ASF GitHub Bot commented on PHOENIX-6078:
-
gjacoby126 commented on pull request
gjacoby126 merged pull request #858:
URL: https://github.com/apache/phoenix/pull/858
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gjacoby126 commented on pull request #858:
URL: https://github.com/apache/phoenix/pull/858#issuecomment-731216070
Test passed save for one JVM crash. Merging.
This is an automated message from the Apache Git Service.
To resp
[
https://issues.apache.org/jira/browse/PHOENIX-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236022#comment-17236022
]
Kadir OZDEMIR commented on PHOENIX-6207:
[~comnetwork], That is a good question
[
https://issues.apache.org/jira/browse/PHOENIX-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235983#comment-17235983
]
ASF GitHub Bot commented on PHOENIX-6078:
-
stoty commented on pull request #858
stoty commented on pull request #858:
URL: https://github.com/apache/phoenix/pull/858#issuecomment-731017405
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235980#comment-17235980
]
chenglei edited comment on PHOENIX-6207 at 11/20/20, 8:09 AM:
---
[
https://issues.apache.org/jira/browse/PHOENIX-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235980#comment-17235980
]
chenglei commented on PHOENIX-6207:
---
[~kozdemir]， I noticed your PR is to prevent the
[
https://issues.apache.org/jira/browse/PHOENIX-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235979#comment-17235979
]
Istvan Toth commented on PHOENIX-6229:
--
Thank you.
> When dataframe write Phoniex
80 matches
Mail list logo
