[jira] [Commented] (PHOENIX-5860) Throw exception which region is closing or splitting when delete data

[ https://issues.apache.org/jira/browse/PHOENIX-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241318#comment-17241318 ] ASF GitHub Bot commented on PHOENIX-5860: - virajjasani commented on pull reques

[GitHub] [phoenix] virajjasani commented on pull request #874: PHOENIX-5860 Throw exception which region is closing or splitting when delete data

virajjasani commented on pull request #874: URL: https://github.com/apache/phoenix/pull/874#issuecomment-736281709 Thanks @joshelser for bringing this up. I just realized that we have this exact same issue reported sometime back this year with Phoenix 4.14.x + HBase 1.3.x for Delete querie

[jira] [Commented] (PHOENIX-6086) Take a snapshot of all SYSTEM tables before attempting to upgrade them

[ https://issues.apache.org/jira/browse/PHOENIX-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241271#comment-17241271 ] Viraj Jasani commented on PHOENIX-6086: --- [~ckulkarni] [~yanxinyi] Are we fine wit

[jira] [Commented] (PHOENIX-5960) Creating a view on a non-existent table throws the wrong exception

[ https://issues.apache.org/jira/browse/PHOENIX-5960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241267#comment-17241267 ] ASF GitHub Bot commented on PHOENIX-5960: - virajjasani closed pull request #987

[jira] [Commented] (PHOENIX-5960) Creating a view on a non-existent table throws the wrong exception

[ https://issues.apache.org/jira/browse/PHOENIX-5960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241266#comment-17241266 ] ASF GitHub Bot commented on PHOENIX-5960: - virajjasani closed pull request #989

[GitHub] [phoenix] virajjasani closed pull request #987: PHOENIX-5960 : Creating view on non-existent table should throw TNFE

virajjasani closed pull request #987: URL: https://github.com/apache/phoenix/pull/987 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [phoenix] virajjasani closed pull request #989: PHOENIX-5960 : Creating view on non-existent table should throw TNFE

virajjasani closed pull request #989: URL: https://github.com/apache/phoenix/pull/989 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (PHOENIX-5860) Throw exception which region is closing or splitting when delete data

[ https://issues.apache.org/jira/browse/PHOENIX-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241241#comment-17241241 ] Hadoop QA commented on PHOENIX-5860: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (PHOENIX-6058) When maxLookback is not enabled, IndexTool should not do deep verification

[ https://issues.apache.org/jira/browse/PHOENIX-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241237#comment-17241237 ] Geoffrey Jacoby commented on PHOENIX-6058: -- [~yanxinyi] We definitely want to

[jira] [Commented] (PHOENIX-6058) When maxLookback is not enabled, IndexTool should not do deep verification

[ https://issues.apache.org/jira/browse/PHOENIX-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241214#comment-17241214 ] Xinyi Yan commented on PHOENIX-6058: Hi [~kozdemir], do you want to commit this pat

[jira] [Commented] (PHOENIX-5860) Throw exception which region is closing or splitting when delete data

[ https://issues.apache.org/jira/browse/PHOENIX-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241172#comment-17241172 ] ASF GitHub Bot commented on PHOENIX-5860: - joshelser commented on pull request

[GitHub] [phoenix] joshelser commented on pull request #874: PHOENIX-5860 Throw exception which region is closing or splitting when delete data

joshelser commented on pull request #874: URL: https://github.com/apache/phoenix/pull/874#issuecomment-736149905 (sorry for the wide ping) @virajjasani @gjacoby126 @ChinmaySKulkarni @apurtell have any of your noticed this one in 1.x? The change seems reasonable to me, but I haven't k

[jira] [Commented] (PHOENIX-5860) Throw exception which region is closing or splitting when delete data

[ https://issues.apache.org/jira/browse/PHOENIX-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241171#comment-17241171 ] ASF GitHub Bot commented on PHOENIX-5860: - joshelser commented on a change in p

[GitHub] [phoenix] joshelser commented on a change in pull request #874: PHOENIX-5860 Throw exception which region is closing or splitting when delete data

joshelser commented on a change in pull request #874: URL: https://github.com/apache/phoenix/pull/874#discussion_r533005013 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java ## @@ -1430,4 +1430,17 @@ public InternalSc

[jira] [Commented] (PHOENIX-5728) Gold files for Phoenix test BaseStatsCollectorIT

[ https://issues.apache.org/jira/browse/PHOENIX-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241117#comment-17241117 ] ASF GitHub Bot commented on PHOENIX-5728: - stoty commented on pull request #990

[GitHub] [phoenix] stoty commented on pull request #990: PHOENIX-5728 : ExplainPlan with plan as attributes object

stoty commented on pull request #990: URL: https://github.com/apache/phoenix/pull/990#issuecomment-736099322 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s | Doc

[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241037#comment-17241037 ] ASF GitHub Bot commented on PHOENIX-5435: - stoty commented on pull request #913

[GitHub] [phoenix] stoty commented on pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata

stoty commented on pull request #913: URL: https://github.com/apache/phoenix/pull/913#issuecomment-736036102 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Doc

[jira] [Commented] (PHOENIX-5728) Gold files for Phoenix test BaseStatsCollectorIT

[ https://issues.apache.org/jira/browse/PHOENIX-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241018#comment-17241018 ] ASF GitHub Bot commented on PHOENIX-5728: - stoty commented on pull request #990

[GitHub] [phoenix] stoty commented on pull request #990: PHOENIX-5728 : ExplainPlan with plan as attributes object

stoty commented on pull request #990: URL: https://github.com/apache/phoenix/pull/990#issuecomment-736017138 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Doc

[jira] [Commented] (PHOENIX-6213) Extend Cell Tags to Delete object.

[ https://issues.apache.org/jira/browse/PHOENIX-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240940#comment-17240940 ] ASF GitHub Bot commented on PHOENIX-6213: - shahrs87 commented on pull request #

[GitHub] [phoenix] shahrs87 commented on pull request #978: [PHOENIX-6213] Extend Cell Tags to Delete object to store source of operation.

shahrs87 commented on pull request #978: URL: https://github.com/apache/phoenix/pull/978#issuecomment-735947330 @gjacoby126 Other than using Hbase's Private Annotation apis, do you have any other review comment that I can address ? ---

[jira] [Commented] (PHOENIX-6213) Extend Cell Tags to Delete object.

[ https://issues.apache.org/jira/browse/PHOENIX-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240927#comment-17240927 ] ASF GitHub Bot commented on PHOENIX-6213: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #978: [PHOENIX-6213] Extend Cell Tags to Delete object to store source of operation.

virajjasani commented on a change in pull request #978: URL: https://github.com/apache/phoenix/pull/978#discussion_r532786843 ## File path: phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java ## @@ -991,6 +999,47 @@ public void preBatchMutateWit

[jira] [Commented] (PHOENIX-6213) Extend Cell Tags to Delete object.

[ https://issues.apache.org/jira/browse/PHOENIX-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240918#comment-17240918 ] ASF GitHub Bot commented on PHOENIX-6213: - shahrs87 commented on a change in pu

[GitHub] [phoenix] shahrs87 commented on a change in pull request #978: [PHOENIX-6213] Extend Cell Tags to Delete object to store source of operation.

shahrs87 commented on a change in pull request #978: URL: https://github.com/apache/phoenix/pull/978#discussion_r532782887 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java ## @@ -479,6 +486,8 @@ void deleteCForQ(Tuple

[jira] [Commented] (PHOENIX-6213) Extend Cell Tags to Delete object.

[ https://issues.apache.org/jira/browse/PHOENIX-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240916#comment-17240916 ] ASF GitHub Bot commented on PHOENIX-6213: - shahrs87 commented on a change in pu

[jira] [Commented] (PHOENIX-5728) Gold files for Phoenix test BaseStatsCollectorIT

[ https://issues.apache.org/jira/browse/PHOENIX-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240917#comment-17240917 ] ASF GitHub Bot commented on PHOENIX-5728: - virajjasani opened a new pull reques

[GitHub] [phoenix] virajjasani opened a new pull request #990: PHOENIX-5728 : ExplainPlan with plan as attributes object

virajjasani opened a new pull request #990: URL: https://github.com/apache/phoenix/pull/990 * ExplainPlan can provide plan as attributes object for simplified assertion of individual plan attributes * Provide an additional API to get plan object * Explain queries can still continue to

[GitHub] [phoenix] shahrs87 commented on a change in pull request #978: [PHOENIX-6213] Extend Cell Tags to Delete object to store source of operation.

shahrs87 commented on a change in pull request #978: URL: https://github.com/apache/phoenix/pull/978#discussion_r532781817 ## File path: phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java ## @@ -991,6 +999,47 @@ public void preBatchMutateWithEx