[GitHub] [phoenix] virajjasani commented on pull request #1012: PHOENIX-6256: Fix MaxConcurrentConnectionsIT test flapper

virajjasani commented on pull request #1012: URL: https://github.com/apache/phoenix/pull/1012#issuecomment-743719665 > TaskRO never gets scheduled at all due to the initial wait being set to Long.MAX_VALUE In that case, only `TASK_HANDLING_INITIAL_DELAY_MS_ATTRIB` is sufficient

[jira] [Commented] (PHOENIX-6256) Fix MaxConcurrentConnectionsIT test flapper

[ https://issues.apache.org/jira/browse/PHOENIX-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248308#comment-17248308 ] ASF GitHub Bot commented on PHOENIX-6256: - virajjasani commented on pull request #1012: URL:

[jira] [Commented] (PHOENIX-6250) Fix ViewMetadataIT test flapper

[ https://issues.apache.org/jira/browse/PHOENIX-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248287#comment-17248287 ] Hadoop QA commented on PHOENIX-6250: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248278#comment-17248278 ] ASF GitHub Bot commented on PHOENIX-5435: - stoty commented on pull request #913: URL:

[GitHub] [phoenix] stoty commented on pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata

stoty commented on pull request #913: URL: https://github.com/apache/phoenix/pull/913#issuecomment-743673616 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[jira] [Commented] (PHOENIX-6218) Rows deleted count for client side deletes is incorrect for immutable tables with indexes

[ https://issues.apache.org/jira/browse/PHOENIX-6218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248271#comment-17248271 ] Hadoop QA commented on PHOENIX-6218: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248234#comment-17248234 ] ASF GitHub Bot commented on PHOENIX-5435: - gjacoby126 commented on a change in pull request

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata

gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541383107 ## File path: phoenix-hbase-compat-1.5.0/src/main/java/org/apache/phoenix/compat/hbase/coprocessor/CompatGlobalIndexChecker.java ## @@ -0,0 +1,27 @@

[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248232#comment-17248232 ] ASF GitHub Bot commented on PHOENIX-5435: - gjacoby126 commented on a change in pull request

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata

gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541382620 ## File path: phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java ## @@ -1239,4 +1239,21 @@ public static boolean isDummy(List result) {

[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248226#comment-17248226 ] ASF GitHub Bot commented on PHOENIX-5435: - gjacoby126 commented on a change in pull request

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata

gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541367097 ## File path: phoenix-core/src/main/java/org/apache/phoenix/util/WALAnnotationUtil.java ## @@ -0,0 +1,49 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248225#comment-17248225 ] ASF GitHub Bot commented on PHOENIX-5435: - gjacoby126 commented on a change in pull request

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata

gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541364685 ## File path: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ## @@ -1257,7 +1261,11 @@ public ImmutableBytesPtr

[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248223#comment-17248223 ] ASF GitHub Bot commented on PHOENIX-5435: - gjacoby126 commented on a change in pull request

[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248224#comment-17248224 ] ASF GitHub Bot commented on PHOENIX-5435: - gjacoby126 commented on a change in pull request

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata

gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541364364 ## File path: phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java ## @@ -93,10 +106,11 @@ * the verified version that is

[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248222#comment-17248222 ] ASF GitHub Bot commented on PHOENIX-5435: - gjacoby126 commented on a change in pull request

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata

gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541363956 ## File path: phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java ## @@ -50,11 +53,19 @@ import

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata

gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541362722 ## File path: phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ## @@ -682,6 +687,49 @@ private void generateMutations(final

[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248221#comment-17248221 ] ASF GitHub Bot commented on PHOENIX-5435: - gjacoby126 commented on a change in pull request

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata

gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541362377 ## File path: phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ## @@ -682,6 +687,49 @@ private void generateMutations(final

[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248215#comment-17248215 ] ASF GitHub Bot commented on PHOENIX-5435: - gjacoby126 commented on a change in pull request

[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248214#comment-17248214 ] ASF GitHub Bot commented on PHOENIX-5435: - gjacoby126 commented on a change in pull request

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata

gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541350748 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java ## @@ -644,4 +651,33 @@ public boolean

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata

gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541349997 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java ## @@ -609,6 +613,9 @@ public boolean

[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248212#comment-17248212 ] ASF GitHub Bot commented on PHOENIX-5435: - gjacoby126 commented on a change in pull request

[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248211#comment-17248211 ] ASF GitHub Bot commented on PHOENIX-5435: - gjacoby126 commented on a change in pull request

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata

gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541347335 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java ## @@ -64,6 +64,7 @@ import

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata

gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541346794 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java ## @@ -1160,6 +1169,12 @@ private PTable

[jira] [Commented] (PHOENIX-5435) Annotate HBase WALs with Phoenix Metadata

[ https://issues.apache.org/jira/browse/PHOENIX-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248209#comment-17248209 ] ASF GitHub Bot commented on PHOENIX-5435: - gjacoby126 commented on a change in pull request

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #913: PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata

gjacoby126 commented on a change in pull request #913: URL: https://github.com/apache/phoenix/pull/913#discussion_r541345592 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java ## @@ -400,7 +400,6 @@ protected boolean

[jira] [Commented] (PHOENIX-6252) Fix BackwardCompatibilityIT test flapper

[ https://issues.apache.org/jira/browse/PHOENIX-6252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248187#comment-17248187 ] Xinyi Yan commented on PHOENIX-6252:

[jira] [Commented] (PHOENIX-6250) Fix ViewMetadataIT test flapper

[ https://issues.apache.org/jira/browse/PHOENIX-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248184#comment-17248184 ] Xinyi Yan commented on PHOENIX-6250: hi [~ckulkarni],

[jira] [Comment Edited] (PHOENIX-6207) Paged server side grouped aggregate operations

[ https://issues.apache.org/jira/browse/PHOENIX-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248160#comment-17248160 ] Kadir OZDEMIR edited comment on PHOENIX-6207 at 12/11/20, 8:28 PM: ---

[jira] [Commented] (PHOENIX-6207) Paged server side grouped aggregate operations

[ https://issues.apache.org/jira/browse/PHOENIX-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248160#comment-17248160 ] Kadir OZDEMIR commented on PHOENIX-6207: [~comnetwork], I have posted the design doc for server

[jira] [Commented] (PHOENIX-6253) Change shaded connector jar naming convention

[ https://issues.apache.org/jira/browse/PHOENIX-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247941#comment-17247941 ] ASF GitHub Bot commented on PHOENIX-6253: - stoty commented on pull request #45: URL:

[GitHub] [phoenix-connectors] stoty commented on pull request #45: PHOENIX-6253 Change shaded connector jar naming convention

stoty commented on pull request #45: URL: https://github.com/apache/phoenix-connectors/pull/45#issuecomment-743213150 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work

[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247921#comment-17247921 ] ASF GitHub Bot commented on PHOENIX-6261: - stoty commented on pull request #1013: URL:

[GitHub] [phoenix] stoty commented on pull request #1013: PHOENIX-6261 Reorganise project structure to make mvn versions:set work

stoty commented on pull request #1013: URL: https://github.com/apache/phoenix/pull/1013#issuecomment-743186057 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s |

[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work

[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247905#comment-17247905 ] Istvan Toth commented on PHOENIX-6261: -- Committed the phoenix-connectors change (minus the gerrit

[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work

[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247903#comment-17247903 ] ASF GitHub Bot commented on PHOENIX-6261: - stoty closed pull request #44: URL:

[GitHub] [phoenix-connectors] stoty closed pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work

stoty closed pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work

[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247861#comment-17247861 ] ASF GitHub Bot commented on PHOENIX-6261: - stoty commented on pull request #44: URL:

[GitHub] [phoenix-connectors] stoty commented on pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work

stoty commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743145493 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work

[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247842#comment-17247842 ] ASF GitHub Bot commented on PHOENIX-6261: - richardantal commented on pull request #44: URL:

[GitHub] [phoenix-connectors] richardantal commented on pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work

richardantal commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743126134 > Nice cleanup, one question: `hbase-common` is not required as `provided` dependency for `phoenix-connectors-phoenix4-compat`? No, it is not. hbase-common is

[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work

[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247832#comment-17247832 ] ASF GitHub Bot commented on PHOENIX-6261: - virajjasani commented on pull request #44: URL:

[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work

[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247833#comment-17247833 ] ASF GitHub Bot commented on PHOENIX-6261: - virajjasani edited a comment on pull request #44:

[GitHub] [phoenix-connectors] virajjasani edited a comment on pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work

virajjasani edited a comment on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743120231 Nice cleanup, one question: `hbase-common` is not required as `provided` dependency for `phoenix-connectors-phoenix4-compat`?

[GitHub] [phoenix-connectors] virajjasani commented on pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work

virajjasani commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743120231 Nice cleanup, one question: `hbase-common` is not required for `phoenix-connectors-phoenix4-compat`?

[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work

[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247830#comment-17247830 ] ASF GitHub Bot commented on PHOENIX-6261: - stoty commented on pull request #44: URL:

[GitHub] [phoenix-connectors] stoty commented on pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work

stoty commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743119197 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (PHOENIX-6251) Fix ConcurrentMutationsExtendedIT.testConcurrentUpsertsWithNoIndexedColumns timout issue

[ https://issues.apache.org/jira/browse/PHOENIX-6251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247817#comment-17247817 ] Hadoop QA commented on PHOENIX-6251: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work

[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247816#comment-17247816 ] ASF GitHub Bot commented on PHOENIX-6261: - stoty opened a new pull request #1014: URL:

[GitHub] [phoenix] stoty opened a new pull request #1014: PHOENIX-6261 Reorganise project structure to make mvn versions:set work

stoty opened a new pull request #1014: URL: https://github.com/apache/phoenix/pull/1014 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PHOENIX-6253) Change shaded connector jar naming convention

[ https://issues.apache.org/jira/browse/PHOENIX-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247811#comment-17247811 ] ASF GitHub Bot commented on PHOENIX-6253: - stoty commented on pull request #45: URL:

[GitHub] [phoenix-connectors] stoty commented on pull request #45: PHOENIX-6253 Change shaded connector jar naming convention

stoty commented on pull request #45: URL: https://github.com/apache/phoenix-connectors/pull/45#issuecomment-743106065 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[jira] [Commented] (PHOENIX-6251) Fix ConcurrentMutationsExtendedIT.testConcurrentUpsertsWithNoIndexedColumns timout issue

[ https://issues.apache.org/jira/browse/PHOENIX-6251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247805#comment-17247805 ] Hadoop QA commented on PHOENIX-6251: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (PHOENIX-6262) Bulk Load have a bug in lowercase tablename

[ https://issues.apache.org/jira/browse/PHOENIX-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247803#comment-17247803 ] chenyuansheng commented on PHOENIX-6262:  How to solve this problem？ > Bulk Load have a bug in

[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work

[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247797#comment-17247797 ] ASF GitHub Bot commented on PHOENIX-6261: - richardantal closed pull request #1011: URL:

[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work

[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247795#comment-17247795 ] ASF GitHub Bot commented on PHOENIX-6261: - richardantal commented on pull request #1011: URL:

[GitHub] [phoenix] richardantal closed pull request #1011: PHOENIX-6261 Reorganise project structure to make mvn versions:set work

richardantal closed pull request #1011: URL: https://github.com/apache/phoenix/pull/1011 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [phoenix] richardantal commented on pull request #1011: PHOENIX-6261 Reorganise project structure to make mvn versions:set work

richardantal commented on pull request #1011: URL: https://github.com/apache/phoenix/pull/1011#issuecomment-743092985 Changing the parent of the the compat modules works here as well as @stoty pointed out. I am closing it as He has a much smaller change.

[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work

[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247792#comment-17247792 ] ASF GitHub Bot commented on PHOENIX-6261: - stoty opened a new pull request #1013: URL:

[GitHub] [phoenix] stoty opened a new pull request #1013: PHOENIX-6261 Reorganise project structure to make mvn versions:set work

stoty opened a new pull request #1013: URL: https://github.com/apache/phoenix/pull/1013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work

[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247782#comment-17247782 ] ASF GitHub Bot commented on PHOENIX-6261: - richardantal edited a comment on pull request #44:

[GitHub] [phoenix-connectors] richardantal edited a comment on pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work

richardantal edited a comment on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743078766 As @stoty pointed out, we don't need to create a common ancestor module here, everything should work fine if we just change the parents of the

[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work

[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247780#comment-17247780 ] ASF GitHub Bot commented on PHOENIX-6261: - richardantal commented on pull request #44: URL:

[jira] [Commented] (PHOENIX-6262) Bulk Load have a bug in lowercase tablename

[ https://issues.apache.org/jira/browse/PHOENIX-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247779#comment-17247779 ] Fan Zhang commented on PHOENIX-6262: (y) > Bulk Load have a bug in lowercase tablename >

[GitHub] [phoenix-connectors] richardantal commented on pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work

richardantal commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743078766 As @stoty pointed out, we don't need to create a common ancestor module here, everything should work fine if we just change the parents of the

[jira] [Commented] (PHOENIX-6262) Bulk Load have a bug in lowercase tablename

[ https://issues.apache.org/jira/browse/PHOENIX-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247775#comment-17247775 ] huajie huang commented on PHOENIX-6262: --- i met the same question :) > Bulk Load have a bug in

[GitHub] [phoenix-connectors] stoty commented on pull request #44: PHOENIX-6261 Reorganise project structure to make mvn versions:set work

stoty commented on pull request #44: URL: https://github.com/apache/phoenix-connectors/pull/44#issuecomment-743067734 I've just checked, and there is no need for phoenix-base. Simply reparenting the compatibility modules to phoenix-connectors works just fine.

[jira] [Commented] (PHOENIX-6261) Reorganise project structure to make mvn versions:set work

[ https://issues.apache.org/jira/browse/PHOENIX-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247765#comment-17247765 ] ASF GitHub Bot commented on PHOENIX-6261: - stoty commented on pull request #44: URL:

[jira] [Commented] (PHOENIX-6253) Change shaded connector jar naming convention

[ https://issues.apache.org/jira/browse/PHOENIX-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247757#comment-17247757 ] Istvan Toth commented on PHOENIX-6253: -- I ended up going with the default maven naming conventions

[jira] [Commented] (PHOENIX-6253) Change shaded connector jar naming convention

[ https://issues.apache.org/jira/browse/PHOENIX-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247756#comment-17247756 ] ASF GitHub Bot commented on PHOENIX-6253: - stoty opened a new pull request #45: URL:

[GitHub] [phoenix-connectors] stoty opened a new pull request #45: PHOENIX-6253 Change shaded connector jar naming convention

stoty opened a new pull request #45: URL: https://github.com/apache/phoenix-connectors/pull/45 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL