[jira] [Commented] (PHOENIX-6262) Bulk Load have a bug in lowercase tablename

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260251#comment-17260251 ] ASF GitHub Bot commented on PHOENIX-6262: - stoty commented on pull request #1072: URL:

[GitHub] [phoenix] stoty commented on pull request #1072: PHOENIX-6262 Bulk Load have a bug in lowercase tablename

2021-01-06 Thread GitBox
stoty commented on pull request #1072: URL: https://github.com/apache/phoenix/pull/1072#issuecomment-755908560 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 52s |

[jira] [Commented] (PHOENIX-6295) Fix non-static inner classes for better memory management

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260246#comment-17260246 ] ASF GitHub Bot commented on PHOENIX-6295: - virajjasani commented on pull request #1053: URL:

[GitHub] [phoenix] virajjasani commented on pull request #1053: PHOENIX-6295 : Fix non-static inner classes for better memory utilization

2021-01-06 Thread GitBox
virajjasani commented on pull request #1053: URL: https://github.com/apache/phoenix/pull/1053#issuecomment-755900715 @gjacoby126 @stoty Could you please help merge this PR and 4.x backport #1054 (and 4.16 backport too as 4.x and 4.16 are exactly same as of now)? After approval, the only

[jira] [Commented] (PHOENIX-6262) Bulk Load have a bug in lowercase tablename

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260236#comment-17260236 ] ASF GitHub Bot commented on PHOENIX-6262: - stoty commented on pull request #1073: URL:

[GitHub] [phoenix] stoty commented on pull request #1073: PHOENIX-6262 Bulk Load have a bug in lowercase tablename

2021-01-06 Thread GitBox
stoty commented on pull request #1073: URL: https://github.com/apache/phoenix/pull/1073#issuecomment-755886232 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[jira] [Commented] (PHOENIX-6262) Bulk Load have a bug in lowercase tablename

2021-01-06 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260229#comment-17260229 ] Hadoop QA commented on PHOENIX-6262: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (PHOENIX-6215) Failed to create local index if I set column type is tinyint with default value

2021-01-06 Thread Chao Wang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260224#comment-17260224 ] Chao Wang commented on PHOENIX-6215: when local index rebuild in "default column", index-rowkey

[jira] [Commented] (PHOENIX-6262) Bulk Load have a bug in lowercase tablename

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260180#comment-17260180 ] ASF GitHub Bot commented on PHOENIX-6262: - wangchao316 opened a new pull request #1073: URL:

[GitHub] [phoenix] wangchao316 opened a new pull request #1073: PHOENIX-6262 Bulk Load have a bug in lowercase tablename

2021-01-06 Thread GitBox
wangchao316 opened a new pull request #1073: URL: https://github.com/apache/phoenix/pull/1073 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (PHOENIX-6262) Bulk Load have a bug in lowercase tablename

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260172#comment-17260172 ] ASF GitHub Bot commented on PHOENIX-6262: - wangchao316 closed pull request #1072: URL:

[GitHub] [phoenix] wangchao316 closed pull request #1072: PHOENIX-6262 Bulk Load have a bug in lowercase tablename

2021-01-06 Thread GitBox
wangchao316 closed pull request #1072: URL: https://github.com/apache/phoenix/pull/1072 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PHOENIX-6262) Bulk Load have a bug in lowercase tablename

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260170#comment-17260170 ] ASF GitHub Bot commented on PHOENIX-6262: - wangchao316 opened a new pull request #1072: URL:

[GitHub] [phoenix] wangchao316 opened a new pull request #1072: PHOENIX-6262 Bulk Load have a bug in lowercase tablename

2021-01-06 Thread GitBox
wangchao316 opened a new pull request #1072: URL: https://github.com/apache/phoenix/pull/1072 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (PHOENIX-6211) Paged scan filters

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260131#comment-17260131 ] ASF GitHub Bot commented on PHOENIX-6211: - gjacoby126 commented on pull request #973: URL:

[GitHub] [phoenix] gjacoby126 commented on pull request #973: PHOENIX-6211 Paged scan filters

2021-01-06 Thread GitBox
gjacoby126 commented on pull request #973: URL: https://github.com/apache/phoenix/pull/973#issuecomment-755798226 @kadirozde - other than above comments lgtm. This is an automated message from the Apache Git Service. To

[jira] [Commented] (PHOENIX-6211) Paged scan filters

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260130#comment-17260130 ] ASF GitHub Bot commented on PHOENIX-6211: - gjacoby126 commented on a change in pull request

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #973: PHOENIX-6211 Paged scan filters

2021-01-06 Thread GitBox
gjacoby126 commented on a change in pull request #973: URL: https://github.com/apache/phoenix/pull/973#discussion_r553021396 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PagedRegionScanner.java ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache

[jira] [Commented] (PHOENIX-5923) Supporting the single cell storage format for mutable global indexes

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260111#comment-17260111 ] ASF GitHub Bot commented on PHOENIX-5923: - gokceni commented on pull request #1063: URL:

[jira] [Commented] (PHOENIX-5923) Supporting the single cell storage format for mutable global indexes

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260110#comment-17260110 ] ASF GitHub Bot commented on PHOENIX-5923: - gokceni closed pull request #1063: URL:

[GitHub] [phoenix] gokceni commented on pull request #1063: PHOENIX-5923 Supporting SINGLE_CELL storage format for indexes on ONE_CELL tables

2021-01-06 Thread GitBox
gokceni commented on pull request #1063: URL: https://github.com/apache/phoenix/pull/1063#issuecomment-755775760 merged on 4.x and master This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [phoenix] gokceni closed pull request #1063: PHOENIX-5923 Supporting SINGLE_CELL storage format for indexes on ONE_CELL tables

2021-01-06 Thread GitBox
gokceni closed pull request #1063: URL: https://github.com/apache/phoenix/pull/1063 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (PHOENIX-3710) Cannot use lowername data table name with indextool

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260097#comment-17260097 ] ASF GitHub Bot commented on PHOENIX-3710: - stoty commented on pull request #1071: URL:

[GitHub] [phoenix] stoty commented on pull request #1071: PHOENIX-3710 Cannot use lowername data table name with indextool

2021-01-06 Thread GitBox
stoty commented on pull request #1071: URL: https://github.com/apache/phoenix/pull/1071#issuecomment-755766305 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 34s |

[jira] [Commented] (PHOENIX-6298) Use timestamp of PENDING_DISABLE_COUNT to calculate elapse time for PENDING_DISABLE state

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260078#comment-17260078 ] ASF GitHub Bot commented on PHOENIX-6298: - stoty commented on pull request #1060: URL:

[GitHub] [phoenix] stoty commented on pull request #1060: PHOENIX-6298 : Use timestamp of PENDING_DISABLE_COUNT to calculate elapse time for PENDING_DISABLE state

2021-01-06 Thread GitBox
stoty commented on pull request #1060: URL: https://github.com/apache/phoenix/pull/1060#issuecomment-755743566 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[jira] [Commented] (PHOENIX-6118) Multi Tenant Workloads using PHERF

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260020#comment-17260020 ] ASF GitHub Bot commented on PHOENIX-6118: - stoty commented on pull request #878: URL:

[GitHub] [phoenix] stoty commented on pull request #878: PHOENIX-6118: Multi Tenant Workloads using PHERF

2021-01-06 Thread GitBox
stoty commented on pull request #878: URL: https://github.com/apache/phoenix/pull/878#issuecomment-755574885 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 49s |

[jira] [Commented] (PHOENIX-3499) Enable null value for quote character for CSVBulkLoad tool

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259937#comment-17259937 ] ASF GitHub Bot commented on PHOENIX-3499: - stoty closed pull request #1065: URL:

[jira] [Commented] (PHOENIX-3499) Enable null value for quote character for CSVBulkLoad tool

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259938#comment-17259938 ] ASF GitHub Bot commented on PHOENIX-3499: - stoty closed pull request #1069: URL:

[GitHub] [phoenix] stoty closed pull request #1069: PHOENIX-3499 Enable null value for quote character for CSVBulkLoad tool

2021-01-06 Thread GitBox
stoty closed pull request #1069: URL: https://github.com/apache/phoenix/pull/1069 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [phoenix] stoty closed pull request #1065: PHOENIX-3499 Enable null value for quote character for CSVBulkLoad tool

2021-01-06 Thread GitBox
stoty closed pull request #1065: URL: https://github.com/apache/phoenix/pull/1065 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (PHOENIX-3710) Cannot use lowername data table name with indextool

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259929#comment-17259929 ] ASF GitHub Bot commented on PHOENIX-3710: - stoty opened a new pull request #1071: URL:

[jira] [Commented] (PHOENIX-3710) Cannot use lowername data table name with indextool

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259930#comment-17259930 ] ASF GitHub Bot commented on PHOENIX-3710: - stoty closed pull request #1071: URL:

[GitHub] [phoenix] stoty closed pull request #1071: PHOENIX-3710 Cannot use lowername data table name with indextool

2021-01-06 Thread GitBox
stoty closed pull request #1071: URL: https://github.com/apache/phoenix/pull/1071 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [phoenix] stoty opened a new pull request #1071: PHOENIX-3710 Cannot use lowername data table name with indextool

2021-01-06 Thread GitBox
stoty opened a new pull request #1071: URL: https://github.com/apache/phoenix/pull/1071 Co-authored-by: Ankit Singhal Co-authored-by: Josh Elser This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (PHOENIX-6303) bump Scala version for spark connector to 2.11.12, the same that Spark 2.4.7 uses

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259922#comment-17259922 ] ASF GitHub Bot commented on PHOENIX-6303: - stoty closed pull request #47: URL:

[GitHub] [phoenix-connectors] stoty closed pull request #47: PHOENIX-6303 bump Scala version for spark connector to 2.11.12, the s…

2021-01-06 Thread GitBox
stoty closed pull request #47: URL: https://github.com/apache/phoenix-connectors/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PHOENIX-5923) Supporting the single cell storage format for mutable global indexes

2021-01-06 Thread Gokcen Iskender (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259920#comment-17259920 ] Gokcen Iskender commented on PHOENIX-5923: -- Thanks [~swaroopa], I rerun the flapper on my

[jira] [Commented] (PHOENIX-6302) Fix ConcurrentUpsertsWithoutIndexedColsIT flapper

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259905#comment-17259905 ] ASF GitHub Bot commented on PHOENIX-6302: - yanxinyi merged pull request #1067: URL:

[GitHub] [phoenix] yanxinyi merged pull request #1067: PHOENIX-6302 : De-flake ConcurrentUpsertsWithoutIndexedColsIT

2021-01-06 Thread GitBox
yanxinyi merged pull request #1067: URL: https://github.com/apache/phoenix/pull/1067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (PHOENIX-6302) Fix ConcurrentUpsertsWithoutIndexedColsIT flapper

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259904#comment-17259904 ] ASF GitHub Bot commented on PHOENIX-6302: - yanxinyi merged pull request #1068: URL:

[GitHub] [phoenix] yanxinyi merged pull request #1068: PHOENIX-6302 : De-flake ConcurrentUpsertsWithoutIndexedColsIT

2021-01-06 Thread GitBox
yanxinyi merged pull request #1068: URL: https://github.com/apache/phoenix/pull/1068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (PHOENIX-6303) bump Scala version for spark connector to 2.11.12, the same that Spark 2.4.7 uses

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259847#comment-17259847 ] ASF GitHub Bot commented on PHOENIX-6303: - richardantal commented on pull request #47: URL:

[GitHub] [phoenix-connectors] richardantal commented on pull request #47: PHOENIX-6303 bump Scala version for spark connector to 2.11.12, the s…

2021-01-06 Thread GitBox
richardantal commented on pull request #47: URL: https://github.com/apache/phoenix-connectors/pull/47#issuecomment-755402704 LGTM This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [phoenix-connectors] stoty commented on pull request #47: PHOENIX-6303 bump Scala version for spark connector to 2.11.12, the s…

2021-01-06 Thread GitBox
stoty commented on pull request #47: URL: https://github.com/apache/phoenix-connectors/pull/47#issuecomment-755361147 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (PHOENIX-6303) bump Scala version for spark connector to 2.11.12, the same that Spark 2.4.7 uses

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259797#comment-17259797 ] ASF GitHub Bot commented on PHOENIX-6303: - stoty commented on pull request #47: URL:

[jira] [Commented] (PHOENIX-3633) null pointer exception when subsquery for not exists returns empty result set

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259796#comment-17259796 ] ASF GitHub Bot commented on PHOENIX-3633: - stoty commented on pull request #1066: URL:

[GitHub] [phoenix] stoty commented on pull request #1066: PHOENIX-3633 null pointer exception when subsquery for not exists ret…

2021-01-06 Thread GitBox
stoty commented on pull request #1066: URL: https://github.com/apache/phoenix/pull/1066#issuecomment-755360495 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

[jira] [Commented] (PHOENIX-6298) Use timestamp of PENDING_DISABLE_COUNT to calculate elapse time for PENDING_DISABLE state

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259757#comment-17259757 ] ASF GitHub Bot commented on PHOENIX-6298: - stoty commented on pull request #1061: URL:

[GitHub] [phoenix] stoty commented on pull request #1061: PHOENIX-6298 : Use timestamp of PENDING_DISABLE_COUNT to calculate elapse time for PENDING_DISABLE state

2021-01-06 Thread GitBox
stoty commented on pull request #1061: URL: https://github.com/apache/phoenix/pull/1061#issuecomment-755336021 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s |

[jira] [Commented] (PHOENIX-3499) Enable null value for quote character for CSVBulkLoad tool

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259751#comment-17259751 ] ASF GitHub Bot commented on PHOENIX-3499: - stoty commented on pull request #1069: URL:

[GitHub] [phoenix] stoty commented on pull request #1069: PHOENIX-3499 Enable null value for quote character for CSVBulkLoad tool

2021-01-06 Thread GitBox
stoty commented on pull request #1069: URL: https://github.com/apache/phoenix/pull/1069#issuecomment-755327752 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 12s |

[jira] [Commented] (PHOENIX-3633) null pointer exception when subsquery for not exists returns empty result set

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259747#comment-17259747 ] ASF GitHub Bot commented on PHOENIX-3633: - stoty commented on pull request #1070: URL:

[GitHub] [phoenix] stoty commented on pull request #1070: PHOENIX-3633 null pointer exception when subsquery for not exists ret…

2021-01-06 Thread GitBox
stoty commented on pull request #1070: URL: https://github.com/apache/phoenix/pull/1070#issuecomment-755323607 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[jira] [Commented] (PHOENIX-6303) bump Scala version for spark connector to 2.11.12, the same that Spark 2.4.7 uses

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259744#comment-17259744 ] ASF GitHub Bot commented on PHOENIX-6303: - stoty opened a new pull request #47: URL:

[GitHub] [phoenix-connectors] stoty opened a new pull request #47: PHOENIX-6303 bump Scala version for spark connector to 2.11.12, the s…

2021-01-06 Thread GitBox
stoty opened a new pull request #47: URL: https://github.com/apache/phoenix-connectors/pull/47 …ame that Spark 2.4.7 uses This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [phoenix] stoty closed pull request #1066: PHOENIX-3633 null pointer exception when subsquery for not exists ret…

2021-01-06 Thread GitBox
stoty closed pull request #1066: URL: https://github.com/apache/phoenix/pull/1066 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (PHOENIX-3633) null pointer exception when subsquery for not exists returns empty result set

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259737#comment-17259737 ] ASF GitHub Bot commented on PHOENIX-3633: - stoty closed pull request #1070: URL:

[jira] [Commented] (PHOENIX-3633) null pointer exception when subsquery for not exists returns empty result set

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259736#comment-17259736 ] ASF GitHub Bot commented on PHOENIX-3633: - stoty closed pull request #1066: URL:

[GitHub] [phoenix] stoty closed pull request #1070: PHOENIX-3633 null pointer exception when subsquery for not exists ret…

2021-01-06 Thread GitBox
stoty closed pull request #1070: URL: https://github.com/apache/phoenix/pull/1070 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (PHOENIX-3633) null pointer exception when subsquery for not exists returns empty result set

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259722#comment-17259722 ] ASF GitHub Bot commented on PHOENIX-3633: - stoty commented on a change in pull request #1070:

[GitHub] [phoenix] stoty commented on a change in pull request #1070: PHOENIX-3633 null pointer exception when subsquery for not exists ret…

2021-01-06 Thread GitBox
stoty commented on a change in pull request #1070: URL: https://github.com/apache/phoenix/pull/1070#discussion_r552631933 ## File path: phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java ## @@ -1217,8 +1217,10 @@ public boolean

[jira] [Commented] (PHOENIX-3633) null pointer exception when subsquery for not exists returns empty result set

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259721#comment-17259721 ] ASF GitHub Bot commented on PHOENIX-3633: - stoty commented on a change in pull request #1070:

[GitHub] [phoenix] stoty commented on a change in pull request #1070: PHOENIX-3633 null pointer exception when subsquery for not exists ret…

2021-01-06 Thread GitBox
stoty commented on a change in pull request #1070: URL: https://github.com/apache/phoenix/pull/1070#discussion_r552631600 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/join/SubqueryIT.java ## @@ -528,10 +528,29 @@ public void testExistsSubquery() throws

[jira] [Commented] (PHOENIX-6297) Fix IndexMetadataIT.testAsyncRebuildAll test flapper

2021-01-06 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259720#comment-17259720 ] Hadoop QA commented on PHOENIX-6297: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (PHOENIX-3633) null pointer exception when subsquery for not exists returns empty result set

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259712#comment-17259712 ] ASF GitHub Bot commented on PHOENIX-3633: - virajjasani commented on a change in pull request

[GitHub] [phoenix] virajjasani commented on a change in pull request #1070: PHOENIX-3633 null pointer exception when subsquery for not exists ret…

2021-01-06 Thread GitBox
virajjasani commented on a change in pull request #1070: URL: https://github.com/apache/phoenix/pull/1070#discussion_r552610534 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/join/SubqueryIT.java ## @@ -528,10 +528,29 @@ public void testExistsSubquery()

[jira] [Commented] (PHOENIX-6297) Fix IndexMetadataIT.testAsyncRebuildAll test flapper

2021-01-06 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259710#comment-17259710 ] Istvan Toth commented on PHOENIX-6297: -- +1 LGTM > Fix IndexMetadataIT.testAsyncRebuildAll test

[jira] [Commented] (PHOENIX-6302) Fix ConcurrentUpsertsWithoutIndexedColsIT flapper

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259707#comment-17259707 ] ASF GitHub Bot commented on PHOENIX-6302: - stoty commented on pull request #1068: URL:

[GitHub] [phoenix] stoty commented on pull request #1068: PHOENIX-6302 : De-flake ConcurrentUpsertsWithoutIndexedColsIT

2021-01-06 Thread GitBox
stoty commented on pull request #1068: URL: https://github.com/apache/phoenix/pull/1068#issuecomment-755296776 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

[jira] [Commented] (PHOENIX-6297) Fix IndexMetadataIT.testAsyncRebuildAll test flapper

2021-01-06 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259694#comment-17259694 ] Hadoop QA commented on PHOENIX-6297: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (PHOENIX-6302) Fix ConcurrentUpsertsWithoutIndexedColsIT flapper

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259691#comment-17259691 ] ASF GitHub Bot commented on PHOENIX-6302: - stoty commented on pull request #1067: URL:

[GitHub] [phoenix] stoty commented on pull request #1067: PHOENIX-6302 : De-flake ConcurrentUpsertsWithoutIndexedColsIT

2021-01-06 Thread GitBox
stoty commented on pull request #1067: URL: https://github.com/apache/phoenix/pull/1067#issuecomment-755285718 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

[jira] [Commented] (PHOENIX-3633) null pointer exception when subsquery for not exists returns empty result set

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259679#comment-17259679 ] ASF GitHub Bot commented on PHOENIX-3633: - stoty commented on pull request #1066: URL:

[GitHub] [phoenix] stoty commented on pull request #1066: PHOENIX-3633 null pointer exception when subsquery for not exists ret…

2021-01-06 Thread GitBox
stoty commented on pull request #1066: URL: https://github.com/apache/phoenix/pull/1066#issuecomment-755279012 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

[jira] [Commented] (PHOENIX-6050) Set properties is invalid

2021-01-06 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259664#comment-17259664 ] Istvan Toth commented on PHOENIX-6050: -- This has nothing to with using Query Server or not. If

[jira] [Commented] (PHOENIX-6262) Bulk Load have a bug in lowercase tablename

2021-01-06 Thread Chao Wang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259658#comment-17259658 ] Chao Wang commented on PHOENIX-6262: hi [~stoty],  could you review this patch? if be suite,  we

[jira] [Comment Edited] (PHOENIX-6262) Bulk Load have a bug in lowercase tablename

2021-01-06 Thread Chao Wang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259658#comment-17259658 ] Chao Wang edited comment on PHOENIX-6262 at 1/6/21, 12:10 PM: -- hi

[jira] [Commented] (PHOENIX-6050) Set properties is invalid

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259654#comment-17259654 ] ASF GitHub Bot commented on PHOENIX-6050: - wangchao316 commented on pull request #1064: URL:

[GitHub] [phoenix] wangchao316 commented on pull request #1064: PHOENIX-6050 Set properties is invalid

2021-01-06 Thread GitBox
wangchao316 commented on pull request #1064: URL: https://github.com/apache/phoenix/pull/1064#issuecomment-755262426 > I agree @wangchao316 that tuning poolsize is crucial for performance optimization. > It is just my opinion that the tuning should be done on the cluster size, in

[jira] [Commented] (PHOENIX-6050) Set properties is invalid

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259631#comment-17259631 ] ASF GitHub Bot commented on PHOENIX-6050: - stoty commented on pull request #1064: URL:

[GitHub] [phoenix] stoty commented on pull request #1064: PHOENIX-6050 Set properties is invalid

2021-01-06 Thread GitBox
stoty commented on pull request #1064: URL: https://github.com/apache/phoenix/pull/1064#issuecomment-755249585 I agree @wangchao316 that tuning poolsize is crucial for performance optimization. It is just my opinion that the tuning should be done on the cluster size, in hbase-site.xml,

[jira] [Commented] (PHOENIX-3633) null pointer exception when subsquery for not exists returns empty result set

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259628#comment-17259628 ] ASF GitHub Bot commented on PHOENIX-3633: - stoty opened a new pull request #1070: URL:

[GitHub] [phoenix] stoty opened a new pull request #1070: PHOENIX-3633 null pointer exception when subsquery for not exists ret…

2021-01-06 Thread GitBox
stoty opened a new pull request #1070: URL: https://github.com/apache/phoenix/pull/1070 …urns empty result set Co-authored-by: Jerry He This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (PHOENIX-3499) Enable null value for quote character for CSVBulkLoad tool

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259626#comment-17259626 ] ASF GitHub Bot commented on PHOENIX-3499: - stoty opened a new pull request #1069: URL:

[GitHub] [phoenix] stoty opened a new pull request #1069: PHOENIX-3499 Enable null value for quote character for CSVBulkLoad tool

2021-01-06 Thread GitBox
stoty opened a new pull request #1069: URL: https://github.com/apache/phoenix/pull/1069 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PHOENIX-6050) Set properties is invalid

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259602#comment-17259602 ] ASF GitHub Bot commented on PHOENIX-6050: - wangchao316 commented on pull request #1064: URL:

[jira] [Commented] (PHOENIX-3499) Enable null value for quote character for CSVBulkLoad tool

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259601#comment-17259601 ] ASF GitHub Bot commented on PHOENIX-3499: - stoty commented on pull request #1065: URL:

[GitHub] [phoenix] wangchao316 commented on pull request #1064: PHOENIX-6050 Set properties is invalid

2021-01-06 Thread GitBox
wangchao316 commented on pull request #1064: URL: https://github.com/apache/phoenix/pull/1064#issuecomment-755231212 and I find from 4.x to 5.x, reduce performance in some changed, which consumer use in our product environment by upgrading. I will always deal this question later.

[GitHub] [phoenix] stoty commented on pull request #1065: PHOENIX-3499 Enable null value for quote character for CSVBulkLoad tool

2021-01-06 Thread GitBox
stoty commented on pull request #1065: URL: https://github.com/apache/phoenix/pull/1065#issuecomment-755231073 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

[jira] [Commented] (PHOENIX-6050) Set properties is invalid

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259590#comment-17259590 ] ASF GitHub Bot commented on PHOENIX-6050: - wangchao316 commented on pull request #1064: URL:

[GitHub] [phoenix] wangchao316 commented on pull request #1064: PHOENIX-6050 Set properties is invalid

2021-01-06 Thread GitBox
wangchao316 commented on pull request #1064: URL: https://github.com/apache/phoenix/pull/1064#issuecomment-755225514 > Also see my objection from the ticket that this will cause discrepancy between the poolsize used by the client, and by the Index rebuilding initiated by MetaDataObserver.

[jira] [Commented] (PHOENIX-6302) Fix ConcurrentUpsertsWithoutIndexedColsIT flapper

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259583#comment-17259583 ] ASF GitHub Bot commented on PHOENIX-6302: - virajjasani opened a new pull request #1068: URL:

[GitHub] [phoenix] virajjasani opened a new pull request #1068: PHOENIX-6302 : De-flake ConcurrentUpsertsWithoutIndexedColsIT

2021-01-06 Thread GitBox
virajjasani opened a new pull request #1068: URL: https://github.com/apache/phoenix/pull/1068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (PHOENIX-6302) Fix ConcurrentUpsertsWithoutIndexedColsIT flapper

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259578#comment-17259578 ] ASF GitHub Bot commented on PHOENIX-6302: - virajjasani opened a new pull request #1067: URL:

[GitHub] [phoenix] virajjasani opened a new pull request #1067: PHOENIX-6302 : De-flake ConcurrentUpsertsWithoutIndexedColsIT

2021-01-06 Thread GitBox
virajjasani opened a new pull request #1067: URL: https://github.com/apache/phoenix/pull/1067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (PHOENIX-3633) null pointer exception when subsquery for not exists returns empty result set

2021-01-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259576#comment-17259576 ] ASF GitHub Bot commented on PHOENIX-3633: - stoty opened a new pull request #1066: URL:

[GitHub] [phoenix] stoty opened a new pull request #1066: PHOENIX-3633 null pointer exception when subsquery for not exists ret…

2021-01-06 Thread GitBox
stoty opened a new pull request #1066: URL: https://github.com/apache/phoenix/pull/1066 …urns empty result set This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (PHOENIX-3710) Cannot use lowername data table name with indextool

2021-01-06 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259575#comment-17259575 ] Hadoop QA commented on PHOENIX-3710: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

  1   2   >