stoty commented on pull request #1138:
URL: https://github.com/apache/phoenix/pull/1138#issuecomment-777254401
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 8s | D
[
https://issues.apache.org/jira/browse/PHOENIX-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282883#comment-17282883
]
ASF GitHub Bot commented on PHOENIX-6379:
-
yanxinyi commented on a change in pu
yanxinyi commented on a change in pull request #1139:
URL: https://github.com/apache/phoenix/pull/1139#discussion_r574283846
##
File path:
phoenix-core/src/test/java/org/apache/phoenix/monitoring/PhoenixMetricImplTest.java
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Sof
[
https://issues.apache.org/jira/browse/PHOENIX-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282870#comment-17282870
]
ASF GitHub Bot commented on PHOENIX-6379:
-
vmeka2020 opened a new pull request
vmeka2020 opened a new pull request #1139:
URL: https://github.com/apache/phoenix/pull/1139
Implement a new Metric Type which will be used for TableMetrics
This is an automated message from the Apache Git Service.
To respond
vmeka2020 closed pull request #1138:
URL: https://github.com/apache/phoenix/pull/1138
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
yanxinyi commented on pull request #1138:
URL: https://github.com/apache/phoenix/pull/1138#issuecomment-777209966
@vmeka2020 can you squash your commits and raise a new PR with the format of
PHOENIX-number Jira title? It will attract to the Jira and run the Hadoop QA,
thanks
---
stoty commented on pull request #1138:
URL: https://github.com/apache/phoenix/pull/1138#issuecomment-777189481
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 5m 37s | D
dbwong commented on pull request #1138:
URL: https://github.com/apache/phoenix/pull/1138#issuecomment-777161073
@mihir6692 Might want to review this.
This is an automated message from the Apache Git Service.
To respond to the
vmeka2020 commented on a change in pull request #1138:
URL: https://github.com/apache/phoenix/pull/1138#discussion_r574205609
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/PhoenixMetricImpl.java
##
@@ -0,0 +1,69 @@
+/*
Review comment:
Modified
yanxinyi commented on a change in pull request #1138:
URL: https://github.com/apache/phoenix/pull/1138#discussion_r574179621
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/PhoenixMetricImpl.java
##
@@ -0,0 +1,69 @@
+/*
Review comment:
format is
vmeka2020 opened a new pull request #1138:
URL: https://github.com/apache/phoenix/pull/1138
JIRA:https://issues.apache.org/jira/browse/PHOENIX-6379
This is an automated message from the Apache Git Service.
To respond to the m
[
https://issues.apache.org/jira/browse/PHOENIX-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282753#comment-17282753
]
Geoffrey Jacoby commented on PHOENIX-6377:
--
I'm a bit unclear on how to detect
stoty commented on pull request #1136:
URL: https://github.com/apache/phoenix/pull/1136#issuecomment-777075796
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s | D
[
https://issues.apache.org/jira/browse/PHOENIX-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282742#comment-17282742
]
ASF GitHub Bot commented on PHOENIX-6377:
-
stoty commented on pull request #113
stoty commented on pull request #1137:
URL: https://github.com/apache/phoenix/pull/1137#issuecomment-777069588
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 5s | D
dbwong commented on pull request #1136:
URL: https://github.com/apache/phoenix/pull/1136#issuecomment-777068938
+1 I think i'd prefer to fix whatever is wrong with the shading to the
approach I mentioned anyway.
This is an a
stoty commented on pull request #1136:
URL: https://github.com/apache/phoenix/pull/1136#issuecomment-777067747
OK, now I understand what you mean.
We're getting everything but sqlline and the hbase compatibility module from
phoenix-core.
I don't really think that adding another mechan
[
https://issues.apache.org/jira/browse/PHOENIX-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282731#comment-17282731
]
ASF GitHub Bot commented on PHOENIX-6377:
-
stoty commented on pull request #113
stoty commented on pull request #1137:
URL: https://github.com/apache/phoenix/pull/1137#issuecomment-777049026
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 9s | D
dbwong commented on pull request #1136:
URL: https://github.com/apache/phoenix/pull/1136#issuecomment-777048722
> I don't really get what you mean. We are already have most common setting
in the parent pom. Can you add a little more detail ?
>
> >
I was referring to an approac
[
https://issues.apache.org/jira/browse/PHOENIX-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282730#comment-17282730
]
Istvan Toth commented on PHOENIX-6377:
--
Could you test the linked PRs [~larsh] ?
stoty commented on pull request #1136:
URL: https://github.com/apache/phoenix/pull/1136#issuecomment-777047501
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s | D
stoty commented on pull request #1136:
URL: https://github.com/apache/phoenix/pull/1136#issuecomment-777046828
> One thing we might want to consider is an import dependency so we can
share a single pom across all of these client flavours. Any thoughts?
I don't really get what you mea
stoty commented on pull request #1133:
URL: https://github.com/apache/phoenix/pull/1133#issuecomment-777038022
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s | D
[
https://issues.apache.org/jira/browse/PHOENIX-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282727#comment-17282727
]
ASF GitHub Bot commented on PHOENIX-6365:
-
stoty commented on pull request #113
dbwong edited a comment on pull request #1136:
URL: https://github.com/apache/phoenix/pull/1136#issuecomment-777035897
Lets unbundle in another jira (is there one already?) as it is not really a
runtime dependency for the client. One thing we might want to consider is an
import dependency
dbwong commented on pull request #1136:
URL: https://github.com/apache/phoenix/pull/1136#issuecomment-777035897
Lets unbundle in another jira (is there one already?) as it is not really a
runtime dependency for the client. One thing we might want to consider is an
import dependency so we
stoty commented on pull request #1136:
URL: https://github.com/apache/phoenix/pull/1136#issuecomment-777030014
We are traditionally including sqlline in phoenix-client for the sqlline.py
client.
I wouldn't be against unbundling it, in fact, I have already done that for
the thin clie
dbwong commented on pull request #1136:
URL: https://github.com/apache/phoenix/pull/1136#issuecomment-777027442
Probably not **_entirely_** related to this but why do we need sqlline as a
runtime dependency in the client?
[
https://issues.apache.org/jira/browse/PHOENIX-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282707#comment-17282707
]
ASF GitHub Bot commented on PHOENIX-6377:
-
stoty opened a new pull request #113
stoty opened a new pull request #1137:
URL: https://github.com/apache/phoenix/pull/1137
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stoty opened a new pull request #1136:
URL: https://github.com/apache/phoenix/pull/1136
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/PHOENIX-6072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282680#comment-17282680
]
Lars Hofhansl commented on PHOENIX-6072:
This change got rid of
{{org.apache.p
[
https://issues.apache.org/jira/browse/PHOENIX-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282671#comment-17282671
]
Istvan Toth commented on PHOENIX-6377:
--
This is the bug you found [~larsh]
> phoe
[
https://issues.apache.org/jira/browse/PHOENIX-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282627#comment-17282627
]
ASF GitHub Bot commented on PHOENIX-6365:
-
stoty commented on pull request #113
stoty commented on pull request #1133:
URL: https://github.com/apache/phoenix/pull/1133#issuecomment-776919169
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s | D
[
https://issues.apache.org/jira/browse/PHOENIX-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282555#comment-17282555
]
Jacob Isaac commented on PHOENIX-6374:
--
Thanks [~gjacoby] for pointing that out. I
[
https://issues.apache.org/jira/browse/PHOENIX-6343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282531#comment-17282531
]
ASF GitHub Bot commented on PHOENIX-6343:
-
stoty commented on pull request #111
stoty commented on pull request #1118:
URL: https://github.com/apache/phoenix/pull/1118#issuecomment-776817599
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m 24s | D
[
https://issues.apache.org/jira/browse/PHOENIX-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282521#comment-17282521
]
Geoffrey Jacoby commented on PHOENIX-6374:
--
Thanks for publishing this, [~jisa
[
https://issues.apache.org/jira/browse/PHOENIX-6343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282493#comment-17282493
]
ASF GitHub Bot commented on PHOENIX-6343:
-
stoty commented on pull request #111
stoty commented on pull request #1117:
URL: https://github.com/apache/phoenix/pull/1117#issuecomment-776762169
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 5m 29s | D
[
https://issues.apache.org/jira/browse/PHOENIX-6343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282384#comment-17282384
]
Viraj Jasani edited comment on PHOENIX-6343 at 2/10/21, 11:27 AM:
---
[
https://issues.apache.org/jira/browse/PHOENIX-6343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282384#comment-17282384
]
Viraj Jasani commented on PHOENIX-6343:
---
[~elserj] Are you fine with this approac
45 matches
Mail list logo
