[
https://issues.apache.org/jira/browse/PHOENIX-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296730#comment-17296730
]
ASF GitHub Bot commented on PHOENIX-6402:
-
lhofhansl edited a comment on pull r
lhofhansl edited a comment on pull request #1159:
URL: https://github.com/apache/phoenix/pull/1159#issuecomment-792208227
@dbwong Yep. On my list. :)
There are also two tests join tests that are actually failing now.
I'll continue when find get time next.
Actually... For the
[
https://issues.apache.org/jira/browse/PHOENIX-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296728#comment-17296728
]
ASF GitHub Bot commented on PHOENIX-6402:
-
lhofhansl commented on pull request
lhofhansl commented on pull request #1159:
URL: https://github.com/apache/phoenix/pull/1159#issuecomment-792208227
@dbwong Yep. On my list. :)
There are also two tests join tests that are actually failing now.
I'll continue when find get time next.
---
[
https://issues.apache.org/jira/browse/PHOENIX-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296699#comment-17296699
]
ASF GitHub Bot commented on PHOENIX-6402:
-
dbwong commented on pull request #11
dbwong commented on pull request #1159:
URL: https://github.com/apache/phoenix/pull/1159#issuecomment-792144478
Could we get some unit tests for some of the small bugfixes you put in
@lhofhansl ? Things like the cases you changed in PVarBinary or similar.
[
https://issues.apache.org/jira/browse/PHOENIX-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296686#comment-17296686
]
Karthik Palanisamy commented on PHOENIX-4622:
-
Fixed by PHOENIX-4933.
> Ph
[
https://issues.apache.org/jira/browse/PHOENIX-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296677#comment-17296677
]
ASF GitHub Bot commented on PHOENIX-6402:
-
stoty commented on pull request #115
stoty commented on pull request #1159:
URL: https://github.com/apache/phoenix/pull/1159#issuecomment-792120446
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 5m 34s | D
[
https://issues.apache.org/jira/browse/PHOENIX-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296658#comment-17296658
]
Lars Hofhansl commented on PHOENIX-6402:
PR filed. I put a bunch of comment on
[
https://issues.apache.org/jira/browse/PHOENIX-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296657#comment-17296657
]
ASF GitHub Bot commented on PHOENIX-6402:
-
lhofhansl commented on a change in p
[
https://issues.apache.org/jira/browse/PHOENIX-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296656#comment-17296656
]
ASF GitHub Bot commented on PHOENIX-6402:
-
lhofhansl commented on a change in p
lhofhansl commented on a change in pull request #1159:
URL: https://github.com/apache/phoenix/pull/1159#discussion_r588930362
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PVarbinary.java
##
@@ -142,7 +142,7 @@ public String toStringLiteral(byte[] b,
lhofhansl commented on a change in pull request #1159:
URL: https://github.com/apache/phoenix/pull/1159#discussion_r588930338
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/iterate/RegionScannerFactory.java
##
@@ -205,6 +210,22 @@ public boolean nextRaw(List resul
[
https://issues.apache.org/jira/browse/PHOENIX-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296655#comment-17296655
]
ASF GitHub Bot commented on PHOENIX-6402:
-
lhofhansl commented on a change in p
lhofhansl commented on a change in pull request #1159:
URL: https://github.com/apache/phoenix/pull/1159#discussion_r588930164
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ExplainTable.java
##
@@ -178,10 +184,19 @@ protected void explain(String prefix, Li
[
https://issues.apache.org/jira/browse/PHOENIX-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296651#comment-17296651
]
ASF GitHub Bot commented on PHOENIX-6402:
-
lhofhansl commented on a change in p
lhofhansl commented on a change in pull request #1159:
URL: https://github.com/apache/phoenix/pull/1159#discussion_r588929957
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
##
@@ -491,6 +476,22 @@ private static void optimizeProjec
[
https://issues.apache.org/jira/browse/PHOENIX-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296649#comment-17296649
]
ASF GitHub Bot commented on PHOENIX-6402:
-
lhofhansl opened a new pull request
lhofhansl opened a new pull request #1159:
URL: https://github.com/apache/phoenix/pull/1159
This works by passing down the filter expression as a scan attribute and
evaluating it after the full tuple has been assembled by merging in columns
from the main column family.
Please review
[
https://issues.apache.org/jira/browse/PHOENIX-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296644#comment-17296644
]
Lars Hofhansl commented on PHOENIX-6402:
-v4 is good and no longer W.I.P.
I fi
[
https://issues.apache.org/jira/browse/PHOENIX-6404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296515#comment-17296515
]
Viraj Jasani commented on PHOENIX-6404:
---
Thanks for the Jira [~stoty]. Unfortunat
22 matches
Mail list logo