[jira] [Commented] (PHOENIX-6430) Added support for full row update for tables when no columns specfied in scenario

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309826#comment-17309826 ] ASF GitHub Bot commented on PHOENIX-6430: - stoty commented on pull request #118

[GitHub] [phoenix] stoty commented on pull request #1186: PHOENIX-6430 Added support for full row update for tables when no columns specfied in scenario

2021-03-26 Thread GitBox
stoty commented on pull request #1186: URL: https://github.com/apache/phoenix/pull/1186#issuecomment-808607859 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 14s | D

[jira] [Commented] (PHOENIX-6429) Add support for global connections and sequential data generators

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309824#comment-17309824 ] ASF GitHub Bot commented on PHOENIX-6429: - ChinmaySKulkarni commented on a chan

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #1185: PHOENIX-6429 Add support for global connections and sequential data generators

2021-03-26 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #1185: URL: https://github.com/apache/phoenix/pull/1185#discussion_r602636895 ## File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/rules/SequentialDateDataGenerator.java ## @@ -0,0 +1,64 @@ +/* + * Licensed t

[jira] [Commented] (PHOENIX-6430) Added support for full row update for tables when no columns specfied in scenario

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309820#comment-17309820 ] ASF GitHub Bot commented on PHOENIX-6430: - jpisaac opened a new pull request #1

[jira] [Commented] (PHOENIX-6429) Add support for global connections and sequential data generators

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309821#comment-17309821 ] ASF GitHub Bot commented on PHOENIX-6429: - stoty commented on pull request #118

[GitHub] [phoenix] stoty commented on pull request #1185: PHOENIX-6429 Add support for global connections and sequential data generators

2021-03-26 Thread GitBox
stoty commented on pull request #1185: URL: https://github.com/apache/phoenix/pull/1185#issuecomment-808599154 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | D

[GitHub] [phoenix] jpisaac opened a new pull request #1186: PHOENIX-6430 Added support for full row update for tables when no columns specfied in scenario

2021-03-26 Thread GitBox
jpisaac opened a new pull request #1186: URL: https://github.com/apache/phoenix/pull/1186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (PHOENIX-6429) Add support for global connections and sequential data generators

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309819#comment-17309819 ] ASF GitHub Bot commented on PHOENIX-6429: - yanxinyi commented on a change in pu

[GitHub] [phoenix] yanxinyi commented on a change in pull request #1185: PHOENIX-6429 Add support for global connections and sequential data generators

2021-03-26 Thread GitBox
yanxinyi commented on a change in pull request #1185: URL: https://github.com/apache/phoenix/pull/1185#discussion_r602638162 ## File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/rules/SequentialVarcharDataGenerator.java ## @@ -0,0 +1,77 @@ +/* + * Licensed to the

[jira] [Commented] (PHOENIX-6429) Add support for global connections and sequential data generators

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309817#comment-17309817 ] ASF GitHub Bot commented on PHOENIX-6429: - yanxinyi commented on a change in pu

[jira] [Commented] (PHOENIX-6429) Add support for global connections and sequential data generators

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309818#comment-17309818 ] ASF GitHub Bot commented on PHOENIX-6429: - yanxinyi commented on a change in pu

[GitHub] [phoenix] yanxinyi commented on a change in pull request #1185: PHOENIX-6429 Add support for global connections and sequential data generators

2021-03-26 Thread GitBox
yanxinyi commented on a change in pull request #1185: URL: https://github.com/apache/phoenix/pull/1185#discussion_r602638143 ## File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/rules/SequentialListDataGenerator.java ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Ap

[GitHub] [phoenix] yanxinyi commented on a change in pull request #1185: PHOENIX-6429 Add support for global connections and sequential data generators

2021-03-26 Thread GitBox
yanxinyi commented on a change in pull request #1185: URL: https://github.com/apache/phoenix/pull/1185#discussion_r602638054 ## File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/rules/SequentialDateDataGenerator.java ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Ap

[jira] [Commented] (PHOENIX-6429) Add support for global connections and sequential data generators

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309816#comment-17309816 ] ASF GitHub Bot commented on PHOENIX-6429: - yanxinyi commented on a change in pu

[GitHub] [phoenix] yanxinyi commented on a change in pull request #1185: PHOENIX-6429 Add support for global connections and sequential data generators

2021-03-26 Thread GitBox
yanxinyi commented on a change in pull request #1185: URL: https://github.com/apache/phoenix/pull/1185#discussion_r602637762 ## File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/rules/SequentialListDataGenerator.java ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Ap

[jira] [Commented] (PHOENIX-6429) Add support for global connections and sequential data generators

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309815#comment-17309815 ] ASF GitHub Bot commented on PHOENIX-6429: - ChinmaySKulkarni commented on a chan

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #1185: PHOENIX-6429 Add support for global connections and sequential data generators

2021-03-26 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #1185: URL: https://github.com/apache/phoenix/pull/1185#discussion_r602635060 ## File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/mt/tenantoperation/PreScenarioOperationSupplier.java ## @@ -48,32 +4

[jira] [Commented] (PHOENIX-6429) Add support for global connections and sequential data generators

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309814#comment-17309814 ] ASF GitHub Bot commented on PHOENIX-6429: - yanxinyi commented on a change in pu

[GitHub] [phoenix] yanxinyi commented on a change in pull request #1185: PHOENIX-6429 Add support for global connections and sequential data generators

2021-03-26 Thread GitBox
yanxinyi commented on a change in pull request #1185: URL: https://github.com/apache/phoenix/pull/1185#discussion_r602637325 ## File path: phoenix-pherf/src/test/java/org/apache/phoenix/pherf/rules/SequentialDateDataGeneratorTest.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to th

[jira] [Commented] (PHOENIX-6429) Add support for global connections and sequential data generators

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309805#comment-17309805 ] ASF GitHub Bot commented on PHOENIX-6429: - jpisaac opened a new pull request #1

[GitHub] [phoenix] jpisaac opened a new pull request #1185: PHOENIX-6429 Add support for global connections and sequential data generators

2021-03-26 Thread GitBox
jpisaac opened a new pull request #1185: URL: https://github.com/apache/phoenix/pull/1185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (PHOENIX-6428) Phoenix select subquery doesn't work on VARCHAR and CHAR types

2021-03-26 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309740#comment-17309740 ] Lars Hofhansl commented on PHOENIX-6428: I see. {code} explain select * from t

[jira] [Commented] (PHOENIX-6420) Wrong result when conditional and regular upserts are passed in the same commit batch

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309731#comment-17309731 ] ASF GitHub Bot commented on PHOENIX-6420: - tkhurana commented on a change in pu

[GitHub] [phoenix] tkhurana commented on a change in pull request #1183: PHOENIX-6420 Wrong result when conditional and regular upserts are passed in the same commit batch

2021-03-26 Thread GitBox
tkhurana commented on a change in pull request #1183: URL: https://github.com/apache/phoenix/pull/1183#discussion_r602584532 ## File path: phoenix-core/src/test/java/org/apache/phoenix/execute/MutationStateTest.java ## @@ -17,23 +17,7 @@ */ package org.apache.phoenix.execut

[GitHub] [phoenix] tkhurana commented on a change in pull request #1183: PHOENIX-6420 Wrong result when conditional and regular upserts are passed in the same commit batch

2021-03-26 Thread GitBox
tkhurana commented on a change in pull request #1183: URL: https://github.com/apache/phoenix/pull/1183#discussion_r602577275 ## File path: phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java ## @@ -586,10 +638,11 @@ public boolean hasNext() {

[jira] [Commented] (PHOENIX-6420) Wrong result when conditional and regular upserts are passed in the same commit batch

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309719#comment-17309719 ] ASF GitHub Bot commented on PHOENIX-6420: - tkhurana commented on a change in pu

[jira] [Commented] (PHOENIX-6420) Wrong result when conditional and regular upserts are passed in the same commit batch

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309614#comment-17309614 ] ASF GitHub Bot commented on PHOENIX-6420: - gjacoby126 commented on a change in

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #1183: PHOENIX-6420 Wrong result when conditional and regular upserts are passed in the same commit batch

2021-03-26 Thread GitBox
gjacoby126 commented on a change in pull request #1183: URL: https://github.com/apache/phoenix/pull/1183#discussion_r601889798 ## File path: phoenix-core/src/test/java/org/apache/phoenix/execute/MutationStateTest.java ## @@ -17,23 +17,7 @@ */ package org.apache.phoenix.exec

[jira] [Commented] (PHOENIX-6420) Wrong result when conditional and regular upserts are passed in the same commit batch

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309555#comment-17309555 ] ASF GitHub Bot commented on PHOENIX-6420: - tkhurana commented on a change in pu

[GitHub] [phoenix] tkhurana commented on a change in pull request #1183: PHOENIX-6420 Wrong result when conditional and regular upserts are passed in the same commit batch

2021-03-26 Thread GitBox
tkhurana commented on a change in pull request #1183: URL: https://github.com/apache/phoenix/pull/1183#discussion_r602450315 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java ## @@ -614,6 +614,48 @@ public void testRowsCreatedViaUpsertOnD

[jira] [Commented] (PHOENIX-6420) Wrong result when conditional and regular upserts are passed in the same commit batch

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309488#comment-17309488 ] ASF GitHub Bot commented on PHOENIX-6420: - gokceni commented on a change in pul

[GitHub] [phoenix] gokceni commented on a change in pull request #1183: PHOENIX-6420 Wrong result when conditional and regular upserts are passed in the same commit batch

2021-03-26 Thread GitBox
gokceni commented on a change in pull request #1183: URL: https://github.com/apache/phoenix/pull/1183#discussion_r602376848 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKeyIT.java ## @@ -614,6 +614,48 @@ public void testRowsCreatedViaUpsertOnDu

[jira] [Commented] (PHOENIX-6398) Returns uniform SQL dialect in calcite for the PQS

2021-03-26 Thread Cong Luo (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309466#comment-17309466 ] Cong Luo commented on PHOENIX-6398: --- [~stoty] Thank you all so much for the review. A

[jira] [Commented] (PHOENIX-6414) Access to Phoenix from Python using SPNEGO

2021-03-26 Thread Jira
[ https://issues.apache.org/jira/browse/PHOENIX-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309399#comment-17309399 ] Carlos GarcĂ­a Montoro commented on PHOENIX-6414: [~stoty], I have just

[GitHub] [phoenix-queryserver] TrilceAC opened a new pull request #59: PHOENIX-6414 Explicit creation of auch mech for SPNEGO

2021-03-26 Thread GitBox
TrilceAC opened a new pull request #59: URL: https://github.com/apache/phoenix-queryserver/pull/59 This PR applies the patch proposed at [PHOENIX-6414](https://issues.apache.org/jira/browse/PHOENIX-6414) with some minor corrections. It is intended to make Phoenix 5.0.0 (PQS) accessible fro

[jira] [Commented] (PHOENIX-6420) Wrong result when conditional and regular upserts are passed in the same commit batch

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309372#comment-17309372 ] ASF GitHub Bot commented on PHOENIX-6420: - stoty commented on pull request #118

[GitHub] [phoenix] stoty commented on pull request #1183: PHOENIX-6420 Wrong result when conditional and regular upserts are passed in the same commit batch

2021-03-26 Thread GitBox
stoty commented on pull request #1183: URL: https://github.com/apache/phoenix/pull/1183#issuecomment-808135772 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | D

[jira] [Commented] (PHOENIX-6247) Change SYSTEM.CATALOG to allow separation of physical name (Hbase name) from logical name (Phoenix name)

2021-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309363#comment-17309363 ] ASF GitHub Bot commented on PHOENIX-6247: - stoty commented on pull request #117

[GitHub] [phoenix] stoty commented on pull request #1170: PHOENIX-6247 Separating logical and physical table names

2021-03-26 Thread GitBox
stoty commented on pull request #1170: URL: https://github.com/apache/phoenix/pull/1170#issuecomment-808130427 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 46s | D

[jira] [Comment Edited] (PHOENIX-6414) Access to Phoenix from Python using SPNEGO

2021-03-26 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309336#comment-17309336 ] Istvan Toth edited comment on PHOENIX-6414 at 3/26/21, 10:34 AM:

[jira] [Commented] (PHOENIX-6414) Access to Phoenix from Python using SPNEGO

2021-03-26 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309338#comment-17309338 ] Istvan Toth commented on PHOENIX-6414: -- Please open a PR with your patch [~TrilceA

[jira] [Commented] (PHOENIX-6414) Access to Phoenix from Python using SPNEGO

2021-03-26 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309336#comment-17309336 ] Istvan Toth commented on PHOENIX-6414: -- I got another report that the PQS in 5.0.0