[GitHub] [phoenix] vmeka2020 commented on pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries

2021-05-05 Thread GitBox
vmeka2020 commented on pull request #1223: URL: https://github.com/apache/phoenix/pull/1223#issuecomment-833260766 @yanxinyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [phoenix] vmeka2020 commented on pull request #1224: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries

2021-05-05 Thread GitBox
vmeka2020 commented on pull request #1224: URL: https://github.com/apache/phoenix/pull/1224#issuecomment-833260828 @yanxinyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [phoenix] vmeka2020 commented on pull request #1160: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries

2021-05-05 Thread GitBox
vmeka2020 commented on pull request #1160: URL: https://github.com/apache/phoenix/pull/1160#issuecomment-833257503 Closing this as i have created a separate PR for 4.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [phoenix] vmeka2020 closed pull request #1160: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries

2021-05-05 Thread GitBox
vmeka2020 closed pull request #1160: URL: https://github.com/apache/phoenix/pull/1160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [phoenix] vmeka2020 opened a new pull request #1224: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries

2021-05-05 Thread GitBox
vmeka2020 opened a new pull request #1224: URL: https://github.com/apache/phoenix/pull/1224 PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [phoenix] vmeka2020 opened a new pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries

2021-05-05 Thread GitBox
vmeka2020 opened a new pull request #1223: URL: https://github.com/apache/phoenix/pull/1223 PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [phoenix] stoty commented on pull request #1211: PHOENIX-6432 Add support for additional load generators

2021-05-05 Thread GitBox
stoty commented on pull request #1211: URL: https://github.com/apache/phoenix/pull/1211#issuecomment-833200850 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 14s | D

[GitHub] [phoenix-queryserver] joshelser edited a comment on pull request #60: PHOENIX-6459 Try to use a Session to pass along any cookies the serve…

2021-05-05 Thread GitBox
joshelser edited a comment on pull request #60: URL: https://github.com/apache/phoenix-queryserver/pull/60#issuecomment-833183046 ``` global maxconn 256 defaults mode http timeout connect 5000ms timeout client 6ms timeout server 6ms frontend http-in

[GitHub] [phoenix-queryserver] joshelser commented on pull request #60: PHOENIX-6459 Try to use a Session to pass along any cookies the serve…

2021-05-05 Thread GitBox
joshelser commented on pull request #60: URL: https://github.com/apache/phoenix-queryserver/pull/60#issuecomment-833183046 ``` global maxconn 256 defaults mode http timeout connect 5000ms timeout client 6ms timeout server 6ms frontend http-in b

[GitHub] [phoenix] jpisaac commented on a change in pull request #1211: PHOENIX-6432 Add support for additional load generators

2021-05-05 Thread GitBox
jpisaac commented on a change in pull request #1211: URL: https://github.com/apache/phoenix/pull/1211#discussion_r627007841 ## File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/mt/operations/TenantOperationFactory.java ## @@ -164,7 +175,7 @@ public void

[GitHub] [phoenix] stoty commented on pull request #1217: PHOENIX-6454: Add feature to SchemaTool to get the DDL in specificati…

2021-05-05 Thread GitBox
stoty commented on pull request #1217: URL: https://github.com/apache/phoenix/pull/1217#issuecomment-833172046 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | D

[GitHub] [phoenix] jpisaac commented on a change in pull request #1211: PHOENIX-6432 Add support for additional load generators

2021-05-05 Thread GitBox
jpisaac commented on a change in pull request #1211: URL: https://github.com/apache/phoenix/pull/1211#discussion_r627023292 ## File path: phoenix-pherf/src/it/java/org/apache/phoenix/pherf/workload/mt/TenantTableOperationWorkloadIT.java ## @@ -0,0 +1,149 @@ +/* + * Licensed to

[GitHub] [phoenix] jpisaac commented on a change in pull request #1211: PHOENIX-6432 Add support for additional load generators

2021-05-05 Thread GitBox
jpisaac commented on a change in pull request #1211: URL: https://github.com/apache/phoenix/pull/1211#discussion_r627022547 ## File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/mt/generators/SequentialLoadEventGenerator.java ## @@ -0,0 +1,169 @@ +package

[GitHub] [phoenix-queryserver] joshelser commented on a change in pull request #60: PHOENIX-6459 Try to use a Session to pass along any cookies the serve…

2021-05-05 Thread GitBox
joshelser commented on a change in pull request #60: URL: https://github.com/apache/phoenix-queryserver/pull/60#discussion_r627021153 ## File path: python-phoenixdb/phoenixdb/avatica/client.py ## @@ -149,6 +149,7 @@ def __init__(self, url, max_retries=None, auth=None, verify=N

[GitHub] [phoenix-queryserver] joshelser commented on a change in pull request #60: PHOENIX-6459 Try to use a Session to pass along any cookies the serve…

2021-05-05 Thread GitBox
joshelser commented on a change in pull request #60: URL: https://github.com/apache/phoenix-queryserver/pull/60#discussion_r627021153 ## File path: python-phoenixdb/phoenixdb/avatica/client.py ## @@ -149,6 +149,7 @@ def __init__(self, url, max_retries=None, auth=None, verify=N

[GitHub] [phoenix] jpisaac commented on a change in pull request #1211: PHOENIX-6432 Add support for additional load generators

2021-05-05 Thread GitBox
jpisaac commented on a change in pull request #1211: URL: https://github.com/apache/phoenix/pull/1211#discussion_r627007841 ## File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/mt/operations/TenantOperationFactory.java ## @@ -164,7 +175,7 @@ public void

[GitHub] [phoenix] gjacoby126 merged pull request #1219: PHOENIX-6437: Parent-Child Delete marker should get replicated via Sy…

2021-05-05 Thread GitBox
gjacoby126 merged pull request #1219: URL: https://github.com/apache/phoenix/pull/1219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [phoenix] gjacoby126 merged pull request #1222: PHOENIX-6437: Parent-Child Delete marker should get replicated via Sy…

2021-05-05 Thread GitBox
gjacoby126 merged pull request #1222: URL: https://github.com/apache/phoenix/pull/1222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [phoenix] stoty commented on pull request #1217: PHOENIX-6454: Add feature to SchemaTool to get the DDL in specificati…

2021-05-05 Thread GitBox
stoty commented on pull request #1217: URL: https://github.com/apache/phoenix/pull/1217#issuecomment-833054742 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | D

[GitHub] [phoenix] stoty commented on pull request #1160: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries

2021-05-05 Thread GitBox
stoty commented on pull request #1160: URL: https://github.com/apache/phoenix/pull/1160#issuecomment-833033802 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 48s | D

[GitHub] [phoenix] kadirozde commented on a change in pull request #1217: PHOENIX-6454: Add feature to SchemaTool to get the DDL in specificati…

2021-05-05 Thread GitBox
kadirozde commented on a change in pull request #1217: URL: https://github.com/apache/phoenix/pull/1217#discussion_r626797026 ## File path: phoenix-tools/src/main/java/org/apache/phoenix/schema/SchemaSynthesisProcessor.java ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache S

[GitHub] [phoenix] gokceni commented on a change in pull request #1216: PHOENIX-6457 - Optionally store schema version string in SYSTEM.CATALOG

2021-05-05 Thread GitBox
gokceni commented on a change in pull request #1216: URL: https://github.com/apache/phoenix/pull/1216#discussion_r626782919 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/CreateTableIT.java ## @@ -1166,6 +1166,31 @@ public void testTableDescriptorPriority()

[GitHub] [phoenix] swaroopak commented on a change in pull request #1217: PHOENIX-6454: Add feature to SchemaTool to get the DDL in specificati…

2021-05-05 Thread GitBox
swaroopak commented on a change in pull request #1217: URL: https://github.com/apache/phoenix/pull/1217#discussion_r626770179 ## File path: phoenix-tools/src/main/java/org/apache/phoenix/schema/SchemaSynthesisProcessor.java ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache S

[GitHub] [phoenix] stoty commented on pull request #1217: PHOENIX-6454: Add feature to SchemaTool to get the DDL in specificati…

2021-05-05 Thread GitBox
stoty commented on pull request #1217: URL: https://github.com/apache/phoenix/pull/1217#issuecomment-832499372 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13s | D

[GitHub] [phoenix] stoty commented on pull request #1222: PHOENIX-6437: Parent-Child Delete marker should get replicated via Sy…

2021-05-05 Thread GitBox
stoty commented on pull request #1222: URL: https://github.com/apache/phoenix/pull/1222#issuecomment-832464409 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 24s | D