[jira] [Commented] (PHOENIX-6485) clean up sqlline.py classpath

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354855#comment-17354855 ] ASF GitHub Bot commented on PHOENIX-6485: - stoty commented on pull request #124

[GitHub] [phoenix] stoty commented on pull request #1243: PHOENIX-6485 clean up sqlline.py classpath

2021-05-31 Thread GitBox
stoty commented on pull request #1243: URL: https://github.com/apache/phoenix/pull/1243#issuecomment-851864170 Can you do the same for the rest of the scripts ? psql, pherf, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (PHOENIX-6453) Possible ArrayIndexOutOfBoundsException while preparing scan start key with multiple key range queries

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354772#comment-17354772 ] ASF GitHub Bot commented on PHOENIX-6453: - stoty closed pull request #1220: URL

[GitHub] [phoenix] stoty closed pull request #1220: PHOENIX-6453 Possible ArrayIndexOutOfBoundsException while preparing …

2021-05-31 Thread GitBox
stoty closed pull request #1220: URL: https://github.com/apache/phoenix/pull/1220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [phoenix-queryserver] stoty closed pull request #66: PHOENIX-6484 Python phoenixdb throws error on empty resultsets with a…

2021-05-31 Thread GitBox
stoty closed pull request #66: URL: https://github.com/apache/phoenix-queryserver/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (PHOENIX-6378) Unbunldle sqqline from phoenix-client-embedded, and use it in sqlline.py

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354638#comment-17354638 ] ASF GitHub Bot commented on PHOENIX-6378: - stoty commented on pull request #124

[GitHub] [phoenix] stoty commented on pull request #1242: PHOENIX-6378 Unbunldle sqqline from phoenix-client-embedded, and use …

2021-05-31 Thread GitBox
stoty commented on pull request #1242: URL: https://github.com/apache/phoenix/pull/1242#issuecomment-851642088 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | D

[GitHub] [phoenix] stoty commented on pull request #1242: PHOENIX-6378 Unbunldle sqqline from phoenix-client-embedded, and use …

2021-05-31 Thread GitBox
stoty commented on pull request #1242: URL: https://github.com/apache/phoenix/pull/1242#issuecomment-851568240 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | D

[jira] [Commented] (PHOENIX-6378) Unbunldle sqqline from phoenix-client-embedded, and use it in sqlline.py

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354524#comment-17354524 ] ASF GitHub Bot commented on PHOENIX-6378: - stoty commented on pull request #124

[jira] [Commented] (PHOENIX-6485) clean up sqlline.py classpath

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354489#comment-17354489 ] ASF GitHub Bot commented on PHOENIX-6485: - stoty commented on a change in pull

[GitHub] [phoenix] stoty commented on a change in pull request #1243: PHOENIX-6485 clean up sqlline.py classpath

2021-05-31 Thread GitBox
stoty commented on a change in pull request #1243: URL: https://github.com/apache/phoenix/pull/1243#discussion_r642504679 ## File path: bin/sqlline.py ## @@ -108,12 +108,10 @@ def kill_child(): colorSetting = "false" java_cmd = java + ' $PHOENIX_OPTS ' + \ -' -cp "'

[GitHub] [phoenix-queryserver] joshelser commented on pull request #65: PHOENIX-6473 Add Hadoop JMXServlet as /jmx endpoint

2021-05-31 Thread GitBox
joshelser commented on pull request #65: URL: https://github.com/apache/phoenix-queryserver/pull/65#issuecomment-851521967 I forgot to reply last week, but I think this is fine to leave it unauthenticated. I can't think of anything harmful exposed via the servlet. Thanks for adding the op

[jira] [Commented] (PHOENIX-6483) Flakes in BasePermissionsIT and AuditLoggingIT

2021-05-31 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354479#comment-17354479 ] Viraj Jasani commented on PHOENIX-6483: --- Just for keeping record for this Jira, c

[jira] [Commented] (PHOENIX-6485) clean up sqlline.py classpath

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354475#comment-17354475 ] ASF GitHub Bot commented on PHOENIX-6485: - stoty commented on pull request #124

[GitHub] [phoenix] stoty commented on pull request #1243: PHOENIX-6485 clean up sqlline.py classpath

2021-05-31 Thread GitBox
stoty commented on pull request #1243: URL: https://github.com/apache/phoenix/pull/1243#issuecomment-851510423 We should go further. We should remove hbase_config_path, and use hbase_conf_dir from phoenix_utils.py instead in every script. The same goes for hbase_conf_path, which i

[jira] [Comment Edited] (PHOENIX-6486) Phoenix uses JodaTime ISO calendar internally, which is incompatible with the JDK time representation

2021-05-31 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354448#comment-17354448 ] Istvan Toth edited comment on PHOENIX-6486 at 5/31/21, 1:14 PM: -

[jira] [Commented] (PHOENIX-6486) Phoenix uses JodaTime ISO calendar internally, which is incompatible with the JDK time representation

2021-05-31 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354448#comment-17354448 ] Istvan Toth commented on PHOENIX-6486: -- I think that switching over to using the J

[jira] [Commented] (PHOENIX-6485) clean up sqlline.py classpath

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354442#comment-17354442 ] ASF GitHub Bot commented on PHOENIX-6485: - richardantal opened a new pull reque

[GitHub] [phoenix] richardantal opened a new pull request #1243: PHOENIX-6485 clean up sqlline.py classpath

2021-05-31 Thread GitBox
richardantal opened a new pull request #1243: URL: https://github.com/apache/phoenix/pull/1243 Change-Id: Iba524a971eb62c42a36eaff4ae303aab5f04e298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (PHOENIX-6378) Unbunldle sqqline from phoenix-client-embedded, and use it in sqlline.py

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354440#comment-17354440 ] ASF GitHub Bot commented on PHOENIX-6378: - stoty commented on pull request #124

[GitHub] [phoenix] stoty commented on pull request #1242: PHOENIX-6378 Unbunldle sqqline from phoenix-client-embedded, and use …

2021-05-31 Thread GitBox
stoty commented on pull request #1242: URL: https://github.com/apache/phoenix/pull/1242#issuecomment-851464632 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 31s | D

[jira] [Commented] (PHOENIX-6378) Unbunldle sqqline from phoenix-client-embedded, and use it in sqlline.py

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354352#comment-17354352 ] ASF GitHub Bot commented on PHOENIX-6378: - stoty commented on pull request #123

[GitHub] [phoenix] stoty commented on pull request #1239: PHOENIX-6378 Unbundle sqlline from phoenix-client

2021-05-31 Thread GitBox
stoty commented on pull request #1239: URL: https://github.com/apache/phoenix/pull/1239#issuecomment-851373945 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | D

[jira] [Commented] (PHOENIX-6378) Unbunldle sqqline from phoenix-client-embedded, and use it in sqlline.py

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354333#comment-17354333 ] ASF GitHub Bot commented on PHOENIX-6378: - richardantal opened a new pull reque

[GitHub] [phoenix] richardantal opened a new pull request #1242: PHOENIX-6378 Unbunldle sqqline from phoenix-client-embedded, and use …

2021-05-31 Thread GitBox
richardantal opened a new pull request #1242: URL: https://github.com/apache/phoenix/pull/1242 …it in sqlline.py Change-Id: Ifd31e25b303ab3d2872b53f4a503219539777544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (PHOENIX-6378) Unbunldle sqqline from phoenix-client-embedded, and use it in sqlline.py

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354298#comment-17354298 ] ASF GitHub Bot commented on PHOENIX-6378: - richardantal merged pull request #12

[GitHub] [phoenix] richardantal merged pull request #1239: PHOENIX-6378 Unbundle sqlline from phoenix-client

2021-05-31 Thread GitBox
richardantal merged pull request #1239: URL: https://github.com/apache/phoenix/pull/1239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[jira] [Commented] (PHOENIX-6378) Unbunldle sqqline from phoenix-client-embedded, and use it in sqlline.py

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354297#comment-17354297 ] ASF GitHub Bot commented on PHOENIX-6378: - richardantal commented on pull reque

[GitHub] [phoenix] richardantal commented on pull request #1239: PHOENIX-6378 Unbundle sqlline from phoenix-client

2021-05-31 Thread GitBox
richardantal commented on pull request #1239: URL: https://github.com/apache/phoenix/pull/1239#issuecomment-851318819 Thanks @stoty for the review. I squashed the commits to 1, before merging. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (PHOENIX-6378) Unbunldle sqqline from phoenix-client-embedded, and use it in sqlline.py

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354281#comment-17354281 ] ASF GitHub Bot commented on PHOENIX-6378: - stoty commented on a change in pull

[GitHub] [phoenix] stoty commented on a change in pull request #1239: PHOENIX-6378 Unbundle sqlline from phoenix-client

2021-05-31 Thread GitBox
stoty commented on a change in pull request #1239: URL: https://github.com/apache/phoenix/pull/1239#discussion_r642298456 ## File path: bin/phoenix_utils.py ## @@ -77,10 +77,16 @@ def findClasspath(command_name): return tryDecode(subprocess.Popen(command, shell=True, stdo

[jira] [Commented] (PHOENIX-6378) Unbunldle sqqline from phoenix-client-embedded, and use it in sqlline.py

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354274#comment-17354274 ] ASF GitHub Bot commented on PHOENIX-6378: - stoty commented on a change in pull

[GitHub] [phoenix] stoty commented on a change in pull request #1239: PHOENIX-6378 Unbundle sqlline from phoenix-client

2021-05-31 Thread GitBox
stoty commented on a change in pull request #1239: URL: https://github.com/apache/phoenix/pull/1239#discussion_r642289833 ## File path: bin/sqlline.py ## @@ -108,7 +108,9 @@ def kill_child(): colorSetting = "false" java_cmd = java + ' $PHOENIX_OPTS ' + \ -' -cp "' +

[jira] [Commented] (PHOENIX-6378) Unbunldle sqqline from phoenix-client-embedded, and use it in sqlline.py

2021-05-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354266#comment-17354266 ] ASF GitHub Bot commented on PHOENIX-6378: - stoty commented on a change in pull

[GitHub] [phoenix] stoty commented on a change in pull request #1239: PHOENIX-6378 Unbundle sqlline from phoenix-client

2021-05-31 Thread GitBox
stoty commented on a change in pull request #1239: URL: https://github.com/apache/phoenix/pull/1239#discussion_r642280324 ## File path: bin/phoenix_utils.py ## @@ -77,10 +77,16 @@ def findClasspath(command_name): return tryDecode(subprocess.Popen(command, shell=True, stdo

[jira] [Commented] (PHOENIX-6481) Strange behavior in upserting-deleting-upserting when primary key contains a ROW TIMESTAMP field

2021-05-31 Thread Jira
[ https://issues.apache.org/jira/browse/PHOENIX-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354258#comment-17354258 ] Richárd Antal commented on PHOENIX-6481: It can be reproduced on the master bra