[jira] [Commented] (PHOENIX-6523) Support for HBase Registry Implementations through Phoenix connection URL

2021-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404952#comment-17404952 ] ASF GitHub Bot commented on PHOENIX-6523: - ramatronics commented on pull reques

[GitHub] [phoenix] ramatronics commented on pull request #1280: PHOENIX-6523: Support for HRpc connection protocol through JDBC URL

2021-08-25 Thread GitBox
ramatronics commented on pull request #1280: URL: https://github.com/apache/phoenix/pull/1280#issuecomment-906109289 Jenkins test this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (PHOENIX-6523) Support for HBase Registry Implementations through Phoenix connection URL

2021-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404950#comment-17404950 ] ASF GitHub Bot commented on PHOENIX-6523: - stoty commented on pull request #128

[GitHub] [phoenix] stoty commented on pull request #1280: PHOENIX-6523: Support for HRpc connection protocol through JDBC URL

2021-08-25 Thread GitBox
stoty commented on pull request #1280: URL: https://github.com/apache/phoenix/pull/1280#issuecomment-906108752 @ramatronics the build artifacts are cleaned up aggressively in a fews days, as the jenkins hosts have little storage. You need to trigger a rebuild (or just run those checks lo

[jira] [Commented] (PHOENIX-6523) Support for HBase Registry Implementations through Phoenix connection URL

2021-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404943#comment-17404943 ] ASF GitHub Bot commented on PHOENIX-6523: - ramatronics commented on pull reques

[GitHub] [phoenix] ramatronics commented on pull request #1280: PHOENIX-6523: Support for HRpc connection protocol through JDBC URL

2021-08-25 Thread GitBox
ramatronics commented on pull request #1280: URL: https://github.com/apache/phoenix/pull/1280#issuecomment-906106591 @stoty the links to checkstyle/whitespaces are missing Also @joshelser I split and moved the parsing logic into classes -- This is an automated message from the Apac

[jira] [Commented] (PHOENIX-6486) Phoenix uses inconsistent chronologies internally, breaking pre-Gregorian date handling

2021-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404525#comment-17404525 ] ASF GitHub Bot commented on PHOENIX-6486: - stoty commented on pull request #129

[GitHub] [phoenix] stoty commented on pull request #1291: PHOENIX-6486 Phoenix uses inconsistent chronologies internally, break…

2021-08-25 Thread GitBox
stoty commented on pull request #1291: URL: https://github.com/apache/phoenix/pull/1291#issuecomment-905562115 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | D

[jira] [Commented] (PHOENIX-6486) Phoenix uses inconsistent chronologies internally, breaking pre-Gregorian date handling

2021-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404426#comment-17404426 ] ASF GitHub Bot commented on PHOENIX-6486: - stoty commented on pull request #128

[GitHub] [phoenix] stoty commented on pull request #1289: PHOENIX-6486 Phoenix uses inconsistent chronologies internally, break…

2021-08-25 Thread GitBox
stoty commented on pull request #1289: URL: https://github.com/apache/phoenix/pull/1289#issuecomment-905477232 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s | D

[jira] [Commented] (PHOENIX-5072) Cursor Query Loops Eternally with Local Index, Returns Fine Without It

2021-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404412#comment-17404412 ] ASF GitHub Bot commented on PHOENIX-5072: - stoty commented on pull request #128

[GitHub] [phoenix] stoty commented on pull request #1287: PHOENIX-5072 Cursor Query Loops Eternally with Local Index, Returns F…

2021-08-25 Thread GitBox
stoty commented on pull request #1287: URL: https://github.com/apache/phoenix/pull/1287#issuecomment-905463139 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m 2s | D

[jira] [Commented] (PHOENIX-6486) Phoenix uses inconsistent chronologies internally, breaking pre-Gregorian date handling

2021-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404367#comment-17404367 ] ASF GitHub Bot commented on PHOENIX-6486: - richardantal opened a new pull reque

[GitHub] [phoenix] richardantal opened a new pull request #1291: PHOENIX-6486 Phoenix uses inconsistent chronologies internally, break…

2021-08-25 Thread GitBox
richardantal opened a new pull request #1291: URL: https://github.com/apache/phoenix/pull/1291 …ing pre-Gregorian date handling -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Commented] (PHOENIX-6486) Phoenix uses inconsistent chronologies internally, breaking pre-Gregorian date handling

2021-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404323#comment-17404323 ] ASF GitHub Bot commented on PHOENIX-6486: - richardantal commented on pull reque

[GitHub] [phoenix] richardantal commented on pull request #1289: PHOENIX-6486 Phoenix uses inconsistent chronologies internally, break…

2021-08-25 Thread GitBox
richardantal commented on pull request #1289: URL: https://github.com/apache/phoenix/pull/1289#issuecomment-905352304 Thanks @dbwong and @stoty for the reviews. I squashed the commits to 1. Will create a PR for 4.x to see test run and merge them together. -- This is an automated messag

[jira] [Commented] (PHOENIX-5072) Cursor Query Loops Eternally with Local Index, Returns Fine Without It

2021-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404320#comment-17404320 ] ASF GitHub Bot commented on PHOENIX-5072: - richardantal commented on a change i

[GitHub] [phoenix] richardantal commented on a change in pull request #1287: PHOENIX-5072 Cursor Query Loops Eternally with Local Index, Returns F…

2021-08-25 Thread GitBox
richardantal commented on a change in pull request #1287: URL: https://github.com/apache/phoenix/pull/1287#discussion_r695587813 ## File path: phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java ## @@ -258,6 +259,16 @@ public QueryPlan optimize(QueryPlan

[jira] [Commented] (PHOENIX-5072) Cursor Query Loops Eternally with Local Index, Returns Fine Without It

2021-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404304#comment-17404304 ] ASF GitHub Bot commented on PHOENIX-5072: - richardantal commented on pull reque

[GitHub] [phoenix] richardantal commented on pull request #1287: PHOENIX-5072 Cursor Query Loops Eternally with Local Index, Returns F…

2021-08-25 Thread GitBox
richardantal commented on pull request #1287: URL: https://github.com/apache/phoenix/pull/1287#issuecomment-905329579 Thank you @ankitsinghal for the review. I've updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Commented] (PHOENIX-5072) Cursor Query Loops Eternally with Local Index, Returns Fine Without It

2021-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404303#comment-17404303 ] ASF GitHub Bot commented on PHOENIX-5072: - richardantal commented on a change i

[GitHub] [phoenix] richardantal commented on a change in pull request #1287: PHOENIX-5072 Cursor Query Loops Eternally with Local Index, Returns F…

2021-08-25 Thread GitBox
richardantal commented on a change in pull request #1287: URL: https://github.com/apache/phoenix/pull/1287#discussion_r695564457 ## File path: phoenix-core/src/main/java/org/apache/phoenix/compile/DeclareCursorCompiler.java ## @@ -48,7 +48,13 @@ public DeclareCursorCompil