[jira] [Commented] (PHOENIX-6555) Wait for permissions to sync in Permission tests

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456922#comment-17456922 ] ASF GitHub Bot commented on PHOENIX-6555: - stoty closed pull request #1336: URL

[jira] [Commented] (PHOENIX-6555) Wait for permissions to sync in Permission tests

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456923#comment-17456923 ] ASF GitHub Bot commented on PHOENIX-6555: - stoty commented on pull request #133

[GitHub] [phoenix] stoty commented on pull request #1336: PHOENIX-6555 Wait for permissions to sync in Permission tests

2021-12-09 Thread GitBox
stoty commented on pull request #1336: URL: https://github.com/apache/phoenix/pull/1336#issuecomment-990676858 This has already been committed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [phoenix] stoty closed pull request #1336: PHOENIX-6555 Wait for permissions to sync in Permission tests

2021-12-09 Thread GitBox
stoty closed pull request #1336: URL: https://github.com/apache/phoenix/pull/1336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (PHOENIX-5985) Consolidate custom EnvironmentEdge classes throughout tests

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456921#comment-17456921 ] ASF GitHub Bot commented on PHOENIX-5985: - stoty commented on pull request #135

[GitHub] [phoenix] stoty commented on pull request #1358: PHOENIX-5985 Consolidate custom EnvironmentEdge classes throughout tests

2021-12-09 Thread GitBox
stoty commented on pull request #1358: URL: https://github.com/apache/phoenix/pull/1358#issuecomment-990674685 This looks promising. Please make a note in the JIRA ticket that you are working on this, and base the patch on the master branch. -- This is an automated message from the Ap

[jira] [Commented] (PHOENIX-6596) Schema extraction double quotes expressions, resulting in un-executabe create statements

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456917#comment-17456917 ] ASF GitHub Bot commented on PHOENIX-6596: - stoty closed pull request #1354: URL

[GitHub] [phoenix] stoty closed pull request #1354: PHOENIX-6596 Schema extraction double quotes expressions, resulting i…

2021-12-09 Thread GitBox
stoty closed pull request #1354: URL: https://github.com/apache/phoenix/pull/1354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (PHOENIX-6596) Schema extraction double quotes expressions, resulting in un-executabe create statements

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456913#comment-17456913 ] ASF GitHub Bot commented on PHOENIX-6596: - stoty commented on a change in pull

[GitHub] [phoenix] stoty commented on a change in pull request #1364: PHOENIX-6596 Schema extraction double quotes expressions, resulting i…

2021-12-09 Thread GitBox
stoty commented on a change in pull request #1364: URL: https://github.com/apache/phoenix/pull/1364#discussion_r766389685 ## File path: phoenix-core/src/main/java/org/apache/phoenix/schema/tool/SchemaExtractionProcessor.java ## @@ -135,8 +135,8 @@ private String getIndexedColu

[jira] [Commented] (PHOENIX-6608) DISCUSS: Rethink MapReduce split generation

2021-12-09 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456903#comment-17456903 ] Istvan Toth commented on PHOENIX-6608: -- Yes, this job is for PetaByte table, and u

[jira] [Commented] (PHOENIX-6603) Create SYSTEM.TRANSFORM table

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456748#comment-17456748 ] ASF GitHub Bot commented on PHOENIX-6603: - gokceni commented on a change in pul

[GitHub] [phoenix] gokceni commented on a change in pull request #1363: PHOENIX-6603: Add SYSTEM.TRANSFORM table (#656)

2021-12-09 Thread GitBox
gokceni commented on a change in pull request #1363: URL: https://github.com/apache/phoenix/pull/1363#discussion_r766182273 ## File path: phoenix-core/src/main/java/org/apache/phoenix/schema/PTable.java ## @@ -247,6 +247,58 @@ public String toString() { }, } +

[jira] [Commented] (PHOENIX-6603) Create SYSTEM.TRANSFORM table

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456747#comment-17456747 ] ASF GitHub Bot commented on PHOENIX-6603: - gokceni commented on a change in pul

[jira] [Commented] (PHOENIX-6603) Create SYSTEM.TRANSFORM table

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456746#comment-17456746 ] ASF GitHub Bot commented on PHOENIX-6603: - gokceni commented on a change in pul

[GitHub] [phoenix] gokceni commented on a change in pull request #1363: PHOENIX-6603: Add SYSTEM.TRANSFORM table (#656)

2021-12-09 Thread GitBox
gokceni commented on a change in pull request #1363: URL: https://github.com/apache/phoenix/pull/1363#discussion_r766182098 ## File path: phoenix-core/src/main/java/org/apache/phoenix/schema/transform/SystemTransformRecord.java ## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apac

[GitHub] [phoenix] gokceni commented on a change in pull request #1363: PHOENIX-6603: Add SYSTEM.TRANSFORM table (#656)

2021-12-09 Thread GitBox
gokceni commented on a change in pull request #1363: URL: https://github.com/apache/phoenix/pull/1363#discussion_r766181700 ## File path: phoenix-core/src/main/java/org/apache/phoenix/schema/transform/Transform.java ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (PHOENIX-6603) Create SYSTEM.TRANSFORM table

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456744#comment-17456744 ] ASF GitHub Bot commented on PHOENIX-6603: - gokceni commented on a change in pul

[GitHub] [phoenix] gokceni commented on a change in pull request #1363: PHOENIX-6603: Add SYSTEM.TRANSFORM table (#656)

2021-12-09 Thread GitBox
gokceni commented on a change in pull request #1363: URL: https://github.com/apache/phoenix/pull/1363#discussion_r766180686 ## File path: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ## @@ -5220,12 +5260,8 @@ private boolean evaluateStmtProperties(M

[jira] [Commented] (PHOENIX-6603) Create SYSTEM.TRANSFORM table

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456582#comment-17456582 ] ASF GitHub Bot commented on PHOENIX-6603: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #1363: PHOENIX-6603: Add SYSTEM.TRANSFORM table (#656)

2021-12-09 Thread GitBox
virajjasani commented on a change in pull request #1363: URL: https://github.com/apache/phoenix/pull/1363#discussion_r765996900 ## File path: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ## @@ -4134,25 +4151,34 @@ public MutationState addColumn(PTab

[jira] [Commented] (PHOENIX-6603) Create SYSTEM.TRANSFORM table

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456493#comment-17456493 ] ASF GitHub Bot commented on PHOENIX-6603: - virajjasani commented on pull reques

[GitHub] [phoenix] virajjasani commented on pull request #1360: PHOENIX-6603: Add SYSTEM.TRANSFORM table (#656)

2021-12-09 Thread GitBox
virajjasani commented on pull request #1360: URL: https://github.com/apache/phoenix/pull/1360#issuecomment-989942645 Review in progress on #1363. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PHOENIX-6603) Create SYSTEM.TRANSFORM table

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456492#comment-17456492 ] ASF GitHub Bot commented on PHOENIX-6603: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #1363: PHOENIX-6603: Add SYSTEM.TRANSFORM table (#656)

2021-12-09 Thread GitBox
virajjasani commented on a change in pull request #1363: URL: https://github.com/apache/phoenix/pull/1363#discussion_r765825430 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/SingleCellIndexIT.java ## @@ -425,7 +425,7 @@ private Connection getTenantCon

[jira] [Commented] (PHOENIX-6603) Create SYSTEM.TRANSFORM table

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456458#comment-17456458 ] ASF GitHub Bot commented on PHOENIX-6603: - virajjasani edited a comment on pull

[jira] [Commented] (PHOENIX-6603) Create SYSTEM.TRANSFORM table

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456457#comment-17456457 ] ASF GitHub Bot commented on PHOENIX-6603: - virajjasani edited a comment on pull

[GitHub] [phoenix] virajjasani edited a comment on pull request #1363: PHOENIX-6603: Add SYSTEM.TRANSFORM table (#656)

2021-12-09 Thread GitBox
virajjasani edited a comment on pull request #1363: URL: https://github.com/apache/phoenix/pull/1363#issuecomment-989869378 Thanks @gokceni, I will start the review. In the meantime, these test failures seem relevant: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR

[GitHub] [phoenix] virajjasani edited a comment on pull request #1363: PHOENIX-6603: Add SYSTEM.TRANSFORM table (#656)

2021-12-09 Thread GitBox
virajjasani edited a comment on pull request #1363: URL: https://github.com/apache/phoenix/pull/1363#issuecomment-989869378 Thanks @gokceni, I will start the review. In the meantime, these test failures seem relevant: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR

[jira] [Commented] (PHOENIX-6603) Create SYSTEM.TRANSFORM table

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456455#comment-17456455 ] ASF GitHub Bot commented on PHOENIX-6603: - virajjasani commented on pull reques

[GitHub] [phoenix] virajjasani commented on pull request #1363: PHOENIX-6603: Add SYSTEM.TRANSFORM table (#656)

2021-12-09 Thread GitBox
virajjasani commented on pull request #1363: URL: https://github.com/apache/phoenix/pull/1363#issuecomment-989869378 Thanks @gokceni, I will start the review. In the meantime, these test failures seem relevant: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR

[jira] [Commented] (PHOENIX-6596) Schema extraction double quotes expressions, resulting in un-executabe create statements

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456425#comment-17456425 ] ASF GitHub Bot commented on PHOENIX-6596: - richardantal opened a new pull reque

[GitHub] [phoenix] richardantal opened a new pull request #1364: PHOENIX-6596 Schema extraction double quotes expressions, resulting i…

2021-12-09 Thread GitBox
richardantal opened a new pull request #1364: URL: https://github.com/apache/phoenix/pull/1364 …n un-executabe create statements Co-authored-by: Istvan Toth -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (PHOENIX-6582) Bump default HBase version to 2.3.7 and 2.4.8

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456398#comment-17456398 ] ASF GitHub Bot commented on PHOENIX-6582: - luocooong commented on pull request

[GitHub] [phoenix] luocooong commented on pull request #1350: PHOENIX-6582 Bump default HBase version to 2.3.7 and 2.4.8

2021-12-09 Thread GitBox
luocooong commented on pull request #1350: URL: https://github.com/apache/phoenix/pull/1350#issuecomment-989812164 @virajjasani That's how it was! Before that, I was curious about why we separated the different versions to commit. Thanks for your explanation. -- This is an automated mess

[jira] [Commented] (PHOENIX-6582) Bump default HBase version to 2.3.7 and 2.4.8

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456370#comment-17456370 ] ASF GitHub Bot commented on PHOENIX-6582: - virajjasani commented on pull reques

[GitHub] [phoenix] virajjasani commented on pull request #1350: PHOENIX-6582 Bump default HBase version to 2.3.7 and 2.4.8

2021-12-09 Thread GitBox
virajjasani commented on pull request #1350: URL: https://github.com/apache/phoenix/pull/1350#issuecomment-989786663 Thanks @luocooong. Or on the other hand, we can bump 2.3.7 on 2.3 release line as a separate PR and on that PR we will try to run test with 2.3.7 with a temporary commit to

[jira] [Commented] (PHOENIX-6582) Bump default HBase version to 2.3.7 and 2.4.8

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456369#comment-17456369 ] ASF GitHub Bot commented on PHOENIX-6582: - luocooong commented on pull request

[GitHub] [phoenix] luocooong commented on pull request #1350: PHOENIX-6582 Bump default HBase version to 2.3.7 and 2.4.8

2021-12-09 Thread GitBox
luocooong commented on pull request #1350: URL: https://github.com/apache/phoenix/pull/1350#issuecomment-989783332 @virajjasani Okay. I think I'll try to do that this weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Commented] (PHOENIX-6582) Bump default HBase version to 2.3.7 and 2.4.8

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456304#comment-17456304 ] ASF GitHub Bot commented on PHOENIX-6582: - virajjasani commented on pull reques

[GitHub] [phoenix] virajjasani commented on pull request #1350: PHOENIX-6582 Bump default HBase version to 2.3.7 and 2.4.8

2021-12-09 Thread GitBox
virajjasani commented on pull request #1350: URL: https://github.com/apache/phoenix/pull/1350#issuecomment-989717436 I have manually triggered the build for this PR. At least we will get test results for 2.4.8 version. @luocooong thanks for your work, if you are planning to include 2.3.7 a