[jira] [Commented] (PHOENIX-5865) column that has default value can not be correctly indexed

2022-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469690#comment-17469690 ] ASF GitHub Bot commented on PHOENIX-5865: - ss77892 commented on pull request #1

[GitHub] [phoenix] ss77892 commented on pull request #1321: PHOENIX-5865 column that has default value can not be correctly indexed

2022-01-05 Thread GitBox
ss77892 commented on pull request #1321: URL: https://github.com/apache/phoenix/pull/1321#issuecomment-1006311792 LGTM +1 Do we have test passed for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Commented] (PHOENIX-6620) TransformTool should fix the unverified rows and do validation

2022-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469673#comment-17469673 ] ASF GitHub Bot commented on PHOENIX-6620: - stoty commented on pull request #137

[GitHub] [phoenix] stoty commented on pull request #1371: PHOENIX-6620 TransformTool to fix unverified rows and do validation

2022-01-05 Thread GitBox
stoty commented on pull request #1371: URL: https://github.com/apache/phoenix/pull/1371#issuecomment-1006289268 Thank you @gokceni. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Commented] (PHOENIX-6620) TransformTool should fix the unverified rows and do validation

2022-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469558#comment-17469558 ] ASF GitHub Bot commented on PHOENIX-6620: - gokceni commented on a change in pul

[GitHub] [phoenix] gokceni commented on a change in pull request #1371: PHOENIX-6620 TransformTool to fix unverified rows and do validation

2022-01-05 Thread GitBox
gokceni commented on a change in pull request #1371: URL: https://github.com/apache/phoenix/pull/1371#discussion_r779164735 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/TransformToolIT.java ## @@ -413,59 +432,314 @@ public void testTransformMutationFailure

[jira] [Commented] (PHOENIX-6620) TransformTool should fix the unverified rows and do validation

2022-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469519#comment-17469519 ] ASF GitHub Bot commented on PHOENIX-6620: - stoty commented on pull request #137

[GitHub] [phoenix] stoty commented on pull request #1371: PHOENIX-6620 TransformTool to fix unverified rows and do validation

2022-01-05 Thread GitBox
stoty commented on pull request #1371: URL: https://github.com/apache/phoenix/pull/1371#issuecomment-1006025907 The indextool fix is PHOENIX-6611 . The fix for setting the verified flag for transactional tables in the normal path was also included in that commit. I am more worried

[jira] [Commented] (PHOENIX-6611) Fix IndexTool -snap option and set VERIFIED in PhoenixIndexImportDirectReducer

2022-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469504#comment-17469504 ] ASF GitHub Bot commented on PHOENIX-6611: - stoty closed pull request #1365: URL

[GitHub] [phoenix] stoty closed pull request #1365: PHOENIX-6611 Multiple IndexTool bugs

2022-01-05 Thread GitBox
stoty closed pull request #1365: URL: https://github.com/apache/phoenix/pull/1365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (PHOENIX-6620) TransformTool should fix the unverified rows and do validation

2022-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469469#comment-17469469 ] ASF GitHub Bot commented on PHOENIX-6620: - gokceni commented on pull request #1

[GitHub] [phoenix] gokceni commented on pull request #1371: PHOENIX-6620 TransformTool to fix unverified rows and do validation

2022-01-05 Thread GitBox
gokceni commented on pull request #1371: URL: https://github.com/apache/phoenix/pull/1371#issuecomment-1005966349 @stoty will do. Do you have a sample test that I can tweak for TransformTool? If the table is transactional and going trough transform and if an update is made, you want to see

[jira] [Commented] (PHOENIX-6611) Fix IndexTool -snap option and set VERIFIED in PhoenixIndexImportDirectReducer

2022-01-05 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469264#comment-17469264 ] Istvan Toth commented on PHOENIX-6611: -- Committed to all active branches. Thanks f

[jira] [Commented] (PHOENIX-6619) Secondary indexes on the columns with a default value works incorrectly

2022-01-05 Thread Jira
[ https://issues.apache.org/jira/browse/PHOENIX-6619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469129#comment-17469129 ] Richárd Antal commented on PHOENIX-6619: Hi I've tested the commands in the des