[jira] [Commented] (PHOENIX-6491) Phoenix High Availability

2022-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561091#comment-17561091 ] ASF GitHub Bot commented on PHOENIX-6491: - gjacoby126 commented on PR #1430: UR

[GitHub] [phoenix] gjacoby126 commented on pull request #1430: PHOENIX-6491 Phoenix High Availability

2022-06-30 Thread GitBox
gjacoby126 commented on PR #1430: URL: https://github.com/apache/phoenix/pull/1430#issuecomment-1171348391 I think if the build failures are addressed and we get a clean test run (not counting the refCount flappers I'm addressing on another JIRA) this should be good to go, unless someone el

[jira] [Commented] (PHOENIX-6491) Phoenix High Availability

2022-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561090#comment-17561090 ] ASF GitHub Bot commented on PHOENIX-6491: - gjacoby126 commented on PR #1430: UR

[GitHub] [phoenix] gjacoby126 commented on pull request #1430: PHOENIX-6491 Phoenix High Availability

2022-06-30 Thread GitBox
gjacoby126 commented on PR #1430: URL: https://github.com/apache/phoenix/pull/1430#issuecomment-1171347436 @dbwong - Thanks, I think you've addressed all my previous comments. However, it looks like the recent pom changes to address the implicit dependencies caused a lot of build errors wit

[jira] [Comment Edited] (PHOENIX-6741) The result of DivideExpression is wrong when two decimal number divide

2022-06-30 Thread chaijunjie (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560951#comment-17560951 ] chaijunjie edited comment on PHOENIX-6741 at 6/30/22 9:50 AM: ---

[jira] [Comment Edited] (PHOENIX-6741) The result of DivideExpression is wrong when two decimal number divide

2022-06-30 Thread chaijunjie (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560951#comment-17560951 ] chaijunjie edited comment on PHOENIX-6741 at 6/30/22 9:42 AM: ---

[jira] [Commented] (PHOENIX-6741) The result of DivideExpression is wrong when two decimal number divide

2022-06-30 Thread chaijunjie (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560951#comment-17560951 ] chaijunjie commented on PHOENIX-6741: - *I think the default min scale should not be

[jira] [Commented] (PHOENIX-6741) The result of DivideExpression is wrong when two decimal number divide

2022-06-30 Thread chaijunjie (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560906#comment-17560906 ] chaijunjie commented on PHOENIX-6741: - In the *DivideExpression* class,  int the fo

[jira] [Commented] (PHOENIX-6491) Phoenix High Availability

2022-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560894#comment-17560894 ] ASF GitHub Bot commented on PHOENIX-6491: - dbwong commented on code in PR #1430

[GitHub] [phoenix] dbwong commented on a diff in pull request #1430: PHOENIX-6491 Phoenix High Availability

2022-06-30 Thread GitBox
dbwong commented on code in PR #1430: URL: https://github.com/apache/phoenix/pull/1430#discussion_r910708348 ## phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixHAAdminTool.java: ## @@ -0,0 +1,634 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[jira] [Commented] (PHOENIX-6491) Phoenix High Availability

2022-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560891#comment-17560891 ] ASF GitHub Bot commented on PHOENIX-6491: - dbwong commented on code in PR #1430

[GitHub] [phoenix] dbwong commented on a diff in pull request #1430: PHOENIX-6491 Phoenix High Availability

2022-06-30 Thread GitBox
dbwong commented on code in PR #1430: URL: https://github.com/apache/phoenix/pull/1430#discussion_r910703294 ## phoenix-core/src/it/java/org/apache/phoenix/jdbc/ClusterRoleRecordGeneratorToolIT.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[jira] (PHOENIX-6741) The result of DivideExpression is wrong when two decimal number divide

2022-06-30 Thread chaijunjie (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6741 ] chaijunjie deleted comment on PHOENIX-6741: - was (Author: JIRAUSER286971): I think it should use the last real maxLength  in *DivideExpression* class, not get from the *getPrecision*  metho

[jira] [Commented] (PHOENIX-6491) Phoenix High Availability

2022-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560871#comment-17560871 ] ASF GitHub Bot commented on PHOENIX-6491: - dbwong commented on code in PR #1430

[jira] [Commented] (PHOENIX-6491) Phoenix High Availability

2022-06-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560868#comment-17560868 ] ASF GitHub Bot commented on PHOENIX-6491: - dbwong commented on code in PR #1430

[GitHub] [phoenix] dbwong commented on a diff in pull request #1430: PHOENIX-6491 Phoenix High Availability

2022-06-30 Thread GitBox
dbwong commented on code in PR #1430: URL: https://github.com/apache/phoenix/pull/1430#discussion_r910691144 ## phoenix-core/src/test/java/org/apache/phoenix/jdbc/ParallelPhoenixPreparedStatementTest.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [phoenix] dbwong commented on a diff in pull request #1430: PHOENIX-6491 Phoenix High Availability

2022-06-30 Thread GitBox
dbwong commented on code in PR #1430: URL: https://github.com/apache/phoenix/pull/1430#discussion_r910690607 ## phoenix-core/src/test/java/org/apache/phoenix/jdbc/FailoverPhoenixConnectionTest.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[jira] [Comment Edited] (PHOENIX-6741) The result of DivideExpression is wrong when two decimal number divide

2022-06-30 Thread chaijunjie (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560845#comment-17560845 ] chaijunjie edited comment on PHOENIX-6741 at 6/30/22 7:19 AM: ---

[jira] [Comment Edited] (PHOENIX-6741) The result of DivideExpression is wrong when two decimal number divide

2022-06-30 Thread chaijunjie (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560845#comment-17560845 ] chaijunjie edited comment on PHOENIX-6741 at 6/30/22 7:14 AM: ---

[jira] [Comment Edited] (PHOENIX-6741) The result of DivideExpression is wrong when two decimal number divide

2022-06-30 Thread chaijunjie (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560845#comment-17560845 ] chaijunjie edited comment on PHOENIX-6741 at 6/30/22 7:12 AM: ---