[jira] [Commented] (PHOENIX-6834) Use Pooled HConnection for Server Side Upsert Select

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640394#comment-17640394 ] ASF GitHub Bot commented on PHOENIX-6834: - stoty closed pull request #1532: PHO

[GitHub] [phoenix] stoty closed pull request #1532: PHOENIX-6834 Use Pooled HConnection for Server Side Upsert Select

2022-11-28 Thread GitBox
stoty closed pull request #1532: PHOENIX-6834 Use Pooled HConnection for Server Side Upsert Select URL: https://github.com/apache/phoenix/pull/1532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Commented] (PHOENIX-6761) Phoenix Client Side Metadata Caching Improvement

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640349#comment-17640349 ] ASF GitHub Bot commented on PHOENIX-6761: - kadirozde merged PR #1506: URL: http

[GitHub] [phoenix] kadirozde merged pull request #1506: PHOENIX-6761 : Phoenix Client Side Metadata Caching Improvement

2022-11-28 Thread GitBox
kadirozde merged PR #1506: URL: https://github.com/apache/phoenix/pull/1506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.a

[jira] [Commented] (PHOENIX-6761) Phoenix Client Side Metadata Caching Improvement

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640285#comment-17640285 ] ASF GitHub Bot commented on PHOENIX-6761: - kadirozde commented on code in PR #1

[GitHub] [phoenix] kadirozde commented on a diff in pull request #1506: PHOENIX-6761 : Phoenix Client Side Metadata Caching Improvement

2022-11-28 Thread GitBox
kadirozde commented on code in PR #1506: URL: https://github.com/apache/phoenix/pull/1506#discussion_r1034123403 ## phoenix-core/src/it/java/org/apache/phoenix/rpc/UpdateCacheIT.java: ## @@ -87,7 +87,7 @@ public void testUpdateCacheForTxnTable() throws Exception { S

[jira] [Commented] (PHOENIX-6752) Duplicate expression nodes in extract nodes during WHERE compilation phase leads to poor performance.

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640280#comment-17640280 ] ASF GitHub Bot commented on PHOENIX-6752: - jpisaac commented on PR #1529: URL:

[GitHub] [phoenix] jpisaac commented on pull request #1529: PHOENIX-6752 Duplicate expression nodes in extract nodes during WHERE compilation phase leads to poor performance

2022-11-28 Thread GitBox
jpisaac commented on PR #1529: URL: https://github.com/apache/phoenix/pull/1529#issuecomment-1329822097 Rebased to the latest and removed unused imports from BaseTest.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Commented] (PHOENIX-6752) Duplicate expression nodes in extract nodes during WHERE compilation phase leads to poor performance.

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640269#comment-17640269 ] ASF GitHub Bot commented on PHOENIX-6752: - jpisaac commented on PR #1508: URL:

[GitHub] [phoenix] jpisaac commented on pull request #1508: PHOENIX-6752 Duplicate expression nodes in extract nodes during WHERE compilation phase leads to poor performance

2022-11-28 Thread GitBox
jpisaac commented on PR #1508: URL: https://github.com/apache/phoenix/pull/1508#issuecomment-1329794896 @gjacoby126 Rebased to latest and removed unused imports -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Commented] (PHOENIX-6835) Flakey RowTimestampIT.testAutomaticallySettingRowTimestampWithDate

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640239#comment-17640239 ] ASF GitHub Bot commented on PHOENIX-6835: - stoty closed pull request #1533: PHO

[GitHub] [phoenix] stoty closed pull request #1533: PHOENIX-6835 Flakey RowTimestampIT.testAutomaticallySettingRowTimesta…

2022-11-28 Thread GitBox
stoty closed pull request #1533: PHOENIX-6835 Flakey RowTimestampIT.testAutomaticallySettingRowTimesta… URL: https://github.com/apache/phoenix/pull/1533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (PHOENIX-6752) Duplicate expression nodes in extract nodes during WHERE compilation phase leads to poor performance.

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640187#comment-17640187 ] ASF GitHub Bot commented on PHOENIX-6752: - jpisaac commented on PR #1529: URL:

[GitHub] [phoenix] jpisaac commented on pull request #1529: PHOENIX-6752 Duplicate expression nodes in extract nodes during WHERE compilation phase leads to poor performance

2022-11-28 Thread GitBox
jpisaac commented on PR #1529: URL: https://github.com/apache/phoenix/pull/1529#issuecomment-1329577240 > @jpisaac This PR seems to be duplicate of #1508 @mnpoonia This is the same PR for the 5.1 branch. @stoty @gjacoby126 can u approve this too, if there are no concerns? --

[jira] [Commented] (PHOENIX-6829) Add code coverage report aggregation with Jacoco

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640050#comment-17640050 ] ASF GitHub Bot commented on PHOENIX-6829: - horvathdora closed pull request #152

[jira] [Commented] (PHOENIX-6829) Add code coverage report aggregation with Jacoco

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640049#comment-17640049 ] ASF GitHub Bot commented on PHOENIX-6829: - horvathdora commented on PR #1524: U

[GitHub] [phoenix] horvathdora closed pull request #1524: PHOENIX-6829: Add code coverage report aggregation with Jacoco

2022-11-28 Thread GitBox
horvathdora closed pull request #1524: PHOENIX-6829: Add code coverage report aggregation with Jacoco URL: https://github.com/apache/phoenix/pull/1524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [phoenix] horvathdora commented on pull request #1524: PHOENIX-6829: Add code coverage report aggregation with Jacoco

2022-11-28 Thread GitBox
horvathdora commented on PR #1524: URL: https://github.com/apache/phoenix/pull/1524#issuecomment-1329150902 Change was merged to master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (PHOENIX-6840) Very flakey ParallelPhoenixConnectionFailureTest

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640046#comment-17640046 ] ASF GitHub Bot commented on PHOENIX-6840: - stoty commented on PR #1536: URL: ht

[GitHub] [phoenix] stoty commented on pull request #1536: PHOENIX-6840 Very flakey ParallelPhoenixConnectionFailureTest

2022-11-28 Thread GitBox
stoty commented on PR #1536: URL: https://github.com/apache/phoenix/pull/1536#issuecomment-1329146238 I have removed the minicluster, AFAICT we don't need it for this test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (PHOENIX-6829) Add code coverage report aggregation with Jacoco

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639985#comment-17639985 ] ASF GitHub Bot commented on PHOENIX-6829: - stoty commented on PR #1524: URL: ht

[GitHub] [phoenix] stoty commented on pull request #1524: PHOENIX-6829: Add code coverage report aggregation with Jacoco

2022-11-28 Thread GitBox
stoty commented on PR #1524: URL: https://github.com/apache/phoenix/pull/1524#issuecomment-1328948996 But then again, there is no actual change in this PR now. Something is not right, @horvathdora. -- This is an automated message from the Apache Git Service. To respond to the message, p

[jira] [Commented] (PHOENIX-6829) Add code coverage report aggregation with Jacoco

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639984#comment-17639984 ] ASF GitHub Bot commented on PHOENIX-6829: - stoty commented on PR #1524: URL: ht

[GitHub] [phoenix] stoty commented on pull request #1524: PHOENIX-6829: Add code coverage report aggregation with Jacoco

2022-11-28 Thread GitBox
stoty commented on PR #1524: URL: https://github.com/apache/phoenix/pull/1524#issuecomment-1328947377 The last run looks good, there is only a single unrelated IT failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Commented] (PHOENIX-6692) Add HBase 2.5 support

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639978#comment-17639978 ] ASF GitHub Bot commented on PHOENIX-6692: - stoty commented on PR #1535: URL: ht

[GitHub] [phoenix] stoty commented on pull request #1535: PHOENIX-6692 Add HBase 2.5 support

2022-11-28 Thread GitBox
stoty commented on PR #1535: URL: https://github.com/apache/phoenix/pull/1535#issuecomment-1328936221 The errors are because I have also updated the default HBase 2.4 version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (PHOENIX-6829) Add code coverage report aggregation with Jacoco

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639900#comment-17639900 ] ASF GitHub Bot commented on PHOENIX-6829: - stoty commented on PR #1524: URL: ht

[GitHub] [phoenix] stoty commented on pull request #1524: PHOENIX-6829: Add code coverage report aggregation with Jacoco

2022-11-28 Thread GitBox
stoty commented on PR #1524: URL: https://github.com/apache/phoenix/pull/1524#issuecomment-1328763230 restarted the CI job manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Comment Edited] (PHOENIX-6655) SYSTEM.SEQUENCE should have CACHE_DATA_ON_WRITE set to true

2022-11-28 Thread Gourab Taparia (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639886#comment-17639886 ] Gourab Taparia edited comment on PHOENIX-6655 at 11/28/22 8:58 AM: --

[jira] [Commented] (PHOENIX-6818) Remove dependency on the i18n-util library

2022-11-28 Thread Rajeshbabu Chintaguntla (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639888#comment-17639888 ] Rajeshbabu Chintaguntla commented on PHOENIX-6818: -- [~symat] could you

[jira] (PHOENIX-6818) Remove dependency on the i18n-util library

2022-11-28 Thread Rajeshbabu Chintaguntla (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6818 ] Rajeshbabu Chintaguntla deleted comment on PHOENIX-6818: -- was (Author: rajeshbabu): [~symat] could you please commit this to 5.1.3 branch as well? > Remove dependency on the i1

[jira] [Comment Edited] (PHOENIX-6655) SYSTEM.SEQUENCE should have CACHE_DATA_ON_WRITE set to true

2022-11-28 Thread Gourab Taparia (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637074#comment-17637074 ] Gourab Taparia edited comment on PHOENIX-6655 at 11/28/22 8:56 AM: --

[jira] [Commented] (PHOENIX-6655) SYSTEM.SEQUENCE should have CACHE_DATA_ON_WRITE set to true

2022-11-28 Thread Gourab Taparia (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639886#comment-17639886 ] Gourab Taparia commented on PHOENIX-6655: - [Please ignore the above comment - i

[jira] [Commented] (PHOENIX-6655) SYSTEM.SEQUENCE should have CACHE_DATA_ON_WRITE set to true

2022-11-28 Thread Gourab Taparia (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639884#comment-17639884 ] Gourab Taparia commented on PHOENIX-6655: - I was working on the changes to make

[jira] (PHOENIX-6655) SYSTEM.SEQUENCE should have CACHE_DATA_ON_WRITE set to true

2022-11-28 Thread Gourab Taparia (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6655 ] Gourab Taparia deleted comment on PHOENIX-6655: - was (Author: gourab.taparia): I was working on the changes to make sure WRITE_DATA_ON_CACHE is set both at new table creation level and

[jira] [Commented] (PHOENIX-6834) Use Pooled HConnection for Server Side Upsert Select

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639876#comment-17639876 ] ASF GitHub Bot commented on PHOENIX-6834: - stoty commented on PR #1532: URL: ht

[GitHub] [phoenix] stoty commented on pull request #1532: PHOENIX-6834 Use Pooled HConnection for Server Side Upsert Select

2022-11-28 Thread GitBox
stoty commented on PR #1532: URL: https://github.com/apache/phoenix/pull/1532#issuecomment-1328720818 Done some manual testing, and added the results to the JIRA: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Comment Edited] (PHOENIX-6834) Use Pooled HConnection for Server Side Upsert Select

2022-11-28 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639863#comment-17639863 ] Istvan Toth edited comment on PHOENIX-6834 at 11/28/22 8:38 AM: -

[jira] [Commented] (PHOENIX-6655) SYSTEM.SEQUENCE should have CACHE_DATA_ON_WRITE set to true

2022-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639869#comment-17639869 ] ASF GitHub Bot commented on PHOENIX-6655: - gourabtaparia opened a new pull requ

[GitHub] [phoenix] gourabtaparia opened a new pull request, #1534: PHOENIX-6655 - SYSTEM.SEQUENCE should have CACHE_DATA_ON_WRITE set to…

2022-11-28 Thread GitBox
gourabtaparia opened a new pull request, #1534: URL: https://github.com/apache/phoenix/pull/1534 … true NOTE : This is just a draft PR right now to facilitate the discussion going on in the jira. The changes in Integration test are WIP and other changes are done. Raising a draft PR a

[jira] [Commented] (PHOENIX-6834) Use Pooled HConnection for Server Side Upsert Select

2022-11-28 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639863#comment-17639863 ] Istvan Toth commented on PHOENIX-6834: -- I haven't added instrumentation, but I did

[jira] [Comment Edited] (PHOENIX-6834) Use Pooled HConnection for Server Side Upsert Select

2022-11-28 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639863#comment-17639863 ] Istvan Toth edited comment on PHOENIX-6834 at 11/28/22 8:21 AM: -