[jira] [Commented] (PHOENIX-6692) Add HBase 2.5 support

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641102#comment-17641102 ] ASF GitHub Bot commented on PHOENIX-6692: - stoty commented on PR #1535: URL: ht

[GitHub] [phoenix] stoty commented on pull request #1535: PHOENIX-6692 Add HBase 2.5 support

2022-11-29 Thread GitBox
stoty commented on PR #1535: URL: https://github.com/apache/phoenix/pull/1535#issuecomment-1331724718 No, in this branch we still support 2.1 and 2.2, which use an older zookeeper where the JARs are not split, @virajjasani. I checked that we're adding the zk-jute dependency in the 2.5 pro

[jira] [Commented] (PHOENIX-6692) Add HBase 2.5 support

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641060#comment-17641060 ] ASF GitHub Bot commented on PHOENIX-6692: - virajjasani commented on PR #1535: U

[GitHub] [phoenix] virajjasani commented on pull request #1535: PHOENIX-6692 Add HBase 2.5 support

2022-11-29 Thread GitBox
virajjasani commented on PR #1535: URL: https://github.com/apache/phoenix/pull/1535#issuecomment-1331634457 Shall we backport [this commit](https://github.com/apache/phoenix/commit/c389aef32be427fd2d0ff0bef114f01e6256a507) as well? Otherwise looks good overall. -- This is an automated me

[jira] [Commented] (PHOENIX-6823) calling Joda-based round() function on temporal PK field causes division by zero error

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640919#comment-17640919 ] ASF GitHub Bot commented on PHOENIX-6823: - stoty closed pull request #1530: PHO

[GitHub] [phoenix] stoty closed pull request #1530: PHOENIX-6823 calling Joda-based round() function on temporal PK field…

2022-11-29 Thread GitBox
stoty closed pull request #1530: PHOENIX-6823 calling Joda-based round() function on temporal PK field… URL: https://github.com/apache/phoenix/pull/1530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (PHOENIX-6823) calling Joda-based round() function on temporal PK field causes division by zero error

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640917#comment-17640917 ] ASF GitHub Bot commented on PHOENIX-6823: - stoty closed pull request #1537: PHO

[GitHub] [phoenix] stoty closed pull request #1537: PHOENIX-6823 calling Joda-based round() function on temporal PK field…

2022-11-29 Thread GitBox
stoty closed pull request #1537: PHOENIX-6823 calling Joda-based round() function on temporal PK field… URL: https://github.com/apache/phoenix/pull/1537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (PHOENIX-6832) Uncovered Global Secondary Indexes

2022-11-29 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640902#comment-17640902 ] Istvan Toth commented on PHOENIX-6832: -- In my experience, the PRs are eventually l

[jira] [Commented] (PHOENIX-6655) SYSTEM.SEQUENCE should have CACHE_DATA_ON_WRITE set to true

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640901#comment-17640901 ] ASF GitHub Bot commented on PHOENIX-6655: - virajjasani commented on PR #1534: U

[GitHub] [phoenix] virajjasani commented on pull request #1534: PHOENIX-6655 - SYSTEM.SEQUENCE should have CACHE_DATA_ON_WRITE set to…

2022-11-29 Thread GitBox
virajjasani commented on PR #1534: URL: https://github.com/apache/phoenix/pull/1534#issuecomment-1331162627 However, it would be good to assert on tests by using the ColumnFamilyDescriptor APIs to validate that cacheOnWrite is set. Moreover, I believe we should also set index and bloo

[jira] [Commented] (PHOENIX-6655) SYSTEM.SEQUENCE should have CACHE_DATA_ON_WRITE set to true

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640888#comment-17640888 ] ASF GitHub Bot commented on PHOENIX-6655: - virajjasani commented on PR #1534: U

[GitHub] [phoenix] virajjasani commented on pull request #1534: PHOENIX-6655 - SYSTEM.SEQUENCE should have CACHE_DATA_ON_WRITE set to…

2022-11-29 Thread GitBox
virajjasani commented on PR #1534: URL: https://github.com/apache/phoenix/pull/1534#issuecomment-1331114308 Since DDL SQL statement doesn't allow updating CF properties, we should use Admin API. Let's see if this can help: ``` diff --git a/phoenix-core/src/main/java/org/apa

[jira] [Commented] (PHOENIX-6832) Uncovered Global Secondary Indexes

2022-11-29 Thread Kadir Ozdemir (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640878#comment-17640878 ] Kadir Ozdemir commented on PHOENIX-6832: For some reason, the activities for th

[jira] [Commented] (PHOENIX-6823) calling Joda-based round() function on temporal PK field causes division by zero error

2022-11-29 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640724#comment-17640724 ] Istvan Toth commented on PHOENIX-6823: -- [https://github.com/apache/phoenix/pull/15

[jira] [Commented] (PHOENIX-6823) calling Joda-based round() function on temporal PK field causes division by zero error

2022-11-29 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640722#comment-17640722 ] Istvan Toth commented on PHOENIX-6823: -- Committed to master. Thanks for the review

[jira] [Commented] (PHOENIX-6823) calling Joda-based round() function on temporal PK field causes division by zero error

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640720#comment-17640720 ] ASF GitHub Bot commented on PHOENIX-6823: - stoty opened a new pull request, #15

[GitHub] [phoenix] stoty opened a new pull request, #1537: PHOENIX-6823 calling Joda-based round() function on temporal PK field…

2022-11-29 Thread GitBox
stoty opened a new pull request, #1537: URL: https://github.com/apache/phoenix/pull/1537 … causes division by zero error also fix other bugs in the key range pushdown logic for temporals -- This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Commented] (PHOENIX-6823) calling Joda-based round() function on temporal PK field causes division by zero error

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640718#comment-17640718 ] ASF GitHub Bot commented on PHOENIX-6823: - stoty commented on code in PR #1530:

[GitHub] [phoenix] stoty commented on a diff in pull request #1530: PHOENIX-6823 calling Joda-based round() function on temporal PK field…

2022-11-29 Thread GitBox
stoty commented on code in PR #1530: URL: https://github.com/apache/phoenix/pull/1530#discussion_r1034779244 ## phoenix-core/src/test/java/org/apache/phoenix/expression/RoundFloorCeilExpressionsTest.java: ## @@ -688,4 +720,1207 @@ public void testFloorDateExpressionForWeek() thr

[jira] [Commented] (PHOENIX-6823) calling Joda-based round() function on temporal PK field causes division by zero error

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640716#comment-17640716 ] ASF GitHub Bot commented on PHOENIX-6823: - stoty commented on code in PR #1530:

[GitHub] [phoenix] stoty commented on a diff in pull request #1530: PHOENIX-6823 calling Joda-based round() function on temporal PK field…

2022-11-29 Thread GitBox
stoty commented on code in PR #1530: URL: https://github.com/apache/phoenix/pull/1530#discussion_r1034771915 ## phoenix-core/src/test/java/org/apache/phoenix/expression/RoundFloorCeilExpressionsTest.java: ## @@ -688,4 +720,1207 @@ public void testFloorDateExpressionForWeek() thr

[jira] [Commented] (PHOENIX-6667) Spark3 connector requires that all columns are specified when writing

2022-11-29 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640694#comment-17640694 ] Istvan Toth commented on PHOENIX-6667: -- Replying to an offline question from Spark