[jira] [Comment Edited] (PHOENIX-6052) GLOBAL_MUTATION_COMMIT_TIME metric doesn't include the time spent in syscat rpc's

2022-12-11 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645915#comment-17645915 ] Rushabh Shah edited comment on PHOENIX-6052 at 12/12/22 5:09 AM:

[jira] [Commented] (PHOENIX-6052) GLOBAL_MUTATION_COMMIT_TIME metric doesn't include the time spent in syscat rpc's

2022-12-11 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645915#comment-17645915 ] Rushabh Shah commented on PHOENIX-6052: --- > Otherwise, I think we don't need _sysc

[jira] [Comment Edited] (PHOENIX-6052) GLOBAL_MUTATION_COMMIT_TIME metric doesn't include the time spent in syscat rpc's

2022-12-11 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645902#comment-17645902 ] Rushabh Shah edited comment on PHOENIX-6052 at 12/12/22 4:44 AM:

[jira] [Commented] (PHOENIX-6052) GLOBAL_MUTATION_COMMIT_TIME metric doesn't include the time spent in syscat rpc's

2022-12-11 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645902#comment-17645902 ] Rushabh Shah commented on PHOENIX-6052: --- Actually I found one bug in current GLOB

[jira] [Commented] (PHOENIX-5980) MUTATION_BATCH_FAILED_SIZE metric is incorrectly updated for failing delete mutations

2022-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645893#comment-17645893 ] ASF GitHub Bot commented on PHOENIX-5980: - shahrs87 commented on PR #1541: URL:

[GitHub] [phoenix] shahrs87 commented on pull request #1541: PHOENIX-5980 MUTATION_BATCH_FAILED_SIZE metric

2022-12-11 Thread GitBox
shahrs87 commented on PR #1541: URL: https://github.com/apache/phoenix/pull/1541#issuecomment-1345823653 One quick observation. The variable `uncommittedStatementIndexes` is used iff the table is transactional. See the code [here](https://github.com/apache/phoenix/blob/dfecc198e88a759105