Re: [PR] PHOENIX-7464 :- Performance Regression in Connection Initialization due to Configuration Handling in ConnInfo [phoenix]

2024-11-15 Thread via GitHub
stoty commented on PR #2027: URL: https://github.com/apache/phoenix/pull/2027#issuecomment-2480465251 I'll try to track this down on Monday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Commented] (PHOENIX-7464) Performance Regression in Connection Initialization due to Configuration Handling in ConnInfo

2024-11-15 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898841#comment-17898841 ] Istvan Toth commented on PHOENIX-7464: -- Thanks. We need to cache, as optimizing H

Re: [PR] PHOENIX-7434 Extend atomic support to single row delete with condition on non-pk columns [phoenix]

2024-11-15 Thread via GitHub
virajjasani commented on code in PR #2008: URL: https://github.com/apache/phoenix/pull/2008#discussion_r1844922826 ## phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java: ## @@ -708,6 +747,28 @@ private void annotateAndCommit(Un

Re: [PR] PHOENIX-7434 Extend atomic support to single row delete with condition on non-pk columns [phoenix]

2024-11-15 Thread via GitHub
virajjasani commented on PR #2008: URL: https://github.com/apache/phoenix/pull/2008#issuecomment-2480446049 > @virajjasani The changes look functionally correct but I didn't like how we are creating a specialized path in the code just for this use case. I would like it better if we can impl

Re: [PR] PHOENIX-7434 Extend atomic support to single row delete with condition on non-pk columns [phoenix]

2024-11-15 Thread via GitHub
virajjasani commented on code in PR #2008: URL: https://github.com/apache/phoenix/pull/2008#discussion_r1844918836 ## phoenix-core-client/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java: ## @@ -833,14 +847,24 @@ public MutationState execute() throws SQLException {

Re: [PR] PHOENIX-7458 : Create new SYSTEM tables for tracking CDC Stream metadata [phoenix]

2024-11-15 Thread via GitHub
virajjasani commented on PR #2025: URL: https://github.com/apache/phoenix/pull/2025#issuecomment-2480386528 You can use configs: ``` props.put(QueryServices.TASK_HANDLING_INITIAL_DELAY_MS_ATTRIB, Long.toString(Long.MAX_VALUE)); ``` -- This is an automated message from the Apa

Re: [PR] PHOENIX-7458 : Create new SYSTEM tables for tracking CDC Stream metadata [phoenix]

2024-11-15 Thread via GitHub
palashc commented on PR #2025: URL: https://github.com/apache/phoenix/pull/2025#issuecomment-2479834117 @virajjasani I am hitting some timing related issues in some tests on this PR due to TaskRegionObserver running in the background. The connection created by it causes some tests to flap,

[PR] PHOENIX-7464 :- Performance Regression in Connection Initialization due to Configuration Handling in ConnInfo [phoenix]

2024-11-15 Thread via GitHub
lokiore opened a new pull request, #2027: URL: https://github.com/apache/phoenix/pull/2027 Creating this PR for one of the solution of JIRA (Caching configuration at ConnectionInfo level as each CQSI can have different confs) -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (PHOENIX-6523) Support for HBase Registry Implementations through Phoenix connection URL

2024-11-15 Thread Lokesh Khurana (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898731#comment-17898731 ] Lokesh Khurana commented on PHOENIX-6523: - Created the new Jira :- PHOENIX-7464

[jira] [Commented] (PHOENIX-7464) Performance Regression in Connection Initialization due to Configuration Handling in ConnInfo

2024-11-15 Thread Lokesh Khurana (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898730#comment-17898730 ] Lokesh Khurana commented on PHOENIX-7464: - [~stoty] Created the new Jira for Pe

[jira] [Comment Edited] (PHOENIX-6523) Support for HBase Registry Implementations through Phoenix connection URL

2024-11-15 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898546#comment-17898546 ] Istvan Toth edited comment on PHOENIX-6523 at 11/15/24 9:55 AM: -

[jira] [Commented] (PHOENIX-6523) Support for HBase Registry Implementations through Phoenix connection URL

2024-11-15 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898546#comment-17898546 ] Istvan Toth commented on PHOENIX-6523: -- Can you open a new ticket to track that [~

[jira] [Commented] (PHOENIX-6523) Support for HBase Registry Implementations through Phoenix connection URL

2024-11-15 Thread Lokesh Khurana (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898507#comment-17898507 ] Lokesh Khurana commented on PHOENIX-6523: - [~stoty] we are pushing 5.2 client t