stoty commented on PR #2121:
URL: https://github.com/apache/phoenix/pull/2121#issuecomment-2811892634
Thanks @virajjasani , please include the addenum @meszinorbi .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
virajjasani commented on PR #2121:
URL: https://github.com/apache/phoenix/pull/2121#issuecomment-2811876208
This is also required:
https://github.com/apache/phoenix/commit/3497291928d629b047cf90851bc61d10c49df1aa
--
This is an automated message from the Apache Git Service.
To respond to t
virajjasani merged PR #2117:
URL: https://github.com/apache/phoenix/pull/2117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix
virajjasani merged PR #2116:
URL: https://github.com/apache/phoenix/pull/2116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix
virajjasani commented on PR #2116:
URL: https://github.com/apache/phoenix/pull/2116#issuecomment-2811866986
Let me merge this now, Sanjeet needs to do some initial account setup yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
stoty commented on PR #2116:
URL: https://github.com/apache/phoenix/pull/2116#issuecomment-2811747890
As a committer, you should be able to do this now independently,
@sanjeet006py .
The simplest way is to click squash and merge here on the PR:
--
This is an automated message from the
sanjeet006py commented on PR #2116:
URL: https://github.com/apache/phoenix/pull/2116#issuecomment-2811718973
@stoty can you please help with merging this and other backport PRs. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
stoty commented on PR #2116:
URL: https://github.com/apache/phoenix/pull/2116#issuecomment-2811688877
The test failures are obviously unrelated, please ignore them in this case
@sanjeet006py
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
kadirozde commented on code in PR #2115:
URL: https://github.com/apache/phoenix/pull/2115#discussion_r2047905374
##
phoenix-core-server/src/main/java/org/apache/phoenix/replication/log/LogFile.java:
##
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
kadirozde commented on code in PR #2115:
URL: https://github.com/apache/phoenix/pull/2115#discussion_r2047940220
##
phoenix-core-server/src/main/java/org/apache/phoenix/replication/log/LogFile.java:
##
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
[
https://issues.apache.org/jira/browse/PHOENIX-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945167#comment-17945167
]
Palash Chauhan commented on PHOENIX-7584:
-
[~vjasani] TTL for system tables is
NihalJain commented on code in PR #2024:
URL: https://github.com/apache/phoenix/pull/2024#discussion_r2047053654
##
phoenix-core-client/src/main/java/org/apache/phoenix/compile/DelegateMutationPlan.java:
##
@@ -20,71 +20,70 @@
import java.sql.ParameterMetaData;
import java.sql
NihalJain commented on code in PR #2024:
URL: https://github.com/apache/phoenix/pull/2024#discussion_r2047051616
##
phoenix-core-client/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java:
##
@@ -84,712 +87,689 @@
import org.slf4j.Logger;
import org.slf4j.LoggerF
NihalJain commented on code in PR #2024:
URL: https://github.com/apache/phoenix/pull/2024#discussion_r2047046966
##
phoenix-core-client/src/main/java/org/apache/phoenix/compile/BindManager.java:
##
@@ -20,61 +20,52 @@
import java.sql.ParameterMetaData;
import java.sql.SQLExcep
NihalJain commented on code in PR #2024:
URL: https://github.com/apache/phoenix/pull/2024#discussion_r2047043258
##
phoenix-core-client/src/main/java/org/apache/phoenix/cache/ServerCacheClient.java:
##
@@ -79,485 +78,497 @@
import org.slf4j.LoggerFactory;
/**
- *
* Client
meszinorbi opened a new pull request, #2121:
URL: https://github.com/apache/phoenix/pull/2121
…nfo (#2083)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
NihalJain commented on PR #2120:
URL: https://github.com/apache/phoenix/pull/2120#issuecomment-2809339421
> I think yetus simply has problems with very large patches @NihalJain .
Ok in that case we can't even have a success build for
https://github.com/apache/phoenix/pull/2024 since i
stoty commented on PR #2120:
URL: https://github.com/apache/phoenix/pull/2120#issuecomment-2809309160
I think yetus simply has problems with very large patches @NihalJain .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
stoty opened a new pull request, #191:
URL: https://github.com/apache/phoenix-omid/pull/191
…sitive dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
NihalJain commented on PR #2120:
URL: https://github.com/apache/phoenix/pull/2120#issuecomment-2809287356
> Some how 1st commit's patch doesnot apply to master. Need to check!
Code is on top of latest master, not sure why patch fails to apply with
error:
```
16:56:40 | Vote |
NihalJain commented on PR #2119:
URL: https://github.com/apache/phoenix/pull/2119#issuecomment-2809272003
> e should make sure that nothing gets committed without spotless between
the reformat and enabling spotless from CI.
Right we must time to merge both one after another.
--
Thi
NihalJain commented on PR #2120:
URL: https://github.com/apache/phoenix/pull/2120#issuecomment-2809269694
Some how 1st commit's patch doesnot apply to master. Need to check!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
stoty commented on PR #2119:
URL: https://github.com/apache/phoenix/pull/2119#issuecomment-2809267722
I agree, separate commits, but we should make sure that nothing gets
committed without spotless between the reformat and enabling spotless from CI.
--
This is an automated message from th
NihalJain commented on PR #2119:
URL: https://github.com/apache/phoenix/pull/2119#issuecomment-2809264384
> We should make sure to merge the reformat and this one together.
Yes makes sense. But should not be a problem even if we do separately.
Advantage being its cleaner and keeps man
[
https://issues.apache.org/jira/browse/PHOENIX-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945038#comment-17945038
]
ASF GitHub Bot commented on PHOENIX-7576:
-
stoty merged PR #177:
URL: https://g
NihalJain commented on PR #2119:
URL: https://github.com/apache/phoenix/pull/2119#issuecomment-2809261174
> Maybe make PR with both in a commit chain ?
Already done at https://github.com/apache/phoenix/pull/2120
--
This is an automated message from the Apache Git Service.
To respond
NihalJain opened a new pull request, #2120:
URL: https://github.com/apache/phoenix/pull/2120
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
stoty merged PR #177:
URL: https://github.com/apache/phoenix-queryserver/pull/177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@pho
stoty commented on PR #2119:
URL: https://github.com/apache/phoenix/pull/2119#issuecomment-2809257287
Maybe make PR with both in a commit chain ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stoty commented on PR #2119:
URL: https://github.com/apache/phoenix/pull/2119#issuecomment-2809256502
We should make sure to merge the reformat and this one together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
NihalJain commented on PR #2119:
URL: https://github.com/apache/phoenix/pull/2119#issuecomment-2809249231
We get spotless error as expected here. (Since we have not run `mvn
spotless:apply` as done in #2024 yet)
```
16:37:33 JIRA Plugin: no credentials provided to write a comment.
stoty commented on PR #2024:
URL: https://github.com/apache/phoenix/pull/2024#issuecomment-2809228120
Thank you.
I suggest asking for reviews again on the last email thread.
We want maximum visibility for this.
--
This is an automated message from the Apache Git Service.
To respo
NihalJain commented on PR #2024:
URL: https://github.com/apache/phoenix/pull/2024#issuecomment-2809229012
> I suggest asking for reviews again on the last email thread.
> We want maximum visibility for this
Sure let me ping once again.
--
This is an automated message from the Apa
stoty commented on PR #2119:
URL: https://github.com/apache/phoenix/pull/2119#issuecomment-2809224997
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
https://ci-hadoop.apache.org/job/Phoen
NihalJain commented on PR #2119:
URL: https://github.com/apache/phoenix/pull/2119#issuecomment-2809224196
Follows up https://github.com/apache/phoenix/pull/2023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
NihalJain opened a new pull request, #2119:
URL: https://github.com/apache/phoenix/pull/2119
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
NihalJain commented on PR #2024:
URL: https://github.com/apache/phoenix/pull/2024#issuecomment-2809211163
> Depends on #2023 Once that is merged we should rebase to master, re-run
spotless and update code here.
> TODO: Rebase before merge
Done.
CC: @stoty
NihalJain commented on PR #2023:
URL: https://github.com/apache/phoenix/pull/2023#issuecomment-2809187490
Thanks @stoty let me rebase and rerun spotless for
https://github.com/apache/phoenix/pull/2024
Also let me raise a PR for integration with build
--
This is an automated message fro
[
https://issues.apache.org/jira/browse/PHOENIX-7523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945017#comment-17945017
]
ASF GitHub Bot commented on PHOENIX-7523:
-
stoty merged PR #176:
URL: https://g
stoty merged PR #176:
URL: https://github.com/apache/phoenix-queryserver/pull/176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@pho
[
https://issues.apache.org/jira/browse/PHOENIX-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945015#comment-17945015
]
Istvan Toth commented on PHOENIX-7576:
--
Committed to queryserver.
Thanks for the r
stoty merged PR #2110:
URL: https://github.com/apache/phoenix/pull/2110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apach
[
https://issues.apache.org/jira/browse/PHOENIX-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945011#comment-17945011
]
ASF GitHub Bot commented on PHOENIX-7583:
-
stoty merged PR #178:
URL: https://g
stoty merged PR #178:
URL: https://github.com/apache/phoenix-queryserver/pull/178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@pho
[
https://issues.apache.org/jira/browse/PHOENIX-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945006#comment-17945006
]
Sanjeet Malhotra commented on PHOENIX-7580:
---
Thanks [~stoty] . PRs are ready
sanjeet006py commented on PR #2116:
URL: https://github.com/apache/phoenix/pull/2116#issuecomment-2808895954
Thanks @stoty. Fixed the commit message in all the 3 PRs for 5.3, 5.2 and
5.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
sanjeet006py closed pull request #2118: PHOENIX-7580: Data in last salt bucket
is not being scanned for range scan (addenudum: fix incompatibility for HBase
2.4 build)
URL: https://github.com/apache/phoenix/pull/2118
--
This is an automated message from the Apache Git Service.
To respond to
stoty commented on PR #2116:
URL: https://github.com/apache/phoenix/pull/2116#issuecomment-2808823309
The PR title is less relevant, @sanjeet006py , the git commit message is the
one I'd like to see changed
Something like :
PHOENIX-7580: Data in last salt bucket is not being scanned fo
stoty closed pull request #2023: PHOENIX-7441 Integrate the Spotless plugin and
update the code template
URL: https://github.com/apache/phoenix/pull/2023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stoty commented on PR #2023:
URL: https://github.com/apache/phoenix/pull/2023#issuecomment-2808816178
rebased and merged manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
sanjeet006py commented on PR #2116:
URL: https://github.com/apache/phoenix/pull/2116#issuecomment-2808789038
@stoty please review the PR title. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stoty commented on PR #2116:
URL: https://github.com/apache/phoenix/pull/2116#issuecomment-2808766625
We ususally use the
" (addendum: description)"
Format for the addendum commit messages, @sanjeet006py .
--
This is an automated message from the Apache Git Service.
To respo
sanjeet006py opened a new pull request, #2116:
URL: https://github.com/apache/phoenix/pull/2116
Fixing Scan API incompatibility with HBase 2.4 introduced in
https://github.com/apache/phoenix/pull/2109
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/PHOENIX-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944978#comment-17944978
]
Sanjeet Malhotra commented on PHOENIX-7580:
---
Sure, thanks
> Data in last sal
[
https://issues.apache.org/jira/browse/PHOENIX-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944977#comment-17944977
]
Istvan Toth commented on PHOENIX-7580:
--
Please also check with -Dhbase.profile=2.2
[
https://issues.apache.org/jira/browse/PHOENIX-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944975#comment-17944975
]
Sanjeet Malhotra commented on PHOENIX-7580:
---
Got it, thanks
> Data in last s
[
https://issues.apache.org/jira/browse/PHOENIX-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944971#comment-17944971
]
Istvan Toth commented on PHOENIX-7580:
--
Yes, the nightlies are run for each HBase
[
https://issues.apache.org/jira/browse/PHOENIX-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944973#comment-17944973
]
Istvan Toth commented on PHOENIX-7580:
--
Just run `mvn clean package -am -pl phoeni
[
https://issues.apache.org/jira/browse/PHOENIX-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944973#comment-17944973
]
Istvan Toth edited comment on PHOENIX-7580 at 4/16/25 7:36 AM:
--
[
https://issues.apache.org/jira/browse/PHOENIX-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944969#comment-17944969
]
Sanjeet Malhotra commented on PHOENIX-7580:
---
I think this is the build:
[htt
[
https://issues.apache.org/jira/browse/PHOENIX-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944968#comment-17944968
]
Sanjeet Malhotra commented on PHOENIX-7580:
---
[~stoty] can you please point me
[
https://issues.apache.org/jira/browse/PHOENIX-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944967#comment-17944967
]
Istvan Toth commented on PHOENIX-7580:
--
Thats right, we have no CI for non-default
[
https://issues.apache.org/jira/browse/PHOENIX-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944966#comment-17944966
]
Sanjeet Malhotra commented on PHOENIX-7580:
---
Thanks [~stoty] for bringing thi
63 matches
Mail list logo
