kadirozde opened a new pull request, #2127:
URL: https://github.com/apache/phoenix/pull/2127
…oop condition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
apurtell commented on code in PR #2115:
URL: https://github.com/apache/phoenix/pull/2115#discussion_r2056732045
##
phoenix-core-server/src/main/java/org/apache/phoenix/replication/log/LogFile.java:
##
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
jpisaac commented on code in PR #2048:
URL: https://github.com/apache/phoenix/pull/2048#discussion_r2056489758
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseRowKeyMatcherTestIT.java:
##
@@ -504,7 +507,42 @@ private Pair
getRowKeyMatchersFromView(PhoenixConnection c
stoty commented on PR #2024:
URL: https://github.com/apache/phoenix/pull/2024#issuecomment-2824235225
Since this is an automated reformat, a complete a review is hopeless.
It's more like:
- have all files been correctly reformatted ?
- Are there any generated files, which may conflic
lfrancke commented on PR #2024:
URL: https://github.com/apache/phoenix/pull/2024#issuecomment-2824145804
Thanks for this PR. I'm happy to spend some time reviewing it but I'm not
sure where/how to start. I did look at 20 or so files and they look good. It's
an honest question: Any suggestio
