[jira] [Commented] (PHOENIX-7253) Perf improvement for non-full scan queries on large table

2024-03-05 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823491#comment-17823491 ] Daniel Wong commented on PHOENIX-7253: -- I found some of my notes: Phoenix code do

[jira] [Commented] (PHOENIX-7253) Perf improvement for non-full scan queries on large table

2024-03-05 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823483#comment-17823483 ] Daniel Wong commented on PHOENIX-7253: -- Hi [~vjasani] I wanted to mention that you

[jira] [Commented] (PHOENIX-5833) Incorrect results with RVCs and AND operator

2023-08-01 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750043#comment-17750043 ] Daniel Wong commented on PHOENIX-5833: -- Thanks [~stoty] for doing this I'm not as

[jira] [Commented] (PHOENIX-6796) Pluggable query logger in Phoenix

2022-09-28 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610786#comment-17610786 ] Daniel Wong commented on PHOENIX-6796: -- For implementation thoughts I had were 3 c

[jira] [Commented] (PHOENIX-6491) Phoenix High Availability

2022-04-27 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529110#comment-17529110 ] Daniel Wong commented on PHOENIX-6491: -- Initial WIP feature commit from our intern

[jira] [Comment Edited] (PHOENIX-6669) RVC returns a wrong result

2022-03-16 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507901#comment-17507901 ] Daniel Wong edited comment on PHOENIX-6669 at 3/16/22, 11:28 PM:

[jira] [Commented] (PHOENIX-6669) RVC returns a wrong result

2022-03-16 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507901#comment-17507901 ] Daniel Wong commented on PHOENIX-6669: -- The rewrite is not correct still.  However

[jira] [Commented] (PHOENIX-6669) RVC returns a wrong result

2022-03-16 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507784#comment-17507784 ] Daniel Wong commented on PHOENIX-6669: -- [~yanxinyi] careful on your transformation

[jira] [Comment Edited] (PHOENIX-6659) RVC with AND clauses return incorrect result

2022-03-02 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500447#comment-17500447 ] Daniel Wong edited comment on PHOENIX-6659 at 3/3/22, 1:37 AM: --

[jira] [Comment Edited] (PHOENIX-6659) RVC with AND clauses return incorrect result

2022-03-02 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500447#comment-17500447 ] Daniel Wong edited comment on PHOENIX-6659 at 3/3/22, 1:34 AM: --

[jira] [Commented] (PHOENIX-6659) RVC with AND clauses return incorrect result

2022-03-02 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500447#comment-17500447 ] Daniel Wong commented on PHOENIX-6659: -- [~yanxinyi] good catch but one thing you n

[jira] [Commented] (PHOENIX-6604) Allow using indexes for wildcard topN queries on salted tables

2021-12-04 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453471#comment-17453471 ] Daniel Wong commented on PHOENIX-6604: -- Some of us are still watching Lars. > All

[jira] [Commented] (PHOENIX-6440) failed to write to multiple index table issue

2021-11-09 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441383#comment-17441383 ] Daniel Wong commented on PHOENIX-6440: -- [~giskender] I assume this was fixed in th

[jira] [Commented] (PHOENIX-6494) Delete data and insert immediately cause the data inconsistently

2021-11-09 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441382#comment-17441382 ] Daniel Wong commented on PHOENIX-6494: -- Not sure what was happening here.  Going t

[jira] [Commented] (PHOENIX-6549) Connection leak checks sometimes fail in tests

2021-11-09 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441379#comment-17441379 ] Daniel Wong commented on PHOENIX-6549: -- Certain paths use both, for specifically u

[jira] [Commented] (PHOENIX-6564) Add Phoenix Connection Failed Global Metric

2021-11-09 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441378#comment-17441378 ] Daniel Wong commented on PHOENIX-6564: -- Per discussion I've assigned to you [~vmek

[jira] [Commented] (PHOENIX-4922) CONVERT_TZ with date 0001-01-01

2021-11-09 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441376#comment-17441376 ] Daniel Wong commented on PHOENIX-4922: -- I was looking at some issues in beginner/n

[jira] [Commented] (PHOENIX-6571) Hang of connections after OutOfMemoryError

2021-10-08 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426343#comment-17426343 ] Daniel Wong commented on PHOENIX-6571: -- Please attach the logs to the issue direct

[jira] [Commented] (PHOENIX-5812) Automatically Close "Idle" Long Open Connections

2021-05-26 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352203#comment-17352203 ] Daniel Wong commented on PHOENIX-5812: -- Coming back to this a bit wondering if we

[jira] [Commented] (PHOENIX-6456) Support query logging for DDL and DML

2021-04-28 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17334923#comment-17334923 ] Daniel Wong commented on PHOENIX-6456: -- Can we consider grouping the logging param

[jira] [Commented] (PHOENIX-5872) Close Internal Phoenix Connections that were running during cancel

2021-02-01 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276511#comment-17276511 ] Daniel Wong commented on PHOENIX-5872: -- Thanks [~stoty] for the help.  Hopefully t

[jira] [Commented] (PHOENIX-5833) Incorrect results with RVCs and AND operator

2020-12-01 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241988#comment-17241988 ] Daniel Wong commented on PHOENIX-5833: -- Trying the old 4.x patch first. > Incorre

[jira] [Commented] (PHOENIX-5436) Histogram view of Global Client Metrics

2020-10-02 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206557#comment-17206557 ] Daniel Wong commented on PHOENIX-5436: -- Hey we should combine this with the work [

[jira] [Commented] (PHOENIX-5872) Close Internal Phoenix Connections that were running during cancel

2020-09-15 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196561#comment-17196561 ] Daniel Wong commented on PHOENIX-5872: -- [~gjacoby] there is a master patch attache

[jira] [Commented] (PHOENIX-5066) The TimeZone is incorrectly used during writing or reading data

2020-09-15 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196547#comment-17196547 ] Daniel Wong commented on PHOENIX-5066: -- Left some initial comments. > The TimeZon

[jira] [Commented] (PHOENIX-5384) org.apache.hadoop.hbase.client.NoServerForRegionException: No server address listed in hbase:meta for region SYSTEM.CATALOG,,1561983176360.29b36daaceebbfc1ff863e445e9

2020-09-15 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196460#comment-17196460 ] Daniel Wong commented on PHOENIX-5384: -- This looks to be an incorrect setup type o

[jira] [Commented] (PHOENIX-5462) Region Server crash with: Added a key not lexically larger than previous

2020-09-15 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196456#comment-17196456 ] Daniel Wong commented on PHOENIX-5462: -- Looks like a mutable index issue we saw an

[jira] [Commented] (PHOENIX-4906) Abnormal query result due to Phoenix plan error

2020-09-15 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196453#comment-17196453 ] Daniel Wong commented on PHOENIX-4906: -- Just going over the high priority issues a

[jira] [Commented] (PHOENIX-5833) Incorrect results with RVCs and AND operator

2020-09-15 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196452#comment-17196452 ] Daniel Wong commented on PHOENIX-5833: -- Patch applied cleanly to my 4.x trying to

[jira] [Commented] (PHOENIX-5287) Incorrect results for COUNT(1) on a table with GLOBAL INDEX

2020-09-15 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196445#comment-17196445 ] Daniel Wong commented on PHOENIX-5287: -- Repinging [~kozdemir] and [~gjacoby] as th

[jira] [Commented] (PHOENIX-5171) SkipScan incorrectly filters composite primary key which the key range contains all values

2020-09-09 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193084#comment-17193084 ] Daniel Wong commented on PHOENIX-5171: -- Main nit I had other than the comment you

[jira] [Commented] (PHOENIX-5171) SkipScan incorrectly filters composite primary key which the key range contains all values

2020-09-09 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192752#comment-17192752 ] Daniel Wong commented on PHOENIX-5171: -- [~larsh] took a look there are some minor

[jira] [Commented] (PHOENIX-6010) Create phoenix-thirdparty, and consume guava through it

2020-08-03 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170369#comment-17170369 ] Daniel Wong commented on PHOENIX-6010: -- Thanks for pinging me on one of the downst

[jira] [Commented] (PHOENIX-6022) RVC Offset does not handle trailing nulls properly

2020-07-29 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167474#comment-17167474 ] Daniel Wong commented on PHOENIX-6022: -- Latest patch for comment only nits.  Pleas

[jira] [Comment Edited] (PHOENIX-6045) Delete that should qualify for index path does not use index when multiple indexes are available.

2020-07-27 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165986#comment-17165986 ] Daniel Wong edited comment on PHOENIX-6045 at 7/27/20, 10:24 PM:

[jira] [Commented] (PHOENIX-6045) Delete that should qualify for index path does not use index when multiple indexes are available.

2020-07-27 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165986#comment-17165986 ] Daniel Wong commented on PHOENIX-6045: -- [~larsh] thats essentially what I was ment

[jira] [Commented] (PHOENIX-6045) Delete that should qualify for index path does not use index when multiple indexes are available.

2020-07-24 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164774#comment-17164774 ] Daniel Wong commented on PHOENIX-6045: -- [~larsh] I think [~kozdemir] has a bit mor

[jira] [Commented] (PHOENIX-6023) Wrong result when issuing query for an immutable table with multiple column families

2020-07-24 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164719#comment-17164719 ] Daniel Wong commented on PHOENIX-6023: -- Thanks [~stoty] for running verify manuall

[jira] [Commented] (PHOENIX-6023) Wrong result when issuing query for an immutable table with multiple column families

2020-07-23 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164049#comment-17164049 ] Daniel Wong commented on PHOENIX-6023: -- Just tracked this failure down myself.  Pl

[jira] [Commented] (PHOENIX-6045) Delete that should qualify for index path does not use index when multiple indexes are available.

2020-07-23 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163985#comment-17163985 ] Daniel Wong commented on PHOENIX-6045: -- FYI [~ChinmayKulkarni] [~kozdemir]  > Del

[jira] [Commented] (PHOENIX-6045) Delete that should qualify for index path does not use index when multiple indexes are available.

2020-07-23 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163984#comment-17163984 ] Daniel Wong commented on PHOENIX-6045: -- With indexes with disjoint set of primary

[jira] [Commented] (PHOENIX-6013) RVC Offset does not handle coerced literal nulls properly.

2020-07-16 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159404#comment-17159404 ] Daniel Wong commented on PHOENIX-6013: -- [~gjacoby] will do waiting on getting the

[jira] [Comment Edited] (PHOENIX-5990) Delete statements don't honor index hints

2020-07-09 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154999#comment-17154999 ] Daniel Wong edited comment on PHOENIX-5990 at 7/10/20, 4:24 AM: -

[jira] [Commented] (PHOENIX-5990) Delete statements don't honor index hints

2020-07-09 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155091#comment-17155091 ] Daniel Wong commented on PHOENIX-5990: -- I'm not sure, I'm guessing some of the rea

[jira] [Commented] (PHOENIX-5990) Delete statements don't honor index hints

2020-07-09 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154999#comment-17154999 ] Daniel Wong commented on PHOENIX-5990: -- I spent some time looking at this.  DELETE

[jira] [Commented] (PHOENIX-5924) RVC Offset does not handle variable length fields exclusive scan boundary correctly

2020-06-15 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136082#comment-17136082 ] Daniel Wong commented on PHOENIX-5924: -- Hoping OSS infra works this time reuploadi

[jira] [Commented] (PHOENIX-5833) Incorrect results with RVCs and AND operator

2020-05-06 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101174#comment-17101174 ] Daniel Wong commented on PHOENIX-5833: -- As discussed offline with [~yanxinyi] and

[jira] [Commented] (PHOENIX-5872) Close Internal Phoenix Connections that were running during cancel

2020-05-04 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099360#comment-17099360 ] Daniel Wong commented on PHOENIX-5872: -- Patch for master is posted now. > Close I

[jira] [Commented] (PHOENIX-5833) Incorrect results with LIKE operator

2020-04-21 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089124#comment-17089124 ] Daniel Wong commented on PHOENIX-5833: -- h3. Error Explanation So the error was in

[jira] [Comment Edited] (PHOENIX-5833) Incorrect results with LIKE operator

2020-04-21 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089124#comment-17089124 ] Daniel Wong edited comment on PHOENIX-5833 at 4/21/20, 11:01 PM:

[jira] [Comment Edited] (PHOENIX-5833) Incorrect results with LIKE operator

2020-04-20 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088003#comment-17088003 ] Daniel Wong edited comment on PHOENIX-5833 at 4/20/20, 6:44 PM: -

[jira] [Commented] (PHOENIX-5833) Incorrect results with LIKE operator

2020-04-20 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088003#comment-17088003 ] Daniel Wong commented on PHOENIX-5833: -- Does look like one of the likey many RVC r

[jira] [Commented] (PHOENIX-5769) Phoenix precommit Flapping HadoopQA Tests in master

2020-04-16 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084610#comment-17084610 ] Daniel Wong commented on PHOENIX-5769: -- Thanks for all your work [~stoty].  I'll s

[jira] [Comment Edited] (PHOENIX-5812) Automatically Close "Idle" Long Open Connections

2020-04-03 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074834#comment-17074834 ] Daniel Wong edited comment on PHOENIX-5812 at 4/3/20, 7:14 PM: --

[jira] [Commented] (PHOENIX-5812) Automatically Close "Idle" Long Open Connections

2020-04-03 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074834#comment-17074834 ] Daniel Wong commented on PHOENIX-5812: -- If we want to do idleness correctly the fi

[jira] [Commented] (PHOENIX-5812) Automatically Close "Idle" Long Open Connections

2020-04-01 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073165#comment-17073165 ] Daniel Wong commented on PHOENIX-5812: -- Thoughts [~liuml07]?  [~vmeka] I think th

[jira] [Commented] (PHOENIX-5812) Automatically Close "Idle" Long Open Connections

2020-04-01 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073019#comment-17073019 ] Daniel Wong commented on PHOENIX-5812: -- FYI [~jisaac] > Automatically Close "Idle

[jira] [Commented] (PHOENIX-5769) Phoenix precommit Flapping HadoopQA Tests in master

2020-03-31 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072371#comment-17072371 ] Daniel Wong commented on PHOENIX-5769: -- So I took a look at the patch but I didn't

[jira] [Commented] (PHOENIX-5812) Automatically Close "Idle" Long Open Connections

2020-03-31 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072317#comment-17072317 ] Daniel Wong commented on PHOENIX-5812: -- Couple more thoughts after doing some addi

[jira] [Commented] (PHOENIX-5812) Automatically Close "Idle" Long Open Connections

2020-03-31 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072202#comment-17072202 ] Daniel Wong commented on PHOENIX-5812: -- FYI [~liuml07] [~ckulkarni] > Automatical

[jira] [Commented] (PHOENIX-5796) Possible query optimization when projecting uncovered columns and querying on indexed columns

2020-03-25 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066944#comment-17066944 ] Daniel Wong commented on PHOENIX-5796: -- Its not necessarily optimal.  There are

[jira] [Commented] (PHOENIX-5796) Possible query optimization when projecting uncovered columns and querying on indexed columns

2020-03-24 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066109#comment-17066109 ] Daniel Wong commented on PHOENIX-5796: -- Its a skip scan join so in theory should j

[jira] [Commented] (PHOENIX-5796) Possible query optimization when projecting uncovered columns and querying on indexed columns

2020-03-24 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066088#comment-17066088 ] Daniel Wong commented on PHOENIX-5796: -- Today at least we can force a range scan t

[jira] [Comment Edited] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

2020-03-06 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053848#comment-17053848 ] Daniel Wong edited comment on PHOENIX-4845 at 3/7/20, 2:09 AM: --

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

2020-03-06 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053848#comment-17053848 ] Daniel Wong commented on PHOENIX-4845: -- I ran these tests locally on master/4.x-HB

[jira] [Commented] (PHOENIX-5711) Fix duplicate NOTICE error on phoenix-client shading

2020-02-11 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034981#comment-17034981 ] Daniel Wong commented on PHOENIX-5711: -- I think there may have been differences in

[jira] [Commented] (PHOENIX-5711) Fix duplicate NOTICE error on phoenix-client shading

2020-02-11 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034941#comment-17034941 ] Daniel Wong commented on PHOENIX-5711: -- Thanks for the patch.  I think I saw this

[jira] [Commented] (PHOENIX-5537) Phoenix-4701 made hard coupling between phoenix.log.level and getting request metrics.

2020-02-11 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034849#comment-17034849 ] Daniel Wong commented on PHOENIX-5537: -- [~yanxinyi] [~ckulkarni] can you help me g

[jira] [Commented] (PHOENIX-5537) Phoenix-4701 made hard coupling between phoenix.log.level and getting request metrics.

2020-02-11 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034848#comment-17034848 ] Daniel Wong commented on PHOENIX-5537: -- [~RichardAntal] In general the changes loo

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

2020-01-14 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015504#comment-17015504 ] Daniel Wong commented on PHOENIX-4845: -- Checked the tests that appears to be a env

[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-10 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013261#comment-17013261 ] Daniel Wong commented on PHOENIX-5628: -- I agree with the above please add composit

[jira] [Commented] (PHOENIX-5614) Remove unnecessary instances of ClassNotFoundException thrown stemming from various QueryUtil APIs

2019-12-17 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16998738#comment-16998738 ] Daniel Wong commented on PHOENIX-5614: -- Took a quick look, we were swallowing exce

[jira] [Commented] (PHOENIX-5510) LoggingPhoenixConnection on close does not log with unclosed statements/result sets

2019-10-07 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946074#comment-16946074 ] Daniel Wong commented on PHOENIX-5510: -- A new method for logging errors dealing wi

[jira] [Commented] (PHOENIX-5510) LoggingPhoenixConnection on close does not log with unclosed statements/result sets

2019-10-05 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945254#comment-16945254 ] Daniel Wong commented on PHOENIX-5510: -- So thinking about this a bit more this may

[jira] [Commented] (PHOENIX-5493) Remove unnecesary iteration in BaseResultIterator

2019-09-25 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937934#comment-16937934 ] Daniel Wong commented on PHOENIX-5493: -- +1 for this patch. Note I would like to g

[jira] [Commented] (PHOENIX-5085) Disentangle BaseResultIterators from the backing Guidepost Data structure

2019-09-16 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930788#comment-16930788 ] Daniel Wong commented on PHOENIX-5085: -- Marking as in progress as part of the Stat

[jira] [Commented] (PHOENIX-5444) Incorrect Phoenix Client Path in phoenix_utils.py

2019-08-13 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906801#comment-16906801 ] Daniel Wong commented on PHOENIX-5444: -- [https://github.com/apache/phoenix/pull/56

[jira] [Commented] (PHOENIX-5142) Protect against bad scan construction causing stack overflow

2019-07-31 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897558#comment-16897558 ] Daniel Wong commented on PHOENIX-5142: -- I'm not sure how to reproduce this in an I

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

2019-07-30 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896605#comment-16896605 ] Daniel Wong commented on PHOENIX-4845: -- I was implementing salt handling by not ha

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

2019-07-30 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896577#comment-16896577 ] Daniel Wong commented on PHOENIX-4845: -- How would we expect them to handle stuff l

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

2019-07-30 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896562#comment-16896562 ] Daniel Wong commented on PHOENIX-4845: -- I'll try, I could require INDEX or NO INDE

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

2019-07-30 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896412#comment-16896412 ] Daniel Wong commented on PHOENIX-4845: -- One additional concern I had based on my a

[jira] [Comment Edited] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

2019-07-29 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895666#comment-16895666 ] Daniel Wong edited comment on PHOENIX-4845 at 7/30/19 12:07 AM: -

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

2019-07-29 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895666#comment-16895666 ] Daniel Wong commented on PHOENIX-4845: -- Updating the high level description with t

[jira] [Commented] (PHOENIX-4846) WhereOptimizer.pushKeyExpressionsToScan() does not work correctly if the sort order of pk columns being filtered on changes

2019-07-22 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890386#comment-16890386 ] Daniel Wong commented on PHOENIX-4846: -- I'll see if I can look at this later this

[jira] [Commented] (PHOENIX-5290) HashJoinMoreIT is flapping

2019-07-17 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887480#comment-16887480 ] Daniel Wong commented on PHOENIX-5290: -- Thanks for commenting on this. I think we

[jira] [Commented] (PHOENIX-5290) HashJoinMoreIT is flapping

2019-07-15 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885544#comment-16885544 ] Daniel Wong commented on PHOENIX-5290: -- Quickly trying to catch up here.  There is

[jira] [Commented] (PHOENIX-4846) WhereOptimizer.pushKeyExpressionsToScan() does not work correctly if the sort order of pk columns being filtered on changes

2019-07-12 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884083#comment-16884083 ] Daniel Wong commented on PHOENIX-4846: -- I'll try to look at this next week. > Whe

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

2019-06-24 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871653#comment-16871653 ] Daniel Wong commented on PHOENIX-4845: -- Lars we discussed this a bit earlier in ou

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

2019-06-21 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16869972#comment-16869972 ] Daniel Wong commented on PHOENIX-4845: -- Initial mostly working outline of approach

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

2019-06-21 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16869950#comment-16869950 ] Daniel Wong commented on PHOENIX-4845: -- [~lhofhansl] I don't quite follow the perf

[jira] [Commented] (PHOENIX-5360) Cleanup anonymous inner classes in WhereOptimizer

2019-06-19 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868102#comment-16868102 ] Daniel Wong commented on PHOENIX-5360: -- One advantage of static inner classes (Say

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

2019-06-19 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868098#comment-16868098 ] Daniel Wong commented on PHOENIX-4845: -- [~Bin Shi] might have some thoughts on thi

[jira] [Comment Edited] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

2019-06-19 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868090#comment-16868090 ] Daniel Wong edited comment on PHOENIX-4845 at 6/19/19 11:15 PM: -

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

2019-06-19 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868090#comment-16868090 ] Daniel Wong commented on PHOENIX-4845: -- So I have began implementing this Jira and

[jira] [Commented] (PHOENIX-5318) Slots passed to SkipScan filter is incorrect for desc primary keys that are prefixes of each other

2019-06-17 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865818#comment-16865818 ] Daniel Wong commented on PHOENIX-5318: -- It is probably good to do since we are sti

[jira] [Commented] (PHOENIX-5231) Configurable Stats Cache

2019-05-30 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852244#comment-16852244 ] Daniel Wong commented on PHOENIX-5231: -- I'm okay with reverting as I personally do

[jira] [Commented] (PHOENIX-5231) Configurable Stats Cache

2019-05-28 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850207#comment-16850207 ] Daniel Wong commented on PHOENIX-5231: -- +1 to Vincent's fix. I'm guessing my vers

[jira] [Commented] (PHOENIX-5231) Configurable Stats Cache

2019-05-28 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850012#comment-16850012 ] Daniel Wong commented on PHOENIX-5231: -- I was trying to come up with a fix I think

[jira] [Commented] (PHOENIX-5231) Configurable Stats Cache

2019-05-25 Thread Daniel Wong (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848296#comment-16848296 ] Daniel Wong commented on PHOENIX-5231: -- That's strange I wonder what changed can y

  1   2   >