[GitHub] phoenix pull request #418: [PHOENIX-3623] Integrate Omid with Phoenix.

2018-12-18 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/418#discussion_r242673332 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/transaction/OmidTransactionProvider.java --- @@ -63,26 +83,106 @@ public

[GitHub] phoenix pull request #418: [PHOENIX-3623] Integrate Omid with Phoenix.

2018-12-18 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/418#discussion_r242673126 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/OmidTransactionalProcessor.java --- @@ -17,13 +17,16 @@ */ package

[GitHub] phoenix pull request #418: [PHOENIX-3623] Integrate Omid with Phoenix.

2018-12-17 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/418#discussion_r242226148 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/transaction/OmidTransactionContext.java --- @@ -18,89 +18,279 @@ package

[GitHub] phoenix pull request #418: [PHOENIX-3623] Integrate Omid with Phoenix.

2018-12-17 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/418#discussion_r242225928 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/transaction/OmidTransactionProvider.java --- @@ -104,10 +204,15 @@ public Provider

[GitHub] phoenix issue #305: Omid2

2018-11-19 Thread JamesRTaylor
Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/305 Test to see differences between omid2 and 4.x-HBase-1.3 ---

[GitHub] phoenix pull request #360: PHOENIX-4731 Make running transactional unit test...

2018-10-03 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/360#discussion_r222508350 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -184,9 +184,24 @@ public boolean apply(PTable index

[GitHub] phoenix pull request #360: PHOENIX-4731 Make running transactional unit test...

2018-10-03 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/360#discussion_r222506752 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/PhoenixTxIndexMutationGenerator.java --- @@ -313,7 +326,18 @@ public int compare(Cell

[GitHub] phoenix pull request #360: PHOENIX-4731 Make running transactional unit test...

2018-10-02 Thread JamesRTaylor
GitHub user JamesRTaylor opened a pull request: https://github.com/apache/phoenix/pull/360 PHOENIX-4731 Make running transactional unit tests for a given provider optional Enables turning transaction tests off for Tephra and/or Omid. Please review, @ohadshacham and/or @twdsilva

[GitHub] phoenix pull request #335: PHOENIX-4791 Propagate projected array elements t...

2018-08-30 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/335#discussion_r214209449 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ProjectArrayElemAfterHashJoinIT.java --- @@ -0,0 +1,179 @@ +/* + * Licensed to

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

2018-08-03 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r207673751 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ExplainTable.java --- @@ -204,15 +205,19 @@ private void appendPKColumnValue