[GitHub] [phoenix] kadirozde commented on a change in pull request #1021: PHOENIX-6267 View Index PK Fixed Width Field Truncation

2020-12-21 Thread GitBox
kadirozde commented on a change in pull request #1021: URL: https://github.com/apache/phoenix/pull/1021#discussion_r546862881 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ViewIndexIT.java ## @@ -458,6 +457,124 @@ public void testMultiTenantViewGlobal

[GitHub] [phoenix] kadirozde commented on a change in pull request #1021: PHOENIX-6267 View Index PK Fixed Width Field Truncation

2020-12-17 Thread GitBox
kadirozde commented on a change in pull request #1021: URL: https://github.com/apache/phoenix/pull/1021#discussion_r545503492 ## File path: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ## @@ -694,16 +696,22 @@ private Void addDataColInfo(final PTabl

[GitHub] [phoenix] kadirozde commented on a change in pull request #1021: PHOENIX-6267 View Index PK Fixed Width Field Truncation

2020-12-17 Thread GitBox
kadirozde commented on a change in pull request #1021: URL: https://github.com/apache/phoenix/pull/1021#discussion_r545503492 ## File path: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ## @@ -694,16 +696,22 @@ private Void addDataColInfo(final PTabl

[GitHub] [phoenix] kadirozde commented on a change in pull request #1021: PHOENIX-6267 View Index PK Fixed Width Field Truncation

2020-12-17 Thread GitBox
kadirozde commented on a change in pull request #1021: URL: https://github.com/apache/phoenix/pull/1021#discussion_r545496221 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ViewIndexIT.java ## @@ -458,6 +457,116 @@ public void testMultiTenantViewGlobal

[GitHub] [phoenix] kadirozde commented on a change in pull request #1021: PHOENIX-6267 View Index PK Fixed Width Field Truncation

2020-12-17 Thread GitBox
kadirozde commented on a change in pull request #1021: URL: https://github.com/apache/phoenix/pull/1021#discussion_r545411206 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ViewIndexIT.java ## @@ -458,6 +457,116 @@ public void testMultiTenantViewGlobal

[GitHub] [phoenix] kadirozde commented on a change in pull request #1021: PHOENIX-6267 View Index PK Fixed Width Field Truncation

2020-12-17 Thread GitBox
kadirozde commented on a change in pull request #1021: URL: https://github.com/apache/phoenix/pull/1021#discussion_r545359432 ## File path: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ## @@ -694,16 +696,22 @@ private Void addDataColInfo(final PTabl

[GitHub] [phoenix] kadirozde commented on a change in pull request #1021: PHOENIX-6267 View Index PK Fixed Width Field Truncation

2020-12-16 Thread GitBox
kadirozde commented on a change in pull request #1021: URL: https://github.com/apache/phoenix/pull/1021#discussion_r544789894 ## File path: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ## @@ -694,16 +695,20 @@ private Void addDataColInfo(final PTabl

[GitHub] [phoenix] kadirozde commented on a change in pull request #1021: PHOENIX-6267 View Index PK Fixed Width Field Truncation

2020-12-16 Thread GitBox
kadirozde commented on a change in pull request #1021: URL: https://github.com/apache/phoenix/pull/1021#discussion_r544767486 ## File path: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ## @@ -695,16 +696,19 @@ private Void addDataColInfo(final PTabl