[GitHub] [phoenix] stoty commented on pull request #890: PHOENIX-6151 Switch phoenix-client to shade-by-default mode

2020-09-30 Thread GitBox
stoty commented on pull request #890: URL: https://github.com/apache/phoenix/pull/890#issuecomment-701489628 Unfortunately we don't have tests to thoroughly check the shaded client. I have run a proprietary test suite on this that runs tests via sqlline, and it didn't throw up any errors

[GitHub] [phoenix] stoty commented on pull request #890: PHOENIX-6151 Switch phoenix-client to shade-by-default mode

2020-10-08 Thread GitBox
stoty commented on pull request #890: URL: https://github.com/apache/phoenix/pull/890#issuecomment-705562685 rebased and reverted to using as the package prefix property. (No changes in the shading) This is an automated mes

[GitHub] [phoenix] stoty commented on pull request #890: PHOENIX-6151 Switch phoenix-client to shade-by-default mode

2020-10-08 Thread GitBox
stoty commented on pull request #890: URL: https://github.com/apache/phoenix/pull/890#issuecomment-705685752 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s | Doc

[GitHub] [phoenix] stoty commented on pull request #890: PHOENIX-6151 Switch phoenix-client to shade-by-default mode

2020-10-08 Thread GitBox
stoty commented on pull request #890: URL: https://github.com/apache/phoenix/pull/890#issuecomment-705799025 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s | Doc

[GitHub] [phoenix] stoty commented on pull request #890: PHOENIX-6151 Switch phoenix-client to shade-by-default mode

2020-10-09 Thread GitBox
stoty commented on pull request #890: URL: https://github.com/apache/phoenix/pull/890#issuecomment-705562685 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use