lefebsy opened a new issue, #1116:
URL: https://github.com/apache/polaris/issues/1116
### Is your feature request related to a problem? Please describe.
Hello,
Polaris tests of deployment with eclipseLink and Postgres : I would like to
be able to declare the name of the schema
flyrain commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1980789090
##
polaris-core/src/main/java/org/apache/polaris/core/storage/s3compatible/S3CompatibleCredentialsStorageIntegration.java:
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Ap
eric-maynard commented on code in PR #1112:
URL: https://github.com/apache/polaris/pull/1112#discussion_r1980754888
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##
@@ -285,7 +285,11 @@ DropEntityResult dropEntityIfExists(
*
MonkeyCanCode commented on issue #1113:
URL: https://github.com/apache/polaris/issues/1113#issuecomment-2699980775
Sample PR for this request in case if we would want to support:
https://github.com/apache/polaris/pull/1115
Also, @sfc-gh-spatel2 can you check if that is what you are lo
MonkeyCanCode opened a new pull request, #1115:
URL: https://github.com/apache/polaris/pull/1115
This feature is requested from
https://github.com/apache/polaris/issues/1113. Currently we don't support pass
in proxy info.
Here is how this PR is being validated:
Terminal 1:
```
flyrain commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1980749790
##
polaris-core/src/main/java/org/apache/polaris/core/storage/s3compatible/S3CompatibleStorageConfigurationInfo.java:
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache
eric-maynard commented on code in PR #1112:
URL: https://github.com/apache/polaris/pull/1112#discussion_r1980754888
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##
@@ -285,7 +285,11 @@ DropEntityResult dropEntityIfExists(
*
eric-maynard commented on code in PR #1112:
URL: https://github.com/apache/polaris/pull/1112#discussion_r1980752638
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##
@@ -285,7 +285,11 @@ DropEntityResult dropEntityIfExists(
*
flyrain commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1980749790
##
polaris-core/src/main/java/org/apache/polaris/core/storage/s3compatible/S3CompatibleStorageConfigurationInfo.java:
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache
flyrain commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1980741611
##
spec/polaris-management-service.yml:
##
@@ -905,6 +907,51 @@ components:
required:
- roleArn
+S3CompatibleStorageConfigInfo:
+ type: object
flyrain commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1980741611
##
spec/polaris-management-service.yml:
##
@@ -905,6 +907,51 @@ components:
required:
- roleArn
+S3CompatibleStorageConfigInfo:
+ type: object
MonkeyCanCode commented on issue #1113:
URL: https://github.com/apache/polaris/issues/1113#issuecomment-2699933592
So currently the code doesn't allow proxy option to be pass in. I can add
this support if there is no concern? I am able to build a local POC setup for
this.
@flyrain @eric-
flyrain merged PR #1114:
URL: https://github.com/apache/polaris/pull/1114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
dennishuo commented on code in PR #1112:
URL: https://github.com/apache/polaris/pull/1112#discussion_r1980690670
##
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -1650,15 +1664,42 @@ public List
listGrantsForCatalogRole(String cat
eric-maynard commented on PR #:
URL: https://github.com/apache/polaris/pull/#issuecomment-2699763331
Good catch @dimas-b, did you mean something like
[this](https://github.com/apache/polaris/pull//commits/97d6201d0b804c5bfdbfb99f45e4f5e75173edcb)?
What I see now when runni
eric-maynard commented on PR #1068:
URL: https://github.com/apache/polaris/pull/1068#issuecomment-2699676879
Adjusted the PR back to having a config; fixed a test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dimas-b commented on code in PR #1112:
URL: https://github.com/apache/polaris/pull/1112#discussion_r1980613682
##
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java:
##
@@ -351,7 +
dimas-b commented on code in PR #:
URL: https://github.com/apache/polaris/pull/#discussion_r1980612811
##
quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##
@@ -239,6 +241,13 @@ public PolarisEntityManager polarisEntityManag
MonkeyCanCode commented on issue #1044:
URL: https://github.com/apache/polaris/issues/1044#issuecomment-2699644696
As https://github.com/apache/polaris/pull/1092 is merged, should we close
this? @flyrain
--
This is an automated message from the Apache Git Service.
To respond to the messa
MonkeyCanCode opened a new pull request, #1114:
URL: https://github.com/apache/polaris/pull/1114
From https://github.com/apache/polaris/pull/1092/files, we added
`eclipselink.session.customizer` and `eclipselink.transaction.join-existing` in
persistence.yaml, this PR added the same for helm
eric-maynard closed issue #464: [FEATURE REQUEST] Support refreshing of vended
credentials with latest iceberg version(1.7.0)
URL: https://github.com/apache/polaris/issues/464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
eric-maynard merged PR #1107:
URL: https://github.com/apache/polaris/pull/1107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
MonkeyCanCode commented on code in PR #1096:
URL: https://github.com/apache/polaris/pull/1096#discussion_r1980580308
##
.github/workflows/python-client.yml:
##
@@ -0,0 +1,85 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreem
singhpk234 commented on code in PR #1112:
URL: https://github.com/apache/polaris/pull/1112#discussion_r1980566440
##
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java:
##
@@ -351,
singhpk234 commented on code in PR #1112:
URL: https://github.com/apache/polaris/pull/1112#discussion_r1980566440
##
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java:
##
@@ -351,
pavibhai commented on PR #1068:
URL: https://github.com/apache/polaris/pull/1068#issuecomment-2699454085
@eric-maynard Thanks for the changes.
I have a question with respect to skipping the configuration of allowed
locations and prefix validation. Is this in scope for this PR and if s
dimas-b commented on PR #1109:
URL: https://github.com/apache/polaris/pull/1109#issuecomment-2699495860
I mean running a custom server outside the Quarkus Integration Test
framework. The server itself may very well be based on Quarkus, but running in
docker, for example.
--
This is an au
MonkeyCanCode commented on code in PR #1096:
URL: https://github.com/apache/polaris/pull/1096#discussion_r1980514241
##
.github/workflows/python-client.yml:
##
@@ -0,0 +1,84 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreem
MonkeyCanCode commented on code in PR #1102:
URL: https://github.com/apache/polaris/pull/1102#discussion_r1980513903
##
.github/workflows/python-license-check.yml:
##
@@ -0,0 +1,77 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
MonkeyCanCode commented on code in PR #1102:
URL: https://github.com/apache/polaris/pull/1102#discussion_r1980512172
##
.github/workflows/python-license-check.yml:
##
@@ -0,0 +1,77 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
collado-mike commented on code in PR #389:
URL: https://github.com/apache/polaris/pull/389#discussion_r1980500751
##
spec/polaris-management-service.yml:
##
@@ -905,6 +907,51 @@ components:
required:
- roleArn
+S3CompatibleStorageConfigInfo:
+ type: ob
sfc-gh-spatel2 opened a new issue, #1113:
URL: https://github.com/apache/polaris/issues/1113
### Is your feature request related to a problem? Please describe.
The Polaris CLi is obtaiend and executed as follows:
git clone https://github.com/apache/polaris.git
cd polaris
dimas-b opened a new pull request, #1112:
URL: https://github.com/apache/polaris/pull/1112
This is mainly needed for the upcoming NoSQL implementation.
Also, this change harmonizes the API parameters across all lookup methods.
This change induces changes in the MetaStore Manager
collado-mike commented on code in PR #1068:
URL: https://github.com/apache/polaris/pull/1068#discussion_r1980474794
##
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##
@@ -264,4 +264,11 @@ public static Builder builder() {
+ ST
dimas-b commented on PR #:
URL: https://github.com/apache/polaris/pull/#issuecomment-2699339319
My mistake, as CI shows the change is not innoccuous :sweat_smile:
```
UnsatisfiedResolutionException: Unsatisfied dependency for type
org.apache.polaris.service.auth.ActiveRole
lefebsy commented on PR #389:
URL: https://github.com/apache/polaris/pull/389#issuecomment-2699276840
Hello,
Last refactoring vending only STS.
- Support of **profile** to manage credentials used by catalog to
communicate with S3
- Refactor the **duplicated functions** used by '
sfc-gh-yzou commented on code in PR #808:
URL: https://github.com/apache/polaris/pull/808#discussion_r1980364343
##
spec/polaris-catalog-apis/policy-apis.yaml:
##
@@ -0,0 +1,508 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license ag
mmgaggle commented on PR #389:
URL: https://github.com/apache/polaris/pull/389#issuecomment-2699232825
Thank you for working on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
flyrain commented on PR #1109:
URL: https://github.com/apache/polaris/pull/1109#issuecomment-2699224595
> I mean any downstream build of Polaris. The `integration-tests` module
allows running the sever in a variety of ways, not assuming any particular
framework (like Quarkus Integration Tes
eric-maynard commented on issue #624:
URL: https://github.com/apache/polaris/issues/624#issuecomment-2699153512
See #1047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
flyrain commented on PR #1109:
URL: https://github.com/apache/polaris/pull/1109#issuecomment-2699175145
> The idea behind the `integration-tests` module is to allow reuse in
different environments (including downstream projects).
>
> `QuarkusSparkIT` executes the sharable test code in
dimas-b commented on PR #1109:
URL: https://github.com/apache/polaris/pull/1109#issuecomment-2699181185
I mean any downstream build of Polaris. The `integration-tests` module
allows running the sever in a variety of ways, not assuming any particular
framework (like Quarkus Integration Tests
andrew4699 commented on code in PR #922:
URL: https://github.com/apache/polaris/pull/922#discussion_r1979937870
##
service/common/src/main/java/org/apache/polaris/service/events/BeforeTableRefreshEvent.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation
renovate-bot opened a new pull request, #1110:
URL: https://github.com/apache/polaris/pull/1110
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.testcontainers:testcontainers-bom](https://java.te
DaniilRoman commented on code in PR #1096:
URL: https://github.com/apache/polaris/pull/1096#discussion_r1980225735
##
.github/workflows/python-client.yml:
##
@@ -0,0 +1,84 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreemen
DaniilRoman commented on code in PR #1096:
URL: https://github.com/apache/polaris/pull/1096#discussion_r1980201244
##
.github/workflows/python-client.yml:
##
@@ -0,0 +1,85 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreemen
dimas-b commented on PR #1109:
URL: https://github.com/apache/polaris/pull/1109#issuecomment-2698838447
> Can we add QuarkusSparkIT to the module integration-tests instead of
creating a new module?
The idea behind the `integration-tests` module is to allow reuse in
different environm
DaniilRoman commented on code in PR #1096:
URL: https://github.com/apache/polaris/pull/1096#discussion_r1980185891
##
.github/workflows/python-client.yml:
##
@@ -0,0 +1,85 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreemen
flyrain commented on PR #1109:
URL: https://github.com/apache/polaris/pull/1109#issuecomment-2698782531
Can we add `QuarkusSparkIT` to the module `integration-tests` instead of
creating a new module? `integration-tests` holds the class
`PolarisSparkIntegrationTest` which is the class `Quark
MonkeyCanCode commented on code in PR #1096:
URL: https://github.com/apache/polaris/pull/1096#discussion_r1980048276
##
.github/workflows/python-client.yml:
##
@@ -0,0 +1,85 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreem
eric-maynard commented on PR #1032:
URL: https://github.com/apache/polaris/pull/1032#issuecomment-2698419628
I'm a bit confused --
`quarkus/server/src/main/distribution/config/application.properties` doesn't
look like the same thing as $PWD to me. Does this really do what the
description s
dimas-b commented on PR #1032:
URL: https://github.com/apache/polaris/pull/1032#issuecomment-2698683635
From my POV, I'd prefer educating users on how to benefit from the multitude
of ways to configure Polaris (which come from the Quarkus infra). I believe it
will be an advantage to all use
annafil commented on issue #1038:
URL: https://github.com/apache/polaris/issues/1038#issuecomment-2698661270
+1 on redirecting, or whatever the PPMC thinks is best. The intent was this
domain would follow the project as part of any IP that needs to be handed over
to the foundation
--
Th
dimas-b commented on code in PR #1107:
URL: https://github.com/apache/polaris/pull/1107#discussion_r1980078519
##
service/common/src/main/java/org/apache/polaris/service/catalog/IcebergCatalogAdapter.java:
##
@@ -459,6 +461,25 @@ public Response listViews(
.build();
eric-maynard commented on code in PR #1107:
URL: https://github.com/apache/polaris/pull/1107#discussion_r1979928173
##
service/common/src/main/java/org/apache/polaris/service/catalog/IcebergCatalogAdapter.java:
##
@@ -459,6 +461,25 @@ public Response listViews(
.build()
MonkeyCanCode commented on code in PR #1096:
URL: https://github.com/apache/polaris/pull/1096#discussion_r1980048276
##
.github/workflows/python-client.yml:
##
@@ -0,0 +1,85 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreem
dimas-b commented on code in PR #1109:
URL: https://github.com/apache/polaris/pull/1109#discussion_r1980044504
##
quarkus/service/build.gradle.kts:
##
@@ -87,24 +87,19 @@ dependencies {
implementation(libs.jakarta.servlet.api)
- testFixturesApi(project(":polaris-tests"))
eric-maynard merged PR #1105:
URL: https://github.com/apache/polaris/pull/1105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
mansehajsingh commented on code in PR #1037:
URL: https://github.com/apache/polaris/pull/1037#discussion_r1980011967
##
service/common/src/main/java/org/apache/polaris/service/http/IfNoneMatch.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
mansehajsingh commented on code in PR #1037:
URL: https://github.com/apache/polaris/pull/1037#discussion_r1980005772
##
service/common/src/main/java/org/apache/polaris/service/http/IfNoneMatch.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
mansehajsingh commented on code in PR #1037:
URL: https://github.com/apache/polaris/pull/1037#discussion_r1980007522
##
service/common/src/main/java/org/apache/polaris/service/http/IfNoneMatch.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
mansehajsingh commented on code in PR #1037:
URL: https://github.com/apache/polaris/pull/1037#discussion_r1980005015
##
service/common/src/main/java/org/apache/polaris/service/http/IfNoneMatch.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
mansehajsingh commented on code in PR #1037:
URL: https://github.com/apache/polaris/pull/1037#discussion_r1980008405
##
service/common/src/main/java/org/apache/polaris/service/http/IfNoneMatch.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
mansehajsingh commented on PR #1037:
URL: https://github.com/apache/polaris/pull/1037#issuecomment-2698550870
I realized a bug I introduced with the parsing of the header, splitting by
whitespace or commas is incorrect because these are not necessarily always
delimiters as they can be conta
eric-maynard commented on PR #490:
URL: https://github.com/apache/polaris/pull/490#issuecomment-2698540191
Sharing a small benchmark
[here](https://gist.github.com/eric-maynard/babfbb85ce5c5773c1a298dc2fe51b02
) where I ran many small values through a cache using soft values -- but
reall
adutra opened a new pull request, #1109:
URL: https://github.com/apache/polaris/pull/1109
The Spark integration tests require specific versions of some dependencies
that conflicting more and more with the versions declared in the Quarkus BOM.
This PR simply isolates `QuarkusSparkIT` i
andrew4699 commented on code in PR #922:
URL: https://github.com/apache/polaris/pull/922#discussion_r1979937870
##
service/common/src/main/java/org/apache/polaris/service/events/BeforeTableRefreshEvent.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation
andrew4699 commented on code in PR #922:
URL: https://github.com/apache/polaris/pull/922#discussion_r1979936982
##
quarkus/defaults/src/main/resources/application.properties:
##
@@ -94,6 +94,8 @@ polaris.persistence.type=in-memory
polaris.file-io.type=default
+polaris.event
eric-maynard commented on code in PR #1107:
URL: https://github.com/apache/polaris/pull/1107#discussion_r1979928173
##
service/common/src/main/java/org/apache/polaris/service/catalog/IcebergCatalogAdapter.java:
##
@@ -459,6 +461,25 @@ public Response listViews(
.build()
eric-maynard commented on code in PR #1107:
URL: https://github.com/apache/polaris/pull/1107#discussion_r1979928173
##
service/common/src/main/java/org/apache/polaris/service/catalog/IcebergCatalogAdapter.java:
##
@@ -459,6 +461,25 @@ public Response listViews(
.build()
andrew4699 commented on code in PR #922:
URL: https://github.com/apache/polaris/pull/922#discussion_r1979926864
##
service/common/src/main/java/org/apache/polaris/service/events/PolarisEventListener.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
jbonofre commented on PR #1032:
URL: https://github.com/apache/polaris/pull/1032#issuecomment-2698437268
@eric-maynard I like your idea of having a `config.properties` in the root
folder that we copy at build time. That's actually even more a good way to
provide "user visible".
Let m
singhpk234 commented on code in PR #1107:
URL: https://github.com/apache/polaris/pull/1107#discussion_r1979920828
##
service/common/src/main/java/org/apache/polaris/service/catalog/IcebergCatalogAdapter.java:
##
@@ -459,6 +461,25 @@ public Response listViews(
.build();
eric-maynard commented on code in PR #1068:
URL: https://github.com/apache/polaris/pull/1068#discussion_r1979920870
##
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##
@@ -264,4 +264,11 @@ public static Builder builder() {
+ ST
singhpk234 commented on code in PR #1107:
URL: https://github.com/apache/polaris/pull/1107#discussion_r1979920828
##
service/common/src/main/java/org/apache/polaris/service/catalog/IcebergCatalogAdapter.java:
##
@@ -459,6 +461,25 @@ public Response listViews(
.build();
eric-maynard commented on issue #1072:
URL: https://github.com/apache/polaris/issues/1072#issuecomment-2698408486
A lack of test coverage is not a bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
eric-maynard commented on PR #1032:
URL: https://github.com/apache/polaris/pull/1032#issuecomment-2698422563
Could we just allow for a top level (i.e. `.../polaris/`) config file which
then gets copied to the requisite Quarkus location at build time?
--
This is an automated message from t
eric-maynard closed issue #967: [BUG] Manifest list files are not deleted
URL: https://github.com/apache/polaris/issues/967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
jbonofre commented on code in PR #1032:
URL: https://github.com/apache/polaris/pull/1032#discussion_r1979912286
##
quarkus/server/src/main/resources/META-INF/services/io.smallrye.config.ConfigSourceInterceptor:
##
@@ -1,20 +0,0 @@
-#
-# Licensed to the Apache Software Foundation
andrew4699 commented on code in PR #1105:
URL: https://github.com/apache/polaris/pull/1105#discussion_r1979910568
##
service/common/src/main/java/org/apache/polaris/service/exception/IcebergExceptionMapper.java:
##
@@ -132,19 +133,19 @@ public static boolean containsAnyAccessDen
jbonofre commented on PR #1032:
URL: https://github.com/apache/polaris/pull/1032#issuecomment-2698408911
@dennishuo @eric-maynard @adutra @dimas-b what do you think about this PR ?
Do you think it could be helpful for our users (to easily find and see all
classic configuration properties) ?
eric-maynard commented on code in PR #922:
URL: https://github.com/apache/polaris/pull/922#discussion_r1979898842
##
quarkus/defaults/src/main/resources/application.properties:
##
@@ -94,6 +94,8 @@ polaris.persistence.type=in-memory
polaris.file-io.type=default
+polaris.eve
eric-maynard commented on code in PR #922:
URL: https://github.com/apache/polaris/pull/922#discussion_r1979904299
##
service/common/src/main/java/org/apache/polaris/service/events/PolarisEventListener.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (
eric-maynard commented on code in PR #922:
URL: https://github.com/apache/polaris/pull/922#discussion_r1979901757
##
service/common/src/main/java/org/apache/polaris/service/events/BeforeTableRefreshEvent.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundatio
flyrain commented on PR #1106:
URL: https://github.com/apache/polaris/pull/1106#issuecomment-2698305690
> Overall it looks good to me. However, I would propose to wait a bit to see
the outcome of the persistence work performed by @dennishuo and @snazy .
Hi @jbonofre , this is a pure r
DaniilRoman commented on code in PR #1102:
URL: https://github.com/apache/polaris/pull/1102#discussion_r1978830776
##
.github/workflows/python-license-check.yml:
##
@@ -0,0 +1,77 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
jbonofre commented on PR #1106:
URL: https://github.com/apache/polaris/pull/1106#issuecomment-2697564776
Overall it looks good to me. However, I would propose to wait a bit to see
the outcome of the persistence work performed by @dennishuo and @snazy .
--
This is an automated message from
DaniilRoman commented on code in PR #1102:
URL: https://github.com/apache/polaris/pull/1102#discussion_r1979179726
##
.github/workflows/python-license-check.yml:
##
@@ -0,0 +1,77 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
DaniilRoman commented on code in PR #1102:
URL: https://github.com/apache/polaris/pull/1102#discussion_r1979179726
##
.github/workflows/python-license-check.yml:
##
@@ -0,0 +1,77 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
DaniilRoman commented on code in PR #1102:
URL: https://github.com/apache/polaris/pull/1102#discussion_r1978830776
##
.github/workflows/python-license-check.yml:
##
@@ -0,0 +1,77 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
90 matches
Mail list logo
