HonahX commented on code in PR #1277:
URL: https://github.com/apache/polaris/pull/1277#discussion_r2031808574
##
spec/generated/bundled-polaris-catalog-service.yaml:
##
@@ -4005,6 +4005,23 @@ components:
properties:
target:
$ref: '#/components/schemas/
flyrain commented on code in PR #1277:
URL: https://github.com/apache/polaris/pull/1277#discussion_r2031789410
##
spec/generated/bundled-polaris-catalog-service.yaml:
##
@@ -4005,6 +4005,23 @@ components:
properties:
target:
$ref: '#/components/schemas
eric-maynard commented on code in PR #1305:
URL: https://github.com/apache/polaris/pull/1305#discussion_r2036265816
##
polaris-core/src/main/java/org/apache/polaris/core/connection/AuthenticationParametersDpo.java:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foun
eric-maynard commented on PR #1347:
URL: https://github.com/apache/polaris/pull/1347#issuecomment-2791200713
@snazy can you take a look at this draft? My impression is that I should be
using the headers from `codeconfig` but I'd like to get your perspective on the
best approach here. Additi
eric-maynard commented on code in PR #1348:
URL: https://github.com/apache/polaris/pull/1348#discussion_r2036256675
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/dao/entity/BaseResult.java:
##
@@ -57,14 +70,90 @@ public String getExtraInformation() {
ret
dimas-b commented on code in PR #490:
URL: https://github.com/apache/polaris/pull/490#discussion_r2036223637
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityWeigher.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
flyrain merged PR #1277:
URL: https://github.com/apache/polaris/pull/1277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
eric-maynard commented on PR #1348:
URL: https://github.com/apache/polaris/pull/1348#issuecomment-2791073080
Unfortunately some Iceberg tests essentially assert that these methods don't
throw exceptions, e.g. `testDropMissingTable` does:
```
((AbstractBooleanAssert)Assertions.asse
eric-maynard commented on code in PR #1348:
URL: https://github.com/apache/polaris/pull/1348#discussion_r2036178512
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/dao/entity/BaseResult.java:
##
@@ -57,14 +64,67 @@ public String getExtraInformation() {
ret
eric-maynard opened a new pull request, #1347:
URL: https://github.com/apache/polaris/pull/1347
As noted in #755 and elsewhere, the generated types in `client/python` are
currently out of date. This introduces a script to regenerate them and a gradle
task to run that script. Once this is wo
dennishuo commented on issue #761:
URL: https://github.com/apache/polaris/issues/761#issuecomment-2791048460
> @dennishuo in the [EntityCache,
L170](https://github.com/apache/polaris/blob/main/polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityCache.java#L170),
there
dimas-b commented on PR #4:
URL: https://github.com/apache/polaris-tools/pull/4#issuecomment-2791023276
This looks like a major addition to Polaris tools. While it looks very
useful at first glance, I guess it would be helpful to have a `dev` ML summary
of how it works and how it is meant t
jbonofre commented on PR #4:
URL: https://github.com/apache/polaris-tools/pull/4#issuecomment-2790939341
@mansehajsingh sure thing ! I will !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
liamzwbao commented on issue #1273:
URL: https://github.com/apache/polaris/issues/1273#issuecomment-2785017112
Hi team, the test mentioned in this issue does not reflect Polaris's actual
behavior — **Polaris does not allow creating a view with a
`customMetadataLocation` outside of the `allo
flyrain merged PR #1314:
URL: https://github.com/apache/polaris/pull/1314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
mansehajsingh commented on PR #4:
URL: https://github.com/apache/polaris-tools/pull/4#issuecomment-2790891813
cc: @jbonofre It would be awesome to get your expertise on licensing and
dependencies for this project.
--
This is an automated message from the Apache Git Service.
To respond to
flyrain commented on code in PR #1292:
URL: https://github.com/apache/polaris/pull/1292#discussion_r2036077007
##
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationTest.java:
##
@@ -109,6 +109,7 @@
*
* {@link
FeatureC
snazy commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035420893
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityCache.java:
##
@@ -255,104 +150,74 @@ public void setCacheMode(EntityCacheMode cacheMode) {
dimas-b opened a new pull request, #1346:
URL: https://github.com/apache/polaris/pull/1346
…ctory
These messages appear to be logging low-level technical details about what
is going on in the factory and are not likely to be of interest to most users
on a daily basis.
-
mansehajsingh commented on code in PR #4:
URL: https://github.com/apache/polaris-tools/pull/4#discussion_r2035923654
##
polaris-synchronizer/api/src/main/java/org/apache/polaris/tools/sync/polaris/PolarisServiceFactory.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Sof
mansehajsingh commented on code in PR #4:
URL: https://github.com/apache/polaris-tools/pull/4#discussion_r2035922780
##
polaris-synchronizer/api/src/main/java/org/apache/polaris/tools/sync/polaris/PolarisSynchronizer.java:
##
@@ -0,0 +1,1135 @@
+/*
+ * Licensed to the Apache Sof
flyrain commented on code in PR #1292:
URL: https://github.com/apache/polaris/pull/1292#discussion_r2035935260
##
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationTest.java:
##
@@ -109,6 +109,7 @@
*
* {@link
FeatureC
flyrain commented on PR #1332:
URL: https://github.com/apache/polaris/pull/1332#issuecomment-2790564767
Thanks @gh-yzou for working on it. Thanks @eric-maynard for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
flyrain merged PR #1332:
URL: https://github.com/apache/polaris/pull/1332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
dennishuo commented on issue #761:
URL: https://github.com/apache/polaris/issues/761#issuecomment-2790481548
Ah sorry @pingtimeout I didn't see your comments last week, there are some
points I can help clarify:
> Because of (2), any stress test that concurrently call different methods
sfc-gh-rliu opened a new issue, #1345:
URL: https://github.com/apache/polaris/issues/1345
### Describe the bug
`@PreMatching` filters run on Vertx event loop threads. In some cases, we
make a blocking call to persistence in a filter, hence blocking the event loop
thread, which is str
travis-bowen commented on code in PR #4:
URL: https://github.com/apache/polaris-tools/pull/4#discussion_r2035770198
##
polaris-synchronizer/api/src/main/java/org/apache/polaris/tools/sync/polaris/catalog/MetadataWrapperTableOperations.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed t
jbonofre commented on code in PR #1292:
URL: https://github.com/apache/polaris/pull/1292#discussion_r2035755886
##
integration-tests/src/main/resources/META-INF/LICENSE:
##
@@ -0,0 +1,213 @@
+ Apache License
+ Version 2.0
dimas-b commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035479230
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityCache.java:
##
@@ -255,104 +150,74 @@ public void setCacheMode(EntityCacheMode cacheMode)
ben-manes commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035750733
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/IndexedCache.java:
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
jbonofre commented on code in PR #1292:
URL: https://github.com/apache/polaris/pull/1292#discussion_r2035707799
##
integration-tests/src/main/resources/META-INF/LICENSE:
##
@@ -0,0 +1,213 @@
+ Apache License
+ Version 2.0
pingtimeout commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035693488
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/IndexedCache.java:
##
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software Foundation (
snazy merged PR #1343:
URL: https://github.com/apache/polaris/pull/1343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
jbonofre commented on code in PR #1292:
URL: https://github.com/apache/polaris/pull/1292#discussion_r2035645897
##
licenses/LICENSE:
##
Review Comment:
Done
##
integration-tests/src/main/resources/META-INF/LICENSE:
##
@@ -0,0 +1,213 @@
+
pingtimeout commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035522063
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityCache.java:
##
@@ -255,104 +150,74 @@ public void setCacheMode(EntityCacheMode cacheMo
dimas-b commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035504254
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/IndexedCache.java:
##
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
adutra merged PR #1340:
URL: https://github.com/apache/polaris/pull/1340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apac
snazy merged PR #1344:
URL: https://github.com/apache/polaris/pull/1344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
dimas-b commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035498187
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/IndexedCache.java:
##
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
dimas-b commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035481454
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/IndexedCache.java:
##
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
dimas-b commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035475655
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityCache.java:
##
@@ -255,104 +150,74 @@ public void setCacheMode(EntityCacheMode cacheMode)
snazy commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035467084
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityCache.java:
##
@@ -18,185 +18,69 @@
*/
package org.apache.polaris.core.persistence.cache;
snazy commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035456985
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityCache.java:
##
@@ -365,50 +230,46 @@ && isNewer(existingCacheEntry, existingCacheEntryByName
snazy commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035455298
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityCache.java:
##
@@ -365,50 +230,46 @@ && isNewer(existingCacheEntry, existingCacheEntryByName
dimas-b commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035431024
##
jcstress-tests/src/jcstress/java/org/apache/polaris/core/persistence/cache/EntityCacheCoherenceTest.java:
##
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Softwar
snazy commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035443386
##
gradle/libs.versions.toml:
##
@@ -97,6 +97,7 @@ threeten-extra = { module = "org.threeten:threeten-extra",
version = "1.8.0" }
[plugins]
jandex = { id = "org.kord
dimas-b commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035428776
##
jcstress-tests/src/jcstress/java/org/apache/polaris/core/persistence/cache/FakeMetaStoreManager.java:
##
@@ -0,0 +1,309 @@
+/*
+ * Licensed to the Apache Software Fo
snazy commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035420893
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityCache.java:
##
@@ -255,104 +150,74 @@ public void setCacheMode(EntityCacheMode cacheMode) {
dimas-b commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035407381
##
bom/build.gradle.kts:
##
@@ -50,5 +50,6 @@ dependencies {
api(project(":polaris-quarkus-spark-tests"))
api(project(":polaris-tests"))
+api(project(":
snazy commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2035402942
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityCache.java:
##
@@ -255,104 +150,74 @@ public void setCacheMode(EntityCacheMode cacheMode) {
jbonofre commented on code in PR #1292:
URL: https://github.com/apache/polaris/pull/1292#discussion_r2035373054
##
licenses/LICENSE:
##
Review Comment:
OK, no problem. I will update accordingly.
--
This is an automated message from the Apache Git Service.
To respond to
pingtimeout commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2034662023
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/IndexedCache.java:
##
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (
renovate-bot opened a new pull request, #1343:
URL: https://github.com/apache/polaris/pull/1343
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.eclipse.persistence:eclipselink](http://www.eclips
akhilputhiry commented on issue #976:
URL: https://github.com/apache/polaris/issues/976#issuecomment-272993
May be duplicate of https://github.com/apache/polaris/issues/336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
akhilputhiry commented on issue #976:
URL: https://github.com/apache/polaris/issues/976#issuecomment-2788861663
I also support this proposal.
* Polaris should accept a well-known endpoint, client ID, and client secret
as input parameters.
* Polaris should be capable of communicatin
forking-renovate[bot] commented on PR #1340:
URL: https://github.com/apache/polaris/pull/1340#issuecomment-2788618914
### Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not
recognize the last commit author and assumes somebody else may have
snazy closed pull request #1228: Introduce
MetaStoreManagerFactory.initializeForService
URL: https://github.com/apache/polaris/pull/1228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
snazy commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2034632017
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/IndexedCache.java:
##
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
snazy commented on code in PR #1339:
URL: https://github.com/apache/polaris/pull/1339#discussion_r2034626667
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/IndexedCache.java:
##
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
snazy merged PR #1342:
URL: https://github.com/apache/polaris/pull/1342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy merged PR #1341:
URL: https://github.com/apache/polaris/pull/1341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
61 matches
Mail list logo
