singhpk234 commented on code in PR #1371:
URL: https://github.com/apache/polaris/pull/1371#discussion_r2053232273
##
quarkus/admin/src/test/java/org/apache/polaris/admintool/relational/jdbc/RelationalJdbcProfile.java:
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software F
singhpk234 commented on code in PR #1371:
URL: https://github.com/apache/polaris/pull/1371#discussion_r2053225580
##
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java:
##
@@ -171,6 +181,20 @@ pu
HonahX opened a new pull request, #1421:
URL: https://github.com/apache/polaris/pull/1421
This is a follow-up of https://github.com/apache/polaris/pull/1357, and in
parallel to https://github.com/apache/polaris/pull/1416. It adds privilege and
auth methods for `getApplicablePolicies`
github-actions[bot] commented on PR #1193:
URL: https://github.com/apache/polaris/pull/1193#issuecomment-2819871752
This PR is stale because it has been open 30 days with no activity. Remove
stale label or comment or this will be closed in 5 days.
--
This is an automated message from the
github-actions[bot] commented on PR #1203:
URL: https://github.com/apache/polaris/pull/1203#issuecomment-2819871698
This PR is stale because it has been open 30 days with no activity. Remove
stale label or comment or this will be closed in 5 days.
--
This is an automated message from the
github-actions[bot] commented on PR #1211:
URL: https://github.com/apache/polaris/pull/1211#issuecomment-2819871656
This PR is stale because it has been open 30 days with no activity. Remove
stale label or comment or this will be closed in 5 days.
--
This is an automated message from the
github-actions[bot] commented on PR #1215:
URL: https://github.com/apache/polaris/pull/1215#issuecomment-2819871610
This PR is stale because it has been open 30 days with no activity. Remove
stale label or comment or this will be closed in 5 days.
--
This is an automated message from the
HonahX opened a new pull request, #1420:
URL: https://github.com/apache/polaris/pull/1420
In https://github.com/apache/polaris/pull/1284 we've made the decision to
rename `snapshot-retention` to `snapshot-expiry`. This PR updates the
corresponding names in `polaris-core`
--
This is a
renovate-bot opened a new pull request, #1419:
URL: https://github.com/apache/polaris/pull/1419
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[com.adobe.testing:s3mock-testcontainers](https://redi
eric-maynard merged PR #1284:
URL: https://github.com/apache/polaris/pull/1284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
mansehajsingh commented on PR #8:
URL: https://github.com/apache/polaris-tools/pull/8#issuecomment-2819720562
cc: @collado-mike
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
mansehajsingh commented on code in PR #8:
URL: https://github.com/apache/polaris-tools/pull/8#discussion_r2053120016
##
polaris-synchronizer/api/src/main/java/org/apache/polaris/tools/sync/polaris/auth/AuthenticationSessionWrapper.java:
##
@@ -0,0 +1,109 @@
+package org.apache.p
mansehajsingh commented on code in PR #8:
URL: https://github.com/apache/polaris-tools/pull/8#discussion_r2053119700
##
polaris-synchronizer/api/src/main/java/org/apache/polaris/tools/sync/polaris/auth/AuthenticationSessionWrapper.java:
##
@@ -0,0 +1,109 @@
+package org.apache.p
mansehajsingh commented on PR #8:
URL: https://github.com/apache/polaris-tools/pull/8#issuecomment-2819719187
Hi @adutra!
> In Polaris, the token exchange grant type is meant primarily for token
refreshes. What is the use case here? Where is the subject token expected to
come from?
collado-mike commented on code in PR #1378:
URL: https://github.com/apache/polaris/pull/1378#discussion_r2053108958
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -1328,6 +1346,41 @@ public void doCommit(TableMetadata base,
dimas-b commented on code in PR #1401:
URL: https://github.com/apache/polaris/pull/1401#discussion_r2053048269
##
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkStore.java:
##
@@ -133,7 +133,7 @@ void d
scottteal opened a new issue, #1418:
URL: https://github.com/apache/polaris/issues/1418
### Describe the bug
When clicking on "Iceberg OpenAPI" in the 0.9.0 docs, the Swagger Editor
returns
```
Fetch error
response status is 404
https://raw.githubusercontent.com/apache/polar
singhpk234 commented on code in PR #1287:
URL: https://github.com/apache/polaris/pull/1287#discussion_r2053040671
##
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/QueryGenerator.java:
##
@@ -0,0 +1,267 @@
+/*
+ * Lic
singhpk234 commented on code in PR #1287:
URL: https://github.com/apache/polaris/pull/1287#discussion_r2053037617
##
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/ResultSetToObjectConverter.java:
##
@@ -0,0 +1,107 @@
gh-yzou commented on code in PR #1287:
URL: https://github.com/apache/polaris/pull/1287#discussion_r2052972975
##
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java:
##
@@ -0,0 +1,171 @@
+/*
+ *
eric-maynard opened a new pull request, #1417:
URL: https://github.com/apache/polaris/pull/1417
This PR reserves the prefix "polaris." for entity properties and provides a
configuration to change the list of reserved prefixes. This is helpful for a
few reasons:
1. It allows the syste
dimas-b merged PR #6:
URL: https://github.com/apache/polaris-tools/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
flyrain merged PR #1415:
URL: https://github.com/apache/polaris/pull/1415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
eric-maynard merged PR #1406:
URL: https://github.com/apache/polaris/pull/1406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
HonahX commented on code in PR #1416:
URL: https://github.com/apache/polaris/pull/1416#discussion_r2052833731
##
service/common/src/main/java/org/apache/polaris/service/catalog/policy/PolicyCatalogHandler.java:
##
@@ -141,4 +160,106 @@ private void authorizeBasicPolicyOperationO
adutra commented on PR #8:
URL: https://github.com/apache/polaris-tools/pull/8#issuecomment-2819162771
Hi @mansehajsingh I have a few questions about the features being introduced
here:
> Polaris supports exchanging an access token for another access token.
In Polaris, the tok
eric-maynard commented on code in PR #1416:
URL: https://github.com/apache/polaris/pull/1416#discussion_r2052785102
##
service/common/src/main/java/org/apache/polaris/service/catalog/policy/PolicyCatalogHandler.java:
##
@@ -141,4 +160,106 @@ private void authorizeBasicPolicyOper
adutra merged PR #1414:
URL: https://github.com/apache/polaris/pull/1414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apac
adutra closed issue #801: Credentials provided or generated when bootstrapping
should not be rotated
URL: https://github.com/apache/polaris/issues/801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
singhpk234 commented on PR #1391:
URL: https://github.com/apache/polaris/pull/1391#issuecomment-2819127610
@fivetran-ashokborra i was mostly coming from the fact that this was not
catched by a test case, so to be it future proof, if some one removes or adds
new permission this would fail.
eric-maynard commented on code in PR #1179:
URL: https://github.com/apache/polaris/pull/1179#discussion_r2052748255
##
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/task/BatchFileCleanupTaskHandlerTest.java:
##
@@ -239,40 +245,45 @@ public void testMetadataFil
eric-maynard commented on code in PR #1179:
URL: https://github.com/apache/polaris/pull/1179#discussion_r2052747457
##
service/common/src/main/java/org/apache/polaris/service/task/FileCleanupTaskHandler.java:
##
@@ -103,4 +120,53 @@ public CompletableFuture tryDelete(
pingtimeout commented on issue #1398:
URL: https://github.com/apache/polaris/issues/1398#issuecomment-2819064063
Thanks for the quick fix @adnanhemani !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
flyrain commented on code in PR #1287:
URL: https://github.com/apache/polaris/pull/1287#discussion_r2052738035
##
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##
@@ -0,0 +1,277 @@
+
eric-maynard closed issue #1398: Getting started docker compose file does not
work anymore
URL: https://github.com/apache/polaris/issues/1398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
eric-maynard merged PR #1407:
URL: https://github.com/apache/polaris/pull/1407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
HonahX commented on code in PR #1416:
URL: https://github.com/apache/polaris/pull/1416#discussion_r2052722416
##
service/common/src/main/java/org/apache/polaris/service/catalog/policy/PolicyCatalogUtils.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation
HonahX opened a new pull request, #1416:
URL: https://github.com/apache/polaris/pull/1416
This is a follow-up of https://github.com/apache/polaris/pull/1357. It adds
privilege and auth methods for `attachPolicy` and `detachPolicy`.
The tests are in `PolicyCatalogHandlerAuthzTest.j
eric-maynard commented on code in PR #1414:
URL: https://github.com/apache/polaris/pull/1414#discussion_r2052707742
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerFactory.java:
##
@@ -237,22 +236,11 @@ private PrincipalSecretsResult
flyrain commented on code in PR #1287:
URL: https://github.com/apache/polaris/pull/1287#discussion_r2052692703
##
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java:
##
@@ -0,0 +1,170 @@
+/*
+ *
pingtimeout opened a new pull request, #9:
URL: https://github.com/apache/polaris-tools/pull/9
_This PR should only be reviewed after #6 is merged as it includes all the
changes from that PR._
This PR contains the following changes:
* e3790a2: Cleanup of README so that it is mo
pingtimeout commented on code in PR #8:
URL: https://github.com/apache/polaris-tools/pull/8#discussion_r2052653845
##
polaris-synchronizer/api/src/main/java/org/apache/polaris/tools/sync/polaris/auth/AuthenticationSessionWrapper.java:
##
@@ -0,0 +1,109 @@
+package org.apache.pol
flyrain commented on PR #1403:
URL: https://github.com/apache/polaris/pull/1403#issuecomment-2818910886
Thanks @HonahX for the change. Thanks @adutra @eric-maynard @singhpk234 for
the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
flyrain merged PR #1403:
URL: https://github.com/apache/polaris/pull/1403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
HonahX commented on PR #1403:
URL: https://github.com/apache/polaris/pull/1403#issuecomment-2818898822
@flyrain Thanks for the suggestion! Yes, that will be helpful for the future
feature we want to support (e.g. `getTablesPerPolicyType`). How about we make
the change in a separate PR and l
HonahX opened a new pull request, #1415:
URL: https://github.com/apache/polaris/pull/1415
The spec has been updated (https://github.com/apache/polaris/pull/1277) that
now `GetApplicablePolicies` shall return a list of `ApplicablePolicies`, which
include the policy's parent namespace and
pingtimeout commented on PR #6:
URL: https://github.com/apache/polaris-tools/pull/6#issuecomment-2818884389
Just a heads up, I believe all comments/questions are addressed. But as I
am not a committer, I need need help from a maintainer to merge this PR.
--
This is an automated message f
pingtimeout commented on code in PR #6:
URL: https://github.com/apache/polaris-tools/pull/6#discussion_r2052632862
##
benchmarks/src/gatling/scala/org/apache/polaris/benchmarks/simulations/ReadTreeDataset.scala:
##
@@ -61,13 +64,31 @@ class ReadTreeDataset extends Simulation {
harksin commented on issue #138:
URL: https://github.com/apache/polaris/issues/138#issuecomment-2818590638
is anyone working on this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
adutra commented on code in PR #1414:
URL: https://github.com/apache/polaris/pull/1414#discussion_r2052452194
##
service/common/src/main/java/org/apache/polaris/service/persistence/InMemoryPolarisMetaStoreManagerFactory.java:
##
@@ -89,12 +89,12 @@ public synchronized Supplier
adutra commented on code in PR #1395:
URL: https://github.com/apache/polaris/pull/1395#discussion_r2052376090
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##
@@ -528,14 +543,177 @@ public Optional loadTableIfStale(
adutra commented on code in PR #1405:
URL: https://github.com/apache/polaris/pull/1405#discussion_r2052324206
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##
@@ -580,7 +586,18 @@ public Optional loadTableIfStale(
}
adutra commented on code in PR #1411:
URL: https://github.com/apache/polaris/pull/1411#discussion_r2052266494
##
quarkus/server/distribution/LICENSE:
##
@@ -2167,6 +2173,12 @@ License (from POM): Apache License 2.0 -
https://www.apache.org/licenses/LICENSE
-
adutra commented on code in PR #1411:
URL: https://github.com/apache/polaris/pull/1411#discussion_r2052263187
##
site/content/in-dev/unreleased/metastores.md:
##
@@ -24,12 +24,11 @@ weight: 700
This page documents important configurations for connecting to a production
datab
jbonofre commented on PR #1411:
URL: https://github.com/apache/polaris/pull/1411#issuecomment-2818026902
> Thanks @jbonofre for working on this. There are a few other places which
also have the
>
> ` -PeclipseLinkDeps=org.postgresql:postgresql:42.7.4`, like the admin
tool page and
55 matches
Mail list logo
