Re: [PR] Auto-bootstrap: add verbose logging [polaris]

2025-05-05 Thread via GitHub
snazy merged PR #1376: URL: https://github.com/apache/polaris/pull/1376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apach

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
dennishuo commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074716349 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
dennishuo commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074711395 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
dennishuo commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074711395 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4

Re: [PR] Implement federation to HadoopCatalog [polaris]

2025-05-05 Thread via GitHub
dennishuo commented on code in PR #1466: URL: https://github.com/apache/polaris/pull/1466#discussion_r2074686001 ## polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java: ## @@ -234,4 +235,11 @@ public static void enforceFeatureEnabledOrThrow(

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-05 Thread via GitHub
singhpk234 commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2074461532 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -173,23 +190,82 @@ p

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-05 Thread via GitHub
singhpk234 commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2074458805 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/RelationalJdbcConfiguration.java: ## @@ -0,0 +1,34 @@

Re: [PR] Exclude generated files in client/python/polaris [polaris]

2025-05-05 Thread via GitHub
github-actions[bot] closed pull request #1248: Exclude generated files in client/python/polaris URL: https://github.com/apache/polaris/pull/1248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Add jcstress dependencies [polaris]

2025-05-05 Thread via GitHub
github-actions[bot] commented on PR #1307: URL: https://github.com/apache/polaris/pull/1307#issuecomment-2853066974 This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. -- This is an automated message from the

Re: [PR] Rename the sibling interfaces of PolarisMetastoreManager [polaris]

2025-05-05 Thread via GitHub
github-actions[bot] commented on PR #1315: URL: https://github.com/apache/polaris/pull/1315#issuecomment-2853066917 This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. -- This is an automated message from the

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
flyrain merged PR #1515: URL: https://github.com/apache/polaris/pull/1515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [I] [FEATURE REQUEST] On-Premise S3 & Remote Signing [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on issue #32: URL: https://github.com/apache/polaris/issues/32#issuecomment-2852875534 Related, smaller scope issue #1530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Refactor storage access configuration handling [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on PR #1504: URL: https://github.com/apache/polaris/pull/1504#issuecomment-2852874827 Thanks for the reminder @ryanovas . I've just filed a fresh issue for this : #1530 (since #32 has large scope) -- This is an automated message from the Apache Git Service. To respond to

[I] Support for non-AWS S3 compatible storage [polaris]

2025-05-05 Thread via GitHub
dimas-b opened a new issue, #1530: URL: https://github.com/apache/polaris/issues/1530 ### Is your feature request related to a problem? Please describe. There are multiple implementations of the S3 API offered by non-AWS systems. This issues tracks adding support for that in Pol

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074479561 ## quarkus/admin/src/testFixtures/java/org/apache/polaris/admintool/PostgresTestResourceLifecycleManager.java: ## @@ -63,7 +63,10 @@ public Map start() { context.c

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074474158 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Au

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074474158 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Au

[PR] [Policy Store | Management Spec] Add policy privileges to spec and update admin service impl [polaris]

2025-05-05 Thread via GitHub
HonahX opened a new pull request, #1529: URL: https://github.com/apache/polaris/pull/1529 Not ready for review This PR adds new policy related privileges to `polaris-management-api.yml` and update `PolarisAdminService` to allow granting new privileges -- This is an auto

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2074467913 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -173,23 +190,82 @@ publ

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2074464961 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -173,23 +190,82 @@ publ

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-05 Thread via GitHub
singhpk234 commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2074461532 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -173,23 +190,82 @@ p

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-05 Thread via GitHub
singhpk234 commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2074458805 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/RelationalJdbcConfiguration.java: ## @@ -0,0 +1,34 @@

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-05 Thread via GitHub
singhpk234 commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2074458805 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/RelationalJdbcConfiguration.java: ## @@ -0,0 +1,34 @@

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-05 Thread via GitHub
singhpk234 commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2074454437 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -173,23 +190,82 @@ p

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074310561 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074310561 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074310561 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
flyrain commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074348269 ## site/content/in-dev/unreleased/configuring-polaris-for-production.md: ## @@ -135,34 +135,32 @@ default, Polaris uses an in-memory metastore. > The default in-memory

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2074339324 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -173,23 +190,82 @@ publ

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2074317542 ## extension/persistence/relational-jdbc/src/test/java/org/apache/polaris/extension/persistence/impl/relational/jdbc/AtomicMetastoreManagerWithJdbcBasePersistenceImplTest.java:

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074310561 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
singhpk234 commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074343118 ## site/content/in-dev/unreleased/configuring-polaris-for-production.md: ## @@ -135,34 +135,32 @@ default, Polaris uses an in-memory metastore. > The default in-mem

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
singhpk234 commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074342843 ## site/content/in-dev/unreleased/configuring-polaris-for-production.md: ## @@ -135,33 +135,19 @@ default, Polaris uses an in-memory metastore. > The default in-mem

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074310561 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074310561 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074310561 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074310561 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074310561 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
flyrain commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074308500 ## site/content/in-dev/unreleased/configuring-polaris-for-production.md: ## @@ -135,34 +135,32 @@ default, Polaris uses an in-memory metastore. > The default in-memory

Re: [PR] Add support for federated principal and role with block for manual role assignment [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1353: URL: https://github.com/apache/polaris/pull/1353#discussion_r2074299008 ## api/management-model/build.gradle.kts: ## @@ -57,6 +57,8 @@ openApiGenerate { additionalProperties.put("apiNameSuffix", "Api") additionalProperties.put("metric

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
singhpk234 commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074297907 ## site/content/in-dev/unreleased/admin-tool.md: ## @@ -74,14 +74,7 @@ The Polaris Admin Tool must be executed with the same configuration as the Polar configurati

Re: [PR] Add Integration tests for Delta tables for Spark Client [polaris]

2025-05-05 Thread via GitHub
gh-yzou commented on code in PR #1500: URL: https://github.com/apache/polaris/pull/1500#discussion_r2074294796 ## plugins/spark/v3.5/integration/build.gradle.kts: ## @@ -51,10 +51,15 @@ dependencies { testImplementation("org.apache.spark:spark-sql_${scalaVersion}:${spark35Ve

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074295034 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074295034 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074294753 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Au

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074292585 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Au

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074278158 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074278158 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074290547 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Au

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074289533 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Au

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
singhpk234 commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074288098 ## site/content/in-dev/unreleased/metastores.md: ## @@ -32,6 +32,29 @@ In order to add other JDBC drivers, you have to build Polaris using the `eclipse ## Polari

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074285877 ## quarkus/admin/src/testFixtures/java/org/apache/polaris/admintool/PostgresTestResourceLifecycleManager.java: ## @@ -63,7 +63,10 @@ public Map start() { context.c

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074283391 ## quarkus/admin/src/testFixtures/java/org/apache/polaris/admintool/PostgresTestResourceLifecycleManager.java: ## @@ -63,7 +63,10 @@ public Map start() { context.c

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074280466 ## quarkus/admin/src/testFixtures/java/org/apache/polaris/admintool/PostgresTestResourceLifecycleManager.java: ## @@ -63,7 +63,10 @@ public Map start() { context.c

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074280466 ## quarkus/admin/src/testFixtures/java/org/apache/polaris/admintool/PostgresTestResourceLifecycleManager.java: ## @@ -63,7 +63,10 @@ public Map start() { context.c

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074278158 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
singhpk234 commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074275204 ## site/content/in-dev/unreleased/metastores.md: ## @@ -32,6 +32,29 @@ In order to add other JDBC drivers, you have to build Polaris using the `eclipse ## Polari

Re: [PR] [JDBC] [DO NOT REVIEW] Add retries with delay [polaris]

2025-05-05 Thread via GitHub
singhpk234 commented on PR #1517: URL: https://github.com/apache/polaris/pull/1517#issuecomment-2852444032 cc @dimas-b @flyrain -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074257711 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Au

Re: [I] Document how Polaris works with different cloud storage(S3, Azure Blob Storage, GCS). [polaris]

2025-05-05 Thread via GitHub
flyrain commented on issue #1325: URL: https://github.com/apache/polaris/issues/1325#issuecomment-2852427548 Per offline discussion with @adnanhemani, we will still need more doc on how different storage setup works. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074241739 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,34 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on PR #1506: URL: https://github.com/apache/polaris/pull/1506#issuecomment-2852423784 I believe the STS credentials concern is not specific to this PR. We can probably deal with that in another PR. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074249270 ## site/content/in-dev/unreleased/metastores.md: ## @@ -32,6 +32,29 @@ In order to add other JDBC drivers, you have to build Polaris using the `eclipse ## Polaris S

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074243975 ## site/content/in-dev/unreleased/configuring-polaris-for-production.md: ## @@ -135,34 +135,32 @@ default, Polaris uses an in-memory metastore. > The default in-memory

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on PR #1506: URL: https://github.com/apache/polaris/pull/1506#issuecomment-2852409287 > @XJDKC - sorry, I know I had previously approved this proposal but reading through some of the comments, I'm questioning something: > > Why do we require a IAM User for Polaris? My

Re: [PR] Use env var in spark container [polaris]

2025-05-05 Thread via GitHub
adnanhemani commented on code in PR #1522: URL: https://github.com/apache/polaris/pull/1522#discussion_r2074243678 ## site/content/in-dev/unreleased/getting-started/using-polaris.md: ## @@ -172,9 +172,8 @@ Finally, note that we include the `hadoop-aws` package here. If your tab

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
dimas-b commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074243975 ## site/content/in-dev/unreleased/configuring-polaris-for-production.md: ## @@ -135,34 +135,32 @@ default, Polaris uses an in-memory metastore. > The default in-memory

Re: [PR] Use env var in spark container [polaris]

2025-05-05 Thread via GitHub
adnanhemani commented on code in PR #1522: URL: https://github.com/apache/polaris/pull/1522#discussion_r2074243678 ## site/content/in-dev/unreleased/getting-started/using-polaris.md: ## @@ -172,9 +172,8 @@ Finally, note that we include the `hadoop-aws` package here. If your tab

Re: [PR] Use env var in spark container [polaris]

2025-05-05 Thread via GitHub
adnanhemani commented on code in PR #1522: URL: https://github.com/apache/polaris/pull/1522#discussion_r2074241794 ## site/content/in-dev/unreleased/getting-started/using-polaris.md: ## @@ -172,9 +172,8 @@ Finally, note that we include the `hadoop-aws` package here. If your tab

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074241739 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,34 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
flyrain commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074200699 ## site/content/in-dev/unreleased/metastores.md: ## @@ -32,6 +32,29 @@ In order to add other JDBC drivers, you have to build Polaris using the `eclipse ## Polaris S

Re: [I] Document how Polaris works with different cloud storage(S3, Azure Blob Storage, GCS). [polaris]

2025-05-05 Thread via GitHub
adnanhemani commented on issue #1325: URL: https://github.com/apache/polaris/issues/1325#issuecomment-2852384660 Given #1435 merged, should we close this @flyrain ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
adnanhemani commented on PR #1506: URL: https://github.com/apache/polaris/pull/1506#issuecomment-2852335595 @XJDKC - sorry, I know I had previously approved this proposal but reading through some of the comments, I'm questioning something: Why do we require a IAM User for Polaris? My

Re: [PR] Add Integration tests for Delta tables for Spark Client [polaris]

2025-05-05 Thread via GitHub
flyrain commented on code in PR #1500: URL: https://github.com/apache/polaris/pull/1500#discussion_r2074164797 ## plugins/spark/v3.5/integration/src/intTest/java/org/apache/polaris/spark/quarkus/it/SparkDeltaIT.java: ## @@ -0,0 +1,265 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Add Integration tests for Delta tables for Spark Client [polaris]

2025-05-05 Thread via GitHub
flyrain commented on code in PR #1500: URL: https://github.com/apache/polaris/pull/1500#discussion_r2074160168 ## plugins/spark/v3.5/integration/build.gradle.kts: ## @@ -51,10 +51,15 @@ dependencies { testImplementation("org.apache.spark:spark-sql_${scalaVersion}:${spark35Ve

Re: [PR] Add Integration tests for Delta tables for Spark Client [polaris]

2025-05-05 Thread via GitHub
flyrain commented on code in PR #1500: URL: https://github.com/apache/polaris/pull/1500#discussion_r2074160168 ## plugins/spark/v3.5/integration/build.gradle.kts: ## @@ -51,10 +51,15 @@ dependencies { testImplementation("org.apache.spark:spark-sql_${scalaVersion}:${spark35Ve

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
eric-maynard commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074155668 ## site/content/in-dev/unreleased/configuring-polaris-for-production.md: ## @@ -135,34 +135,32 @@ default, Polaris uses an in-memory metastore. > The default in-m

Re: [PR] Add Integration tests for Delta tables for Spark Client [polaris]

2025-05-05 Thread via GitHub
flyrain commented on code in PR #1500: URL: https://github.com/apache/polaris/pull/1500#discussion_r2074151417 ## plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java: ## @@ -151,13 +151,20 @@ public Table createTable( String provider = properti

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
adnanhemani commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2074136270 ## site/content/in-dev/unreleased/admin-tool.md: ## @@ -74,14 +74,7 @@ The Polaris Admin Tool must be executed with the same configuration as the Polar configurat

Re: [I] [FEATURE REQUEST] Add Support for Adding cloud credential from polaris cli. [polaris]

2025-05-05 Thread via GitHub
adnanhemani commented on issue #1516: URL: https://github.com/apache/polaris/issues/1516#issuecomment-285699 If running on an AWS-managed instance (such as EC2) - then using an IAM Instance Profile role (or similar for different AWS services) would be the recommended way to control what

Re: [PR] Add support for federated principal and role with block for manual role assignment [polaris]

2025-05-05 Thread via GitHub
collado-mike commented on PR #1353: URL: https://github.com/apache/polaris/pull/1353#issuecomment-2852071767 > I think we have to remove the ability to persist federated principals/roles. I'll elaborate on the dev-ML. This has already been discussed on the mailing list. There is no pe

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-05 Thread via GitHub
dennishuo commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2074012033 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,34 @@ components: format: password description: Bearer token (input-only) +SigV4

Re: [PR] Refactor storage access configuration handling [polaris]

2025-05-05 Thread via GitHub
ryanovas commented on PR #1504: URL: https://github.com/apache/polaris/pull/1504#issuecomment-2851990248 With the other issue arrive S3-compatible storage closed, and this step towards it merged, where can we keep up with the overall progress of S3-compatible storage now? -- This is an a

Re: [PR] Implement federation to HadoopCatalog [polaris]

2025-05-05 Thread via GitHub
eric-maynard commented on code in PR #1466: URL: https://github.com/apache/polaris/pull/1466#discussion_r2073971189 ## polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java: ## @@ -234,4 +235,11 @@ public static void enforceFeatureEnabledOrThrow(

Re: [PR] Implement federation to HadoopCatalog [polaris]

2025-05-05 Thread via GitHub
eric-maynard commented on code in PR #1466: URL: https://github.com/apache/polaris/pull/1466#discussion_r2073959622 ## polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java: ## @@ -234,4 +235,11 @@ public static void enforceFeatureEnabledOrThrow(

Re: [PR] Interface changes for pagination [polaris]

2025-05-05 Thread via GitHub
eric-maynard commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2073950129 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/PageToken.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Interface changes for pagination [polaris]

2025-05-05 Thread via GitHub
eric-maynard commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2073950129 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/PageToken.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Interface changes for pagination [polaris]

2025-05-05 Thread via GitHub
eric-maynard commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2073944331 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/ReadFromStartPageToken.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Implement federation to HadoopCatalog [polaris]

2025-05-05 Thread via GitHub
dennishuo commented on code in PR #1466: URL: https://github.com/apache/polaris/pull/1466#discussion_r2073870563 ## polaris-core/src/main/java/org/apache/polaris/core/connection/hadoop/HadoopConnectionConfigInfoDpo.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Softwar

Re: [I] [FEATURE REQUEST] Add Support for Adding cloud credential from polaris cli. [polaris]

2025-05-05 Thread via GitHub
chenyue9713 commented on issue #1516: URL: https://github.com/apache/polaris/issues/1516#issuecomment-2851889211 Hi @eric-maynard , it is good to know Polaris server can upgrade its AWS credentials without a restart and may I know what is the best practice in production to pass AWS credenti

Re: [PR] Add support for federated principal and role with block for manual role assignment [polaris]

2025-05-05 Thread via GitHub
collado-mike commented on code in PR #1353: URL: https://github.com/apache/polaris/pull/1353#discussion_r2073924410 ## spec/polaris-management-service.yml: ## @@ -1151,6 +1175,10 @@ components: maxLength: 256 pattern: '^(?!\s*[s|S][y|Y][s|S][t|T][e|E][m|M]\

Re: [I] Concurrent Namespace Update Fails with RuntimeException and 500 Error [polaris]

2025-05-05 Thread via GitHub
singhpk234 commented on issue #1390: URL: https://github.com/apache/polaris/issues/1390#issuecomment-2851883325 Adding more details, so essentially the IcebergCatalog at service layer itself thows up [code](https://github.com/apache/polaris/blob/main/service/common/src/main/java/org/apache/

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
singhpk234 commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2073916646 ## site/content/in-dev/unreleased/configuring-polaris-for-production.md: ## @@ -135,33 +135,19 @@ default, Polaris uses an in-memory metastore. > The default in-mem

Re: [PR] [JDBC] : Deprecate EclipseLink [polaris]

2025-05-05 Thread via GitHub
singhpk234 commented on code in PR #1515: URL: https://github.com/apache/polaris/pull/1515#discussion_r2073915719 ## helm/polaris/README.md: ## @@ -186,161 +186,161 @@ kubectl delete namespace polaris ## Values -| Key | Type | Default | Description | -|-|--|

Re: [I] [FEATURE REQUEST] Add Support for Adding cloud credential from polaris cli. [polaris]

2025-05-05 Thread via GitHub
eric-maynard commented on issue #1516: URL: https://github.com/apache/polaris/issues/1516#issuecomment-2851864047 Hey @chenyue9713, the way this is meant to work in production is indeed that the Polaris server can update its AWS credentials without a restart. The env variable method for get

[I] Fix annoying "split package" build warnings [polaris]

2025-05-05 Thread via GitHub
adutra opened a new issue, #849: URL: https://github.com/apache/polaris/issues/849 ### Is your feature request related to a problem? Please describe. When building Polaris, we often see an annoying message printed many times to the console, e.g.: ``` Detected a split package

Re: [I] Fix annoying "split package" build warnings [polaris]

2025-05-05 Thread via GitHub
eric-maynard commented on issue #849: URL: https://github.com/apache/polaris/issues/849#issuecomment-2851854919 I still see some errors of this form: ``` Detected a split package usage which is considered a bad practice and should be avoided. Following packages were detected in mul

Re: [PR] Implement pagination for list APIs [polaris]

2025-05-05 Thread via GitHub
eric-maynard commented on code in PR #273: URL: https://github.com/apache/polaris/pull/273#discussion_r2073847427 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/OffsetPageToken.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Implement pagination for list APIs [polaris]

2025-05-05 Thread via GitHub
eric-maynard commented on PR #273: URL: https://github.com/apache/polaris/pull/273#issuecomment-2851710994 @flyrain, please see #1528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Implement pagination for list APIs [polaris]

2025-05-05 Thread via GitHub
eric-maynard closed pull request #273: Implement pagination for list APIs URL: https://github.com/apache/polaris/pull/273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

  1   2   >