Re: [PR] Add cleanup support for partition-level statistics files when `DROP TABLE PURGE` [polaris]

2025-05-08 Thread via GitHub
danielhumanmod commented on code in PR #1508: URL: https://github.com/apache/polaris/pull/1508#discussion_r2080943590 ## quarkus/service/src/test/java/org/apache/polaris/service/quarkus/task/TaskTestUtils.java: ## @@ -161,4 +179,26 @@ public static StatisticsFile writeStatsFile(

[PR] main: Update dependency com.adobe.testing:s3mock-testcontainers to v4.2.0 [polaris]

2025-05-08 Thread via GitHub
renovate-bot opened a new pull request, #1551: URL: https://github.com/apache/polaris/pull/1551 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.adobe.testing:s3mock-testcontainers](https://redi

Re: [PR] Fix updating the storage config [polaris]

2025-05-08 Thread via GitHub
github-actions[bot] commented on PR #1191: URL: https://github.com/apache/polaris/pull/1191#issuecomment-2864885470 This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. -- This is an automated message from the

Re: [PR] Require explict user-consent to enable HadoopFileIO [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1532: URL: https://github.com/apache/polaris/pull/1532#discussion_r2080644065 ## quarkus/service/src/test/java/org/apache/polaris/service/quarkus/admin/PolarisOverlappingTableTest.java: ## @@ -73,10 +74,25 @@ private int createTable(TestServices

Re: [PR] Introduce reserved-properties setting; reserve "polaris." by default [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on PR #1417: URL: https://github.com/apache/polaris/pull/1417#issuecomment-2864681294 Let's keep it open for another day or so in case other people have opinions on this change. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-08 Thread via GitHub
singhpk234 commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2080663558 ## quarkus/common/build.gradle.kts: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements

Re: [PR] [Docs] Add JDBC retry properties [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1550: URL: https://github.com/apache/polaris/pull/1550#discussion_r2080655980 ## site/content/in-dev/unreleased/configuration.md: ## @@ -77,43 +77,46 @@ read-only mode, as Polaris only reads the configuration file once, at startup. ## Polaris

[PR] [Docs] Add JDBC retry properties [polaris]

2025-05-08 Thread via GitHub
singhpk234 opened a new pull request, #1550: URL: https://github.com/apache/polaris/pull/1550 ### About the changes Add docs for relational JDBC retry properties introduced via : https://github.com/apache/polaris/pull/1517 -- This is an automated message from the Apache Git Service

Re: [PR] Introduce reserved-properties setting; reserve "polaris." by default [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1417: URL: https://github.com/apache/polaris/pull/1417#discussion_r2080628062 ## service/common/src/main/java/org/apache/polaris/service/config/ReservedProperties.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Introduce reserved-properties setting; reserve "polaris." by default [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1417: URL: https://github.com/apache/polaris/pull/1417#discussion_r2080623337 ## service/common/src/main/java/org/apache/polaris/service/config/ReservedProperties.java: ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Introduce reserved-properties setting; reserve "polaris." by default [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1417: URL: https://github.com/apache/polaris/pull/1417#discussion_r2080623337 ## service/common/src/main/java/org/apache/polaris/service/config/ReservedProperties.java: ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Introduce reserved-properties setting; reserve "polaris." by default [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1417: URL: https://github.com/apache/polaris/pull/1417#discussion_r2080622368 ## service/common/src/main/java/org/apache/polaris/service/config/ReservedProperties.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Introduce reserved-properties setting; reserve "polaris." by default [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1417: URL: https://github.com/apache/polaris/pull/1417#discussion_r2080620689 ## service/common/src/main/java/org/apache/polaris/service/config/ReservedProperties.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add DefaultConfigurationStoreDecorator to support inject callContext for DefaultConfigurationStore [polaris]

2025-05-08 Thread via GitHub
gh-yzou commented on code in PR #1505: URL: https://github.com/apache/polaris/pull/1505#discussion_r2080605159 ## service/common/src/main/java/org/apache/polaris/service/config/DefaultConfigurationStoreDecorator.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software F

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2080598630 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -173,23 +186,105 @@ pub

Re: [PR] Spec: Add SigV4 Auth Support for Catalog Federation [polaris]

2025-05-08 Thread via GitHub
XJDKC commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2080566407 ## spec/polaris-management-service.yml: ## @@ -938,6 +940,40 @@ components: format: password description: Bearer token (input-only) +SigV4Auth

Re: [PR] Auto-bootstrap: add verbose logging [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on PR #1376: URL: https://github.com/apache/polaris/pull/1376#issuecomment-2864554974 I'll look into that if noone else has a fix in progress :thinking: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[PR] main: Update postgres Docker tag to v17.5 [polaris]

2025-05-08 Thread via GitHub
renovate-bot opened a new pull request, #1549: URL: https://github.com/apache/polaris/pull/1549 This PR contains the following updates: | Package | Update | Change | |---|---|---| | postgres | minor | `17.4` -> `17.5` | --- ### Configuration 📅 **Schedule**: B

Re: [PR] Add support for federated principal and role with block for manual role assignment [polaris]

2025-05-08 Thread via GitHub
collado-mike commented on PR #1353: URL: https://github.com/apache/polaris/pull/1353#issuecomment-2864554303 I responded on the ML. It doesn't really matter. @snazy if we remove the field from the Principal entity, will you remove the -1 on the PR? -- This is an automated message from the

[PR] main: Update dependency boto3 to v1.38.12 [polaris]

2025-05-08 Thread via GitHub
renovate-bot opened a new pull request, #1548: URL: https://github.com/apache/polaris/pull/1548 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [boto3](https://redirect.github.com/boto/boto3) | `==1.

Re: [PR] Use env var in spark container [polaris]

2025-05-08 Thread via GitHub
adnanhemani commented on code in PR #1522: URL: https://github.com/apache/polaris/pull/1522#discussion_r2080503389 ## site/content/in-dev/unreleased/getting-started/using-polaris.md: ## @@ -236,9 +235,6 @@ org.apache.iceberg.exceptions.ForbiddenException: Forbidden: Principal '

Re: [PR] Introduce reserved-properties setting; reserve "polaris." by default [polaris]

2025-05-08 Thread via GitHub
eric-maynard commented on code in PR #1417: URL: https://github.com/apache/polaris/pull/1417#discussion_r2080385230 ## service/common/src/main/java/org/apache/polaris/service/config/ReservedProperties.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Introduce reserved-properties setting; reserve "polaris." by default [polaris]

2025-05-08 Thread via GitHub
eric-maynard commented on code in PR #1417: URL: https://github.com/apache/polaris/pull/1417#discussion_r2080380020 ## service/common/src/main/java/org/apache/polaris/service/config/ReservedProperties.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Introduce reserved-properties setting; reserve "polaris." by default [polaris]

2025-05-08 Thread via GitHub
eric-maynard commented on code in PR #1417: URL: https://github.com/apache/polaris/pull/1417#discussion_r2080390398 ## integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisManagementServiceIntegrationTest.java: ## @@ -2102,6 +2103,129 @@ public void testDrop

Re: [PR] Introduce reserved-properties setting; reserve "polaris." by default [polaris]

2025-05-08 Thread via GitHub
eric-maynard commented on code in PR #1417: URL: https://github.com/apache/polaris/pull/1417#discussion_r2080390398 ## integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisManagementServiceIntegrationTest.java: ## @@ -2102,6 +2103,129 @@ public void testDrop

Re: [PR] Introduce reserved-properties setting; reserve "polaris." by default [polaris]

2025-05-08 Thread via GitHub
eric-maynard commented on code in PR #1417: URL: https://github.com/apache/polaris/pull/1417#discussion_r2080380855 ## service/common/src/main/java/org/apache/polaris/service/config/ReservedProperties.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Require explict user-consent to enable HadoopFileIO [polaris]

2025-05-08 Thread via GitHub
snazy commented on PR #1532: URL: https://github.com/apache/polaris/pull/1532#issuecomment-2863996619 > Can we focus on this change? We can work on other changes in followup if necessary. The underlying issue is way too serious, what you propose is by far not enough. -- This is an

Re: [PR] Add release guide on the website [polaris]

2025-05-08 Thread via GitHub
flyrain commented on PR #1539: URL: https://github.com/apache/polaris/pull/1539#issuecomment-2863805100 Thanks @jbonofre for the release guide. Thanks @dimas-b for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Require explict user-consent to enable HadoopFileIO [polaris]

2025-05-08 Thread via GitHub
flyrain commented on PR #1532: URL: https://github.com/apache/polaris/pull/1532#issuecomment-2863897744 > The default of SUPPORTED_CATALOG_STORAGE_TYPES is changed to not include the FILE storage type. Can we focus on this change? We can work on other changes in followup if necessary

Re: [PR] Add release guide on the website [polaris]

2025-05-08 Thread via GitHub
flyrain merged PR #1539: URL: https://github.com/apache/polaris/pull/1539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] Introduce reserved-properties setting; reserve "polaris." by default [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1417: URL: https://github.com/apache/polaris/pull/1417#discussion_r2080176437 ## integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisManagementServiceIntegrationTest.java: ## @@ -2102,6 +2103,129 @@ public void testDropNames

Re: [PR] Add DefaultConfigurationStoreDecorator to support inject callContext for DefaultConfigurationStore [polaris]

2025-05-08 Thread via GitHub
collado-mike commented on code in PR #1505: URL: https://github.com/apache/polaris/pull/1505#discussion_r2080193750 ## service/common/src/main/java/org/apache/polaris/service/config/DefaultConfigurationStoreDecorator.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Interface changes for pagination [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2080163100 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java: ## @@ -169,6 +170,23 @@ public static boolean isCreate(UpdateTabl

[PR] main: Update actions/stale digest to f78de97 [polaris]

2025-05-08 Thread via GitHub
renovate-bot opened a new pull request, #1547: URL: https://github.com/apache/polaris/pull/1547 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | actions/stale | action | digest | `816d9db` -> `f78de97` | --- ### Config

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2080165850 ## quarkus/service/build.gradle.kts: ## @@ -40,6 +40,7 @@ dependencies { implementation(platform(libs.opentelemetry.bom)) implementation(platform(libs.quarkus.b

Re: [PR] Interface changes for pagination [polaris]

2025-05-08 Thread via GitHub
eric-maynard commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2080152035 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java: ## @@ -169,6 +170,23 @@ public static boolean isCreate(Updat

Re: [PR] Interface changes for pagination [polaris]

2025-05-08 Thread via GitHub
eric-maynard commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2080141520 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/DonePageToken.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Interface changes for pagination [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2080138610 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java: ## @@ -169,6 +170,23 @@ public static boolean isCreate(UpdateTabl

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2080111979 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -173,23 +189,105 @@ pub

Re: [PR] Interface changes for pagination [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2080136331 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/ReadFromStartPageToken.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Interface changes for pagination [polaris]

2025-05-08 Thread via GitHub
eric-maynard commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2080133654 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/DonePageToken.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-08 Thread via GitHub
singhpk234 commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2080133452 ## quarkus/service/build.gradle.kts: ## @@ -40,6 +40,7 @@ dependencies { implementation(platform(libs.opentelemetry.bom)) implementation(platform(libs.quarku

Re: [PR] Interface changes for pagination [polaris]

2025-05-08 Thread via GitHub
eric-maynard commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2080132406 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java: ## @@ -169,6 +170,23 @@ public static boolean isCreate(Updat

Re: [PR] Interface changes for pagination [polaris]

2025-05-08 Thread via GitHub
eric-maynard commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2080131391 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/ReadFromStartPageToken.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Interface changes for pagination [polaris]

2025-05-08 Thread via GitHub
eric-maynard commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2080131873 ## service/common/build.gradle.kts: ## @@ -104,6 +104,7 @@ dependencies { testFixturesImplementation(project(":polaris-api-management-model")) testFixturesIm

Re: [PR] Interface changes for pagination [polaris]

2025-05-08 Thread via GitHub
eric-maynard commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2080124909 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/ReadFromStartPageToken.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Interface changes for pagination [polaris]

2025-05-08 Thread via GitHub
eric-maynard commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2080120839 ## extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java: ## @@ -45

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2080114359 ## quarkus/service/build.gradle.kts: ## @@ -40,6 +40,7 @@ dependencies { implementation(platform(libs.opentelemetry.bom)) implementation(platform(libs.quarkus.b

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2080111979 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -173,23 +189,105 @@ pub

Re: [PR] Interface changes for pagination [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2080097116 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/PageToken.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Interface changes for pagination [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2080093479 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/PageToken.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Interface changes for pagination [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2079930782 ## extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java: ## @@ -450,27

Re: [PR] Interface changes for pagination [polaris]

2025-05-08 Thread via GitHub
dimas-b commented on code in PR #1528: URL: https://github.com/apache/polaris/pull/1528#discussion_r2079934994 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/PageToken.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-08 Thread via GitHub
singhpk234 commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2079997560 ## quarkus/common/build.gradle.kts: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-08 Thread via GitHub
singhpk234 commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2079997560 ## quarkus/common/build.gradle.kts: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements

Re: [PR] Use env var in spark container [polaris]

2025-05-08 Thread via GitHub
owenowenisme commented on PR #1522: URL: https://github.com/apache/polaris/pull/1522#issuecomment-2863216852 @eric-maynard PTAL🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [I] Task handling is incomplete [polaris]

2025-05-08 Thread via GitHub
snazy commented on issue #774: URL: https://github.com/apache/polaris/issues/774#issuecomment-2862358409 I think that it's also very important that no two instances run the same task. Otherwise it's not safe to run Polaris in an HA/LB setup. -- This is an automated message from the Apa

Re: [PR] Add support for federated principal and role with block for manual role assignment [polaris]

2025-05-08 Thread via GitHub
snazy commented on PR #1353: URL: https://github.com/apache/polaris/pull/1353#issuecomment-2862154954 > > As mentioned on the ML, there's no need to have that "federated" flag on principals, which is still there. > > Per Dmitri's comment above > > > As discussed, having API-lev

Re: [PR] [JDBC] Add retries with delay [polaris]

2025-05-08 Thread via GitHub
snazy commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2079103744 ## quarkus/common/build.gradle.kts: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. Se

Re: [PR] Create a wrapper script to generate python client; regenerate the python client [polaris]

2025-05-08 Thread via GitHub
eric-maynard commented on code in PR #1347: URL: https://github.com/apache/polaris/pull/1347#discussion_r2079036380 ## spec/iceberg-rest-catalog-open-api.yaml: ## @@ -260,6 +260,7 @@ paths: parameters: - $ref: '#/components/parameters/page-token' - $ref: