flyrain merged PR #1598:
URL: https://github.com/apache/polaris/pull/1598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
flyrain commented on code in PR #1598:
URL: https://github.com/apache/polaris/pull/1598#discussion_r2093971951
##
quarkus/admin/src/main/resources/application.properties:
##
@@ -23,7 +23,7 @@
# Cf. https://quarkus.io/guides/all-config
quarkus.application.name=Apache Polaris
flyrain commented on PR #1532:
URL: https://github.com/apache/polaris/pull/1532#issuecomment-2888112228
As I said in the email thread, I don't think `ALLOW_INSECURE_STORAGE_TYPES`
is necessary, but I'm OK with it. With that, +0 on the PR.
--
This is an automated message from the Apache Gi
dimas-b commented on code in PR #1555:
URL: https://github.com/apache/polaris/pull/1555#discussion_r2093752613
##
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##
@@ -428,7 +443,7 @@ pub
XJDKC commented on PR #1506:
URL: https://github.com/apache/polaris/pull/1506#issuecomment-2887848328
Thanks everyone for reviewing this PR! I really appreciate the thoughtful
comments which helped me think more thoroughly about the problem and refine the
proposal to cover more use cases.
dimas-b commented on code in PR #1555:
URL: https://github.com/apache/polaris/pull/1555#discussion_r2093755058
##
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##
Review Comment:
dimas-b commented on code in PR #1555:
URL: https://github.com/apache/polaris/pull/1555#discussion_r2093755058
##
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##
Review Comment:
eric-maynard commented on code in PR #1586:
URL: https://github.com/apache/polaris/pull/1586#discussion_r2093647999
##
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##
@@ -99,4 +111,23 @@ public boolean isChildOf(StorageLocation potentialParent
eric-maynard commented on code in PR #1586:
URL: https://github.com/apache/polaris/pull/1586#discussion_r2093651812
##
polaris-core/src/test/java/org/apache/polaris/service/storage/StorageLocationTest.java:
##
@@ -19,17 +19,41 @@
package org.apache.polaris.service.storage;
i
RussellSpitzer commented on code in PR #433:
URL: https://github.com/apache/polaris/pull/433#discussion_r2093660555
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -881,11 +859,57 @@ public Map getCredentialConfig(
g
eric-maynard commented on code in PR #1586:
URL: https://github.com/apache/polaris/pull/1586#discussion_r2093651484
##
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##
@@ -99,4 +111,23 @@ public boolean isChildOf(StorageLocation potentialParent
eric-maynard commented on code in PR #1586:
URL: https://github.com/apache/polaris/pull/1586#discussion_r2093649331
##
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##
@@ -99,4 +111,23 @@ public boolean isChildOf(StorageLocation potentialParent
eric-maynard commented on code in PR #1586:
URL: https://github.com/apache/polaris/pull/1586#discussion_r2093649331
##
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##
@@ -99,4 +111,23 @@ public boolean isChildOf(StorageLocation potentialParent
eric-maynard commented on code in PR #1586:
URL: https://github.com/apache/polaris/pull/1586#discussion_r2093650020
##
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##
@@ -99,4 +111,23 @@ public boolean isChildOf(StorageLocation potentialParent
eric-maynard commented on code in PR #1586:
URL: https://github.com/apache/polaris/pull/1586#discussion_r2093647746
##
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##
@@ -99,4 +111,23 @@ public boolean isChildOf(StorageLocation potentialParent
eric-maynard commented on code in PR #1586:
URL: https://github.com/apache/polaris/pull/1586#discussion_r2093647302
##
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##
@@ -104,4 +112,22 @@ public boolean isChildOf(StorageLocation potentialParen
eric-maynard commented on PR #433:
URL: https://github.com/apache/polaris/pull/433#issuecomment-2887626582
Per @RussellSpitzer's review I've removed references to
`StringLoadTableResponse` and the `MetadataJson` type used to build it. I did
leave some related code changes in place, such as
eric-maynard commented on code in PR #433:
URL: https://github.com/apache/polaris/pull/433#discussion_r2093632379
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -881,11 +859,57 @@ public Map getCredentialConfig(
get
collado-mike merged PR #1353:
URL: https://github.com/apache/polaris/pull/1353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
eric-maynard commented on code in PR #433:
URL: https://github.com/apache/polaris/pull/433#discussion_r2093629474
##
service/common/src/main/java/org/apache/polaris/service/persistence/MetadataCacheManager.java:
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Founda
dimas-b commented on PR #1586:
URL: https://github.com/apache/polaris/pull/1586#issuecomment-2887498027
I mostly meant that this PR should not claim that it `Fixes #1545` (in the
descriptio) :)
I did not mean to expand the scope of this PR. We can merge this incremental
improvement,
adutra commented on PR #1589:
URL: https://github.com/apache/polaris/pull/1589#issuecomment-2887494227
> it might be preferable to have a separate docker image for the admin tool
and have only the combined archive-based distribution. WDYT?
If that's the plan I can live with that 👍
dimas-b commented on code in PR #1598:
URL: https://github.com/apache/polaris/pull/1598#discussion_r2093555863
##
quarkus/admin/src/main/resources/application.properties:
##
@@ -23,7 +23,7 @@
# Cf. https://quarkus.io/guides/all-config
quarkus.application.name=Apache Polaris
XJDKC commented on code in PR #1506:
URL: https://github.com/apache/polaris/pull/1506#discussion_r2093547957
##
spec/polaris-management-service.yml:
##
@@ -938,6 +940,38 @@ components:
format: password
description: Bearer token (input-only)
+SigV4Auth
XJDKC commented on code in PR #1506:
URL: https://github.com/apache/polaris/pull/1506#discussion_r2093538231
##
spec/polaris-management-service.yml:
##
@@ -868,6 +868,8 @@ components:
description: URI to the remote catalog service
authenticationParameters:
adutra commented on code in PR #1506:
URL: https://github.com/apache/polaris/pull/1506#discussion_r2093519235
##
spec/polaris-management-service.yml:
##
@@ -938,6 +940,38 @@ components:
format: password
description: Bearer token (input-only)
+SigV4Aut
adutra commented on code in PR #1506:
URL: https://github.com/apache/polaris/pull/1506#discussion_r2093524329
##
spec/polaris-management-service.yml:
##
@@ -868,6 +868,8 @@ components:
description: URI to the remote catalog service
authenticationParameters:
XJDKC commented on code in PR #1506:
URL: https://github.com/apache/polaris/pull/1506#discussion_r2093503044
##
spec/polaris-management-service.yml:
##
@@ -938,6 +940,38 @@ components:
format: password
description: Bearer token (input-only)
+SigV4Auth
XJDKC commented on code in PR #1506:
URL: https://github.com/apache/polaris/pull/1506#discussion_r2093503044
##
spec/polaris-management-service.yml:
##
@@ -938,6 +940,38 @@ components:
format: password
description: Bearer token (input-only)
+SigV4Auth
flyrain commented on code in PR #1600:
URL: https://github.com/apache/polaris/pull/1600#discussion_r2093501640
##
site/content/in-dev/unreleased/policy.md:
##
@@ -0,0 +1,200 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
dimas-b commented on code in PR #1506:
URL: https://github.com/apache/polaris/pull/1506#discussion_r2093487546
##
spec/polaris-management-service.yml:
##
@@ -938,6 +940,38 @@ components:
format: password
description: Bearer token (input-only)
+SigV4Au
XJDKC commented on code in PR #1506:
URL: https://github.com/apache/polaris/pull/1506#discussion_r2093477962
##
spec/polaris-management-service.yml:
##
@@ -938,6 +940,38 @@ components:
format: password
description: Bearer token (input-only)
+SigV4Auth
XJDKC commented on code in PR #1506:
URL: https://github.com/apache/polaris/pull/1506#discussion_r2093477962
##
spec/polaris-management-service.yml:
##
@@ -938,6 +940,38 @@ components:
format: password
description: Bearer token (input-only)
+SigV4Auth
jbonofre commented on code in PR #1561:
URL: https://github.com/apache/polaris/pull/1561#discussion_r2093476212
##
quarkus/admin/distribution/NOTICE:
##
@@ -15,358 +15,11 @@ This binary artifact bundles the following projects with
NOTICE:
Group: info.picocli Name: picocli Na
singhpk234 merged PR #1584:
URL: https://github.com/apache/polaris/pull/1584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.
collado-mike commented on PR #1353:
URL: https://github.com/apache/polaris/pull/1353#issuecomment-2887358780
> PR LGTM, but there are CI failures...
Oh - it's running against the latest main. I kept running it locally, but
after I rebase on main, I see the error
--
This is an autom
eric-maynard commented on code in PR #433:
URL: https://github.com/apache/polaris/pull/433#discussion_r2091970580
##
service/common/src/main/java/org/apache/polaris/service/persistence/MetadataCacheManager.java:
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Founda
eric-maynard commented on PR #433:
URL: https://github.com/apache/polaris/pull/433#issuecomment-2887341231
Sounds good @RussellSpitzer, thanks for taking a look. I will unwind the
changes related to directly serving the metadata.json content from persistence
for now.
--
This is an automa
eric-maynard commented on PR #1596:
URL: https://github.com/apache/polaris/pull/1596#issuecomment-2887317455
Personally I'm fine with you not using `@PolarisImmutable` -- I still
haven't figured out why we need that or why my IDE so often doesn't seem to
like it:
https://github.com/user-
flyrain commented on code in PR #1600:
URL: https://github.com/apache/polaris/pull/1600#discussion_r2093442877
##
site/content/in-dev/unreleased/policy.md:
##
@@ -0,0 +1,200 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
XJDKC commented on code in PR #1506:
URL: https://github.com/apache/polaris/pull/1506#discussion_r2087431839
##
spec/polaris-management-service.yml:
##
@@ -1023,6 +1057,49 @@ components:
allOf:
- $ref: '#/components/schemas/StorageConfigInfo'
+ServiceIdenti
dimas-b commented on code in PR #1506:
URL: https://github.com/apache/polaris/pull/1506#discussion_r2093430843
##
spec/polaris-management-service.yml:
##
@@ -938,6 +940,38 @@ components:
format: password
description: Bearer token (input-only)
+SigV4Au
XJDKC commented on code in PR #1506:
URL: https://github.com/apache/polaris/pull/1506#discussion_r2093410457
##
spec/polaris-management-service.yml:
##
@@ -938,6 +940,38 @@ components:
format: password
description: Bearer token (input-only)
+SigV4Auth
XJDKC commented on code in PR #1506:
URL: https://github.com/apache/polaris/pull/1506#discussion_r2093410457
##
spec/polaris-management-service.yml:
##
@@ -938,6 +940,38 @@ components:
format: password
description: Bearer token (input-only)
+SigV4Auth
XJDKC commented on code in PR #1506:
URL: https://github.com/apache/polaris/pull/1506#discussion_r2093410457
##
spec/polaris-management-service.yml:
##
@@ -938,6 +940,38 @@ components:
format: password
description: Bearer token (input-only)
+SigV4Auth
XJDKC commented on code in PR #1506:
URL: https://github.com/apache/polaris/pull/1506#discussion_r2093410457
##
spec/polaris-management-service.yml:
##
@@ -938,6 +940,38 @@ components:
format: password
description: Bearer token (input-only)
+SigV4Auth
singhpk234 commented on code in PR #1600:
URL: https://github.com/apache/polaris/pull/1600#discussion_r2093292694
##
site/content/in-dev/unreleased/policy.md:
##
@@ -0,0 +1,200 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licens
dimas-b commented on code in PR #1506:
URL: https://github.com/apache/polaris/pull/1506#discussion_r2093203514
##
spec/polaris-management-service.yml:
##
@@ -938,6 +940,38 @@ components:
format: password
description: Bearer token (input-only)
+SigV4Au
fabio-rizzo-01 commented on PR #1596:
URL: https://github.com/apache/polaris/pull/1596#issuecomment-2886074876
> @fabio-rizzo-01 I think the ask is that you use [this
interface](https://github.com/apache/polaris/blob/2e373e51ce5434c26635535b684ff210a53b1745/tools/immutables/src/main/java/org
snazy merged PR #1574:
URL: https://github.com/apache/polaris/pull/1574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy merged PR #1575:
URL: https://github.com/apache/polaris/pull/1575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy merged PR #1577:
URL: https://github.com/apache/polaris/pull/1577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy merged PR #1578:
URL: https://github.com/apache/polaris/pull/1578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
eric-maynard commented on code in PR #1566:
URL: https://github.com/apache/polaris/pull/1566#discussion_r2087416766
##
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/GetConfigTest.java:
##
@@ -39,7 +39,14 @@ public class GetConfigTest {
@ValueSource(
54 matches
Mail list logo
