gh-yzou commented on code in PR #1505:
URL: https://github.com/apache/polaris/pull/1505#discussion_r2097018440
##
service/common/src/main/java/org/apache/polaris/service/config/DefaultConfigurationStoreDecorator.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software F
gh-yzou commented on code in PR #1505:
URL: https://github.com/apache/polaris/pull/1505#discussion_r2097120812
##
service/common/src/main/java/org/apache/polaris/service/config/DefaultConfigurationStoreDecorator.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software F
singhpk234 commented on code in PR #1600:
URL: https://github.com/apache/polaris/pull/1600#discussion_r2097115419
##
site/content/in-dev/unreleased/policy.md:
##
@@ -0,0 +1,197 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licens
gh-yzou commented on code in PR #1505:
URL: https://github.com/apache/polaris/pull/1505#discussion_r2097115938
##
service/common/src/main/java/org/apache/polaris/service/config/DefaultConfigurationStoreDecorator.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software F
adnanhemani commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2096979589
##
site/content/in-dev/unreleased/getting-started/quickstart.md:
##
@@ -36,7 +36,8 @@ cd ~/polaris
:polaris-quarkus-admin:assemble --rerun \
-Dquarkus.contain
flyrain commented on code in PR #1600:
URL: https://github.com/apache/polaris/pull/1600#discussion_r2096970786
##
site/content/in-dev/unreleased/policy.md:
##
@@ -0,0 +1,207 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
XJDKC commented on code in PR #1624:
URL: https://github.com/apache/polaris/pull/1624#discussion_r2096982670
##
service/common/src/test/java/org/apache/polaris/service/catalog/io/FileIOFactoryTest.java:
##
@@ -198,7 +198,7 @@ public void testLoadFileIOForCleanupTask() {
//
adnanhemani commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2096979589
##
site/content/in-dev/unreleased/getting-started/quickstart.md:
##
@@ -36,7 +36,8 @@ cd ~/polaris
:polaris-quarkus-admin:assemble --rerun \
-Dquarkus.contain
flyrain commented on code in PR #1600:
URL: https://github.com/apache/polaris/pull/1600#discussion_r2096965891
##
site/content/in-dev/unreleased/policy.md:
##
@@ -0,0 +1,207 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
adnanhemani commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2096972264
##
getting-started/eclipselink/docker-compose.yml:
##
@@ -82,7 +82,7 @@ services:
--conf, "spark.sql.catalog.quickstart_catalog.type=rest",
--conf,
"
flyrain commented on PR #1600:
URL: https://github.com/apache/polaris/pull/1600#issuecomment-2893031100
> was wondering, can we follow an E2E example for ex :
>
> 1. define policy 1, policy 2
> 2. attach policy 1 on table (NS1.tb1) and policy 2 on namsepace (NS1)
> 3. get appli
flyrain commented on code in PR #1600:
URL: https://github.com/apache/polaris/pull/1600#discussion_r2096966320
##
site/content/in-dev/unreleased/policy.md:
##
@@ -0,0 +1,207 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
MonkeyCanCode commented on PR #1609:
URL: https://github.com/apache/polaris/pull/1609#issuecomment-2892816662
> @snazy - not sure if we're on the same page here but these bundle JARs
aren't the ones from AWS/Azure/GCP but rather ones that are compiled by Apache
Iceberg to solve this exact p
MonkeyCanCode commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2096800119
##
getting-started/eclipselink/docker-compose.yml:
##
@@ -82,7 +82,7 @@ services:
--conf, "spark.sql.catalog.quickstart_catalog.type=rest",
--conf,
MonkeyCanCode commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2096804622
##
getting-started/assets/.env:
##
Review Comment:
Good suggestion. This is fixed.
##
getting-started/eclipselink/docker-compose.yml:
##
adnanhemani commented on PR #1610:
URL: https://github.com/apache/polaris/pull/1610#issuecomment-2892655882
> This PR raises a question about how we structure the docker-compose
commands. I understand the desire to reduce the amount of duplicated yaml
across docker-compose files. However, f
adnanhemani commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2096694571
##
getting-started/eclipselink/docker-compose.yml:
##
@@ -82,7 +82,7 @@ services:
--conf, "spark.sql.catalog.quickstart_catalog.type=rest",
--conf,
"
adnanhemani commented on code in PR #1600:
URL: https://github.com/apache/polaris/pull/1600#discussion_r2096657446
##
site/content/in-dev/unreleased/policy.md:
##
@@ -0,0 +1,207 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licen
singhpk234 commented on code in PR #1600:
URL: https://github.com/apache/polaris/pull/1600#discussion_r2096642194
##
site/content/in-dev/unreleased/policy.md:
##
@@ -0,0 +1,207 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licens
singhpk234 commented on code in PR #1600:
URL: https://github.com/apache/polaris/pull/1600#discussion_r2096642194
##
site/content/in-dev/unreleased/policy.md:
##
@@ -0,0 +1,207 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licens
adnanhemani commented on code in PR #1604:
URL: https://github.com/apache/polaris/pull/1604#discussion_r2096640150
##
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##
@@ -44,8 +44,10 @@ protected StorageLocation(@Nonnull String location) {
adnanhemani commented on code in PR #1604:
URL: https://github.com/apache/polaris/pull/1604#discussion_r2096639901
##
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##
@@ -44,8 +44,10 @@ protected StorageLocation(@Nonnull String location) {
flyrain commented on code in PR #1624:
URL: https://github.com/apache/polaris/pull/1624#discussion_r2096617052
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -232,7 +222,16 @@ public String name() {
}
@VisibleForTest
flyrain opened a new pull request, #1624:
URL: https://github.com/apache/polaris/pull/1624
As we discussed
[here](https://github.com/apache/polaris/pull/1532#issuecomment-2868205342),
this PR removes the config to make it safer.
--
This is an automated message from the Apache Git Service
renovate-bot opened a new pull request, #1622:
URL: https://github.com/apache/polaris/pull/1622
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [boto3](https://redirect.github.com/boto/boto3) | `==1.
renovate-bot opened a new pull request, #1623:
URL: https://github.com/apache/polaris/pull/1623
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[com.google.cloud:google-cloud-storage-bom](https://re
dimas-b commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2096605152
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -433,39 +446,174 @@ protected TableMetadata commit(TableOpera
adnanhemani commented on PR #1609:
URL: https://github.com/apache/polaris/pull/1609#issuecomment-2892493263
@snazy - not sure if we're on the same page here but these bundle JARs
aren't the ones from AWS/Azure/GCP but rather ones that are compiled by Apache
Iceberg to solve this exact probl
singhpk234 commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2096595995
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -433,39 +446,174 @@ protected TableMetadata commit(TableOp
HonahX commented on code in PR #1600:
URL: https://github.com/apache/polaris/pull/1600#discussion_r2096588753
##
site/content/in-dev/unreleased/policy.md:
##
@@ -0,0 +1,207 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license ag
adnanhemani commented on PR #1523:
URL: https://github.com/apache/polaris/pull/1523#issuecomment-2892474008
I agree with the analysis you've stated too. I think it really comes down to
point 1) that you made - and if someone has context as to whether they
considered this approach before put
HonahX commented on code in PR #1600:
URL: https://github.com/apache/polaris/pull/1600#discussion_r2096588298
##
site/content/in-dev/unreleased/policy.md:
##
@@ -0,0 +1,207 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license ag
gh-yzou commented on code in PR #1505:
URL: https://github.com/apache/polaris/pull/1505#discussion_r2096588190
##
service/common/src/main/java/org/apache/polaris/service/config/DefaultConfigurationStoreDecorator.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software F
HonahX commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096578731
##
spec/polaris-management-service.yml:
##
@@ -1387,6 +1417,26 @@ components:
- tableName
- privilege
+PolicyGrant:
+ allOf:
+
singhpk234 commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2096572524
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -433,39 +446,174 @@ protected TableMetadata commit(TableOp
sfc-gh-yzou commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096555697
##
spec/polaris-management-service.yml:
##
@@ -1387,6 +1417,26 @@ components:
- tableName
- privilege
+PolicyGrant:
+ allOf:
+
flyrain commented on code in PR #1600:
URL: https://github.com/apache/polaris/pull/1600#discussion_r2096549132
##
site/content/in-dev/unreleased/policy.md:
##
@@ -0,0 +1,207 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
flyrain commented on code in PR #1600:
URL: https://github.com/apache/polaris/pull/1600#discussion_r2096545867
##
site/content/in-dev/unreleased/policy.md:
##
@@ -0,0 +1,207 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
sfc-gh-yzou commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096542651
##
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrivilege.java:
##
@@ -150,6 +150,11 @@ public enum PolarisPrivilege {
CATALOG_DETACH_POLICY(
HonahX commented on code in PR #1600:
URL: https://github.com/apache/polaris/pull/1600#discussion_r2096538340
##
site/content/in-dev/unreleased/policy.md:
##
@@ -0,0 +1,207 @@
+---
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license ag
HonahX commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096522587
##
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -1937,4 +2023,68 @@ private boolean revokePrivilegeOnTableLikeFromRole(
HonahX commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096522140
##
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -528,6 +533,47 @@ private void authorizeGrantOnTableLikeOperationOrThrow
dimas-b commented on PR #1555:
URL: https://github.com/apache/polaris/pull/1555#issuecomment-2892330335
I suppose shared page token classes can be in `polaris-core`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
HonahX opened a new pull request, #1621:
URL: https://github.com/apache/polaris/pull/1621
In `PolarisAdminService` we have a group of `authorizePrivilegeOn*` and
`grantPrivilegeOn*`/`revokePrivilegeOn*` methods for privilege grant/revoke on
catalog, namespace, table, view, etc. This PR
williamhyun commented on PR #1619:
URL: https://github.com/apache/polaris/pull/1619#issuecomment-2892297929
S3 and Azure regression tests are skipped on GitHub Action, will need to
update those as well before merging.
--
This is an automated message from the Apache Git Service.
To respond
adnanhemani commented on PR #1610:
URL: https://github.com/apache/polaris/pull/1610#issuecomment-2892295392
While there are some good call-outs in this PR of things we should change,
there are also some regressions. Please do not merge this PR - give me until
EOD to get comments in.
--
T
dimas-b commented on code in PR #1543:
URL: https://github.com/apache/polaris/pull/1543#discussion_r2096504614
##
spec/polaris-catalog-apis/generic-tables-api.yaml:
##
@@ -212,6 +214,8 @@ components:
- `properties` properties for the generic table passed on creation
dimas-b commented on code in PR #1505:
URL: https://github.com/apache/polaris/pull/1505#discussion_r2096496812
##
service/common/src/main/java/org/apache/polaris/service/config/DefaultConfigurationStoreDecorator.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software F
williamhyun commented on code in PR #1619:
URL: https://github.com/apache/polaris/pull/1619#discussion_r2096499056
##
regtests/t_spark_sql/src/spark_sql_views.sh:
##
@@ -23,7 +23,7 @@ SPARK_BEARER_TOKEN="${REGTEST_ROOT_BEARER_TOKEN}"
curl -i -X POST -H "Authorization: Bearer
adnanhemani commented on issue #1613:
URL: https://github.com/apache/polaris/issues/1613#issuecomment-2892276958
Orthogonal thought: Ideally, we should do the work to make JDBC the
Quickstart experience instead of EclipseLink, which has all these things
thought up of with much more details
gh-yzou commented on code in PR #1543:
URL: https://github.com/apache/polaris/pull/1543#discussion_r2096495983
##
spec/polaris-catalog-apis/generic-tables-api.yaml:
##
@@ -212,6 +214,8 @@ components:
- `properties` properties for the generic table passed on creation
dimas-b commented on code in PR #1619:
URL: https://github.com/apache/polaris/pull/1619#discussion_r2096487377
##
regtests/t_spark_sql/src/spark_sql_views.sh:
##
@@ -23,7 +23,7 @@ SPARK_BEARER_TOKEN="${REGTEST_ROOT_BEARER_TOKEN}"
curl -i -X POST -H "Authorization: Bearer ${SP
collado-mike commented on code in PR #1505:
URL: https://github.com/apache/polaris/pull/1505#discussion_r2096485894
##
service/common/src/main/java/org/apache/polaris/service/config/DefaultConfigurationStoreDecorator.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Softw
adnanhemani commented on PR #1604:
URL: https://github.com/apache/polaris/pull/1604#issuecomment-2892234327
> Can you elaborate on when .. would be a valid in a path? For me, .. is a
path-traversal in the presence of it raises the question "why is this not the
source of a path-traversal-att
dimas-b commented on code in PR #1604:
URL: https://github.com/apache/polaris/pull/1604#discussion_r2096484269
##
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##
@@ -44,8 +44,10 @@ protected StorageLocation(@Nonnull String location) {
t
dimas-b commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2096468064
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -433,39 +446,174 @@ protected TableMetadata commit(TableOpera
dimas-b commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2096468064
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -433,39 +446,174 @@ protected TableMetadata commit(TableOpera
adnanhemani commented on PR #1604:
URL: https://github.com/apache/polaris/pull/1604#issuecomment-2892219306
> I'm also confused on having multiple PRs for the same issue.
Please see
https://github.com/apache/polaris/pull/1586#discussion_r2094201688 and
https://github.com/apache/polar
dimas-b commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2096455650
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -433,39 +446,174 @@ protected TableMetadata commit(TableOpera
singhpk234 commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2096436975
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -433,39 +446,174 @@ protected TableMetadata commit(TableOp
dimas-b commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2096452402
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -433,39 +446,173 @@ protected TableMetadata commit(TableOpera
singhpk234 commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2096449577
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -433,39 +446,174 @@ protected TableMetadata commit(TableOp
dimas-b commented on code in PR #1586:
URL: https://github.com/apache/polaris/pull/1586#discussion_r2096448449
##
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##
@@ -19,8 +19,9 @@
package org.apache.polaris.core.storage;
import jakarta.ann
dimas-b commented on code in PR #1586:
URL: https://github.com/apache/polaris/pull/1586#discussion_r2096448449
##
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##
@@ -19,8 +19,9 @@
package org.apache.polaris.core.storage;
import jakarta.ann
dimas-b commented on code in PR #1586:
URL: https://github.com/apache/polaris/pull/1586#discussion_r2096447863
##
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##
@@ -19,8 +19,9 @@
package org.apache.polaris.core.storage;
import jakarta.ann
dimas-b commented on code in PR #1586:
URL: https://github.com/apache/polaris/pull/1586#discussion_r2091891820
##
polaris-core/src/test/java/org/apache/polaris/service/storage/StorageLocationTest.java:
##
@@ -19,17 +19,41 @@
package org.apache.polaris.service.storage;
import
singhpk234 commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2096436975
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -433,39 +446,174 @@ protected TableMetadata commit(TableOp
dimas-b commented on PR #1506:
URL: https://github.com/apache/polaris/pull/1506#issuecomment-2892151793
I propose to merge on May 20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
dimas-b commented on PR #1614:
URL: https://github.com/apache/polaris/pull/1614#issuecomment-2892070458
#1610 seems to offer a more holistic fix for the same problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dimas-b commented on PR #1610:
URL: https://github.com/apache/polaris/pull/1610#issuecomment-2892068966
> I would rather have everything contained in a single docker-compose file
I support that. I even suggested that in
https://github.com/apache/polaris/pull/1470#discussion_r207092787
dimas-b commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2096357756
##
getting-started/assets/.env:
##
Review Comment:
Would you mind making this a regular file (not having `.` in front of the
name)?.. and maybe rename to `getting
eric-maynard commented on PR #1555:
URL: https://github.com/apache/polaris/pull/1555#issuecomment-2892024904
Is there a way I can do that without a bunch of redundant code? Right now we
have 3 metastores that can all use the same token implementation, so I wouldn't
want to have 3 copies of
dimas-b commented on code in PR #1614:
URL: https://github.com/apache/polaris/pull/1614#discussion_r2096334002
##
getting-started/jdbc/README.md:
##
@@ -40,6 +40,8 @@ This example requires `jq` to be installed on your machine.
export QUARKUS_DATASOURCE_JDBC_URL=jdbc:postgre
dimas-b commented on code in PR #1543:
URL: https://github.com/apache/polaris/pull/1543#discussion_r2096321577
##
spec/polaris-catalog-apis/generic-tables-api.yaml:
##
@@ -212,6 +214,8 @@ components:
- `properties` properties for the generic table passed on creation
dimas-b commented on code in PR #1543:
URL: https://github.com/apache/polaris/pull/1543#discussion_r2096321577
##
spec/polaris-catalog-apis/generic-tables-api.yaml:
##
@@ -212,6 +214,8 @@ components:
- `properties` properties for the generic table passed on creation
dimas-b commented on issue #1612:
URL: https://github.com/apache/polaris/issues/1612#issuecomment-2891991233
Since it's a recent change and UX is probably impacted, marking this as a
1.0 blocker
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dimas-b commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2096312949
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -433,39 +446,174 @@ protected TableMetadata commit(TableOpera
dimas-b commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2096312445
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -433,39 +446,174 @@ protected TableMetadata commit(TableOpera
dimas-b commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2096312445
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -433,39 +446,174 @@ protected TableMetadata commit(TableOpera
dimas-b commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2096305322
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -433,39 +446,174 @@ protected TableMetadata commit(TableOpera
singhpk234 opened a new pull request, #1620:
URL: https://github.com/apache/polaris/pull/1620
### About the change
I’d like to propose adding context-aware functions to Apache Polaris so that
view definitions can resolve security context on the Polaris side (aka catalog
end without
flyrain commented on PR #1563:
URL: https://github.com/apache/polaris/pull/1563#issuecomment-2891840686
> Use it for Minio, Keycloak, Postgres, etc etc etc.
Just to clarify, Postgres doesn't use it, and Minio and Keycloak are not
part of the Polaris repo.
We also have no clear time
flyrain commented on PR #1606:
URL: https://github.com/apache/polaris/pull/1606#issuecomment-2891831198
Thanks @pingtimeout and @jbonofre for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
flyrain merged PR #1606:
URL: https://github.com/apache/polaris/pull/1606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
williamhyun commented on PR #1619:
URL: https://github.com/apache/polaris/pull/1619#issuecomment-2891824913
cc: @eric-maynard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
williamhyun opened a new pull request, #1619:
URL: https://github.com/apache/polaris/pull/1619
As per [https://github.com/apache/polaris/issues/1617](#1617), we will be
setting the default value of DROP WITH PURGE to false.
--
This is an automated message from the Apache Git Serv
HonahX commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096225357
##
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrivilege.java:
##
@@ -150,6 +150,11 @@ public enum PolarisPrivilege {
CATALOG_DETACH_POLICY(81, P
HonahX commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096221531
##
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -1937,4 +2023,68 @@ private boolean revokePrivilegeOnTableLikeFromRole(
HonahX commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096215517
##
service/common/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java:
##
@@ -621,6 +623,19 @@ public Response addGrantToCatalogRole(
admin
flyrain closed issue #563: Resources not properly closed, resource & memory
leaks
URL: https://github.com/apache/polaris/issues/563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
HonahX commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096198389
##
spec/polaris-management-service.yml:
##
@@ -1278,6 +1278,20 @@ components:
- TABLE_READ_DATA
- TABLE_WRITE_DATA
- TABLE_FULL_METADATA
+
HonahX commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096188949
##
spec/polaris-management-service.yml:
##
@@ -1278,6 +1278,20 @@ components:
- TABLE_READ_DATA
- TABLE_WRITE_DATA
- TABLE_FULL_METADATA
+
pjanuario commented on code in PR #1614:
URL: https://github.com/apache/polaris/pull/1614#discussion_r2096188152
##
getting-started/jdbc/README.md:
##
@@ -40,6 +40,8 @@ This example requires `jq` to be installed on your machine.
export QUARKUS_DATASOURCE_JDBC_URL=jdbc:postg
HonahX commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096165510
##
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisPolicyServiceIntegrationTest.java:
##
@@ -427,6 +442,176 @@ NS2_T1, new Schema(Types.NestedF
eric-maynard opened a new issue, #1617:
URL: https://github.com/apache/polaris/issues/1617
### Describe the bug
As mentioned in #774 and elsewhere, DROP WITH PURGE is currently somewhat
unreliable. While there is some ongoing work to make this operation more
scalable and robust, we s
HonahX commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096138502
##
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisPolicyServiceIntegrationTest.java:
##
@@ -427,6 +442,176 @@ NS2_T1, new Schema(Types.NestedF
HonahX commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096134438
##
spec/polaris-management-service.yml:
##
@@ -1334,6 +1356,14 @@ components:
- NAMESPACE_FULL_METADATA
- TABLE_FULL_METADATA
- VIEW_FULL_META
flyrain commented on issue #563:
URL: https://github.com/apache/polaris/issues/563#issuecomment-2891610940
Closed it per community discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
singhpk234 commented on code in PR #1614:
URL: https://github.com/apache/polaris/pull/1614#discussion_r2096090403
##
getting-started/jdbc/README.md:
##
@@ -40,6 +40,8 @@ This example requires `jq` to be installed on your machine.
export QUARKUS_DATASOURCE_JDBC_URL=jdbc:post
flyrain commented on issue #774:
URL: https://github.com/apache/polaris/issues/774#issuecomment-2891591790
We can turn drop-by-purge off by default in 1.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
1 - 100 of 148 matches
Mail list logo
