Tishj commented on issue #1658:
URL: https://github.com/apache/polaris/issues/1658#issuecomment-2903437249
@dimas-b as mentioned:
> Removing the double quotes around the options here made it execute
successfully
"here" being the problematic `application.properties` file
Are
jbonofre commented on PR #1589:
URL: https://github.com/apache/polaris/pull/1589#issuecomment-2903361401
Any artifact we distribute should have license/notice/disclaimer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jbonofre commented on PR #1589:
URL: https://github.com/apache/polaris/pull/1589#issuecomment-2903360425
@flyrain you are good here. My previous comment is "for information" (to
explain the reason why we have to keep those files :)).
--
This is an automated message from the Apache Git Se
flyrain commented on PR #1589:
URL: https://github.com/apache/polaris/pull/1589#issuecomment-2903357993
> By the way, as we still have separate docker images, we also have to keep
LICENSE/NOTICE/DISCLAIMER in both admin and server.
Thanks @jbonofre ! I intentionally left them in these
jbonofre commented on PR #1589:
URL: https://github.com/apache/polaris/pull/1589#issuecomment-2903339366
By the way, as we still have separate docker images, we also have to keep
LICENSE/NOTICE/DISCLAIMER in both admin and server.
--
This is an automated message from the Apache Git Servic
jbonofre commented on PR #1589:
URL: https://github.com/apache/polaris/pull/1589#issuecomment-2903338459
@flyrain I will do the LICENSE/NOTICE/DISCLAIMER work on another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
flyrain commented on PR #1610:
URL: https://github.com/apache/polaris/pull/1610#issuecomment-2903330664
Thanks @MonkeyCanCode for the fix! Thanks @pingtimeout , @dimas-b , and
@adnanhemani for the review. Let's keep fixing what's left.
--
This is an automated message from the Apache Git
flyrain merged PR #1610:
URL: https://github.com/apache/polaris/pull/1610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
flyrain commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2103838169
##
site/content/in-dev/unreleased/getting-started/using-polaris.md:
##
@@ -176,7 +179,9 @@ Finally, note that we include the `iceberg-aws-bundle`
package here. If your
flyrain commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2103829075
##
site/content/in-dev/unreleased/getting-started/quickstart.md:
##
@@ -83,11 +89,6 @@ When using a Gradle-launched Polaris instance in this
tutorial, we'll launch an
adnanhemani commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2103829247
##
getting-started/eclipselink/docker-compose.yml:
##
@@ -82,7 +82,7 @@ services:
--conf, "spark.sql.catalog.quickstart_catalog.type=rest",
--conf,
"
flyrain commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2103828412
##
site/content/in-dev/unreleased/getting-started/quickstart.md:
##
@@ -83,11 +89,6 @@ When using a Gradle-launched Polaris instance in this
tutorial, we'll launch an
adnanhemani commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2103826247
##
site/content/in-dev/unreleased/getting-started/quickstart.md:
##
@@ -36,9 +36,38 @@ cd ~/polaris
:polaris-quarkus-admin:assemble --rerun \
-Dquarkus.contai
flyrain commented on code in PR #1659:
URL: https://github.com/apache/polaris/pull/1659#discussion_r2103769050
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -169,10 +169,10 @@ public class IcebergCatalog extends
BaseMetast
MonkeyCanCode commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2103738051
##
site/content/in-dev/unreleased/getting-started/quickstart.md:
##
@@ -36,9 +36,38 @@ cd ~/polaris
:polaris-quarkus-admin:assemble --rerun \
-Dquarkus.cont
hildo commented on PR #1660:
URL: https://github.com/apache/polaris/pull/1660#issuecomment-2903151776
Closing, as this has been addressed in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
hildo closed pull request #1660: Quickstart documentation contained an error
around starting Polaris using docker compose
URL: https://github.com/apache/polaris/pull/1660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
hildo commented on code in PR #1660:
URL: https://github.com/apache/polaris/pull/1660#discussion_r2103717572
##
getting-started/eclipselink/docker-compose-bootstrap-db.yml:
##
@@ -25,7 +25,7 @@ services:
polaris.persistence.type: eclipse-link
polaris.persistence.ec
hildo commented on code in PR #1660:
URL: https://github.com/apache/polaris/pull/1660#discussion_r2103716733
##
getting-started/eclipselink/docker-compose-bootstrap-db.yml:
##
@@ -25,7 +25,7 @@ services:
polaris.persistence.type: eclipse-link
polaris.persistence.ec
eric-maynard commented on PR #1555:
URL: https://github.com/apache/polaris/pull/1555#issuecomment-2903087580
np @dimas-b, happy to iterate and try to get it right. I tried to push some
new changes based on your guidance above. I think this is still cleaner than
what we had before, too. Let
hildo commented on code in PR #1660:
URL: https://github.com/apache/polaris/pull/1660#discussion_r2103686973
##
getting-started/assets/postgres/pg_hba.conf:
##
@@ -0,0 +1,2 @@
+hostallall all md5
Review Comment:
FYI, this is what's b
hildo commented on code in PR #1660:
URL: https://github.com/apache/polaris/pull/1660#discussion_r2103686466
##
getting-started/assets/postgres/pg_hba.conf:
##
@@ -0,0 +1,2 @@
+hostallall all md5
Review Comment:
I am using what is de
adnanhemani commented on code in PR #1660:
URL: https://github.com/apache/polaris/pull/1660#discussion_r2103679535
##
getting-started/assets/postgres/pg_hba.conf:
##
@@ -0,0 +1,2 @@
+hostallall all md5
Review Comment:
I didn't find t
github-actions[bot] commented on PR #1395:
URL: https://github.com/apache/polaris/pull/1395#issuecomment-2903052390
This PR is stale because it has been open 30 days with no activity. Remove
stale label or comment or this will be closed in 5 days.
--
This is an automated message from the
hildo commented on PR #1660:
URL: https://github.com/apache/polaris/pull/1660#issuecomment-2903030544
@adnanhemani happy to help! I did find that I needed to tweak the
Postgress settings to allow connections to be accepted.. So I have pushed
more changes. Please let me know if this is
flyrain commented on PR #1589:
URL: https://github.com/apache/polaris/pull/1589#issuecomment-2903026266
Local test passed. Here are the structure now in the binary bundle. All
comments should be addressed. Please take a look @jbonofre @dimas-b @adutra
@snazy @singhpk234. Consolidation of LI
adnanhemani commented on PR #1660:
URL: https://github.com/apache/polaris/pull/1660#issuecomment-2903014889
Please do hit "Publish" on this PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
flyrain commented on code in PR #1589:
URL: https://github.com/apache/polaris/pull/1589#discussion_r2103590908
##
quarkus/admin/build.gradle.kts:
##
@@ -108,17 +102,10 @@ val quarkusBuild =
tasks.named("quarkusBuild")
val distTar =
tasks.named("distTar") {
dependsOn(qu
hildo opened a new pull request, #1660:
URL: https://github.com/apache/polaris/pull/1660
Hello. I was interested in learning more about Polaris, and when to run an
instance up using the instructions in the documentation. I reached the
docker-compose example for starting polaris and the co
flyrain commented on code in PR #1589:
URL: https://github.com/apache/polaris/pull/1589#discussion_r2103582374
##
quarkus/distribution/distribution/README.md:
##
@@ -0,0 +1,69 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreeme
flyrain commented on code in PR #1589:
URL: https://github.com/apache/polaris/pull/1589#discussion_r2103582493
##
quarkus/distribution/scripts/run.sh:
##
@@ -16,24 +16,30 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions a
dimas-b commented on PR #1555:
URL: https://github.com/apache/polaris/pull/1555#issuecomment-2902886175
> Turning this page-token into a PageToken actually used to be done with
persistence-specific logic, but I refactored that out in response to
https://github.com/apache/polaris/pull/1528#d
dimas-b closed issue #1658: `SUPPORTED_CATALOG_STORAGE_TYPES` can not be
overridden, due to invalid `application.properties`
URL: https://github.com/apache/polaris/issues/1658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
dimas-b commented on issue #1658:
URL: https://github.com/apache/polaris/issues/1658#issuecomment-2902872201
The error message may be a bit misleading in this case, but the actual error
appears to be in the custom config overrides.
The storage types options should probably be somethin
dimas-b opened a new pull request, #1659:
URL: https://github.com/apache/polaris/pull/1659
Following up on #1694
* Restore `private` scope on internal fields in `IcebergCatalog`
* Use a test-only setter instead of sub-classing to manage injecting test
FileIO implementations
flyrain commented on code in PR #1589:
URL: https://github.com/apache/polaris/pull/1589#discussion_r2103559840
##
quarkus/distribution/build.gradle.kts:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreeme
flyrain commented on PR #1589:
URL: https://github.com/apache/polaris/pull/1589#issuecomment-2902845151
> This change uses a bunch of highly discouraged Gradle practices:
>
> * It's accessing _another_ Gradle projects and those tasks - that's bad
practice and highly discouraged.
>
flyrain commented on code in PR #1589:
URL: https://github.com/apache/polaris/pull/1589#discussion_r2103545362
##
quarkus/distribution/build.gradle.kts:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreeme
singhpk234 merged PR #1643:
URL: https://github.com/apache/polaris/pull/1643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.
singhpk234 closed issue #1613: Quickstart getting-started/jdbc is missing
Client Id and Client Secret
URL: https://github.com/apache/polaris/issues/1613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
singhpk234 commented on issue #1613:
URL: https://github.com/apache/polaris/issues/1613#issuecomment-2902818642
No, i think its fixed !, closing this as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
flyrain commented on code in PR #1589:
URL: https://github.com/apache/polaris/pull/1589#discussion_r2103540988
##
quarkus/admin/build.gradle.kts:
##
@@ -108,17 +102,10 @@ val quarkusBuild =
tasks.named("quarkusBuild")
val distTar =
tasks.named("distTar") {
dependsOn(qu
Tishj opened a new issue, #1658:
URL: https://github.com/apache/polaris/issues/1658
### Describe the bug
```
Configuration validation failed:
SRCFG00050: polaris.features."SUPPORTED_CATALOG_STORAGE_TYPES" in
PropertiesConfigSource[source=jar:file:///polaris_catalog/quarkus/
pavibhai commented on issue #214:
URL: https://github.com/apache/polaris/issues/214#issuecomment-2902677890
> We cannot use s3a as the protocol because it is not supported:
That can be resolved by configuring the S3AFileSystem to handle `s3` scheme
by doing the following:
```
--
eric-maynard merged PR #1641:
URL: https://github.com/apache/polaris/pull/1641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
adnanhemani commented on code in PR #433:
URL: https://github.com/apache/polaris/pull/433#discussion_r2098853001
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -1297,22 +1306,35 @@ public TableMetadata refresh() {
ret
eric-maynard commented on PR #1555:
URL: https://github.com/apache/polaris/pull/1555#issuecomment-2902728893
@dimas-b per the spec, the request provides `page-token` and `page-size`. So
there is no `A1`, but the presence of `A2` or `A3` implies `A1`.
Turning this `page-token` into a `
eric-maynard commented on code in PR #1625:
URL: https://github.com/apache/polaris/pull/1625#discussion_r2103468073
##
CONTRIBUTING.md:
##
@@ -64,32 +64,60 @@ Before starting on a large code change, please describe the
concept/design of wh
The best way to provide changes is
flyrain commented on issue #214:
URL: https://github.com/apache/polaris/issues/214#issuecomment-2902710117
I don't think anyone is working on it. Thanks for picking it up, @pavibhai !
Assigned it to you.
--
This is an automated message from the Apache Git Service.
To respond to the messag
eric-maynard merged PR #1651:
URL: https://github.com/apache/polaris/pull/1651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
pavibhai commented on issue #214:
URL: https://github.com/apache/polaris/issues/214#issuecomment-2902679673
If no one is working on this, I would like to work and contribute this back.
We would like to support both `s3` and `s3a` schemes wrt to AWS S3 in polaris.
--
This is an automated m
renovate-bot opened a new pull request, #1657:
URL: https://github.com/apache/polaris/pull/1657
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [boto3](https://redirect.github.com/boto/boto3) | `==1.
HonahX merged PR #1628:
URL: https://github.com/apache/polaris/pull/1628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apac
flyrain commented on issue #1649:
URL: https://github.com/apache/polaris/issues/1649#issuecomment-2902619619
Hi @snazy, would you mind taking a look at this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
dimas-b commented on code in PR #1589:
URL: https://github.com/apache/polaris/pull/1589#discussion_r2103414519
##
quarkus/admin/build.gradle.kts:
##
@@ -108,17 +102,10 @@ val quarkusBuild =
tasks.named("quarkusBuild")
val distTar =
tasks.named("distTar") {
dependsOn(qu
dimas-b commented on code in PR #1589:
URL: https://github.com/apache/polaris/pull/1589#discussion_r2103413928
##
quarkus/distribution/build.gradle.kts:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreeme
adnanhemani commented on code in PR #1610:
URL: https://github.com/apache/polaris/pull/1610#discussion_r2103400389
##
site/content/in-dev/unreleased/getting-started/quickstart.md:
##
@@ -36,9 +36,38 @@ cd ~/polaris
:polaris-quarkus-admin:assemble --rerun \
-Dquarkus.contai
adnanhemani commented on PR #1604:
URL: https://github.com/apache/polaris/pull/1604#issuecomment-2902564451
> There are too many unrelated changes in this PR after the last push, it
seems
Sorry, made a mistake in how I rebased it and got everything played on top
of this PR. I've forc
flyrain commented on code in PR #1589:
URL: https://github.com/apache/polaris/pull/1589#discussion_r2103386504
##
quarkus/distribution/distribution/README.md:
##
@@ -0,0 +1,69 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreeme
singhpk234 commented on code in PR #1628:
URL: https://github.com/apache/polaris/pull/1628#discussion_r2103354934
##
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/QueryGenerator.java:
##
@@ -60,23 +64,20 @@ public st
flyrain commented on PR #1589:
URL: https://github.com/apache/polaris/pull/1589#issuecomment-2902526329
I ran a quick size check: the admin-tool weighs in at ~100 MB and the server
at ~200 MB. After merging, the combined package is still ~200 MB, which tells
us the server’s lib set is essen
adnanhemani commented on issue #1613:
URL: https://github.com/apache/polaris/issues/1613#issuecomment-2902501542
@pjanuario is this after #1646?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dimas-b commented on code in PR #1628:
URL: https://github.com/apache/polaris/pull/1628#discussion_r2103148029
##
polaris-core/src/main/java/org/apache/polaris/core/policy/TransactionalPolicyMappingPersistence.java:
##
@@ -54,7 +54,7 @@ default void deleteFromPolicyMappingRecord
dimas-b commented on PR #1555:
URL: https://github.com/apache/polaris/pull/1555#issuecomment-2902344278
I think it is preferable to delegate all handling of tokens to the
Persistence implementations.
We can certainly have a generic holder type (e.g. `Token`) to avoid passing
those pa
keithgchapman opened a new issue, #1656:
URL: https://github.com/apache/polaris/issues/1656
### Is your feature request related to a problem? Please describe.
As discussed
[here](https://github.com/apache/polaris/pull/1625/files#r2098361539) the
default commit message generated today
dimas-b commented on PR #1589:
URL: https://github.com/apache/polaris/pull/1589#issuecomment-2902242067
> Consolidate the shared libs between Admin Tool and Server
I'm a bit lost now as to the purpose of the archive-based distribution.
From my POV, the archive is meant mostly f
RussellSpitzer commented on code in PR #1625:
URL: https://github.com/apache/polaris/pull/1625#discussion_r2103199598
##
CONTRIBUTING.md:
##
@@ -64,32 +64,60 @@ Before starting on a large code change, please describe the
concept/design of wh
The best way to provide changes i
RussellSpitzer commented on code in PR #1625:
URL: https://github.com/apache/polaris/pull/1625#discussion_r2103194748
##
CONTRIBUTING.md:
##
@@ -64,32 +64,60 @@ Before starting on a large code change, please describe the
concept/design of wh
The best way to provide changes i
keithgchapman commented on code in PR #1625:
URL: https://github.com/apache/polaris/pull/1625#discussion_r2103188944
##
CONTRIBUTING.md:
##
@@ -64,32 +64,60 @@ Before starting on a large code change, please describe the
concept/design of wh
The best way to provide changes is
adutra commented on PR #1589:
URL: https://github.com/apache/polaris/pull/1589#issuecomment-2902190390
@flyrain since we are moving forward with the single distribution, I have
concerns about this TODO item:
> Consolidate the shared libs between Admin Tool and Server
I am not s
dimas-b merged PR #1652:
URL: https://github.com/apache/polaris/pull/1652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
dimas-b commented on code in PR #1589:
URL: https://github.com/apache/polaris/pull/1589#discussion_r2103137694
##
quarkus/distribution/distribution/README.md:
##
@@ -0,0 +1,69 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreeme
flyrain closed pull request #1639: [Python Client] CI for Python client
(Continue PR#1096)
URL: https://github.com/apache/polaris/pull/1639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
flyrain commented on code in PR #1589:
URL: https://github.com/apache/polaris/pull/1589#discussion_r2103130070
##
quarkus/distribution/scripts/run.sh:
##
@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/bin/bash
Review Comment:
Restored.
--
This is an automated message from the
singhpk234 commented on code in PR #1629:
URL: https://github.com/apache/polaris/pull/1629#discussion_r2103141552
##
service/common/src/main/java/org/apache/polaris/service/storage/StorageConfiguration.java:
##
@@ -61,21 +63,31 @@ public interface StorageConfiguration {
Optio
RussellSpitzer commented on PR #1654:
URL: https://github.com/apache/polaris/pull/1654#issuecomment-2902079955
> Alternative : #1655
>
> Shall we wait a couple of days for other entries?
Sure no problem as long we get a few :) I would never want to squash
someone's artistic dri
dimas-b commented on code in PR #1589:
URL: https://github.com/apache/polaris/pull/1589#discussion_r2103126063
##
quarkus/distribution/distribution/README.md:
##
@@ -0,0 +1,69 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreeme
singhpk234 closed issue #1647: Quick start broken
URL: https://github.com/apache/polaris/issues/1647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: iss
RussellSpitzer commented on issue #1653:
URL: https://github.com/apache/polaris/issues/1653#issuecomment-2902102167
Proposal from Dmitri
https://github.com/apache/polaris/pull/1655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
RussellSpitzer commented on issue #1653:
URL: https://github.com/apache/polaris/issues/1653#issuecomment-2902101561
Proposal from Scott
https://github.com/apache/polaris/pull/1654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
dimas-b commented on code in PR #1589:
URL: https://github.com/apache/polaris/pull/1589#discussion_r2103120911
##
quarkus/distribution/scripts/run.sh:
##
@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/bin/bash
Review Comment:
@flyrain : would you mind restoring the original sheban
dimas-b opened a new pull request, #1655:
URL: https://github.com/apache/polaris/pull/1655
Contributes to #1653
Alternative to #1654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dimas-b commented on PR #1654:
URL: https://github.com/apache/polaris/pull/1654#issuecomment-2902069652
Alternative : #1655
Shall we wait a couple of days for other entries?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
dimas-b commented on PR #1655:
URL: https://github.com/apache/polaris/pull/1655#issuecomment-2902065939
For ref: the "polar star" is hand made :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
dimas-b commented on PR #1655:
URL: https://github.com/apache/polaris/pull/1655#issuecomment-2902063576
Example rendition:
--
This is an automated message from the Apache Git Service.
To respo
singhpk234 commented on PR #1646:
URL: https://github.com/apache/polaris/pull/1646#issuecomment-2902057375
Thank so much, everyone for the quick review (@flyrain @eric-maynard
@dimas-b @RussellSpitzer @snazy) !
Thank you @pjanuario for your contribution (marked you as co-author) !
-
singhpk234 commented on issue #1647:
URL: https://github.com/apache/polaris/issues/1647#issuecomment-2902058347
fixed via : https://github.com/apache/polaris/pull/1646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
singhpk234 merged PR #1646:
URL: https://github.com/apache/polaris/pull/1646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.
singhpk234 commented on code in PR #1646:
URL: https://github.com/apache/polaris/pull/1646#discussion_r2103066000
##
getting-started/jdbc/docker-compose.yml:
##
@@ -29,18 +29,22 @@ services:
# Optional, allows attaching a debugger to the Polaris JVM
- "5005:5005"
flyrain commented on PR #1646:
URL: https://github.com/apache/polaris/pull/1646#issuecomment-2902008637
> LGTM, but we should fix everywhere else that needs this
Here is another issue broken by #1532,
https://github.com/apache/polaris/issues/1649. I agreed we need to fix them
all. Bu
singhpk234 commented on code in PR #1646:
URL: https://github.com/apache/polaris/pull/1646#discussion_r2103041422
##
getting-started/jdbc/docker-compose.yml:
##
@@ -29,18 +29,22 @@ services:
# Optional, allows attaching a debugger to the Polaris JVM
- "5005:5005"
HonahX closed pull request #1643: [Policy Store] Fix: Add
CATALOG_MANAGE_METADATA to policy attachment privileges' super privilege set
URL: https://github.com/apache/polaris/pull/1643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
dimas-b commented on PR #1654:
URL: https://github.com/apache/polaris/pull/1654#issuecomment-2901957508
Having alternatives SGTM. I'll open one from my side presently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
dimas-b commented on code in PR #1654:
URL: https://github.com/apache/polaris/pull/1654#discussion_r2103016247
##
service/common/src/main/resources/org/apache/polaris/service/banner.txt:
##
@@ -1,20 +1,22 @@
-
- @@@ @ @ @ @ @ @@
dimas-b commented on code in PR #1654:
URL: https://github.com/apache/polaris/pull/1654#discussion_r2102996150
##
quarkus/admin/src/main/resources/org/apache/polaris/admintool/banner.txt:
##
@@ -1,20 +1,22 @@
-
Review Comment:
correct
--
This is an automated message from
flyrain closed issue #1640: logred: command not found
URL: https://github.com/apache/polaris/issues/1640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
flyrain commented on issue #1640:
URL: https://github.com/apache/polaris/issues/1640#issuecomment-2901890491
Fixed by [#1648](https://github.com/apache/polaris/pull/1648)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
flyrain commented on PR #1648:
URL: https://github.com/apache/polaris/pull/1648#issuecomment-2901885990
Thanks @ModEtchFill for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
forking-renovate[bot] commented on PR #1652:
URL: https://github.com/apache/polaris/pull/1652#issuecomment-2901864083
### Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not
recognize the last commit author and assumes somebody else may have
flyrain merged PR #1648:
URL: https://github.com/apache/polaris/pull/1648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
1 - 100 of 135 matches
Mail list logo
