eric-maynard commented on code in PR #1686:
URL: https://github.com/apache/polaris/pull/1686#discussion_r2158089209
##
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/QueryGenerator.java:
##
@@ -208,6 +209,59 @@ static QueryFragment gener
eric-maynard commented on code in PR #1686:
URL: https://github.com/apache/polaris/pull/1686#discussion_r2158089905
##
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##
@@ -622,6 +632,64 @@ public boolean ha
eric-maynard commented on code in PR #1686:
URL: https://github.com/apache/polaris/pull/1686#discussion_r2158089209
##
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/QueryGenerator.java:
##
@@ -208,6 +209,59 @@ static QueryFragment gener
eric-maynard commented on code in PR #1686:
URL: https://github.com/apache/polaris/pull/1686#discussion_r2158088066
##
persistence/relational-jdbc/src/main/resources/h2/schema-v2.sql:
##
@@ -0,0 +1,128 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or
singhpk234 commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2157998980
##
runtime/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##
@@ -170,6 +175,34 @@ public UserSecretsManagerFactory userSecret
sclee01 commented on PR #1905:
URL: https://github.com/apache/polaris/pull/1905#issuecomment-2989730162
We’ve aligned on using `POLARIS,root,s3cr3t` for consistency and
searchability. All files now reflect this.
--
This is an automated message from the Apache Git Service.
To respond t
singhpk234 commented on code in PR #1686:
URL: https://github.com/apache/polaris/pull/1686#discussion_r2157976040
##
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/QueryGenerator.java:
##
@@ -208,6 +209,59 @@ static QueryFragment generat
eric-maynard commented on PR #1905:
URL: https://github.com/apache/polaris/pull/1905#issuecomment-2989656338
I'm having trouble figuring out the state of the PR based on what appear to
be two conflicting comments:
* https://github.com/apache/polaris/pull/1905#discussion_r2153433994
* h
eric-maynard commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2157938345
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/S3AccessConfig.java:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation
eric-maynard commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2157938345
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/S3AccessConfig.java:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation
eric-maynard commented on PR #1913:
URL: https://github.com/apache/polaris/pull/1913#issuecomment-2989645376
I took a quick look -- pooling the STS clients seems like a reasonable thing
to do and this approach to doing so looks pretty correct to me. However it's
not totally clear to me why
singhpk234 commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r215788
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -607,8 +829,15 @@ protected ViewMetadata commit(ViewOperat
fivetran-arunsuri commented on issue #1875:
URL: https://github.com/apache/polaris/issues/1875#issuecomment-2989455928
>They are not needed any more in JDBC. It's safe to drop them. I consider
its backward-compatible.
@flyrain We're migrating from the EclipseLink-based version of Polaris
fivetran-arunsuri commented on issue #1875:
URL: https://github.com/apache/polaris/issues/1875#issuecomment-2989449600
Thanks for the responses. Okay We will try these mentioned steps and update
here
--
This is an automated message from the Apache Git Service.
To respond to the message, p
dimas-b opened a new pull request, #1913:
URL: https://github.com/apache/polaris/pull/1913
No functional change.
Introduce a dedicated interface for StsClient suppliers and implement it
using a pool of cached clients.
All client are "thin" and share the same `SdkHttpClient`. Th
eric-maynard opened a new pull request, #1912:
URL: https://github.com/apache/polaris/pull/1912
The CLI currently only supports the version of EXTERNAL catalogs that was
present in 0.9.0. Now, EXTERNAL catalogs can be configured with various
configurations relating to federation. This PR up
adutra commented on PR #1695:
URL: https://github.com/apache/polaris/pull/1695#issuecomment-2988259372
> > > > Optional follow-up: merge polaris-server into polaris-service to
simplify the module layout (not a blocker for this PR).
> > >
> > >
> > > I'm strongly -1 on this. I'm pr
adutra merged PR #1911:
URL: https://github.com/apache/polaris/pull/1911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apac
adutra opened a new pull request, #1911:
URL: https://github.com/apache/polaris/pull/1911
Since #1897, the jobs in gradle.yaml changed and the "build" job was split
into many smaller jobs. But since it was a required job, it couldn't be removed
immediately.
--
This is an auto
19 matches
Mail list logo
