gh-yzou commented on code in PR #1908:
URL: https://github.com/apache/polaris/pull/1908#discussion_r2159744142
##
codestyle/checkstyle_suppressions.xml:
##
@@ -0,0 +1,32 @@
+
+
+https://checkstyle.org/dtds/suppressions_1_2.dtd";>
+
+
+
+
Review Comment:
Actually, i think
gh-yzou commented on code in PR #1908:
URL: https://github.com/apache/polaris/pull/1908#discussion_r2159742321
##
codestyle/checkstyle.xml:
##
@@ -26,6 +26,10 @@
+
+
Review Comment:
it is not the same, actually line 41-42 is not doing anything, the config
sa
singhpk234 merged PR #1919:
URL: https://github.com/apache/polaris/pull/1919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.
gh-yzou commented on PR #1921:
URL: https://github.com/apache/polaris/pull/1921#issuecomment-2993197504
@flyrain yes, once i got those the two PRs handled, i can take care of them
together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
gh-yzou opened a new pull request, #1921:
URL: https://github.com/apache/polaris/pull/1921
…857)"
This reverts commit 1f7f127536a088911bf940addd1d05c07ff99a68.
The shadowJar plugin actually stops publish the original jar, which is not
what spark client intend to publish for the
gh-yzou commented on code in PR #1908:
URL: https://github.com/apache/polaris/pull/1908#discussion_r2159744142
##
codestyle/checkstyle_suppressions.xml:
##
@@ -0,0 +1,32 @@
+
+
+https://checkstyle.org/dtds/suppressions_1_2.dtd";>
+
+
+
+
Review Comment:
Actually, i think
travis-bowen commented on PR #1920:
URL: https://github.com/apache/polaris/pull/1920#issuecomment-2993071147
Thanks for the input @dimas-b ! I'm pretty new to the Quarkus stuff so let
me try that out!
--
This is an automated message from the Apache Git Service.
To respond to the message,
travis-bowen commented on code in PR #1920:
URL: https://github.com/apache/polaris/pull/1920#discussion_r2159736638
##
runtime/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##
@@ -101,9 +101,16 @@ public StorageCredentialCache storageCred
travis-bowen opened a new pull request, #1920:
URL: https://github.com/apache/polaris/pull/1920
Want to be able to allow for Polaris Authorizer to be customizable at the
request level, while still maintaining existing behavior of a single
application level implementation.
--
dimas-b commented on code in PR #1908:
URL: https://github.com/apache/polaris/pull/1908#discussion_r2159728265
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/rest/GenericTable.java:
##
@@ -0,0 +1,190 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
dimas-b commented on code in PR #1908:
URL: https://github.com/apache/polaris/pull/1908#discussion_r2159726544
##
codestyle/checkstyle_suppressions.xml:
##
@@ -0,0 +1,32 @@
+
+
+https://checkstyle.org/dtds/suppressions_1_2.dtd";>
+
+
+
+
Review Comment:
Is it possible to
dimas-b commented on code in PR #1908:
URL: https://github.com/apache/polaris/pull/1908#discussion_r2159725586
##
codestyle/checkstyle.xml:
##
@@ -26,6 +26,10 @@
+
+
Review Comment:
Is this not the same as line 41?
--
This is an automated message from the
dimas-b commented on code in PR #1908:
URL: https://github.com/apache/polaris/pull/1908#discussion_r2159725586
##
codestyle/checkstyle.xml:
##
@@ -26,6 +26,10 @@
+
+
Review Comment:
Is this not the same as lines 41-42?
--
This is an automated message from
gh-yzou commented on PR #1908:
URL: https://github.com/apache/polaris/pull/1908#issuecomment-2992991777
@flyrain i added the stacktrace in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
gh-yzou commented on code in PR #1908:
URL: https://github.com/apache/polaris/pull/1908#discussion_r2159691339
##
plugins/spark/v3.5/integration/src/intTest/java/org/apache/polaris/spark/quarkus/it/PolarisManagementClient.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache
gh-yzou commented on code in PR #1908:
URL: https://github.com/apache/polaris/pull/1908#discussion_r2159691525
##
codestyle/checkstyle_no_illegalimport.xml:
##
Review Comment:
switched to use suppress rule now
--
This is an automated message from the Apache Git Service.
flyrain commented on issue #1875:
URL: https://github.com/apache/polaris/issues/1875#issuecomment-2992976483
The existing entities will continue to function as-is. The ID generation
algorithm change is self-contained and won't affect logic outside of the ID
generator itself. The only minor
flyrain commented on PR #1919:
URL: https://github.com/apache/polaris/pull/1919#issuecomment-2992930397
Thanks @singhpk234 for adding the config! Not a blocker: I think it's also
worth to add a description how the feature works!
--
This is an automated message from the Apache Git Service.
singhpk234 opened a new pull request, #1919:
URL: https://github.com/apache/polaris/pull/1919
### About the change
Adds the docs for rolling back commit conflict, the commit message has been
thorough
https://github.com/apache/polaris/commit/793cf086f1f784c36296b1ea75298a08ce608ef2
eric-maynard commented on PR #1883:
URL: https://github.com/apache/polaris/pull/1883#issuecomment-2991952129
@dimas-b I have only been loosely following that thread, but it looks like
we may be all set now?
--
This is an automated message from the Apache Git Service.
To respond to the mes
dimas-b merged PR #1905:
URL: https://github.com/apache/polaris/pull/1905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159375708
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
flyrain merged PR #1883:
URL: https://github.com/apache/polaris/pull/1883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159373065
##
runtime/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##
@@ -170,6 +175,34 @@ public UserSecretsManagerFactory userSecretsMa
flyrain commented on code in PR #1915:
URL: https://github.com/apache/polaris/pull/1915#discussion_r2159494774
##
site/content/release-guide.md:
##
@@ -183,6 +183,22 @@ Next, you have to close the staging repository:
4. At the top, select "Close" and follow the instructions
5.
flyrain commented on code in PR #1915:
URL: https://github.com/apache/polaris/pull/1915#discussion_r2159490029
##
site/content/release-guide.md:
##
@@ -101,13 +101,13 @@ If it's the first RC for the release, you have to create
a release branch:
```
git branch release/x.y.z
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159282540
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
singhpk234 commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159283045
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation
singhpk234 commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2158001989
##
runtime/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##
@@ -170,6 +175,34 @@ public UserSecretsManagerFactory userSecret
snazy opened a new pull request, #1918:
URL: https://github.com/apache/polaris/pull/1918
Looks like parallel admin-tool tests can run into port-clashes, that should
not occur on port 8081.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
dimas-b commented on PR #1913:
URL: https://github.com/apache/polaris/pull/1913#issuecomment-2992086094
> Could we instead start more top-down with S3-compatible storage support
and figure out if these changes are actually necessary?
I can do that, but the diff is going to be large ;)
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159278045
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159371518
##
runtime/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##
@@ -170,6 +175,34 @@ public UserSecretsManagerFactory userSecretsMa
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159373601
##
runtime/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##
@@ -170,6 +175,34 @@ public UserSecretsManagerFactory userSecretsMa
flyrain commented on PR #1910:
URL: https://github.com/apache/polaris/pull/1910#issuecomment-2992396404
> NB: we should try to use `versioned-docs` branch. See
[237ce0c](https://github.com/apache/polaris/commit/237ce0c86a05eea4ef768caded15c20f746a1400)
Thanks @jbonofre ! What's the pl
dimas-b commented on issue #1917:
URL: https://github.com/apache/polaris/issues/1917#issuecomment-2992203026
@singhpk234 : do you have any WIP PR for supporting this on the Iceberg side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159367094
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/S3AccessConfig.java:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
flyrain commented on code in PR #1908:
URL: https://github.com/apache/polaris/pull/1908#discussion_r2159414955
##
plugins/spark/v3.5/spark/build.gradle.kts:
##
@@ -78,15 +57,9 @@ dependencies {
exclude("org.apache.commons", "*")
}
- implementation("org.apache.iceberg:
singhpk234 commented on issue #1917:
URL: https://github.com/apache/polaris/issues/1917#issuecomment-2992292845
Not so far i am planning to raise this soon, we just need builder to expose
lastSequenceNumber
--
This is an automated message from the Apache Git Service.
To respond to the mes
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159367679
##
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/StsClientSupplier.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159278045
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
dimas-b commented on PR #1913:
URL: https://github.com/apache/polaris/pull/1913#issuecomment-2992243353
Marking this PR as "draft" to add end-to-end support for MinIO. Please feel
free to comment anyway.
--
This is an automated message from the Apache Git Service.
To respond to the messag
dimas-b commented on code in PR #1908:
URL: https://github.com/apache/polaris/pull/1908#discussion_r2159332717
##
codestyle/checkstyle_no_illegalimport.xml:
##
Review Comment:
I'm not sure this approach is ideal for making exceptions to Checkstyle
rules.
@adutra :
dimas-b commented on PR #1908:
URL: https://github.com/apache/polaris/pull/1908#issuecomment-2992182086
I raised some concerns about this PR on the dev ML:
https://lists.apache.org/thread/0z30f3cfvm41hxlbxgp4fqdpv7mfgnv8
Let's resolve that discussion before merging.
--
This is an a
singhpk234 commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2157998980
##
runtime/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##
@@ -170,6 +175,34 @@ public UserSecretsManagerFactory userSecret
snazy merged PR #1797:
URL: https://github.com/apache/polaris/pull/1797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
flyrain commented on code in PR #1908:
URL: https://github.com/apache/polaris/pull/1908#discussion_r2159306810
##
plugins/spark/v3.5/integration/build.gradle.kts:
##
@@ -45,9 +45,13 @@ dependencies {
implementation(project(":polaris-runtime-service"))
- testImplementatio
flyrain commented on PR #1908:
URL: https://github.com/apache/polaris/pull/1908#issuecomment-2992158105
A minor suggestion, would you mind sharing the error msg/stack trace of the
issue the PR trying to fix? This will provide more context people who track
this issue.
--
This is an autom
dimas-b commented on PR #1883:
URL: https://github.com/apache/polaris/pull/1883#issuecomment-2992155717
The question of re-branch from `main` has been settled, indeed, so I'm ok
with merging this PR. No re-branching per:
https://lists.apache.org/thread/m4lfwo9lkwjj8gjhqm8no5nhlnd2cdhq
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159271954
##
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/StsClientSupplier.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
singhpk234 commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159303274
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation
flyrain commented on code in PR #1908:
URL: https://github.com/apache/polaris/pull/1908#discussion_r2159302577
##
plugins/spark/v3.5/integration/src/intTest/java/org/apache/polaris/spark/quarkus/it/PolarisManagementClient.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache
singhpk234 commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159292996
##
runtime/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##
@@ -170,6 +175,34 @@ public UserSecretsManagerFactory userSecret
singhpk234 commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2158007526
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159294053
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
dimas-b commented on PR #1913:
URL: https://github.com/apache/polaris/pull/1913#issuecomment-2992116158
@singhpk234 : Sorry, I do not see your comments (even via above links).
Could you re-summit them?
--
This is an automated message from the Apache Git Service.
To respond to the message,
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159273930
##
runtime/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##
@@ -170,6 +175,34 @@ public UserSecretsManagerFactory userSecretsMa
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159286263
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2159275602
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
singhpk234 commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2159185184
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -433,39 +450,203 @@ protected TableMetadata commit(TableOp
singhpk234 merged PR #1285:
URL: https://github.com/apache/polaris/pull/1285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.
singhpk234 opened a new issue, #1917:
URL: https://github.com/apache/polaris/issues/1917
### Is your feature request related to a problem? Please describe.
Details : https://github.com/apache/polaris/pull/1285#discussion_r2138517000
### Describe the solution you'd like
_N
dimas-b commented on PR #1905:
URL: https://github.com/apache/polaris/pull/1905#issuecomment-2991843946
This PR moves all default / example credentials to `s3cr3t` as far as I can
tell. I'm fine with this approach.
--
This is an automated message from the Apache Git Service.
To respond to
singhpk234 commented on PR #1285:
URL: https://github.com/apache/polaris/pull/1285#issuecomment-2991949935
Thank you @eric-maynard @dimas-b @RussellSpitzer @snazy for the reviews !
This feature is gonna be really helpful for Polaris users !
--
This is an automated message from the
singhpk234 commented on PR #1285:
URL: https://github.com/apache/polaris/pull/1285#issuecomment-2991912593
@snazy its even configurable at a snapshot level the writers need to add a
property to consider it applicable to the feature, so IMHO its even more
granular than table, i initially sta
monali45 opened a new issue, #1916:
URL: https://github.com/apache/polaris/issues/1916
### Describe the bug
I m using quickstart guide
```
export ASSETS_PATH=$(pwd)/getting-started/assets/
export QUARKUS_DATASOURCE_JDBC_URL=$(printf '%s'
"jdbc:postgresql:///postgres")
singhpk234 commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2159131074
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -85,24 +96,51 @@
import org.apache.polaris.core.config.Fe
dimas-b commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2159118735
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##
@@ -85,24 +96,51 @@
import org.apache.polaris.core.config.Featu
adutra commented on code in PR #1915:
URL: https://github.com/apache/polaris/pull/1915#discussion_r2158964017
##
site/content/release-guide.md:
##
@@ -183,6 +183,22 @@ Next, you have to close the staging repository:
4. At the top, select "Close" and follow the instructions
5.
jbonofre opened a new pull request, #1915:
URL: https://github.com/apache/polaris/pull/1915
I found a few typos in the release guide.
I'm also using this PR to add a section about Docker image staging in the
release guide.
--
This is an automated message from the Apache Git Service
70 matches
Mail list logo
