Re: [I] Consider changing the repo setting to change how the default message is generated [polaris]

2025-07-08 Thread via GitHub
ajantha-bhat commented on issue #1656: URL: https://github.com/apache/polaris/issues/1656#issuecomment-3051200329 I have raised an ASF ticket for the same https://issues.apache.org/jira/browse/INFRA-26990. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [I] Consider changing the repo setting to change how the default message is generated [polaris]

2025-07-08 Thread via GitHub
ajantha-bhat commented on issue #1656: URL: https://github.com/apache/polaris/issues/1656#issuecomment-3051141771 @jbonofre: Do you have any update on this? If not, I will check with ASF infra regarding this. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Publish Helm README.md in https://polaris.apache.org/ [polaris]

2025-07-08 Thread via GitHub
MonkeyCanCode commented on issue #1323: URL: https://github.com/apache/polaris/issues/1323#issuecomment-3051105796 This is completed (manually for now...automation will come soon): https://github.com/apache/polaris/pull/2014 -- This is an automated message from the Apache Git Service. To

Re: [I] Build always fail on a fresh repo for the first build attempt [polaris]

2025-07-08 Thread via GitHub
MonkeyCanCode commented on issue #1976: URL: https://github.com/apache/polaris/issues/1976#issuecomment-3051098563 No longer reproducible with latest main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Build always fail on a fresh repo for the first build attempt [polaris]

2025-07-08 Thread via GitHub
MonkeyCanCode closed issue #1976: Build always fail on a fresh repo for the first build attempt URL: https://github.com/apache/polaris/issues/1976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Publish helm doc [polaris]

2025-07-08 Thread via GitHub
MonkeyCanCode opened a new pull request, #2014: URL: https://github.com/apache/polaris/pull/2014 This PR does one time publication of helm doc into hugo. As discussed in https://github.com/apache/polaris/pull/2006, we will enable automation for this workflow in the following PR. -- This

Re: [PR] Publish helm doc to hugo site [polaris]

2025-07-08 Thread via GitHub
MonkeyCanCode closed pull request #2006: Publish helm doc to hugo site URL: https://github.com/apache/polaris/pull/2006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Publish helm doc to hugo site [polaris]

2025-07-08 Thread via GitHub
MonkeyCanCode commented on PR #2006: URL: https://github.com/apache/polaris/pull/2006#issuecomment-3051040298 > > realized that the Helm README.md is generated, but there's nothing that guarantees that the file is up to date. I think, it would be better to not track the generated README.md

Re: [PR] Rename SUPPORTED_CATALOG_CONNECTION_TYPES [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on code in PR #1959: URL: https://github.com/apache/polaris/pull/1959#discussion_r2193911983 ## polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java: ## @@ -34,11 +35,12 @@ public class BehaviorChangeConfiguration exte

Re: [PR] Rename SUPPORTED_CATALOG_CONNECTION_TYPES [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on code in PR #1959: URL: https://github.com/apache/polaris/pull/1959#discussion_r2193911983 ## polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java: ## @@ -34,11 +35,12 @@ public class BehaviorChangeConfiguration exte

Re: [PR] Add `pathStyleAccess` to AwsStorageConfigInfo [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on code in PR #2012: URL: https://github.com/apache/polaris/pull/2012#discussion_r2193909029 ## spec/polaris-management-service.yml: ## @@ -1056,6 +1056,12 @@ components: type: string description: endpoint for STS requests (op

Re: [PR] Add `pathStyleAccess` to AwsStorageConfigInfo [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on code in PR #2012: URL: https://github.com/apache/polaris/pull/2012#discussion_r2193908312 ## polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java: ## @@ -71,21 +76,23 @@ public AwsStorageConfigurationInfo(

Re: [PR] Add `pathStyleAccess` to AwsStorageConfigInfo [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on code in PR #2012: URL: https://github.com/apache/polaris/pull/2012#discussion_r2193907919 ## polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java: ## @@ -71,21 +76,23 @@ public AwsStorageConfigurationInfo(

Re: [PR] Fix doc to remove privileges may take up to one hour to take effect and add Policy to securable object [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on code in PR #2009: URL: https://github.com/apache/polaris/pull/2009#discussion_r2193905818 ## site/content/in-dev/unreleased/access-control.md: ## @@ -43,6 +43,7 @@ has the following securable objects: - Namespace - Iceberg table - View +- Policy Rev

Re: [PR] Add External Identity Providers page to unreleased documentation [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on code in PR #2013: URL: https://github.com/apache/polaris/pull/2013#discussion_r2193896274 ## site/content/in-dev/unreleased/external-idp.md: ## @@ -0,0 +1,344 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

Re: [PR] Add External Identity Providers page to unreleased documentation [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on PR #2013: URL: https://github.com/apache/polaris/pull/2013#issuecomment-3050928760 cc @adutra / @collado-mike for visibility -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Remove circular dependency between entity and api schema [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on PR #1990: URL: https://github.com/apache/polaris/pull/1990#issuecomment-3050918650 +1 @flyrain, your comment reminds me of the discussion on [this other PR](https://github.com/apache/polaris/pull/1899#issuecomment-2977562907). Unfortunately right now the `...Entity

Re: [PR] [PROPOSAL] Add Context-Aware Functions for Apache Polaris [polaris]

2025-07-08 Thread via GitHub
github-actions[bot] commented on PR #1620: URL: https://github.com/apache/polaris/pull/1620#issuecomment-3050880334 This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. -- This is an automated message from the

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
gh-yzou commented on PR #2011: URL: https://github.com/apache/polaris/pull/2011#issuecomment-3050844978 I see you updated the description with just one release page now, that should be good enough -- This is an automated message from the Apache Git Service. To respond to the message, plea

[PR] Add External Identity Providers page to unreleased documentation [polaris]

2025-07-08 Thread via GitHub
markhoerth opened a new pull request, #2013: URL: https://github.com/apache/polaris/pull/2013 Adds a new documentation page explaining how to configure external identity providers for authentication in Apache Polaris. The page provides setup guidance and examples for using OIDC wi

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
gh-yzou commented on PR #2011: URL: https://github.com/apache/polaris/pull/2011#issuecomment-3050673724 @flyrain you might want to update the description since it doesn't match what this PR is actually doing now -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
gh-yzou commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193672471 ## site/content/downloads/current-release.md: ## @@ -0,0 +1,33 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
flyrain commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193671118 ## site/content/downloads/current-release.md: ## @@ -0,0 +1,33 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
flyrain commented on PR #2011: URL: https://github.com/apache/polaris/pull/2011#issuecomment-3050676879 > @flyrain you might want to update the description since it doesn't match what this PR is actually doing now any suggestion for the description? -- This is an automated message

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
flyrain commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193576712 ## site/hugo.yaml: ## @@ -93,9 +93,6 @@ imaging: menu: main: -- name: GitHub - url: https://github.com/apache/polaris - Review Comment: This change m

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
flyrain commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193654184 ## site/content/downloads/current-release.md: ## @@ -0,0 +1,33 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
gh-yzou commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193644510 ## site/content/downloads/current-release.md: ## @@ -0,0 +1,33 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

[PR] Add `pathStyleAccess` to AwsStorageConfigInfo [polaris]

2025-07-08 Thread via GitHub
dimas-b opened a new pull request, #2012: URL: https://github.com/apache/polaris/pull/2012 This change allows configuring the "path-style" access mode in S3 clients (both in Polaris Servers and Iceberg REST Catalog API clients). This change is applicable both to AWS storage and to non

Re: [PR] Publish 1.0.0 documents [polaris]

2025-07-08 Thread via GitHub
flyrain commented on PR #1910: URL: https://github.com/apache/polaris/pull/1910#issuecomment-3050594688 @snazy moved it to a new dir(`releases`) as you suggested -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
flyrain commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193608472 ## site/content/downloads/current-release.md: ## @@ -0,0 +1,33 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
dimas-b commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193628477 ## site/content/downloads/current-release.md: ## @@ -0,0 +1,33 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] Cleanup collaborators in `.asf.yaml` [polaris]

2025-07-08 Thread via GitHub
dimas-b merged PR #2008: URL: https://github.com/apache/polaris/pull/2008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
flyrain commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193622621 ## site/content/downloads/current-release.md: ## @@ -0,0 +1,33 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
dimas-b commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193616093 ## site/content/downloads/current-release.md: ## @@ -0,0 +1,33 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
flyrain commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193613423 ## site/content/downloads/current-release.md: ## @@ -0,0 +1,33 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
dimas-b commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193613630 ## site/content/downloads/current-release.md: ## @@ -0,0 +1,33 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
flyrain commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193613423 ## site/content/downloads/current-release.md: ## @@ -0,0 +1,33 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
flyrain commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193611372 ## site/content/downloads/current-release.md: ## @@ -0,0 +1,33 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
flyrain commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193608472 ## site/content/downloads/current-release.md: ## @@ -0,0 +1,33 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
dimas-b commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193598100 ## site/content/downloads/current-release.md: ## @@ -0,0 +1,33 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
dimas-b commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193592805 ## site/content/downloads/current-release.md: ## @@ -0,0 +1,33 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
flyrain commented on code in PR #2011: URL: https://github.com/apache/polaris/pull/2011#discussion_r2193576712 ## site/hugo.yaml: ## @@ -93,9 +93,6 @@ imaging: menu: main: -- name: GitHub - url: https://github.com/apache/polaris - Review Comment: This change m

[PR] Restructure the download page [polaris]

2025-07-08 Thread via GitHub
flyrain opened a new pull request, #2011: URL: https://github.com/apache/polaris/pull/2011 Before: https://github.com/user-attachments/assets/c1ca7bf4-4178-469b-895b-13456c27bc39"; /> After: https://github.com/user-attachments/assets/439331a7-ffac-4623-9ea5-a6b4c4bbd041"; /> htt

Re: [PR] Add Delegation Service Module and REST Framework [polaris]

2025-07-08 Thread via GitHub
williamhyun commented on code in PR #1981: URL: https://github.com/apache/polaris/pull/1981#discussion_r2193498561 ## delegation-service/src/main/java/org/apache/polaris/delegation/api/DelegationApi.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Add KMS support for S3 [polaris]

2025-07-08 Thread via GitHub
pavibhai commented on code in PR #1424: URL: https://github.com/apache/polaris/pull/1424#discussion_r2193493293 ## polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java: ## @@ -298,4 +298,12 @@ public static void enforceFeatureEnabledOrThrow(

[I] Support database bootstrap in the admin tool [polaris]

2025-07-08 Thread via GitHub
dimas-b opened a new issue, #2010: URL: https://github.com/apache/polaris/issues/2010 ### Is your feature request related to a problem? Please describe. Currently the [Admin Tool](https://github.com/apache/polaris/tree/main/runtime/admin) has a `bootstrap` command that initializes "r

Re: [PR] Initial integration for hudi tables within Polaris [polaris]

2025-07-08 Thread via GitHub
gh-yzou commented on code in PR #1862: URL: https://github.com/apache/polaris/pull/1862#discussion_r2190961940 ## plugins/spark/v3.5/integration/src/intTest/resources/logback.xml: ## @@ -32,6 +32,9 @@ out the configuration if you would like ot see all spark debug log during the

Re: [PR] Initial integration for hudi tables within Polaris [polaris]

2025-07-08 Thread via GitHub
gh-yzou commented on PR #1862: URL: https://github.com/apache/polaris/pull/1862#issuecomment-3050223421 @rahil-c sorry, i made my comment yesterday, but forgot to push it. I did a push, and added some more comments, please let me know if you have more questions about this! As we have di

Re: [PR] Add KMS support for S3 [polaris]

2025-07-08 Thread via GitHub
flyrain commented on code in PR #1424: URL: https://github.com/apache/polaris/pull/1424#discussion_r2193370359 ## polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java: ## @@ -298,4 +298,12 @@ public static void enforceFeatureEnabledOrThrow(

Re: [PR] Remove circular dependency between entity and api schema [polaris]

2025-07-08 Thread via GitHub
flyrain commented on PR #1990: URL: https://github.com/apache/polaris/pull/1990#issuecomment-3050192078 `PolarisEntityCore` and its derived classes serve as business objects shared across multiple persistence backends. They are not persistence model types themselves. I’m open to relocating

Re: [PR] Initial integration for hudi tables within Polaris [polaris]

2025-07-08 Thread via GitHub
gh-yzou commented on code in PR #1862: URL: https://github.com/apache/polaris/pull/1862#discussion_r2193312774 ## plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java: ## @@ -263,25 +279,39 @@ public String[][] listNamespaces(String[] namespace) thr

Re: [PR] Introduce an option to add object storage prefix to table locations [polaris]

2025-07-08 Thread via GitHub
eric-maynard merged PR #1966: URL: https://github.com/apache/polaris/pull/1966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polari

Re: [PR] feat(auth): Ability to override active roles provider per realm [polaris]

2025-07-08 Thread via GitHub
dimas-b commented on code in PR #2000: URL: https://github.com/apache/polaris/pull/2000#discussion_r2193300845 ## runtime/defaults/src/main/resources/application.properties: ## @@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second= polaris.rate-limiter.t

Re: [PR] feat(auth): Ability to override active roles provider per realm [polaris]

2025-07-08 Thread via GitHub
dimas-b merged PR #2000: URL: https://github.com/apache/polaris/pull/2000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] Initial integration for hudi tables within Polaris [polaris]

2025-07-08 Thread via GitHub
gh-yzou commented on code in PR #1862: URL: https://github.com/apache/polaris/pull/1862#discussion_r2190961940 ## plugins/spark/v3.5/integration/src/intTest/resources/logback.xml: ## @@ -32,6 +32,9 @@ out the configuration if you would like ot see all spark debug log during the

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on code in PR #2007: URL: https://github.com/apache/polaris/pull/2007#discussion_r2193169188 ## polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java: ## @@ -124,6 +124,18 @@ T cast(Object value) { return this.typ.cast(va

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on code in PR #2007: URL: https://github.com/apache/polaris/pull/2007#discussion_r2193159633 ## polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java: ## @@ -124,6 +124,18 @@ T cast(Object value) { return this.typ.cast(va

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-08 Thread via GitHub
dimas-b commented on code in PR #2007: URL: https://github.com/apache/polaris/pull/2007#discussion_r2193124147 ## polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java: ## @@ -124,6 +124,18 @@ T cast(Object value) { return this.typ.cast(value);

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-08 Thread via GitHub
dimas-b commented on code in PR #2007: URL: https://github.com/apache/polaris/pull/2007#discussion_r2193126197 ## polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java: ## @@ -124,6 +124,18 @@ T cast(Object value) { return this.typ.cast(value);

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-08 Thread via GitHub
dimas-b commented on code in PR #2007: URL: https://github.com/apache/polaris/pull/2007#discussion_r2193124147 ## polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java: ## @@ -124,6 +124,18 @@ T cast(Object value) { return this.typ.cast(value);

Re: [I] [FEATURE REQUEST] Document how to setup, configure and use multi-realms [polaris]

2025-07-08 Thread via GitHub
flyrain commented on issue #308: URL: https://github.com/apache/polaris/issues/308#issuecomment-3049824855 The "Admin-tool" page covers a lot of ground, this dedicated "realm" page(https://polaris.apache.org/in-dev/unreleased/realm/) for realm is the one telling a complete story. I think we

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-08 Thread via GitHub
poojanilangekar commented on code in PR #2007: URL: https://github.com/apache/polaris/pull/2007#discussion_r2193005068 ## polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java: ## @@ -124,6 +124,18 @@ T cast(Object value) { return this.typ.cast

Re: [PR] Add polaris-spark-bundle project to help packing and publish the Spark Client shadow Jar [polaris]

2025-07-08 Thread via GitHub
gh-yzou commented on PR #1991: URL: https://github.com/apache/polaris/pull/1991#issuecomment-3049763314 @snazy I don't need a separate project to publish both Jars (polaris-spark-3.5_2.13-1.1.0-incubating-SNAPSHOT.jar and polaris-spark-3.5_2.12-1.1.0-incubating-SNAPSHOT-bundle.jar). This is

Re: [I] Consider changing the repo setting to change how the default message is generated [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on issue #1656: URL: https://github.com/apache/polaris/issues/1656#issuecomment-3049684441 Hey @jbonofre / @ajantha-bhat just wanted to check in on this again -- I'm still manually copying the descriptions into the commit message :) -- This is an automated message f

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-08 Thread via GitHub
poojanilangekar commented on code in PR #2007: URL: https://github.com/apache/polaris/pull/2007#discussion_r2193005068 ## polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java: ## @@ -124,6 +124,18 @@ T cast(Object value) { return this.typ.cast

Re: [PR] Add Delegation Service Module and REST Framework [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on code in PR #1981: URL: https://github.com/apache/polaris/pull/1981#discussion_r2193004598 ## delegation-service/src/main/java/org/apache/polaris/delegation/api/DelegationApi.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on code in PR #2007: URL: https://github.com/apache/polaris/pull/2007#discussion_r2192994774 ## polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java: ## @@ -124,6 +124,18 @@ T cast(Object value) { return this.typ.cast(va

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on code in PR #2007: URL: https://github.com/apache/polaris/pull/2007#discussion_r2192994774 ## polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java: ## @@ -124,6 +124,18 @@ T cast(Object value) { return this.typ.cast(va

Re: [PR] Add Delegation Service Module and REST Framework [polaris]

2025-07-08 Thread via GitHub
jbonofre commented on code in PR #1981: URL: https://github.com/apache/polaris/pull/1981#discussion_r2192985883 ## delegation-service/src/main/java/org/apache/polaris/delegation/api/DelegationApi.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add Delegation Service Module and REST Framework [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on PR #1981: URL: https://github.com/apache/polaris/pull/1981#issuecomment-3049626190 Hey @dimas-b, is there a particular thread on the ML you're looking to close? The most recent message from you just says `I'll certainly have a deeper look later` but that was a coup

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 1: Entity Transformation System [polaris]

2025-07-08 Thread via GitHub
XJDKC commented on PR #1899: URL: https://github.com/apache/polaris/pull/1899#issuecomment-3049624280 Update from slack: We may lean to remove the Entity Transformation System but inject service identity directly. We have three possible injection points: * **Option 1**: Persist only

Re: [PR] Add Delegation Service Module and REST Framework [polaris]

2025-07-08 Thread via GitHub
eric-maynard commented on code in PR #1981: URL: https://github.com/apache/polaris/pull/1981#discussion_r2192981115 ## delegation-service/src/main/java/org/apache/polaris/delegation/api/DelegationApi.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Add Delegation Service Module and REST Framework [polaris]

2025-07-08 Thread via GitHub
jbonofre commented on code in PR #1981: URL: https://github.com/apache/polaris/pull/1981#discussion_r2192954978 ## delegation-service/src/main/java/org/apache/polaris/delegation/api/DelegationApi.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-08 Thread via GitHub
poojanilangekar commented on code in PR #2007: URL: https://github.com/apache/polaris/pull/2007#discussion_r2192861661 ## polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java: ## @@ -124,6 +124,18 @@ T cast(Object value) { return this.typ.cast

Re: [PR] Rename SUPPORTED_CATALOG_CONNECTION_TYPES [polaris]

2025-07-08 Thread via GitHub
poojanilangekar commented on code in PR #1959: URL: https://github.com/apache/polaris/pull/1959#discussion_r2192851849 ## polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java: ## @@ -34,11 +35,12 @@ public class BehaviorChangeConfiguration e

Re: [I] [FEATURE REQUEST] Document how to setup, configure and use multi-realms [polaris]

2025-07-08 Thread via GitHub
adam-christian-software commented on issue #308: URL: https://github.com/apache/polaris/issues/308#issuecomment-3049355665 @flyrain - I believe we have done this via the documentation for the Admin Tool in 1.0, right? https://polaris.apache.org/in-dev/unreleased/admin-tool/ @Pr

Re: [PR] Fix helm doc [polaris]

2025-07-08 Thread via GitHub
MonkeyCanCode merged PR #2001: URL: https://github.com/apache/polaris/pull/2001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polar

Re: [PR] Add KMS support for S3 [polaris]

2025-07-08 Thread via GitHub
pavibhai commented on code in PR #1424: URL: https://github.com/apache/polaris/pull/1424#discussion_r2192675939 ## polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java: ## @@ -298,4 +298,12 @@ public static void enforceFeatureEnabledOrThrow(

Re: [PR] Add KMS support for S3 [polaris]

2025-07-08 Thread via GitHub
pavibhai commented on code in PR #1424: URL: https://github.com/apache/polaris/pull/1424#discussion_r2192655627 ## polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java: ## @@ -185,7 +184,14 @@ private IamPolicy policyString( b

Re: [PR] Add KMS support for S3 [polaris]

2025-07-08 Thread via GitHub
pavibhai commented on PR #1424: URL: https://github.com/apache/polaris/pull/1424#issuecomment-3049143949 @fivetran-ashokborra Thanks for working on this. I wanted to see if this is still being actively pursued? We are interested in support the bucket keys in credential vending i.e. when ven

Re: [PR] Add KMS support for S3 [polaris]

2025-07-08 Thread via GitHub
pavibhai commented on code in PR #1424: URL: https://github.com/apache/polaris/pull/1424#discussion_r2192643775 ## polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java: ## @@ -198,7 +206,32 @@ private IamPolicy policyString( b

Re: [PR] Publish helm doc to hugo site [polaris]

2025-07-08 Thread via GitHub
adutra commented on PR #2006: URL: https://github.com/apache/polaris/pull/2006#issuecomment-3049011368 > realized that the Helm README.md is generated, but there's nothing that guarantees that the file is up to date. I think, it would be better to not track the generated README.md in Git or

Re: [PR] Fix helm doc [polaris]

2025-07-08 Thread via GitHub
adutra commented on code in PR #2001: URL: https://github.com/apache/polaris/pull/2001#discussion_r2192532625 ## helm/polaris/README.md.gotmpl: ## @@ -96,15 +81,14 @@ The below instructions assume a local Kubernetes cluster is running and Helm is Common setup Create th

Re: [PR] feat(auth): Ability to override active roles provider per realm [polaris]

2025-07-08 Thread via GitHub
adutra commented on code in PR #2000: URL: https://github.com/apache/polaris/pull/2000#discussion_r2192500053 ## runtime/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java: ## @@ -341,9 +342,12 @@ public QuarkusAuthenticationRealmConfiguration

Re: [PR] feat(auth): Ability to override active roles provider per realm [polaris]

2025-07-08 Thread via GitHub
adutra commented on code in PR #2000: URL: https://github.com/apache/polaris/pull/2000#discussion_r2192494079 ## runtime/defaults/src/main/resources/application.properties: ## @@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second= polaris.rate-limiter.to

Re: [PR] feat(auth): Ability to override active roles provider per realm [polaris]

2025-07-08 Thread via GitHub
adutra commented on code in PR #2000: URL: https://github.com/apache/polaris/pull/2000#discussion_r2192492730 ## runtime/defaults/src/main/resources/application.properties: ## @@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second= polaris.rate-limiter.to

Re: [PR] feat(auth): Ability to override active roles provider per realm [polaris]

2025-07-08 Thread via GitHub
dimas-b commented on code in PR #2000: URL: https://github.com/apache/polaris/pull/2000#discussion_r2192457575 ## runtime/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java: ## @@ -341,9 +342,12 @@ public QuarkusAuthenticationRealmConfiguration

Re: [PR] Fix doc to remove privileges may take up to one hour to take effect and add Policy to securable object [polaris]

2025-07-08 Thread via GitHub
Copilot commented on code in PR #2009: URL: https://github.com/apache/polaris/pull/2009#discussion_r2192152348 ## site/content/in-dev/unreleased/access-control.md: ## @@ -43,6 +43,7 @@ has the following securable objects: - Namespace - Iceberg table - View +- Policy Review C

[PR] Fix doc to remove privileges may take up to one hour to take effect and add Policy to securable object [polaris]

2025-07-08 Thread via GitHub
cgpoh opened a new pull request, #2009: URL: https://github.com/apache/polaris/pull/2009 Minor update for the access control doc: 1. Remove the misleading section on privileges granted may take up to one hour to take effect. I've tested granting the privileges and confirmed that t

Re: [PR] feat(auth): Ability to override active roles provider per realm [polaris]

2025-07-08 Thread via GitHub
adutra commented on code in PR #2000: URL: https://github.com/apache/polaris/pull/2000#discussion_r2192108267 ## runtime/defaults/src/main/resources/application.properties: ## @@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second= polaris.rate-limiter.to

[PR] Cleanup collaborators in `.asf.yaml` [polaris]

2025-07-08 Thread via GitHub
snazy opened a new pull request, #2008: URL: https://github.com/apache/polaris/pull/2008 Some devs were added in the past to `.asf.yaml` to let CI run w/o committer approval. After [INFRA-26985](https://issues.apache.org/jira/browse/INFRA-26985) this is no longer necessary, so the file can

Re: [PR] Publish helm doc to hugo site [polaris]

2025-07-08 Thread via GitHub
snazy commented on PR #2006: URL: https://github.com/apache/polaris/pull/2006#issuecomment-3047791792 I wonder whether it's not easier to just copy the README.md file from `helm/polaris` to `site/content/in-dev/unreleased` when it's generated. The workflow for releases is to take what's i

Re: [PR] Add polaris-spark-bundle project to help packing and publish the Spark Client shadow Jar [polaris]

2025-07-08 Thread via GitHub
snazy commented on PR #1991: URL: https://github.com/apache/polaris/pull/1991#issuecomment-3047708068 @gh-yzou I still do not understand why you need to add a new Gradle project just to have one other jar. It is possible to build and publish both the "raw" and the "shadow" jar from a single

Re: [PR] Remove circular dependency between entity and api schema [polaris]

2025-07-08 Thread via GitHub
snazy commented on PR #1990: URL: https://github.com/apache/polaris/pull/1990#issuecomment-3047689705 The overall concern I raised in #780 is that the low-level persistence model depends on higher-level public API types. So this change to remove the direct dependencies from the persistenc