Re: [PR] Publish helm doc [polaris]

2025-07-10 Thread via GitHub
MonkeyCanCode commented on PR #2014: URL: https://github.com/apache/polaris/pull/2014#issuecomment-3060688450 > I think we on the same page. It's great to have doc for Helm for sure, but maintaining two exact copies isn't. One option is having the complete doc page in Polaris website only,

Re: [I] Hosted helm chart in a Helm Repository [polaris]

2025-07-10 Thread via GitHub
flyrain commented on issue #1269: URL: https://github.com/apache/polaris/issues/1269#issuecomment-3060665350 The Helm Chart has been published along with the release 1.0.0. Repo: https://downloads.apache.org/incubator/polaris/helm-chart -- This is an automated message from the Apache G

[PR] Remove kind [polaris]

2025-07-10 Thread via GitHub
MonkeyCanCode opened a new pull request, #2028: URL: https://github.com/apache/polaris/pull/2028 This PR remove reference for `kind` and we will be only supporting `minikube` going forward. Details in mailing thread: https://lists.apache.org/thread/cmf1rcpsd7nv7jx79wvbl5pymhltrhg5 -- Thi

Re: [I] Hosted helm chart in a Helm Repository [polaris]

2025-07-10 Thread via GitHub
flyrain closed issue #1269: Hosted helm chart in a Helm Repository URL: https://github.com/apache/polaris/issues/1269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[PR] Use Makefile to simplify setup and commands [polaris]

2025-07-10 Thread via GitHub
MonkeyCanCode opened a new pull request, #2027: URL: https://github.com/apache/polaris/pull/2027 This PR brings in a root-level Makefile to simplify and centralize how we set up our development environment and run common build tasks for Polaris. **The Problem I Noticed:** Right now

Re: [PR] Publish helm doc [polaris]

2025-07-10 Thread via GitHub
flyrain commented on PR #2014: URL: https://github.com/apache/polaris/pull/2014#issuecomment-3060506504 I think we on the same page. It's great to have doc for Helm for sure, but maintaining two exact copies isn't. One option is having the complete doc page in Polaris website only, and to a

Re: [I] Website docs issues after 1.0.0 release [polaris]

2025-07-10 Thread via GitHub
MonkeyCanCode commented on issue #2024: URL: https://github.com/apache/polaris/issues/2024#issuecomment-3060100306 For `"in-dev docs warning" not highlighted`, this issue I am award and reported to @jbonofre as well. This is due to changes made in https://github.com/apache/polaris/pull/1967

Re: [PR] Publish helm doc [polaris]

2025-07-10 Thread via GitHub
MonkeyCanCode commented on PR #2014: URL: https://github.com/apache/polaris/pull/2014#issuecomment-3060077550 > > The reason why we will have a file there within the helm repo is due to helm-doc rendering. > > I'm not quite familiar with Helm use cases. Do helm end users really care

Re: [PR] Use the 0.9.0 doc from the releases branch [polaris]

2025-07-10 Thread via GitHub
flyrain commented on code in PR #2026: URL: https://github.com/apache/polaris/pull/2026#discussion_r2199320157 ## site/hugo.yaml: ## @@ -98,19 +98,18 @@ menu: weight: 100 params: orderby: weight.desc -- name: "All Releases" - identifier: "all-rele

[PR] Use the 0.9.0 doc from the releases branch [polaris]

2025-07-10 Thread via GitHub
flyrain opened a new pull request, #2026: URL: https://github.com/apache/polaris/pull/2026 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Use isolated request contexts for task execution [polaris]

2025-07-10 Thread via GitHub
github-actions[bot] commented on PR #1817: URL: https://github.com/apache/polaris/pull/1817#issuecomment-3059993463 This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. -- This is an automated message from the

Re: [PR] Publish helm doc [polaris]

2025-07-10 Thread via GitHub
flyrain commented on PR #2014: URL: https://github.com/apache/polaris/pull/2014#issuecomment-3059988611 > The reason why we will have a file there within the helm repo is due to helm-doc rendering. I'm not quite familiar with Helm use cases. Do helm end users really care about helm-

Re: [PR] Publish helm doc [polaris]

2025-07-10 Thread via GitHub
MonkeyCanCode merged PR #2014: URL: https://github.com/apache/polaris/pull/2014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polar

Re: [PR] Publish helm doc [polaris]

2025-07-10 Thread via GitHub
MonkeyCanCode commented on PR #2014: URL: https://github.com/apache/polaris/pull/2014#issuecomment-3059942302 > LGTM > Not a blocker: I'm just a bit concern about the sync between two directories. Is it OK to not have a README within `helm/Polaris`, or just have a dummy one without worry

Re: [PR] Publish helm doc [polaris]

2025-07-10 Thread via GitHub
flyrain commented on PR #2014: URL: https://github.com/apache/polaris/pull/2014#issuecomment-3059929804 LGTM Not a blocker: I'm just a bit concern about the sync between two directories. Is it OK to not have a README within `helm/Polaris`, or just have a dummy one without worrying about

Re: [PR] Add Helm Chart repo to the downloads page [polaris]

2025-07-10 Thread via GitHub
flyrain merged PR #2025: URL: https://github.com/apache/polaris/pull/2025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] Add Helm Chart repo to the downloads page [polaris]

2025-07-10 Thread via GitHub
sfc-gh-ygu commented on code in PR #2025: URL: https://github.com/apache/polaris/pull/2025#discussion_r2199259867 ## site/content/downloads/_index.md: ## @@ -28,6 +27,9 @@ params: show_page_toc: true --- +## Helm Chart +Repo: https://downloads.apache.org/incubator/polaris

Re: [PR] Add Helm Chart repo to the downloads page [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on code in PR #2025: URL: https://github.com/apache/polaris/pull/2025#discussion_r2199243408 ## site/content/downloads/_index.md: ## @@ -28,6 +27,9 @@ params: show_page_toc: true --- +## Helm Chart +Repo: https://downloads.apache.org/incubator/polaris/he

Re: [PR] Add Helm Chart repo to the downloads page [polaris]

2025-07-10 Thread via GitHub
flyrain commented on code in PR #2025: URL: https://github.com/apache/polaris/pull/2025#discussion_r2199223411 ## site/content/downloads/_index.md: ## @@ -17,7 +17,6 @@ # specific language governing permissions and limitations # under the License. # -title: "Releases" Review

[PR] Add Helm Chart repo to the downloads page [polaris]

2025-07-10 Thread via GitHub
flyrain opened a new pull request, #2025: URL: https://github.com/apache/polaris/pull/2025 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on PR #2007: URL: https://github.com/apache/polaris/pull/2007#issuecomment-3059498473 If no other feedback, I'll merge tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Build instructions not working [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on issue #1916: URL: https://github.com/apache/polaris/issues/1916#issuecomment-3059491526 `polaris_schema` is created by default, but it's not on the PG search path by default. ``` polaris=# \dn List of schemas Name | Owner

Re: [D] Apache Polaris Roadmap Proposal [polaris]

2025-07-10 Thread via GitHub
GitHub user flyrain edited a discussion: Apache Polaris Roadmap Proposal Over the past months, we've collaborated with a wide range of stakeholders—companies, developers, and users—who are invested in the evolution of Apache Polaris. This roadmap consolidates those insights into a shared visi

Re: [D] Apache Polaris Roadmap Proposal [polaris]

2025-07-10 Thread via GitHub
GitHub user flyrain edited a discussion: Apache Polaris Roadmap Proposal Over the past months, we've collaborated with a wide range of stakeholders—companies, developers, and users—who are invested in the evolution of Apache Polaris. This roadmap consolidates those insights into a shared visi

Re: [D] Apache Polaris Roadmap Proposal [polaris]

2025-07-10 Thread via GitHub
GitHub user flyrain edited a discussion: Apache Polaris Roadmap Proposal Over the past months, we've collaborated with a wide range of stakeholders—companies, developers, and users—who are invested in the evolution of Apache Polaris. This roadmap consolidates those insights into a shared visi

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-10 Thread via GitHub
poojanilangekar commented on PR #2007: URL: https://github.com/apache/polaris/pull/2007#issuecomment-3059479930 Turns out I just needed to rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [D] Apache Polaris Roadmap Proposal [polaris]

2025-07-10 Thread via GitHub
GitHub user flyrain edited a discussion: Apache Polaris Roadmap Proposal Over the past months, we've collaborated with a wide range of stakeholders—companies, developers, and users—who are invested in the evolution of Apache Polaris. This roadmap consolidates those insights into a shared visi

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-10 Thread via GitHub
poojanilangekar commented on PR #2007: URL: https://github.com/apache/polaris/pull/2007#issuecomment-3059470130 This is strange, the build passed on my machine. I will try and fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on PR #2007: URL: https://github.com/apache/polaris/pull/2007#issuecomment-3059461602 @poojanilangekar : it looks like some direct field access still exists :thinking: some parallel code changes perhaps... -- This is an automated message from the Apache Git Service. To r

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-10 Thread via GitHub
poojanilangekar commented on code in PR #2007: URL: https://github.com/apache/polaris/pull/2007#discussion_r2198954970 ## polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java: ## @@ -124,6 +124,18 @@ T cast(Object value) { return this.typ.cast

Re: [PR] Rename SUPPORTED_CATALOG_CONNECTION_TYPES [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on PR #1959: URL: https://github.com/apache/polaris/pull/1959#issuecomment-3059448416 It is possible to have custom code to deal with Smallrye configs at a low level and provide property redirects, but I think it'll be much more complex in the end. -- This is an automa

Re: [PR] Rename SUPPORTED_CATALOG_CONNECTION_TYPES [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on PR #1959: URL: https://github.com/apache/polaris/pull/1959#issuecomment-3059440007 This PR deals with Polaris-specific config, so I'm not sure #2000 is applicable to this rename "as is". The tricky part is that Polaris config can be realm-specific and we cannot provide

Re: [PR] Rename SUPPORTED_CATALOG_CONNECTION_TYPES [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on PR #1959: URL: https://github.com/apache/polaris/pull/1959#issuecomment-3059422057 I'd prefer using the old config name (for now) to making a breaking change. Appreciate your effort on this PR @poojanilangekar ! -- This is an automated message from the Apache Gi

Re: [PR] Add `pathStyleAccess` to AwsStorageConfigInfo [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on code in PR #2012: URL: https://github.com/apache/polaris/pull/2012#discussion_r2198934058 ## spec/polaris-management-service.yml: ## @@ -1056,6 +1056,12 @@ components: type: string description: endpoint for STS requests (optiona

Re: [PR] Rename SUPPORTED_CATALOG_CONNECTION_TYPES [polaris]

2025-07-10 Thread via GitHub
poojanilangekar commented on PR #1959: URL: https://github.com/apache/polaris/pull/1959#issuecomment-3059409806 I'd prefer doing something similar to #2000. (The PR adds a deprecated comment on the existing property and creates a new one.) -- This is an automated message from the Apache

Re: [PR] Rename SUPPORTED_CATALOG_CONNECTION_TYPES [polaris]

2025-07-10 Thread via GitHub
poojanilangekar commented on PR #1959: URL: https://github.com/apache/polaris/pull/1959#issuecomment-3059378695 Hey @eric-maynard, I agree that this change has gotten larger than what I had initially planned. I am planning to close this PR because I think it's orthogonal to the goal of the

Re: [PR] Rename SUPPORTED_CATALOG_CONNECTION_TYPES [polaris]

2025-07-10 Thread via GitHub
poojanilangekar closed pull request #1959: Rename SUPPORTED_CATALOG_CONNECTION_TYPES URL: https://github.com/apache/polaris/pull/1959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Rename SUPPORTED_CATALOG_CONNECTION_TYPES [polaris]

2025-07-10 Thread via GitHub
poojanilangekar commented on code in PR #1959: URL: https://github.com/apache/polaris/pull/1959#discussion_r2198894638 ## polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java: ## @@ -34,11 +35,12 @@ public class BehaviorChangeConfiguration e

Re: [PR] Update Makefile for python client with auto setup [polaris]

2025-07-10 Thread via GitHub
HonahX merged PR #1995: URL: https://github.com/apache/polaris/pull/1995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apac

Re: [PR] Add RealmConfig [polaris]

2025-07-10 Thread via GitHub
eric-maynard commented on code in PR #2015: URL: https://github.com/apache/polaris/pull/2015#discussion_r2198595141 ## polaris-core/src/main/java/org/apache/polaris/core/config/RealmConfigImpl.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Add RealmConfig [polaris]

2025-07-10 Thread via GitHub
eric-maynard commented on code in PR #2015: URL: https://github.com/apache/polaris/pull/2015#discussion_r2198595141 ## polaris-core/src/main/java/org/apache/polaris/core/config/RealmConfigImpl.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Use application-scoped StorageCredentialCache [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on code in PR #2022: URL: https://github.com/apache/polaris/pull/2022#discussion_r2198537121 ## polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCache.java: ## @@ -50,13 +50,10 @@ public class StorageCredentialCache { private

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on code in PR #2007: URL: https://github.com/apache/polaris/pull/2007#discussion_r2198509694 ## polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java: ## @@ -124,6 +124,18 @@ T cast(Object value) { return this.typ.cast(value);

Re: [PR] Add RealmConfig [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on code in PR #2015: URL: https://github.com/apache/polaris/pull/2015#discussion_r2198507298 ## polaris-core/src/main/java/org/apache/polaris/core/config/RealmConfigImpl.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Add `pathStyleAccess` to AwsStorageConfigInfo [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on code in PR #2012: URL: https://github.com/apache/polaris/pull/2012#discussion_r2198502257 ## spec/polaris-management-service.yml: ## @@ -1056,6 +1056,12 @@ components: type: string description: endpoint for STS requests (optiona

Re: [PR] Add `pathStyleAccess` to AwsStorageConfigInfo [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on code in PR #2012: URL: https://github.com/apache/polaris/pull/2012#discussion_r2198499673 ## spec/polaris-management-service.yml: ## @@ -1056,6 +1056,12 @@ components: type: string description: endpoint for STS requests (optiona

Re: [PR] Add RealmConfig [polaris]

2025-07-10 Thread via GitHub
eric-maynard commented on code in PR #2015: URL: https://github.com/apache/polaris/pull/2015#discussion_r2198474097 ## polaris-core/src/main/java/org/apache/polaris/core/config/RealmConfigImpl.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-10 Thread via GitHub
eric-maynard commented on code in PR #2007: URL: https://github.com/apache/polaris/pull/2007#discussion_r2198471751 ## polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java: ## @@ -124,6 +124,18 @@ T cast(Object value) { return this.typ.cast(va

Re: [PR] Add `pathStyleAccess` to AwsStorageConfigInfo [polaris]

2025-07-10 Thread via GitHub
eric-maynard commented on code in PR #2012: URL: https://github.com/apache/polaris/pull/2012#discussion_r2198470837 ## spec/polaris-management-service.yml: ## @@ -1056,6 +1056,12 @@ components: type: string description: endpoint for STS requests (op

Re: [PR] Remove duplicate MetaStoreManagerFactory mocks [polaris]

2025-07-10 Thread via GitHub
eric-maynard merged PR #2023: URL: https://github.com/apache/polaris/pull/2023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polari

Re: [PR] Add `pathStyleAccess` to AwsStorageConfigInfo [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on code in PR #2012: URL: https://github.com/apache/polaris/pull/2012#discussion_r2198318843 ## spec/polaris-management-service.yml: ## @@ -1056,6 +1056,12 @@ components: type: string description: endpoint for STS requests (optiona

Re: [PR] Add `pathStyleAccess` to AwsStorageConfigInfo [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on code in PR #2012: URL: https://github.com/apache/polaris/pull/2012#discussion_r2198313864 ## spec/polaris-management-service.yml: ## @@ -1056,6 +1056,12 @@ components: type: string description: endpoint for STS requests (optiona

Re: [PR] Make PolarisConfiguration member variables private [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on code in PR #2007: URL: https://github.com/apache/polaris/pull/2007#discussion_r2198297035 ## polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java: ## @@ -124,6 +124,18 @@ T cast(Object value) { return this.typ.cast(value);

Re: [PR] Add RealmConfig [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on PR #2015: URL: https://github.com/apache/polaris/pull/2015#issuecomment-3058303008 @eric-maynard : are you ok with merging this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add RealmConfig [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on code in PR #2015: URL: https://github.com/apache/polaris/pull/2015#discussion_r2198285150 ## polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCache.java: ## @@ -82,11 +78,9 @@ public StorageCredentialCache( /** How long cr

Re: [PR] Remove circular dependency between entity and api schema [polaris]

2025-07-10 Thread via GitHub
gfakbar20 commented on PR #1990: URL: https://github.com/apache/polaris/pull/1990#issuecomment-3057905149 if no, think it is a good idea to localized the usage of openApi generated class instead of the widespread use of it as currently happen -- This is an automated message from the Apach

Re: [PR] [WIP] Remove circular dependency between entity and api schema [polaris]

2025-07-10 Thread via GitHub
gfakbar20 commented on PR #1990: URL: https://github.com/apache/polaris/pull/1990#issuecomment-3057890875 reopening the pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [WIP] Remove circular dependency between entity and api schema [polaris]

2025-07-10 Thread via GitHub
gfakbar20 commented on PR #1990: URL: https://github.com/apache/polaris/pull/1990#issuecomment-3057887031 > I’m open to relocating the converters if needed, but could you clarify the concern around placing converters within business object classes? just a pragmatic one, and the curren

Re: [I] Build instructions not working [polaris]

2025-07-10 Thread via GitHub
monali45 commented on issue #1916: URL: https://github.com/apache/polaris/issues/1916#issuecomment-3057685006 Done below steps: - modified application.properties : polaris.realm-context.realms=polaris polaris.persistence.type=relational-jdbc - polaris server - r

Re: [PR] Remove duplicate MetaStoreManagerFactory mocks [polaris]

2025-07-10 Thread via GitHub
dimas-b commented on code in PR #2023: URL: https://github.com/apache/polaris/pull/2023#discussion_r2197550502 ## runtime/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java: ## @@ -450,42 +446,6 @@ protected boolean supportsNotifications() {

Re: [PR] Use application-scoped StorageCredentialCache [polaris]

2025-07-10 Thread via GitHub
XN137 commented on code in PR #2022: URL: https://github.com/apache/polaris/pull/2022#discussion_r2197217262 ## runtime/service/src/test/java/org/apache/polaris/service/quarkus/catalog/PolarisGenericTableCatalogTest.java: ## @@ -288,42 +283,6 @@ public void after() throws IOExce

[I] Website docs issues after 1.0.0 release [polaris]

2025-07-10 Thread via GitHub
snazy opened a new issue, #2024: URL: https://github.com/apache/polaris/issues/2024 ### Describe the bug Some things there... 1. "main branch warning": https://github.com/user-attachments/assets/1ef8d3a6-468a-43ef-b752-858b50b08bfe"; /> 2. left-side navigation missing "in-de

Re: [PR] Use application-scoped StorageCredentialCache [polaris]

2025-07-10 Thread via GitHub
snazy commented on code in PR #2022: URL: https://github.com/apache/polaris/pull/2022#discussion_r2197104849 ## runtime/service/src/test/java/org/apache/polaris/service/quarkus/catalog/PolarisGenericTableCatalogTest.java: ## @@ -288,42 +283,6 @@ public void after() throws IOExce

Re: [PR] Make StorageCredentialCache safe for multi-realm usage [polaris]

2025-07-10 Thread via GitHub
XN137 commented on code in PR #2021: URL: https://github.com/apache/polaris/pull/2021#discussion_r2197006317 ## polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCacheKey.java: ## @@ -44,18 +42,13 @@ public class StorageCredentialCacheKey { p

Re: [PR] Make StorageCredentialCache safe for multi-realm usage [polaris]

2025-07-10 Thread via GitHub
XN137 commented on code in PR #2021: URL: https://github.com/apache/polaris/pull/2021#discussion_r2197002985 ## runtime/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java: ## @@ -465,7 +465,7 @@ public Supplier getOrCreateSessionSupplier(

Re: [PR] Make StorageCredentialCache safe for multi-realm usage [polaris]

2025-07-10 Thread via GitHub
snazy commented on code in PR #2021: URL: https://github.com/apache/polaris/pull/2021#discussion_r2196959527 ## runtime/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java: ## @@ -465,7 +465,7 @@ public Supplier getOrCreateSessionSupplier(

Re: [PR] Use application-scoped StorageCredentialCache [polaris]

2025-07-10 Thread via GitHub
snazy commented on PR #2022: URL: https://github.com/apache/polaris/pull/2022#issuecomment-3056261698 Converted to "draft state", as it depends on another PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Remove duplicate MetaStoreManagerFactory mocks [polaris]

2025-07-10 Thread via GitHub
XN137 commented on code in PR #2023: URL: https://github.com/apache/polaris/pull/2023#discussion_r2196895654 ## runtime/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java: ## @@ -450,42 +446,6 @@ protected boolean supportsNotifications() {

Re: [PR] Remove duplicate MetaStoreManagerFactory mocks [polaris]

2025-07-10 Thread via GitHub
XN137 commented on code in PR #2023: URL: https://github.com/apache/polaris/pull/2023#discussion_r2196895654 ## runtime/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java: ## @@ -450,42 +446,6 @@ protected boolean supportsNotifications() {

[PR] Remove duplicate MetaStoreManagerFactory mocks [polaris]

2025-07-10 Thread via GitHub
XN137 opened a new pull request, #2023: URL: https://github.com/apache/polaris/pull/2023 also rename the field for clarity and consistency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[PR] Use application-scoped StorageCredentialCache [polaris]

2025-07-10 Thread via GitHub
XN137 opened a new pull request, #2022: URL: https://github.com/apache/polaris/pull/2022 WIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

Re: [PR] Small Benchmarks improvements [polaris-tools]

2025-07-10 Thread via GitHub
pingtimeout merged PR #25: URL: https://github.com/apache/polaris-tools/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polar