Re: [PR] WIP feat(idgen): Start Implementation of NoSQL with the ID Generation Framework [polaris]

2025-07-17 Thread via GitHub
snazy commented on code in PR #2131: URL: https://github.com/apache/polaris/pull/2131#discussion_r2215052076 ## persistence/nosql/idgen/impl/src/main/resources/META-INF/beans.xml: ## @@ -0,0 +1,24 @@ + + +https://jakarta.ee/xml/ns/jakartaee"; + xmlns:xsi="http://www.w3.org/2001

Re: [PR] WIP feat(idgen): Start Implementation of NoSQL with the ID Generation Framework [polaris]

2025-07-17 Thread via GitHub
snazy commented on code in PR #2131: URL: https://github.com/apache/polaris/pull/2131#discussion_r2215036515 ## persistence/nosql/idgen/api/src/main/java/org/apache/polaris/ids/api/MonotonicClock.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Python client: add support for endpoint, sts-endpoint, path-style-access [polaris]

2025-07-17 Thread via GitHub
snazy commented on code in PR #2127: URL: https://github.com/apache/polaris/pull/2127#discussion_r2215022981 ## client/python/cli/command/catalogs.py: ## @@ -64,6 +64,9 @@ class CatalogsCommand(Command): remove_properties: List[str] hadoop_warehouse: str iceberg_r

Re: [PR] fix(deps): update dependency io.smallrye.config:smallrye-config-core to v3.13.3 [polaris]

2025-07-17 Thread via GitHub
snazy merged PR #2130: URL: https://github.com/apache/polaris/pull/2130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apach

Re: [PR] fix(deps): update quarkus platform and group to v3.24.4 [polaris]

2025-07-17 Thread via GitHub
snazy merged PR #2128: URL: https://github.com/apache/polaris/pull/2128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apach

Re: [PR] fix(deps): update dependency boto3 to v1.39.8 [polaris]

2025-07-17 Thread via GitHub
snazy merged PR #2129: URL: https://github.com/apache/polaris/pull/2129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apach

Re: [I] Unstructured data support in Apache Polaris [polaris]

2025-07-17 Thread via GitHub
jbonofre commented on issue #586: URL: https://github.com/apache/polaris/issues/586#issuecomment-3086767715 I worked on a proposal about this. I will share the proposal on the mailing list very soon. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] WIP feat(idgen): Start Implementation of NoSQL with the ID Generation Framework [polaris]

2025-07-17 Thread via GitHub
dimas-b commented on code in PR #2131: URL: https://github.com/apache/polaris/pull/2131#discussion_r2214750693 ## persistence/nosql/idgen/api/src/main/java/org/apache/polaris/ids/api/SnowflakeIdGenerator.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundatio

[PR] WIP feat(idgen): Start Implementation of NoSQL with the ID Generation Framework [polaris]

2025-07-17 Thread via GitHub
adam-christian-software opened a new pull request, #2131: URL: https://github.com/apache/polaris/pull/2131 # Motivation This implementation starts the series of PRs to implement the NoSQL work presented in https://docs.google.com/document/d/1POUWe0xMZOBoaJ6Rgiw35ziEoc6OEYCiW7Zk6bR9H6M/ed

Re: [PR] fix(deps): update dependency org.apache.iceberg:iceberg-bom to v1.9.2 [polaris]

2025-07-17 Thread via GitHub
dimas-b merged PR #2126: URL: https://github.com/apache/polaris/pull/2126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] fix(deps): update dependency org.apache.iceberg:iceberg-bom to v1.9.2 [polaris]

2025-07-17 Thread via GitHub
dimas-b commented on PR #2126: URL: https://github.com/apache/polaris/pull/2126#issuecomment-3086374431 Re: S3 tests, I'm planning to run then in CI on MinIO (once the backend is fully ready) -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[PR] fix(deps): update dependency io.smallrye.config:smallrye-config-core to v3.13.3 [polaris]

2025-07-17 Thread via GitHub
renovate-bot opened a new pull request, #2130: URL: https://github.com/apache/polaris/pull/2130 This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [io.smallrye.config:smallrye-config-core](https://smallrye.io) ([source](https://re

[PR] fix(deps): update dependency boto3 to v1.39.8 [polaris]

2025-07-17 Thread via GitHub
renovate-bot opened a new pull request, #2129: URL: https://github.com/apache/polaris/pull/2129 This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [boto3](https://redirect.github.com/boto/boto3) | `==1.39.7` -> `==1.39.8` | [![ag

Re: [PR] feat(helm): Add support for external authentication [polaris]

2025-07-17 Thread via GitHub
adutra merged PR #2104: URL: https://github.com/apache/polaris/pull/2104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apac

Re: [PR] Use Makefile to simplify setup and commands [polaris]

2025-07-17 Thread via GitHub
MonkeyCanCode commented on PR #2027: URL: https://github.com/apache/polaris/pull/2027#issuecomment-3085366562 > > > Don't get me wrong, but it seems the setup is quite opinionated. The Makefile requires devs to use new things, that do not necessarily match their daily workflows. For example

Re: [I] Client's "venv" is never updated [polaris]

2025-07-17 Thread via GitHub
MonkeyCanCode commented on issue #1221: URL: https://github.com/apache/polaris/issues/1221#issuecomment-3085278061 > Can we close it as [#1222](https://github.com/apache/polaris/pull/1222) has merged? At least it shouldn't be a 1.0 blocker now. @snazy should we close this one as now t

Re: [PR] Add server and client support for the new generic table `baseLocation` field [polaris]

2025-07-17 Thread via GitHub
gh-yzou commented on PR #2122: URL: https://github.com/apache/polaris/pull/2122#issuecomment-3085108696 @dimas-b Thanks! Could you help take a look somtime? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Python client: add support for endpoint, sts-endpoint, path-style-access [polaris]

2025-07-17 Thread via GitHub
eric-maynard commented on code in PR #2127: URL: https://github.com/apache/polaris/pull/2127#discussion_r2213874271 ## client/python/cli/command/catalogs.py: ## @@ -64,6 +64,9 @@ class CatalogsCommand(Command): remove_properties: List[str] hadoop_warehouse: str ic

Re: [PR] Package polaris client as python package [polaris]

2025-07-17 Thread via GitHub
MonkeyCanCode commented on PR #2049: URL: https://github.com/apache/polaris/pull/2049#issuecomment-3084803394 @eric-maynard / @HonahX may I have a review here? This will get us a proper packaging for polaris client as well as to help us to remove dependency on the bash script (and use it on

Re: [PR] Python client: add support for endpoint, sts-endpoint, path-style-access [polaris]

2025-07-17 Thread via GitHub
eric-maynard commented on code in PR #2127: URL: https://github.com/apache/polaris/pull/2127#discussion_r2213866090 ## client/python/cli/command/catalogs.py: ## @@ -64,6 +64,9 @@ class CatalogsCommand(Command): remove_properties: List[str] hadoop_warehouse: str ic

Re: [PR] feat(helm): Add support for external authentication [polaris]

2025-07-17 Thread via GitHub
MonkeyCanCode commented on code in PR #2104: URL: https://github.com/apache/polaris/pull/2104#discussion_r2213222792 ## helm/polaris/README.md: ## @@ -189,21 +189,24 @@ ct install --namespace polaris --charts ./helm/polaris |-|--|-|-| | advancedConf

Re: [PR] Python client: add support for endpoint, sts-endpoint, path-style-access [polaris]

2025-07-17 Thread via GitHub
MonkeyCanCode commented on code in PR #2127: URL: https://github.com/apache/polaris/pull/2127#discussion_r2213848168 ## client/python/cli/command/catalogs.py: ## @@ -64,6 +64,9 @@ class CatalogsCommand(Command): remove_properties: List[str] hadoop_warehouse: str i

Re: [PR] Part 1 : Adds RLS and CLS control Policies [polaris]

2025-07-17 Thread via GitHub
singhpk234 commented on PR #2048: URL: https://github.com/apache/polaris/pull/2048#issuecomment-3084708025 @snazy @adutra thank you for sharing your feedbacks, i want to walk you all through what my thought process was : Why Iceberg Expressions and not SQL Iceberg expresions are p

[PR] chore(deps): update dependency io.quarkus to v3.24.4 [polaris]

2025-07-17 Thread via GitHub
renovate-bot opened a new pull request, #2128: URL: https://github.com/apache/polaris/pull/2128 This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | io.quarkus | `3.24.3` -> `3.24.4` | [![age](https://developer.mend.io/api/mc/badges

Re: [PR] Add IMPLICIT authentication support to the CLI [polaris]

2025-07-17 Thread via GitHub
eric-maynard merged PR #2121: URL: https://github.com/apache/polaris/pull/2121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polari

Re: [PR] Python client: add support for endpoint, sts-endpoint, path-style-access [polaris]

2025-07-17 Thread via GitHub
eric-maynard commented on code in PR #2127: URL: https://github.com/apache/polaris/pull/2127#discussion_r2213791278 ## client/python/cli/constants.py: ## @@ -222,6 +225,11 @@ class Create: EXTERNAL_ID = "(Only for S3) The external ID to use when connecting to S3"

Re: [PR] Python client: add support for endpoint, sts-endpoint, path-style-access [polaris]

2025-07-17 Thread via GitHub
eric-maynard commented on code in PR #2127: URL: https://github.com/apache/polaris/pull/2127#discussion_r2213790497 ## client/python/cli/command/catalogs.py: ## @@ -64,6 +64,9 @@ class CatalogsCommand(Command): remove_properties: List[str] hadoop_warehouse: str ic

Re: [PR] AWS CloudWatch Event Sink Implementation [polaris]

2025-07-17 Thread via GitHub
eric-maynard commented on code in PR #1965: URL: https://github.com/apache/polaris/pull/1965#discussion_r2213781651 ## service/common/src/main/java/org/apache/polaris/service/events/AwsCloudWatchEventListener.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] AWS CloudWatch Event Sink Implementation [polaris]

2025-07-17 Thread via GitHub
eric-maynard commented on code in PR #1965: URL: https://github.com/apache/polaris/pull/1965#discussion_r2213779987 ## service/common/src/main/java/org/apache/polaris/service/events/AwsCloudWatchEventListener.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] AWS CloudWatch Event Sink Implementation [polaris]

2025-07-17 Thread via GitHub
eric-maynard commented on code in PR #1965: URL: https://github.com/apache/polaris/pull/1965#discussion_r2213775761 ## service/common/src/main/java/org/apache/polaris/service/events/AwsCloudWatchEventListener.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Extensible pagination token implementation [polaris]

2025-07-17 Thread via GitHub
eric-maynard commented on code in PR #1938: URL: https://github.com/apache/polaris/pull/1938#discussion_r2213771840 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/PageTokenUtil.java: ## @@ -0,0 +1,267 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Part 1 : Adds RLS and CLS control Policies [polaris]

2025-07-17 Thread via GitHub
adutra commented on PR #2048: URL: https://github.com/apache/polaris/pull/2048#issuecomment-3084574973 > Row-level filter expressions benefit a lot from CASE, CAST, COALESCE etc. Not sure whether it's worth to not have those available to users. Indeed, the ability to express something

Re: [PR] feat(helm): Add support for external authentication [polaris]

2025-07-17 Thread via GitHub
MonkeyCanCode commented on code in PR #2104: URL: https://github.com/apache/polaris/pull/2104#discussion_r2213222792 ## helm/polaris/README.md: ## @@ -189,21 +189,24 @@ ct install --namespace polaris --charts ./helm/polaris |-|--|-|-| | advancedConf

[PR] Python client: add support for endpoint, sts-endpoint, path-style-access [polaris]

2025-07-17 Thread via GitHub
snazy opened a new pull request, #2127: URL: https://github.com/apache/polaris/pull/2127 Amends #1913 and #2012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Abstract polaris-runtime-service tests for all persistence implementations [polaris]

2025-07-17 Thread via GitHub
snazy merged PR #2106: URL: https://github.com/apache/polaris/pull/2106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apach

Re: [PR] AWS CloudWatch Event Sink Implementation [polaris]

2025-07-17 Thread via GitHub
snazy commented on code in PR #1965: URL: https://github.com/apache/polaris/pull/1965#discussion_r2212830643 ## service/common/src/main/java/org/apache/polaris/service/events/AwsCloudWatchEventListener.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Part 1 : Adds RLS and CLS control Policies [polaris]

2025-07-17 Thread via GitHub
snazy commented on code in PR #2048: URL: https://github.com/apache/polaris/pull/2048#discussion_r2212550907 ## polaris-core/src/main/java/org/apache/polaris/core/policy/content/IcebergExpressionListDeserializer.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software F

Re: [PR] feat(helm): Add support for external authentication [polaris]

2025-07-17 Thread via GitHub
adutra commented on code in PR #2104: URL: https://github.com/apache/polaris/pull/2104#discussion_r2212609682 ## helm/polaris/tests/configmap_test.yaml: ## @@ -336,3 +427,33 @@ tests: asserts: - matchRegex: { path: 'data["application.properties"]', pattern: "polaris

Re: [PR] feat(helm): Add support for external authentication [polaris]

2025-07-17 Thread via GitHub
adutra commented on code in PR #2104: URL: https://github.com/apache/polaris/pull/2104#discussion_r2212610906 ## helm/polaris/README.md: ## @@ -189,21 +189,24 @@ ct install --namespace polaris --charts ./helm/polaris |-|--|-|-| | advancedConfig | ob

Re: [I] Document Polaris Integration with Third-Party Identity Providers (IDPs) [polaris]

2025-07-17 Thread via GitHub
adutra commented on issue #1327: URL: https://github.com/apache/polaris/issues/1327#issuecomment-3083040643 This has been partially addressed by #2013, although that PR does not cover how to setup the IDP for Polaris (users, groups, roles, etc.) or how to integrate with common IDPs (Okta, A

Re: [PR] Part 1 : Adds RLS and CLS control Policies [polaris]

2025-07-17 Thread via GitHub
snazy commented on PR #2048: URL: https://github.com/apache/polaris/pull/2048#issuecomment-3083016697 (Replying to the later editor PR description) > Note: In last Apache Iceberg Community Sync all were generally alligned that using iceberg expression with extending its support for refere

Re: [PR] feat(helm): Add support for external authentication [polaris]

2025-07-17 Thread via GitHub
adutra commented on code in PR #2104: URL: https://github.com/apache/polaris/pull/2104#discussion_r2212553207 ## helm/polaris/README.md: ## @@ -189,21 +189,24 @@ ct install --namespace polaris --charts ./helm/polaris |-|--|-|-| | advancedConfig | ob

Re: [PR] Add Events for PolarisServiceImpl APIs [polaris]

2025-07-17 Thread via GitHub
snazy commented on code in PR #1904: URL: https://github.com/apache/polaris/pull/1904#discussion_r2212355993 ## service/common/src/main/java/org/apache/polaris/service/events/AfterCatalogGetEvent.java: ## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF)