Re: [PR] feat(docs): Add Getting Stated guide for MinIO [polaris]

2025-08-01 Thread via GitHub
eric-maynard commented on code in PR #2227: URL: https://github.com/apache/polaris/pull/2227#discussion_r2249138722 ## site/content/in-dev/unreleased/getting-started/minio.md: ## @@ -0,0 +1,114 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

Re: [PR] feat(docs): Add Getting Stated guide for MinIO [polaris]

2025-08-01 Thread via GitHub
eric-maynard commented on code in PR #2227: URL: https://github.com/apache/polaris/pull/2227#discussion_r2249138416 ## site/content/in-dev/unreleased/getting-started/minio.md: ## @@ -0,0 +1,114 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

Re: [PR] feat(docs): Add Getting Stated guide for MinIO [polaris]

2025-08-01 Thread via GitHub
eric-maynard commented on code in PR #2227: URL: https://github.com/apache/polaris/pull/2227#discussion_r2249138576 ## site/content/in-dev/unreleased/getting-started/minio.md: ## @@ -0,0 +1,114 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

Re: [PR] feat(docs): Add Getting Stated guide for MinIO [polaris]

2025-08-01 Thread via GitHub
eric-maynard commented on code in PR #2227: URL: https://github.com/apache/polaris/pull/2227#discussion_r2249138161 ## site/content/in-dev/unreleased/getting-started/minio.md: ## @@ -0,0 +1,114 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

Re: [PR] feat(docs): Add Getting Stated guide for MinIO [polaris]

2025-08-01 Thread via GitHub
eric-maynard commented on code in PR #2227: URL: https://github.com/apache/polaris/pull/2227#discussion_r2249137947 ## site/content/in-dev/unreleased/getting-started/minio.md: ## @@ -0,0 +1,114 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

Re: [PR] Remove redundant locations when constructing access policies [polaris]

2025-08-01 Thread via GitHub
eric-maynard commented on code in PR #2149: URL: https://github.com/apache/polaris/pull/2149#discussion_r2249133209 ## polaris-core/src/main/java/org/apache/polaris/core/storage/StorageUtil.java: ## @@ -62,4 +68,50 @@ public class StorageUtil { public static @Nonnull String g

Re: [PR] Support Lance format in generic table [polaris]

2025-08-01 Thread via GitHub
gh-yzou commented on code in PR #2239: URL: https://github.com/apache/polaris/pull/2239#discussion_r2249031204 ## plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java: ## @@ -182,6 +188,9 @@ public Table alterTable(Identifier ident, TableChange... c

Re: [PR] Support Lance format in generic table [polaris]

2025-08-01 Thread via GitHub
gh-yzou commented on code in PR #2239: URL: https://github.com/apache/polaris/pull/2239#discussion_r2249026117 ## plugins/spark/README.md: ## @@ -83,6 +86,9 @@ bin/spark-shell \ --conf spark.sql.catalog.polaris.credential="root:secret" \ --conf spark.sql.catalog.polaris.scope=

Re: [PR] Support Lance format in generic table [polaris]

2025-08-01 Thread via GitHub
flyrain commented on code in PR #2239: URL: https://github.com/apache/polaris/pull/2239#discussion_r2249024219 ## plugins/spark/README.md: ## @@ -60,6 +60,9 @@ bin/spark-shell \ --conf spark.sql.catalog..credential="root:secret" \ --conf spark.sql.catalog..scope='PRINCIPAL_ROL

Re: [PR] Support Lance format in generic table [polaris]

2025-08-01 Thread via GitHub
flyrain commented on code in PR #2239: URL: https://github.com/apache/polaris/pull/2239#discussion_r2249023400 ## plugins/spark/README.md: ## @@ -123,4 +132,4 @@ Following describes the current functionality limitations of the Polaris Spark c 2) Create a Delta table without ex

Re: [I] Malformed subscoped credentials error with external s3 [polaris]

2025-08-01 Thread via GitHub
dimas-b commented on issue #2207: URL: https://github.com/apache/polaris/issues/2207#issuecomment-3146010146 I can look into this in +1 week (unless someone else picks it up)... I'll mark this issue for 1.1.0 proactively, but inclusion into the release is not guaranteed :) -- This is an

Re: [I] Malformed subscoped credentials error with external s3 [polaris]

2025-08-01 Thread via GitHub
dimas-b closed issue #2207: Malformed subscoped credentials error with external s3 URL: https://github.com/apache/polaris/issues/2207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] feat: Add `endpointInternal` to `AwsStorageConfigInfo` [polaris]

2025-08-01 Thread via GitHub
dimas-b commented on PR #2213: URL: https://github.com/apache/polaris/pull/2213#issuecomment-3146007013 @flyrain : feel free to revert -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] feat: Add `endpointInternal` to `AwsStorageConfigInfo` [polaris]

2025-08-01 Thread via GitHub
flyrain commented on PR #2213: URL: https://github.com/apache/polaris/pull/2213#issuecomment-3146005631 As a spec change, we will need to conclude the dev ML discussion or vote before merging. I don't think there is a consensus in the discussion thread, https://lists.apache.org/thread/9nggn

Re: [PR] Make `*StorageConfigurationInfo` types immutable [polaris]

2025-08-01 Thread via GitHub
dimas-b commented on code in PR #2236: URL: https://github.com/apache/polaris/pull/2236#discussion_r2249009104 ## polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java: ## @@ -18,95 +18,37 @@ */ package org.apache.polaris.core.storage

[PR] fix(deps): update dependency boto3 to v1.40.1 [polaris]

2025-08-01 Thread via GitHub
renovate-bot opened a new pull request, #2240: URL: https://github.com/apache/polaris/pull/2240 This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [boto3](https://redirect.github.com/boto/boto3) | `==1.40.0` -> `==1.40.1` | [![ag

[PR] Support Lance format in generic table [polaris]

2025-08-01 Thread via GitHub
jackye1995 opened a new pull request, #2239: URL: https://github.com/apache/polaris/pull/2239 Integrate Lance format with the generic tables API and allow it to be used in the Spark connector -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Remove redundant locations when constructing access policies [polaris]

2025-08-01 Thread via GitHub
snazy commented on code in PR #2149: URL: https://github.com/apache/polaris/pull/2149#discussion_r2248651812 ## polaris-core/src/main/java/org/apache/polaris/core/storage/StorageUtil.java: ## @@ -62,4 +68,50 @@ public class StorageUtil { public static @Nonnull String getBucke

Re: [PR] Remove redundant locations when constructing access policies [polaris]

2025-08-01 Thread via GitHub
snazy commented on code in PR #2149: URL: https://github.com/apache/polaris/pull/2149#discussion_r2248651812 ## polaris-core/src/main/java/org/apache/polaris/core/storage/StorageUtil.java: ## @@ -62,4 +68,50 @@ public class StorageUtil { public static @Nonnull String getBucke

Re: [PR] chore(deps): update dependency gradle to v9 [polaris]

2025-08-01 Thread via GitHub
forking-renovate[bot] commented on PR #2226: URL: https://github.com/apache/polaris/pull/2226#issuecomment-3145457441 ### Edited/Blocked Notification Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have

Re: [PR] chore(deps): update dependency mypy to >=1.17, <=1.17.1 [polaris]

2025-08-01 Thread via GitHub
snazy merged PR #2218: URL: https://github.com/apache/polaris/pull/2218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apach

Re: [PR] JDBC: SERIALIZABLE/EntityNotFoundException [polaris]

2025-08-01 Thread via GitHub
singhpk234 commented on code in PR #2219: URL: https://github.com/apache/polaris/pull/2219#discussion_r2248582752 ## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -183,11 +183,17 @@ private void persi

Re: [PR] JDBC: SERIALIZABLE/EntityNotFoundException [polaris]

2025-08-01 Thread via GitHub
singhpk234 commented on code in PR #2219: URL: https://github.com/apache/polaris/pull/2219#discussion_r2248582752 ## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -183,11 +183,17 @@ private void persi

[I] bootstrap command always creates a principal with name "root" | external IDP configuration with dynamic principals results in a chicken and egg problem [polaris]

2025-08-01 Thread via GitHub
creepysta opened a new issue, #2238: URL: https://github.com/apache/polaris/issues/2238 ### Describe the bug I'm trying to configure polaris 1.0.0 to work with external Identity Provider following - https://github.com/apache/polaris/pull/1397 Looks like when bootstrap, `java -j

Re: [PR] Part 1 : Adds RLS and CLS control Policies [polaris]

2025-08-01 Thread via GitHub
singhpk234 commented on PR #2048: URL: https://github.com/apache/polaris/pull/2048#issuecomment-3145299844 Could you clarify which of the points above are directly related to this pr? Or is this a general objection to any work on FGAC until the above questions have all been resolved?

Re: [PR] Add Events for PolarisServiceImpl APIs [polaris]

2025-08-01 Thread via GitHub
eric-maynard commented on PR #1904: URL: https://github.com/apache/polaris/pull/1904#issuecomment-3145168186 @snazy are there still changes you'd like to see here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Make `*StorageConfigurationInfo` types immutable [polaris]

2025-08-01 Thread via GitHub
snazy commented on code in PR #2236: URL: https://github.com/apache/polaris/pull/2236#discussion_r2248415949 ## polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java: ## @@ -18,95 +18,37 @@ */ package org.apache.polaris.core.storage.a

Re: [PR] Prepare upgrade to Gradle 9 [polaris]

2025-08-01 Thread via GitHub
snazy commented on code in PR #2237: URL: https://github.com/apache/polaris/pull/2237#discussion_r2248381123 ## api/management-model/build.gradle.kts: ## @@ -50,13 +50,13 @@ val generatedOpenApiSrcDir = project.layout.buildDirectory.dir("generated-openap openApiGenerate { /

[PR] Prepare upgrade to Gradle 9 [polaris]

2025-08-01 Thread via GitHub
snazy opened a new pull request, #2237: URL: https://github.com/apache/polaris/pull/2237 * `shadowPub.kt` the change removes a special case that doesn't apply to Polaris * `api/...` build scripts - changes due to nullable type handling (`Property` vs `Property` - latter is ... weird)

Re: [PR] chore(deps): update dependency gradle to v9 [polaris]

2025-08-01 Thread via GitHub
snazy commented on PR #2226: URL: https://github.com/apache/polaris/pull/2226#issuecomment-3145093271 Quarkus issue https://github.com/quarkusio/quarkus/issues/49294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] chore(deps): update dependency gradle to v9 [polaris]

2025-08-01 Thread via GitHub
snazy commented on PR #2226: URL: https://github.com/apache/polaris/pull/2226#issuecomment-3145072307 Oops... ``` Caused by: org.gradle.api.InvalidUserCodeException: Cannot mutate the hierarchy of configuration ':polaris-core:compilePlusRuntime' after the configuration was consume

Re: [I] [FEATURE REQUEST] On-Premise S3 & Remote Signing [polaris]

2025-08-01 Thread via GitHub
metadaddy commented on issue #32: URL: https://github.com/apache/polaris/issues/32#issuecomment-3145017911 @dimas-b No, it's purely a cloud-based service, like S3. You can sign up for an account, with 10 GB of free storage, no credit card required, or I can create a test bucket and provide

Re: [I] [FEATURE REQUEST] On-Premise S3 & Remote Signing [polaris]

2025-08-01 Thread via GitHub
dimas-b commented on issue #32: URL: https://github.com/apache/polaris/issues/32#issuecomment-3144996855 @metadaddy : Does B2 have an OSS version runnable in Docker (for testing)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] [FEATURE REQUEST] On-Premise S3 & Remote Signing [polaris]

2025-08-01 Thread via GitHub
metadaddy commented on issue #32: URL: https://github.com/apache/polaris/issues/32#issuecomment-3144991873 Hi @adutra - I work at Backblaze; our [B2 cloud object store](https://www.backblaze.com/cloud-storage) is S3-compatible, but we do not currently have an STS, so I'm keen to move this a

Re: [PR] Make `*StorageConfigurationInfo` types immutable [polaris]

2025-08-01 Thread via GitHub
dimas-b commented on code in PR #2236: URL: https://github.com/apache/polaris/pull/2236#discussion_r2248282283 ## polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java: ## @@ -18,95 +18,37 @@ */ package org.apache.polaris.core.storage

Re: [PR] Remove config parameter from `PolarisStorageIntegration#getSubscopedCreds` [polaris]

2025-08-01 Thread via GitHub
snazy commented on code in PR #2235: URL: https://github.com/apache/polaris/pull/2235#discussion_r2248277534 ## service/common/src/main/java/org/apache/polaris/service/storage/PolarisStorageIntegrationProviderImpl.java: ## @@ -81,27 +85,32 @@ public PolarisStorageIntegrationProv

[PR] Make `*StorageConfigurationInfo` types immutable [polaris]

2025-08-01 Thread via GitHub
snazy opened a new pull request, #2236: URL: https://github.com/apache/polaris/pull/2236 This change eventually enables usage of the `*StorageConfigurationInfo` in the `StorageCredentialCacheKey` due to the then memoized hash-code values, to eliminate a couple of JSON re-serializations. -

Re: [PR] Remove config parameter from `PolarisStorageIntegration#getSubscopedCreds` [polaris]

2025-08-01 Thread via GitHub
dimas-b commented on code in PR #2235: URL: https://github.com/apache/polaris/pull/2235#discussion_r2248262082 ## service/common/src/main/java/org/apache/polaris/service/storage/PolarisStorageIntegrationProviderImpl.java: ## @@ -81,27 +85,32 @@ public PolarisStorageIntegrationPr

Re: [PR] Remove PolarisCallContext.getMetaStore [polaris]

2025-08-01 Thread via GitHub
dimas-b commented on code in PR #2229: URL: https://github.com/apache/polaris/pull/2229#discussion_r2248180699 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/BaseMetaStoreManager.java: ## @@ -53,6 +56,16 @@ public static PolarisStorageConfigurationInfo extrac

Re: [PR] Remove PolarisCallContext.getMetaStore [polaris]

2025-08-01 Thread via GitHub
snazy commented on code in PR #2229: URL: https://github.com/apache/polaris/pull/2229#discussion_r2248149172 ## polaris-core/src/testFixtures/java/org/apache/polaris/core/persistence/PolarisTestMetaStoreManager.java: ## @@ -2903,9 +2900,10 @@ void testPolicyMappingCleanup() {

Re: [PR] JDBC: SERIALIZABLE/EntityNotFoundException [polaris]

2025-08-01 Thread via GitHub
dimas-b commented on code in PR #2219: URL: https://github.com/apache/polaris/pull/2219#discussion_r2248146061 ## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -183,11 +183,17 @@ private void persistE

[PR] Remove config parameter from `PolarisStorageIntegration#getSubscopedCreds` [polaris]

2025-08-01 Thread via GitHub
snazy opened a new pull request, #2235: URL: https://github.com/apache/polaris/pull/2235 Instances of `PolarisStorageIntegration` are created for a particular `PolarisStorageConfigurationInfo`, the same value is then passed into `PSI.getSubscopedCreds()`. This change removes the conf

Re: [PR] Replace PolarisEntityManager with ResolutionManifestFactory [polaris]

2025-08-01 Thread via GitHub
XN137 commented on PR #2210: URL: https://github.com/apache/polaris/pull/2210#issuecomment-3144642258 rebased again after trivial conflict in `AbstractIcebergCatalogViewTest.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Merge polaris-service-common into polaris-runtime-service [polaris]

2025-08-01 Thread via GitHub
adutra commented on PR #2233: URL: https://github.com/apache/polaris/pull/2233#issuecomment-3144571544 The failing test does not fail to me locally: `testCreateGcpCredentialsFromStaticToken` – I am investigating. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Fix deprecated Quarkus log properties [polaris]

2025-08-01 Thread via GitHub
dimas-b merged PR #2216: URL: https://github.com/apache/polaris/pull/2216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] feat: Add `endpointInternal` to `AwsStorageConfigInfo` [polaris]

2025-08-01 Thread via GitHub
dimas-b merged PR #2213: URL: https://github.com/apache/polaris/pull/2213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] feat(docs): Add Getting Stated guide for MinIO [polaris]

2025-08-01 Thread via GitHub
dimas-b commented on PR #2227: URL: https://github.com/apache/polaris/pull/2227#issuecomment-3144544264 A docker-compose file would be nice, but I wanted to have a prominent doc for people building something from scratch. I've seen a few messages where the catalog creation step appeared to

[PR] Only pass `RealmConfig` to `PolarisStorageIntegration` [polaris]

2025-08-01 Thread via GitHub
snazy opened a new pull request, #2234: URL: https://github.com/apache/polaris/pull/2234 All `PolarisStorageIntegration` requite only the `RealmConfig`, not the whole `CallContext`. This makes it easier for the new tasks impleemntations (both proposals). -- This is an automated message f

Re: [I] [FEATURE REQUEST] On-Premise S3 & Remote Signing [polaris]

2025-08-01 Thread via GitHub
adutra commented on issue #32: URL: https://github.com/apache/polaris/issues/32#issuecomment-3144394618 FYI I'm going to take a stab at request signing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Merge service common [polaris]

2025-08-01 Thread via GitHub
adutra opened a new pull request, #2233: URL: https://github.com/apache/polaris/pull/2233 As discussed in the ML here is a PR that merges polaris-service-common into polaris-runtime-service. 99% of the changes are file moves or renamings: - d15c8265a113358696a57c2d873bf97b008e0

Re: [I] Malformed subscoped credentials error with external s3 [polaris]

2025-08-01 Thread via GitHub
lastranget commented on issue #2207: URL: https://github.com/apache/polaris/issues/2207#issuecomment-3144303412 Yeah, that would be great. We can provide local credentials to our clients. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] add the schema-setup for admin tool [polaris]

2025-08-01 Thread via GitHub
adutra commented on PR #2196: URL: https://github.com/apache/polaris/pull/2196#issuecomment-3144136407 @sclee01 I went ahead and started the thread: https://lists.apache.org/thread/6c7lzgy3675jrrtbrrxsm8l0xd1fo1mj Please chime in! 🙏 -- This is an automated message from the Apache

Re: [PR] JDBC: SERIALIZABLE/EntityNotFoundException [polaris]

2025-08-01 Thread via GitHub
snazy commented on code in PR #2219: URL: https://github.com/apache/polaris/pull/2219#discussion_r2247639330 ## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -183,11 +183,17 @@ private void persistEnt

Re: [PR] feat: Add `endpointInternal` to `AwsStorageConfigInfo` [polaris]

2025-08-01 Thread via GitHub
snazy commented on code in PR #2213: URL: https://github.com/apache/polaris/pull/2213#discussion_r2247621486 ## spec/polaris-management-service.yml: ## @@ -1050,12 +1050,23 @@ components: example: "us-east-2" endpoint: type: string -

Re: [PR] Remove CallContext.CURRENT_CONTEXT [polaris]

2025-08-01 Thread via GitHub
snazy merged PR #2203: URL: https://github.com/apache/polaris/pull/2203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apach

Re: [PR] Fix compilation warnings in AzureCredentialStorageIntegrationTest [polaris]

2025-08-01 Thread via GitHub
adutra merged PR #2231: URL: https://github.com/apache/polaris/pull/2231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apac

Re: [PR] Fix Awaitility build configuration [polaris]

2025-08-01 Thread via GitHub
adutra merged PR #2232: URL: https://github.com/apache/polaris/pull/2232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apac

Re: [PR] feat(docs): Add Getting Stated guide for MinIO [polaris]

2025-08-01 Thread via GitHub
adutra commented on PR #2227: URL: https://github.com/apache/polaris/pull/2227#issuecomment-3143937666 Nice addition, although I'm wondering: wouldn't it be better to create a docker-compose getting-started example in the directory below? https://github.com/apache/polaris/tree/main/g

[PR] Fix Awaitility build configuration [polaris]

2025-08-01 Thread via GitHub
adutra opened a new pull request, #2232: URL: https://github.com/apache/polaris/pull/2232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

Re: [I] Remove and ban usage of `[Inheritable]ThreadLocal` [polaris]

2025-08-01 Thread via GitHub
XN137 commented on issue #463: URL: https://github.com/apache/polaris/issues/463#issuecomment-3143925166 https://github.com/apache/polaris/pull/2203 removes the thread local `CallContext.CURRENT_CONTEXT` which is probably biggest offender in the codebase as `PolarisEclipseLinkMetaSto

[PR] Fix compilation warnings in AzureCredentialStorageIntegrationTest [polaris]

2025-08-01 Thread via GitHub
adutra opened a new pull request, #2231: URL: https://github.com/apache/polaris/pull/2231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

Re: [PR] chore(deps): update actions/stale digest to 8f717f0 [polaris]

2025-08-01 Thread via GitHub
snazy merged PR #2224: URL: https://github.com/apache/polaris/pull/2224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apach

Re: [PR] Replace TestPolarisMetaStoreManager with Mockito.spy [polaris]

2025-08-01 Thread via GitHub
XN137 commented on code in PR #2230: URL: https://github.com/apache/polaris/pull/2230#discussion_r2247439127 ## runtime/service/src/test/java/org/apache/polaris/service/quarkus/admin/ManagementServiceTest.java: ## @@ -302,34 +300,19 @@ public void testCatalogNotReturnedWhenDele

[PR] Replace TestPolarisMetaStoreManager with Mockito.spy [polaris]

2025-08-01 Thread via GitHub
XN137 opened a new pull request, #2230: URL: https://github.com/apache/polaris/pull/2230 this takes less code and is more flexible in the future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Call MetaStoreManagerFactory.getOrCreateSession once in QuarkusProducers [polaris]

2025-08-01 Thread via GitHub
XN137 commented on PR #2214: URL: https://github.com/apache/polaris/pull/2214#issuecomment-3143837912 closing as it will become obsolete anyway with other ongoing PRs most likely -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Call MetaStoreManagerFactory.getOrCreateSession once in QuarkusProducers [polaris]

2025-08-01 Thread via GitHub
XN137 closed pull request #2214: Call MetaStoreManagerFactory.getOrCreateSession once in QuarkusProducers URL: https://github.com/apache/polaris/pull/2214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[PR] Remove polaris call context.get meta store [polaris]

2025-08-01 Thread via GitHub
XN137 opened a new pull request, #2229: URL: https://github.com/apache/polaris/pull/2229 unfinished WIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Automate the release guide [polaris]

2025-08-01 Thread via GitHub
pingtimeout commented on PR #2156: URL: https://github.com/apache/polaris/pull/2156#issuecomment-3143651894 I updated the code to include the current changes being discussed in the Helm PR and to integrate code review feedback. I am going to update the PR description with output example so

Re: [PR] Automate the release guide [polaris]

2025-08-01 Thread via GitHub
pingtimeout commented on code in PR #2156: URL: https://github.com/apache/polaris/pull/2156#discussion_r2247271426 ## releasey/README.md: ## @@ -0,0 +1,131 @@ + + +# Polaris Release Automation Scripts + +This directory contains scripts to automate the Apache Polaris release pro

Re: [PR] Automate the release guide [polaris]

2025-08-01 Thread via GitHub
pingtimeout commented on code in PR #2156: URL: https://github.com/apache/polaris/pull/2156#discussion_r2247269683 ## releasey/04-build-and-test.sh: ## @@ -0,0 +1,118 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] Automate the release guide [polaris]

2025-08-01 Thread via GitHub
pingtimeout commented on code in PR #2156: URL: https://github.com/apache/polaris/pull/2156#discussion_r2247268142 ## releasey/libs/_files.sh: ## @@ -0,0 +1,50 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreeme

[PR] Fix CLI error polaris: not found [polaris]

2025-08-01 Thread via GitHub
eric-maynard opened a new pull request, #2228: URL: https://github.com/apache/polaris/pull/2228 After #2049, some users reported errors when running the CLI: ``` ./polaris ./polaris: line 71: exec: polaris: not found ``` I was able to reproduce this and found that reverting