snazy merged PR #2382:
URL: https://github.com/apache/polaris/pull/2382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
jbonofre opened a new pull request, #2382:
URL: https://github.com/apache/polaris/pull/2382
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
flyrain commented on code in PR #2267:
URL: https://github.com/apache/polaris/pull/2267#discussion_r2284199353
##
site/content/in-dev/unreleased/getting-started/_index.md:
##
@@ -23,3 +23,101 @@ weight: 101
build:
render: never
---
+
+# Getting Started with Apache Polaris B
XN137 commented on code in PR #2381:
URL: https://github.com/apache/polaris/pull/2381#discussion_r2284130968
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/TransactionalMetaStoreManagerImpl.java:
##
@@ -93,6 +93,7 @@ public class TransactionalMet
XN137 opened a new pull request, #2381:
URL: https://github.com/apache/polaris/pull/2381
the ultimate goal is removing the `PolarisCallContext` parameter from every
`PolarisMetaStoreManager` interface method, so we make steps towards reducing
its usage first.
--
This is an automated mess
XN137 commented on PR #2337:
URL: https://github.com/apache/polaris/pull/2337#issuecomment-3199222943
rebased after tiny conflict in `CatalogHandler.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
XN137 commented on code in PR #2372:
URL: https://github.com/apache/polaris/pull/2372#discussion_r2284067463
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/AbstractTransactionalPersistence.java:
##
@@ -51,6 +52,13 @@
* the BasePersistence metho
dimas-b commented on code in PR #2197:
URL: https://github.com/apache/polaris/pull/2197#discussion_r2283629147
##
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java:
##
@@ -167,6 +168,18 @@ public Response createCatalog(
return Response.s
MonkeyCanCode commented on issue #2362:
URL: https://github.com/apache/polaris/issues/2362#issuecomment-3198849121
I am not sure if branch matter. As
[https://github.com/apache/polaris/pulls?page=2&q=is%3Apr+is%3Aopen
i](https://github.com/apache/polaris/pull/2192) is not merged, he will st
eric-maynard merged PR #2379:
URL: https://github.com/apache/polaris/pull/2379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
eric-maynard commented on issue #2362:
URL: https://github.com/apache/polaris/issues/2362#issuecomment-3198660484
Hey @JarroVGIT -- is this from main, or the 1.0 release branch?
cc @MonkeyCanCode
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
bmlyr opened a new pull request, #2380:
URL: https://github.com/apache/polaris/pull/2380
Add PodDisruptionBudget support to Helm chart
(https://kubernetes.io/docs/tasks/run-application/configure-pdb/)
This PR should resolve #2345
--
This is an automated message from the Apache Git Ser
binarycat0 commented on code in PR #2375:
URL: https://github.com/apache/polaris/pull/2375#discussion_r2283600672
##
runtime/test-common/src/main/java/org/apache/polaris/test/commons/s3mock/S3Mock.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
dimas-b commented on code in PR #2375:
URL: https://github.com/apache/polaris/pull/2375#discussion_r2283585936
##
runtime/test-common/src/main/java/org/apache/polaris/test/commons/s3mock/S3Mock.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
eric-maynard merged PR #2376:
URL: https://github.com/apache/polaris/pull/2376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
dimas-b commented on PR #2337:
URL: https://github.com/apache/polaris/pull/2337#issuecomment-3198337089
@XN137 : unfortunately, there's a merge conflict now... Could you fix it,
please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
eric-maynard merged PR #2359:
URL: https://github.com/apache/polaris/pull/2359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
eric-maynard opened a new pull request, #2379:
URL: https://github.com/apache/polaris/pull/2379
In #2369 Iceberg table federation was refactored around the new
`IcebergRESTExternalCatalogFactory` type based on discussion in the community
sync. This has unblocked the ability to federate to m
RussellSpitzer commented on code in PR #2280:
URL: https://github.com/apache/polaris/pull/2280#discussion_r2283331272
##
runtime/server/build.gradle.kts:
##
@@ -39,9 +39,6 @@ val distributionElements by
}
dependencies {
- implementation(project(":polaris-core"))
Review C
renovate-bot opened a new pull request, #2378:
URL: https://github.com/apache/polaris/pull/2378
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
| [org.apache.hive:hive-metastore](https://hive.apache.org)
([source](https://redirec
eric-maynard merged PR #2355:
URL: https://github.com/apache/polaris/pull/2355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
RussellSpitzer commented on code in PR #2280:
URL: https://github.com/apache/polaris/pull/2280#discussion_r2283324619
##
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationBase.java:
##
@@ -146,11 +148,13 @@ public abstract class Pola
binarycat0 commented on code in PR #2375:
URL: https://github.com/apache/polaris/pull/2375#discussion_r2283286560
##
runtime/test-common/build.gradle.kts:
##
@@ -32,6 +32,7 @@ configurations.all {
}
dependencies {
+ api(libs.s3mock.testcontainers)
Review Comment:
I repl
dimas-b commented on code in PR #2372:
URL: https://github.com/apache/polaris/pull/2372#discussion_r2283077239
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/AbstractTransactionalPersistence.java:
##
@@ -51,6 +52,13 @@
* the BasePersistence met
dimas-b commented on code in PR #2372:
URL: https://github.com/apache/polaris/pull/2372#discussion_r2283077239
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/AbstractTransactionalPersistence.java:
##
@@ -51,6 +52,13 @@
* the BasePersistence met
renovate-bot opened a new pull request, #2377:
URL: https://github.com/apache/polaris/pull/2377
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
|
[io.prometheus:prometheus-metrics-exporter-servlet-jakarta](https://redirect.github
dimas-b merged PR #2361:
URL: https://github.com/apache/polaris/pull/2361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
dimas-b commented on PR #2337:
URL: https://github.com/apache/polaris/pull/2337#issuecomment-3197862062
This change does not appear to change any code behaviour. Given that it has
been in review for 5 days, I'm going to merge it later today, unless new
comments are posted.
--
This is an
binarycat0 commented on code in PR #2375:
URL: https://github.com/apache/polaris/pull/2375#discussion_r2283053711
##
runtime/test-common/src/main/java/org/apache/polaris/test/commons/s3mock/S3Mock.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
snazy commented on code in PR #2375:
URL: https://github.com/apache/polaris/pull/2375#discussion_r2283027080
##
runtime/test-common/build.gradle.kts:
##
@@ -32,6 +32,7 @@ configurations.all {
}
dependencies {
+ api(libs.s3mock.testcontainers)
Review Comment:
Not such a
binarycat0 commented on code in PR #2375:
URL: https://github.com/apache/polaris/pull/2375#discussion_r2283015564
##
gradle/libs.versions.toml:
##
@@ -22,6 +22,7 @@ checkstyle = "10.25.0"
hadoop = "3.4.1"
iceberg = "1.9.2" # Ensure to update the iceberg version in regtests to
adutra commented on PR #2280:
URL: https://github.com/apache/polaris/pull/2280#issuecomment-3197495353
FYI: I was requested to produce a design doc for this feature:
https://docs.google.com/document/d/1ygdia7u4bUHUt6n8XhZo48aKoIyyrCvKqan3XP25iB8/edit?usp=sharing
--
This is an autom
adutra commented on issue #32:
URL: https://github.com/apache/polaris/issues/32#issuecomment-3197494618
FYI: I was requested to produce a design doc for this feature:
https://docs.google.com/document/d/1ygdia7u4bUHUt6n8XhZo48aKoIyyrCvKqan3XP25iB8/edit?usp=sharing
--
This is an auto
snazy commented on code in PR #1965:
URL: https://github.com/apache/polaris/pull/1965#discussion_r2282792817
##
service/common/src/main/java/org/apache/polaris/service/events/AwsCloudWatchEventListener.java:
##
@@ -0,0 +1,264 @@
+/*
+ * Licensed to the Apache Software Foundation
snazy commented on PR #1339:
URL: https://github.com/apache/polaris/pull/1339#issuecomment-3197452530
I think this change needs attention, as it addresses data race conditions in
Apache Polaris.
This cache is sadly not just used as a "dumb but easy to reason about"
read-through-cach
snazy commented on code in PR #1844:
URL: https://github.com/apache/polaris/pull/1844#discussion_r2282740241
##
service/common/src/main/java/org/apache/polaris/service/events/listeners/InMemoryBufferPolarisPersistenceEventListener.java:
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to t
pingtimeout commented on code in PR #2223:
URL: https://github.com/apache/polaris/pull/2223#discussion_r2282733767
##
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -1737,6 +1761,80 @@ public boolean revokePrivilegeOnNamespaceFromR
snazy commented on PR #2048:
URL: https://github.com/apache/polaris/pull/2048#issuecomment-3197360421
Again, this PR sets the way how the policies are persisted pretty much in
stone.
I think, there's an assumption that policies are managed in Polaris only as
Iceberg Expressions, and
snazy commented on code in PR #2223:
URL: https://github.com/apache/polaris/pull/2223#discussion_r2282713316
##
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -1737,6 +1761,80 @@ public boolean revokePrivilegeOnNamespaceFromRole(
tokoko commented on issue #2373:
URL: https://github.com/apache/polaris/issues/2373#issuecomment-3197322653
got it, thanks for the quick response. I assumed that part was already taken
care of because of the "activated principal roles" message. I guess we'll work
around it by syncing grants
poojanilangekar commented on code in PR #2223:
URL: https://github.com/apache/polaris/pull/2223#discussion_r2282638889
##
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -1737,6 +1761,80 @@ public boolean revokePrivilegeOnNamespaceF
snazy commented on PR #2223:
URL: https://github.com/apache/polaris/pull/2223#issuecomment-3197197076
The implementation of
`PolarisAdminService.createSyntheticNamespaceEntities()` looks racy to me. I
suspect that will fail in various ways when concurrent requests target the same
table/vie
XN137 commented on code in PR #2337:
URL: https://github.com/apache/polaris/pull/2337#discussion_r2282489546
##
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##
@@ -138,8 +138,8 @@ public class IcebergCatalogAdapter
snazy commented on code in PR #2337:
URL: https://github.com/apache/polaris/pull/2337#discussion_r2282460328
##
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##
@@ -138,8 +138,8 @@ public class IcebergCatalogAdapter
adutra merged PR #2307:
URL: https://github.com/apache/polaris/pull/2307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apac
snazy opened a new pull request, #2376:
URL: https://github.com/apache/polaris/pull/2376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues
pingtimeout commented on code in PR #2375:
URL: https://github.com/apache/polaris/pull/2375#discussion_r2282315106
##
gradle/libs.versions.toml:
##
@@ -22,6 +22,7 @@ checkstyle = "10.25.0"
hadoop = "3.4.1"
iceberg = "1.9.2" # Ensure to update the iceberg version in regtests to
snazy commented on code in PR #2267:
URL: https://github.com/apache/polaris/pull/2267#discussion_r2282242394
##
site/content/in-dev/unreleased/getting-started/_index.md:
##
@@ -23,3 +23,101 @@ weight: 101
build:
render: never
---
+
+# Getting Started with Apache Polaris Bin
snazy commented on code in PR #2339:
URL: https://github.com/apache/polaris/pull/2339#discussion_r2282221085
##
client/python/cli/command/catalogs.py:
##
@@ -121,18 +122,17 @@ def validate(self):
f"
{Argument.to_flag_name(Arguments.CATALOG_SERVI
snazy commented on code in PR #2375:
URL: https://github.com/apache/polaris/pull/2375#discussion_r2282201615
##
gradle/libs.versions.toml:
##
@@ -22,6 +22,7 @@ checkstyle = "10.25.0"
hadoop = "3.4.1"
iceberg = "1.9.2" # Ensure to update the iceberg version in regtests to keep
jasonf20 commented on code in PR #2341:
URL: https://github.com/apache/polaris/pull/2341#discussion_r2281535465
##
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##
@@ -420,16 +423,45 @@ public Response loadTable(
jasonf20 commented on code in PR #2341:
URL: https://github.com/apache/polaris/pull/2341#discussion_r2281535465
##
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##
@@ -420,16 +423,45 @@ public Response loadTable(
jasonf20 commented on code in PR #2341:
URL: https://github.com/apache/polaris/pull/2341#discussion_r2281535465
##
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##
@@ -420,16 +423,45 @@ public Response loadTable(
binarycat0 opened a new pull request, #2375:
URL: https://github.com/apache/polaris/pull/2375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
adutra commented on code in PR #2280:
URL: https://github.com/apache/polaris/pull/2280#discussion_r2281920428
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/signer/S3RequestSignerImpl.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foun
jasonf20 commented on code in PR #2341:
URL: https://github.com/apache/polaris/pull/2341#discussion_r2281535465
##
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##
@@ -420,16 +423,45 @@ public Response loadTable(
adutra commented on PR #2307:
URL: https://github.com/apache/polaris/pull/2307#issuecomment-3195891255
Had to rebase to fix merge conflicts – PTAL again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
adutra commented on code in PR #2307:
URL: https://github.com/apache/polaris/pull/2307#discussion_r2281825644
##
polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisPrincipal.java:
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
adutra commented on issue #2373:
URL: https://github.com/apache/polaris/issues/2373#issuecomment-3195850742
Hi @tokoko thanks for reporting this!
Unfortunately for now you need to create principals, principal roles _and
grants_ in Polaris before being able to use Keycloak principals.
snazy merged PR #2363:
URL: https://github.com/apache/polaris/pull/2363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy merged PR #2371:
URL: https://github.com/apache/polaris/pull/2371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
XN137 opened a new pull request, #2374:
URL: https://github.com/apache/polaris/pull/2374
similar to 7af85be7f45c933a377314a669e2a16633c93532 we should prefer the
existing helper methods on the entity instead
--
This is an automated message from the Apache Git Service.
To respond to the me
XN137 commented on PR #2290:
URL: https://github.com/apache/polaris/pull/2290#issuecomment-3195517021
> Both loadEntitiesByName and loadEntitiesById seem like they solve the N+1
problem and also avoid trying to serialize lambdas over the wire.
we could use those but we still would be
tokoko opened a new issue, #2373:
URL: https://github.com/apache/polaris/issues/2373
### Describe the bug
I have set up keycloak as an external auth backend (with mixed auth type). I
managed get authentication working and validated that principals are being
pulled correctly. I also c
jasonf20 commented on code in PR #2341:
URL: https://github.com/apache/polaris/pull/2341#discussion_r2281535465
##
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##
@@ -420,16 +423,45 @@ public Response loadTable(
jasonf20 commented on code in PR #2341:
URL: https://github.com/apache/polaris/pull/2341#discussion_r2281535465
##
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##
@@ -420,16 +423,45 @@ public Response loadTable(
XN137 opened a new pull request, #2372:
URL: https://github.com/apache/polaris/pull/2372
the ultimate goal is removing the `PolarisCallContext` parameter from every
`PolarisMetaStoreManager` interface method, so we make steps towards reducing
its usage first.
--
This is an automated mess
67 matches
Mail list logo
