flyrain commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3339824403
Hi @binarycat0, it's a great suggestion! Thank you. Could you file a new
issue for it? We could move the related discussion there.
--
This is an automated message from the Apache
binarycat0 commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3338559696
Hello coleagues, if you'll allow me, I'd like to add my two cents.
First of all, it's really great that such a big amount of work has been done
and this is a huge achievement 🫶
HonahX commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3329942245
+1 on option 2, I think we will need to publish to PyPI anyway to make it
convenient to distribute.
--
This is an automated message from the Apache Git Service.
To respond to the me
HonahX commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3329907034
For 2, I recently got a working draft locally to generate wheels for
multiple MacOS and many linux. I will send out a draft for review soon : ).
> The binary distribution would
flyrain commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3272868259
I run into this issue when I git clone Polaris to a new location, and run
the cli tool `./polaris`.
```
Installing the current project: polaris (1.0.0)
'PythonInfo' object h
MonkeyCanCode commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3301261981
> Yes. We can ask gradle to invoke subprocess which should work. I can riase
the PR later tonight.
>
> > [@MonkeyCanCode](https://github.com/MonkeyCanCode), thanks a lot
HonahX commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3300546911
@MonkeyCanCode Thanks for for all the working on this topic.
I see another place of enhancement and would like to learn your thoughts!
Currently the wheel we build is specific
flyrain commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3300370169
@MonkeyCanCode, thanks a lot for working on #2557. One thing still block
publishing is that Python distribution build was done by `makefile`, not gradle
task. #2530 still cannot use
MonkeyCanCode commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3300390194
Yes. We can ask gradle to invoke subprocess which should work. I can riase
the PR later tonight.
> @MonkeyCanCode, thanks a lot for working on #2557. One thing still bloc
flyrain commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3294208015
Works well now. Thanks a lot for all the fixes, @MonkeyCanCode @HonahX ! I
will try to test it with #2530.
--
This is an automated message from the Apache Git Service.
To respond
HonahX commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3293659992
PR out: https://github.com/apache/polaris/pull/2569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
HonahX commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3293560687
@flyrain Thanks for another attempt. This seems to be a poetry bug:
https://github.com/python-poetry/poetry/issues/10504#issuecomment-3176923981.
that it will update `virtualenv` to a
flyrain commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3293490248
@HonahX and @MonkeyCanCode , you are right on about the openapi verison, I
was using 7.14 before. But even with #2557, the openapi can still fall back to
7.14 whenever I run `python3
HonahX commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3288896047
Hi @flyrain , which version of `openapi-generator-cli` did you install?
Currently our spec file could only works for
`"openapi-generator-cli==7.11.0.post0` due to some compatibility i
HonahX commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3288929922
@MonkeyCanCode I just found my previous ticket about this and there was also
some depedency conflict involved:
https://github.com/apache/polaris/issues/1822#issue-3123175447. TLDR, ne
MonkeyCanCode commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3288898479
That is correct. I am planning to check what does it take for us to upgrade
to newer one later this weekend.
> Hi @flyrain , which version of `openapi-generator-cli` did
flyrain commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-321838
Sorry for the late response, here is the output
```
(.venv) ygu@FM4LQ4GJ90 polaris % cd client/python
(.venv) ygu@FM4LQ4GJ90 python % python3 generate_clients.py -v
...
MonkeyCanCode commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3272897472
> 'PythonInfo' object has no attribute 'tcl_lib'
Seems to be working fine for me:
```
➜ Desktop mkdir 2 && cd 2 && git clone g...@github.com:apache/polaris.git
&&
flyrain commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3272872934
A draft PR to publish it, https://github.com/apache/polaris/pull/2530.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
flyrain commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3272731044
Thanks a lot @MonkeyCanCode ! We will need to copy it to the distribution
module, like #1589 what does. An update to binary distribution readme is also
needed.
https://github.com/po
MonkeyCanCode commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3268318399
@flyrain all changes are now merged.
> The only left PR for this: https://github.com/apache/polaris/pull/2425
--
This is an automated message from the Apache Gi
MonkeyCanCode commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3263405541
The only left PR for this: https://github.com/apache/polaris/pull/2425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
MonkeyCanCode commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3222428993
> > Thanks [@MonkeyCanCode](https://github.com/MonkeyCanCode) . Could you
share these PRs?
> > > asking users to specify SCRIPT_DIR doesn't make much sense anymore imo.
>
MonkeyCanCode commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3221306675
> Thanks [@MonkeyCanCode](https://github.com/MonkeyCanCode) . Could you
share these PRs?
>
> > asking users to specify SCRIPT_DIR doesn't make much sense anymore imo.
flyrain commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3221288013
Thanks @MonkeyCanCode . Could you share these PRs?
> asking users to specify SCRIPT_DIR doesn't make much sense anymore imo.
Agreed.
--
This is an automated message
MonkeyCanCode commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3217747017
> The plan sounds great to me. Thanks
[@MonkeyCanCode](https://github.com/MonkeyCanCode) for picking it up! At least,
we will need to fix item 3 and 4 before packaging it the b
flyrain commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3215193936
The plan sounds great to me. Thanks @MonkeyCanCode for picking it up! At
least, we will need to fix item 3 and 4 before packaging it the binary
distribution.
--
This is an automa
MonkeyCanCode commented on issue #2419:
URL: https://github.com/apache/polaris/issues/2419#issuecomment-3213043919
Thanks for bring this up @flyrain. Here are my two cents:
Before we can do so, we should fix couple old issues we have with client
code such as following
1. remove doc
flyrain opened a new issue, #2419:
URL: https://github.com/apache/polaris/issues/2419
### Is your feature request related to a problem? Please describe.
Users who only uses binary distribution can use the CLI directly from the
package. There is no need to grab the tools from anywhere
29 matches
Mail list logo
