[jira] [Commented] (RATIS-2109) RaftLogBase#updateCommitIndex should return true only if commitIndex is increased

2024-06-05 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852315#comment-17852315 ] Tsz-wo Sze commented on RATIS-2109: --- [~ivanandika], That is a good point! The code sho

Re: [PR] RATIS-2109. RaftLogBase#updateCommitIndex should return true only if commitIndex is increased [ratis]

2024-06-05 Thread via GitHub
szetszwo merged PR #1109: URL: https://github.com/apache/ratis/pull/1109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ratis.apache

[jira] [Updated] (RATIS-2109) RaftLogBase#updateCommitIndex should return true only if commitIndex is increased

2024-06-05 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze updated RATIS-2109: -- Component/s: server > RaftLogBase#updateCommitIndex should return true only if commitIndex is > increa

[jira] [Resolved] (RATIS-2109) RaftLogBase#updateCommitIndex should return true only if commitIndex is increased

2024-06-05 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze resolved RATIS-2109. --- Fix Version/s: 3.1.1 Resolution: Fixed The pull request is now merged. Thanks, [~ivanandika]!

[jira] [Commented] (RATIS-2104) TestLeaderInstallSnapshot may fail with java.lang.IllegalStateException: allLeaks.size = 4

2024-06-05 Thread Duong (Jira)
[ https://issues.apache.org/jira/browse/RATIS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852521#comment-17852521 ] Duong commented on RATIS-2104: -- [~szetszwo]  Even if LogAppender is still running in MiniRa

[jira] [Commented] (RATIS-2104) TestLeaderInstallSnapshot may fail with java.lang.IllegalStateException: allLeaks.size = 4

2024-06-05 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852574#comment-17852574 ] Tsz-wo Sze commented on RATIS-2104: --- Try store the value. Otherwise, if the buffer is

Re: [PR] RATIS-2106. Add configuration reference for RaftClient [ratis]

2024-06-05 Thread via GitHub
smengcl commented on PR #1107: URL: https://github.com/apache/ratis/pull/1107#issuecomment-2151006330 Thanks @szetszwo for reviewing and merging this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (RATIS-2104) TestLeaderInstallSnapshot may fail with java.lang.IllegalStateException: allLeaks.size = 4

2024-06-05 Thread Duong (Jira)
[ https://issues.apache.org/jira/browse/RATIS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852602#comment-17852602 ] Duong commented on RATIS-2104: -- Tried that, same result [~szetszwo]. The finally block is sk

[jira] [Commented] (RATIS-2104) TestLeaderInstallSnapshot may fail with java.lang.IllegalStateException: allLeaks.size = 4

2024-06-05 Thread Duong (Jira)
[ https://issues.apache.org/jira/browse/RATIS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852605#comment-17852605 ] Duong commented on RATIS-2104: -- Another problem is [onComplete|https://github.com/apache/ra

[jira] [Commented] (RATIS-2104) TestLeaderInstallSnapshot may fail with java.lang.IllegalStateException: allLeaks.size = 4

2024-06-05 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852622#comment-17852622 ] Tsz-wo Sze commented on RATIS-2104: --- bq. The guarantee that "finally" blocks always run

[jira] [Commented] (RATIS-2104) TestLeaderInstallSnapshot may fail with java.lang.IllegalStateException: allLeaks.size = 4

2024-06-05 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852623#comment-17852623 ] Tsz-wo Sze commented on RATIS-2104: --- [~duongnguyen], btw, please take a look the - Ill